From nobody@FreeBSD.org  Sun Sep 11 20:43:45 2011
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id ADC76106564A
	for <freebsd-gnats-submit@FreeBSD.org>; Sun, 11 Sep 2011 20:43:45 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22])
	by mx1.freebsd.org (Postfix) with ESMTP id 9E0E08FC13
	for <freebsd-gnats-submit@FreeBSD.org>; Sun, 11 Sep 2011 20:43:45 +0000 (UTC)
Received: from red.freebsd.org (localhost [127.0.0.1])
	by red.freebsd.org (8.14.4/8.14.4) with ESMTP id p8BKhjm0027578
	for <freebsd-gnats-submit@FreeBSD.org>; Sun, 11 Sep 2011 20:43:45 GMT
	(envelope-from nobody@red.freebsd.org)
Received: (from nobody@localhost)
	by red.freebsd.org (8.14.4/8.14.4/Submit) id p8BKhjXs027566;
	Sun, 11 Sep 2011 20:43:45 GMT
	(envelope-from nobody)
Message-Id: <201109112043.p8BKhjXs027566@red.freebsd.org>
Date: Sun, 11 Sep 2011 20:43:45 GMT
From: Jim Pirzyk <pirzyk@FreeBSD.org>
To: freebsd-gnats-submit@FreeBSD.org
Subject: [maintainer-update] p5-Sys-Filesystem default package builds on amd64 platform
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         160666
>Category:       ports
>Synopsis:       [maintainer-update] p5-Sys-Filesystem default package builds on amd64 platform
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    crees
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sun Sep 11 20:50:06 UTC 2011
>Closed-Date:    Mon Nov 28 20:38:11 UTC 2011
>Last-Modified:  Mon Nov 28 20:38:11 UTC 2011
>Originator:     Jim Pirzyk
>Release:        8.2-RELEASE
>Organization:
>Environment:
FreeBSD amigo.home.pirzyk.org 8.2-RELEASE FreeBSD 8.2-RELEASE #0: Thu Feb 17 02:41:51 UTC 2011     root@mason.cse.buffalo.edu:/usr/obj/usr/src/sys/GENERIC  amd64

>Description:
Not sure why this was put in the Makefile, but p5-Sys-Filesystem builds on amd64 the same as all other platforms (i.e. i386, sparc, etc).  Removing the block to create the package on amd64.
>How-To-Repeat:
ftp ftp.freebsd.org and look for p5-Sys-Filesystem, the pre-built package does not exist.
>Fix:


Patch attached with submission follows:

--- Makefile.org	1969-12-31 19:00:00.000000000 -0500
+++ Makefile	2011-09-11 11:46:35.964605696 -0400
@@ -0,0 +1,36 @@
+# New ports collection makefile for:   p5-Sys-Filesystem
+# Date created:                        Thu May 25 21:12:53 CDT 2006
+# Whom:                                        Jim Pirzyk pirzyk@freebsd.org
+#
+# $FreeBSD: ports/sysutils/p5-Sys-Filesystem/Makefile,v 1.8 2010/12/08 19:29:44 linimon Exp $
+#
+
+PORTNAME=	Sys-Filesystem
+PORTVERSION=	1.30
+CATEGORIES=	sysutils perl5
+MASTER_SITES=	CPAN
+MASTER_SITE_SUBDIR=	Sys
+PKGNAMEPREFIX=	p5-
+
+MAINTAINER=	pirzyk@FreeBSD.org
+COMMENT=	Perl module to Retrieve list of filesystems and their properties
+
+RUN_DEPENDS=	p5-Params-Util>=1.0:${PORTSDIR}/devel/p5-Params-Util
+BUILD_DEPENDS=	${RUN_DEPENDS}
+
+PERL_MODBUILD=	yes
+
+MAN3=		Sys::Filesystem::Mswin32.3 \
+		Sys::Filesystem.3 \
+		Sys::Filesystem::Linux.3 \
+		Sys::Filesystem::Darwin.3 \
+		Sys::Filesystem::Cygwin.3 \
+		Sys::Filesystem::Aix.3 \
+		Sys::Filesystem::Unix.3 \
+		Sys::Filesystem::Dummy.3 \
+		Sys::Filesystem::Freebsd.3 \
+		Sys::Filesystem::Solaris.3 \
+		Sys::Filesystem::Hpux.3 \
+		Sys::Filesystem::Netbsd.3
+
+.include <bsd.port.mk>


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->crees 
Responsible-Changed-By: crees 
Responsible-Changed-When: Sun Oct 30 20:43:05 UTC 2011 
Responsible-Changed-Why:  
I'll take it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=160666 
State-Changed-From-To: open->feedback 
State-Changed-By: crees 
State-Changed-When: Sun Nov 13 16:49:56 UTC 2011 
State-Changed-Why:  
Sorry about the huge delay. I've spoken with pav@ about this problem; 
there is no fstab on the build machines, therefore it will not build on 
them.  I would suggest that we make this MANUAL_PACKAGE_BUILD on all 
archs, since this is the case.  Alternatively, you could find a way to 
let the port build in the absence of /etc/fstab? 

http://www.freebsd.org/cgi/query-pr.cgi?pr=160666 

From: Chris Rees <utisoft@gmail.com>
To: bug-followup@freebsd.org, pirzyk@freebsd.org
Cc:  
Subject: Re: ports/160666: [maintainer-update] p5-Sys-Filesystem default
 package builds on amd64 platform
Date: Tue, 15 Nov 2011 18:56:50 +0000

 Just a thought.
 
 We could fake an fstab with an empty one, and trick the configure
 script into reading that.
 
 Does this work for you?
 
 http://www.bayofrum.net/~crees/patches/p5-Sys-Filesystem.patch
 
 Chris

From: Jim Pirzyk <pirzyk@freebsd.org>
To: Chris Rees <utisoft@gmail.com>
Cc: bug-followup@freebsd.org
Subject: Re: ports/160666: [maintainer-update] p5-Sys-Filesystem default package builds on amd64 platform
Date: Tue, 15 Nov 2011 19:07:49 -0500

 -----BEGIN PGP SIGNED MESSAGE-----
 Hash: SHA256
 
 That sounds like a reasonable test.  Looking at the code, it does not =
 complain if the fstab file is empty.  So why does the system have no =
 /etc/fstab file?
 
 - - JimP
 
 On Nov 15, 2011, at 1:56 PM, Chris Rees wrote:
 
 > Just a thought.
 >=20
 > We could fake an fstab with an empty one, and trick the configure
 > script into reading that.
 >=20
 > Does this work for you?
 >=20
 > http://www.bayofrum.net/~crees/patches/p5-Sys-Filesystem.patch
 >=20
 > Chris
 
 - --- @(#) $Id: dot.signature,v 1.15 2007/12/27 15:06:13 pirzyk Exp $
     __o  jim@pirzyk.org =
 --------------------------------------------------
  _'\<,_
 (*)/ (*) I'd rather be out biking.
 
 -----BEGIN PGP SIGNATURE-----
 Version: GnuPG v1.4.10 (Darwin)
 
 iFcDBQFOwv7WUQdE3d8ckhQRCMVzAP4nk9iTQezy5V2OelG8rds31Rar+YFbozFp
 uoPRZL5JVwD+Joil7wyI04SR6JumPuUzwyhKUFWXwjuv5+8sPxCqYpM=3D
 =3DE1yk
 -----END PGP SIGNATURE-----

From: Chris Rees <utisoft@gmail.com>
To: Jim Pirzyk <pirzyk@freebsd.org>
Cc: bug-followup@freebsd.org
Subject: Re: ports/160666: [maintainer-update] p5-Sys-Filesystem default
 package builds on amd64 platform
Date: Wed, 16 Nov 2011 07:23:53 +0000

 --14dae9340b7f72dd1704b1d4fc5e
 Content-Type: text/plain; charset=ISO-8859-1
 
 It doesn't need one; it's not a problem in the build jails.
 
 The requirement for an fstab during build is a quirk of the port.
 
 Chris
 
 --14dae9340b7f72dd1704b1d4fc5e
 Content-Type: text/html; charset=ISO-8859-1
 
 <p>It doesn&#39;t need one; it&#39;s not a problem in the build jails.</p>
 <p>The requirement for an fstab during build is a quirk of the port.</p>
 <p>Chris</p>
 
 --14dae9340b7f72dd1704b1d4fc5e--

From: Jim Pirzyk <pirzyk@freebsd.org>
To: Chris Rees <utisoft@gmail.com>
Cc: bug-followup@freebsd.org
Subject: Re: ports/160666: [maintainer-update] p5-Sys-Filesystem default package builds on amd64 platform
Date: Wed, 16 Nov 2011 07:18:58 -0500

 -----BEGIN PGP SIGNED MESSAGE-----
 Hash: SHA256
 
 Sorry, but it is *not* a quirk.  If I want to have an interface to fstab =
 in perl, the port would expect to find a /etc/fstab file.  This is a =
 problem with the build team's assumption that jail =3D=3D host and in =
 this is proof that assumption is not true.
 
 - - JimP
 
 On Nov 16, 2011, at 2:23 AM, Chris Rees wrote:
 
 > It doesn't need one; it's not a problem in the build jails.
 >=20
 > The requirement for an fstab during build is a quirk of the port.
 >=20
 > Chris
 >=20
 
 - --- @(#) $Id: dot.signature,v 1.15 2007/12/27 15:06:13 pirzyk Exp $
     __o  jim@pirzyk.org =
 --------------------------------------------------
  _'\<,_
 (*)/ (*) I'd rather be out biking.
 
 -----BEGIN PGP SIGNATURE-----
 Version: GnuPG v1.4.10 (Darwin)
 
 iFcDBQFOw6oyUQdE3d8ckhQRCEl4AQC8dzsBs/STix+0YUr4+k3MrW3/OS4DJgzn
 g1ER7nfpyAD/UOmz9Re2uG+GsqM26vUU2tdGAMxbqy1HRO91Aer5c3k=3D
 =3Dsy1M
 -----END PGP SIGNATURE-----

From: Chris Rees <utisoft@gmail.com>
To: bug-followup@freebsd.org
Cc:  
Subject: Re: ports/160666: [maintainer-update] p5-Sys-Filesystem default
 package builds on amd64 platform
Date: Thu, 17 Nov 2011 20:05:38 +0000

 OK, the main issue is that the port should only require an fstab on
 the _runtime_ system.  If you want a package built, then the _build_
 process must cope with an absent fstab.
 
 This shouldn't cause any problems in the generated package, so would
 you mind if I commit? It'll at least remove the MANUAL_PACKAGE_BUILD
 lines...
 
 Chris

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/160666: commit references a PR
Date: Mon, 28 Nov 2011 20:23:18 +0000 (UTC)

 crees       2011-11-28 20:23:10 UTC
 
   FreeBSD ports repository
 
   Modified files:
     sysutils/p5-Sys-Filesystem Makefile 
   Log:
   Fake fstab for compile stage, fixing build on package cluster.
   
   PR:             ports/160666
   Approved by:    pirzyk (maintainer)
   Feature safe:   yes
   
   Revision  Changes    Path
   1.10      +5 -6      ports/sysutils/p5-Sys-Filesystem/Makefile
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: feedback->closed 
State-Changed-By: crees 
State-Changed-When: Mon Nov 28 20:38:10 UTC 2011 
State-Changed-Why:  
Fixed as discussed.  Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=160666 
>Unformatted:
