From nobody@FreeBSD.org  Sun Sep 11 15:31:59 2011
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 77F6A1065672
	for <freebsd-gnats-submit@FreeBSD.org>; Sun, 11 Sep 2011 15:31:59 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22])
	by mx1.freebsd.org (Postfix) with ESMTP id 67D578FC0A
	for <freebsd-gnats-submit@FreeBSD.org>; Sun, 11 Sep 2011 15:31:59 +0000 (UTC)
Received: from red.freebsd.org (localhost [127.0.0.1])
	by red.freebsd.org (8.14.4/8.14.4) with ESMTP id p8BFVxDf072039
	for <freebsd-gnats-submit@FreeBSD.org>; Sun, 11 Sep 2011 15:31:59 GMT
	(envelope-from nobody@red.freebsd.org)
Received: (from nobody@localhost)
	by red.freebsd.org (8.14.4/8.14.4/Submit) id p8BFVxtl072038;
	Sun, 11 Sep 2011 15:31:59 GMT
	(envelope-from nobody)
Message-Id: <201109111531.p8BFVxtl072038@red.freebsd.org>
Date: Sun, 11 Sep 2011 15:31:59 GMT
From: "4720@hushmail.com" <4720@hushmail.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: [patch] comms/minicom: make lrzsz dependency optional
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         160661
>Category:       ports
>Synopsis:       [patch] comms/minicom: make lrzsz dependency optional
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    eadler
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Sun Sep 11 15:40:05 UTC 2011
>Closed-Date:    Tue Oct 25 01:04:42 UTC 2011
>Last-Modified:  Tue Oct 25 01:10:02 UTC 2011
>Originator:     4720@hushmail.com
>Release:        
>Organization:
>Environment:
>Description:
the minicom port lists lrzsz as a required dependency, but it is only needed for doing file transfers. patch turns required depend into default on option.
>How-To-Repeat:

>Fix:
Index: Makefile
===================================================================
RCS file: /home/ncvs/ports/comms/minicom/Makefile,v
retrieving revision 1.56
diff -u -r1.56 Makefile
--- Makefile	17 Aug 2011 21:04:58 -0000	1.56
+++ Makefile	10 Sep 2011 08:45:42 -0000
@@ -14,9 +14,13 @@
 MAINTAINER=	johans@FreeBSD.org
 COMMENT=	An MS-DOS Telix serial communication program "workalike"
 
-RUN_DEPENDS=	lrz:${PORTSDIR}/comms/lrzsz
+OPTIONS=	LRZSZ	"Install X/Y/ZMODEM protocol handlers"	on
 
-USE_ICONV=	yes
+.include <bsd.port.options.mk>
+
+.if defined(WITH_LRZSZ)
+RUN_DEPENDS=	lrz:${PORTSDIR}/comms/lrzsz
+.endif
 
 .if defined(WITHOUT_NLS)
 CONFIGURE_ARGS+=--disable-nls
@@ -26,6 +30,7 @@
 PLIST_SUB+=	NLS=""
 .endif
 
+USE_ICONV=	yes
 CPPFLAGS+=	-I${LOCALBASE}/include
 LDFLAGS+=	-L${LOCALBASE}/lib
 GNU_CONFIGURE=	yes


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->johans 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Sun Sep 11 15:40:20 UTC 2011 
Responsible-Changed-Why:  
Over to maintainer (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=160661 
Responsible-Changed-From-To: johans->eadler 
Responsible-Changed-By: eadler 
Responsible-Changed-When: Tue Oct 25 00:48:11 UTC 2011 
Responsible-Changed-Why:  
maintainer timeout so I'll commit it 

http://www.freebsd.org/cgi/query-pr.cgi?pr=160661 
State-Changed-From-To: open->closed 
State-Changed-By: eadler 
State-Changed-When: Tue Oct 25 01:04:41 UTC 2011 
State-Changed-Why:  
Committed. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=160661 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/160661: commit references a PR
Date: Tue, 25 Oct 2011 01:00:55 +0000 (UTC)

 eadler      2011-10-25 01:00:40 UTC
 
   FreeBSD ports repository
 
   Modified files:
     comms/minicom        Makefile 
   Log:
   - make lzr dep. optional
   
   PR:             ports/160661
   Submitted by:   "4720@hushmail.com" <4720@hushmail.com>
   Approved by:    maintainer timeout (6 weeks)
   Approved by:    bapt,sahil (mentors, implicit)
   
   Revision  Changes    Path
   1.57      +7 -2      ports/comms/minicom/Makefile
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
