From root@eu.route.mx  Sat Sep 10 15:36:17 2011
Return-Path: <root@eu.route.mx>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id F0BED1065670
	for <FreeBSD-gnats-submit@freebsd.org>; Sat, 10 Sep 2011 15:36:17 +0000 (UTC)
	(envelope-from root@eu.route.mx)
Received: from eu.route.mx (eu.route.mx [46.137.95.40])
	by mx1.freebsd.org (Postfix) with ESMTP id 58B578FC0C
	for <FreeBSD-gnats-submit@freebsd.org>; Sat, 10 Sep 2011 15:36:17 +0000 (UTC)
Received: (qmail 99543 invoked by uid 0); 10 Sep 2011 15:36:16 -0000
Message-Id: <20110910153616.99542.qmail@eu.route.mx>
Date: 10 Sep 2011 15:36:16 -0000
From: nbari@dalmp.com
Reply-To: nbari@dalmp.com
To: FreeBSD-gnats-submit@freebsd.org
Cc: nbari@dalmp.com
Subject: [PATCH] databases/mysql55-server Add WITH_COLLATION and WITH_CHARSET
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         160630
>Category:       ports
>Synopsis:       [PATCH] databases/mysql55-server Add WITH_COLLATION and WITH_CHARSET
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    ale
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          update
>Submitter-Id:   current-users
>Arrival-Date:   Sat Sep 10 15:40:03 UTC 2011
>Closed-Date:    Tue Sep 13 14:56:32 UTC 2011
>Last-Modified:  Tue Sep 13 16:00:23 UTC 2011
>Originator:     Nicolas de Bari Embriz <nbari@dalmp.com>
>Release:        FreeBSD 8.2-RELEASE i386
>Organization:
>Environment:


	
>Description:
  When updating to mysql55 there are no options like previous mysql5X version of specifying the CHARSET

  With this patch user can specify the CHARSET and COLLATION using something like;

  make WITH_CHARSET=uft8 WITH_COLLATION=utf8_unicode_ci

>How-To-Repeat:
	
>Fix:

	

--- mysql55-server.diff begins here ---
diff -urN mysql55-server-old/Makefile mysql55-server/Makefile
--- mysql55-server-old/Makefile	2011-09-10 14:38:44.000000000 +0000
+++ mysql55-server/Makefile	2011-09-10 15:16:00.000000000 +0000
@@ -53,6 +53,12 @@
 .if defined(WITH_FASTMTX)
 CMAKE_ARGS+=	-DWITH_FAST_MUTEXES=1
 .endif
+.if defined(WITH_CHARSET) && ${WITH_CHARSET} != ""
+CMAKE_ARGS+=	-DDEFAULT_CHARSET=${WITH_CHARSET}
+.endif
+.if defined(WITH_COLLATION) && ${WITH_COLLATION} != ""
+CMAKE_ARGS+=	-DDEFAULT_COLLATION=${WITH_COLLATION}
+.endif
 
 # MySQL-Server part
 .if !defined(CLIENT_ONLY)
--- mysql55-server.diff ends here ---


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->ale 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Sat Sep 10 15:40:33 UTC 2011 
Responsible-Changed-Why:  
Over to maintainer (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=160630 

From: Nicolas de Bari Embriz Garcia Rojas <nbari@dalmp.com>
To: bug-followup@FreeBSD.org, nbari@dalmp.com
Cc:  
Subject: Re: ports/160630: [PATCH] databases/mysql55-server Add WITH_COLLATION
 and WITH_CHARSET
Date: Sat, 10 Sep 2011 16:47:38 +0100

 --000e0ce0b18ea06db204ac9836b3
 Content-Type: text/plain; charset=ISO-8859-1
 
 The correct way to use it is:
 
 make WITH_CHARSET="utf8" WITH_COLLATION="utf8_unicode_ci" install clean
 
 with "" on the options
 
 --000e0ce0b18ea06db204ac9836b3
 Content-Type: text/html; charset=ISO-8859-1
 Content-Transfer-Encoding: quoted-printable
 
 The correct way to use it is:=A0<div><br></div><div>make WITH_CHARSET=3D&qu=
 ot;utf8&quot; WITH_COLLATION=3D&quot;utf8_unicode_ci&quot; install clean</d=
 iv><div><br></div><div>with &quot;&quot; on the options</div>
 
 --000e0ce0b18ea06db204ac9836b3--
State-Changed-From-To: open->closed 
State-Changed-By: ale 
State-Changed-When: Tue Sep 13 14:56:05 UTC 2011 
State-Changed-Why:  
You should use my.cnf for this config params. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=160630 

From: Nicolas de Bari Embriz Garcia Rojas <nbari@dalmp.com>
To: bug-followup@FreeBSD.org, nbari@dalmp.com
Cc:  
Subject: Re: ports/160630: [PATCH] databases/mysql55-server Add WITH_COLLATION
 and WITH_CHARSET
Date: Tue, 13 Sep 2011 16:50:02 +0100

 --001517448634c1274c04acd498fe
 Content-Type: text/plain; charset=ISO-8859-1
 
 Any chance to keep the options so it can be backwards compatible with
 previous versions of the mysql port ?
 
 regards
 
 --001517448634c1274c04acd498fe
 Content-Type: text/html; charset=ISO-8859-1
 
 Any chance to keep the options so it can be backwards compatible with previous versions of the mysql port ?<div><br></div><div>regards</div><div><br></div><div><br></div>
 
 --001517448634c1274c04acd498fe--
>Unformatted:
