From nobody@FreeBSD.org  Sat Sep 10 03:46:38 2011
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 1ABB0106566C
	for <freebsd-gnats-submit@FreeBSD.org>; Sat, 10 Sep 2011 03:46:38 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22])
	by mx1.freebsd.org (Postfix) with ESMTP id E64E18FC16
	for <freebsd-gnats-submit@FreeBSD.org>; Sat, 10 Sep 2011 03:46:37 +0000 (UTC)
Received: from red.freebsd.org (localhost [127.0.0.1])
	by red.freebsd.org (8.14.4/8.14.4) with ESMTP id p8A3kbma006513
	for <freebsd-gnats-submit@FreeBSD.org>; Sat, 10 Sep 2011 03:46:37 GMT
	(envelope-from nobody@red.freebsd.org)
Received: (from nobody@localhost)
	by red.freebsd.org (8.14.4/8.14.4/Submit) id p8A3kbwV006512;
	Sat, 10 Sep 2011 03:46:37 GMT
	(envelope-from nobody)
Message-Id: <201109100346.p8A3kbwV006512@red.freebsd.org>
Date: Sat, 10 Sep 2011 03:46:37 GMT
From: Kevin Oberman <kob6558@gmail.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: sysutils/fusefs-kmod fails to build on amd64
X-Send-Pr-Version: www-3.1
X-GNATS-Notify: amistry@am-productions.biz

>Number:         160608
>Category:       ports
>Synopsis:       sysutils/fusefs-kmod fails to build on amd64
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    swills
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sat Sep 10 03:50:08 UTC 2011
>Closed-Date:    Wed Sep 21 20:30:31 UTC 2011
>Last-Modified:  Wed Sep 21 20:30:31 UTC 2011
>Originator:     Kevin Oberman
>Release:        Current (9.0-Beta2)
>Organization:
>Environment:
FreeBSD rogue.local 9.0-BETA2 FreeBSD 9.0-BETA2 #9: Thu Sep  8 20:53:55 PDT 2011     root@rogue.local:/usr/obj/usr/src/sys/GENERIC  amd64

>Description:
Building of the fusefs-kmod port failed in fuse_modules/fuse_vfsops.c due to an incorrect typing of the third argument of calls to vfs_flagopt. It the variables 'mntopts and __mntopts are declared to be int when vfs_flagopt expects uint64_t.

fuse_vfsops.c: In function 'fuse_mount':
fuse_vfsops.c:339: warning: passing argument 3 of 'vfs_flagopt' from incompatible pointer type
fuse_vfsops.c:339: warning: passing argument 3 of 'vfs_flagopt' from incompatible pointer type
fuse_vfsops.c:340: warning: passing argument 3 of 'vfs_flagopt' from incompatible pointer type
fuse_vfsops.c:340: warning: passing argument 3 of 'vfs_flagopt' from incompatible pointer type
fuse_vfsops.c:341: warning: passing argument 3 of 'vfs_flagopt' from incompatible pointer type
fuse_vfsops.c:341: warning: passing argument 3 of 'vfs_flagopt' from incompatible pointer type
fuse_vfsops.c:342: warning: passing argument 3 of 'vfs_flagopt' from incompatible pointer type
fuse_vfsops.c:342: warning: passing argument 3 of 'vfs_flagopt' from incompatible pointer type
fuse_vfsops.c:343: warning: passing argument 3 of 'vfs_flagopt' from incompatible pointer type
fuse_vfsops.c:343: warning: passing argument 3 of 'vfs_flagopt' from incompatible pointer type

Proposed fix may not be correct, but it did allow the port to build. Perhaps a cast would have been the right answer.
>How-To-Repeat:
cd /usr/ports/sysutils/fusefs-kmod && make
>Fix:
--- fuse_vfsops.c.broken	2011-09-09 20:43:36.000000000 -0700
+++ fuse_vfsops.c	2011-09-09 20:44:32.000000000 -0700
@@ -231,7 +231,8 @@
 	struct cdev *fdev;
 	struct sx *slock;
 	struct fuse_data *data;
-	int mntopts = 0, __mntopts = 0, max_read_set = 0, secondary = 0;
+	uint64_t mntopts = 0, __mntopts = 0;
+	int max_read_set = 0, secondary = 0;
 	unsigned max_read = ~0;
 	struct vnode *rvp;
 	struct fuse_vnode_data *fvdat;


>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->feedback 
State-Changed-By: edwin 
State-Changed-When: Sat Sep 10 03:50:19 UTC 2011 
State-Changed-Why:  
Awaiting maintainers feedback (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=160608 

From: Edwin Groothuis <edwin@FreeBSD.org>
To: amistry@am-productions.biz
Cc: bug-followup@FreeBSD.org
Subject: Re: ports/160608: sysutils/fusefs-kmod fails to build on amd64
Date: Sat, 10 Sep 2011 03:50:17 UT

 Maintainer of sysutils/fusefs-kmod,
 
 Please note that PR ports/160608 has just been submitted.
 
 If it contains a patch for an upgrade, an enhancement or a bug fix
 you agree on, reply to this email stating that you approve the patch
 and a committer will take care of it.
 
 The full text of the PR can be found at:
     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/160608
 
 -- 
 Edwin Groothuis via the GNATS Auto Assign Tool
 edwin@FreeBSD.org

From: Ivan Klymenko <fidaj@ukr.net>
To: bug-followup@FreeBSD.org, kob6558@gmail.com
Cc:  
Subject: Re: ports/160608: sysutils/fusefs-kmod fails to build on amd64
Date: Sat, 10 Sep 2011 09:34:42 +0300

 This problem report is a duplicate
 http://www.freebsd.org/cgi/query-pr.cgi?pr=159361&cat=

From: Kevin Oberman <kob6558@gmail.com>
To: Ivan Klymenko <fidaj@ukr.net>
Cc: bug-followup@freebsd.org
Subject: Re: ports/160608: sysutils/fusefs-kmod fails to build on amd64
Date: Sat, 10 Sep 2011 09:21:51 -0700

 On Fri, Sep 9, 2011 at 11:34 PM, Ivan Klymenko <fidaj@ukr.net> wrote:
 > This problem report is a duplicate
 > http://www.freebsd.org/cgi/query-pr.cgi?pr=159361&cat=
 
 PR ports/159361 is a bit of a mess as it conflates two PRa related to
 the fusefs-kmod port.
 
 The long patch in the PR is mostly changes that are already committed
 to the port. Only a single
 change, from 'int' to 'uint64_t' in the third hunk is required, as far
 as I can tell. It changes three
 variables from 'int' to 'uint64_t', where mine only changed the first
 two, but I can't say which is
 more correct and it may make no difference.
 
 Please don't assume that the committed patch is the complete fix.
 -- 
 R. Kevin Oberman, Network Engineer - Retired
 E-mail: kob6558@gmail.com
Responsible-Changed-From-To: freebsd-ports-bugs->swills 
Responsible-Changed-By: swills 
Responsible-Changed-When: Mon Sep 19 00:33:16 UTC 2011 
Responsible-Changed-Why:  
I'll take it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=160608 

From: Steve Wills <swills@FreeBSD.org>
To: bug-followup@FreeBSD.org, Kevin Oberman <kob6558@gmail.com>,
        amistry@am-productions.biz
Cc:  
Subject: Re: ports/160608: sysutils/fusefs-kmod fails to build on amd64
Date: Sun, 18 Sep 2011 20:44:59 -0400

 This is a multi-part message in MIME format.
 --------------030300050000060106070404
 Content-Type: text/plain; charset=ISO-8859-1
 Content-Transfer-Encoding: 7bit
 
 -----BEGIN PGP SIGNED MESSAGE-----
 Hash: SHA1
 
 The attached patch fixes it so that it builds on both 9.x and 8.x. Patch
 is also available here:
 
 http://people.freebsd.org/~swills/fusefs_kmod_patch.txt
 
 in case it gets lost.
 
 Without the conditionalization, it breaks on 8.x. There wasn't a
 OSVERSION bump for the change to vfs_flagopt, so I used the closest
 thing I could find.
 
 Maintainer, do you approve?
 
 Thanks,
 Steve
 -----BEGIN PGP SIGNATURE-----
 Version: GnuPG v2.0.17 (FreeBSD)
 
 iQEcBAEBAgAGBQJOdpCKAAoJEPXPYrMgexuhj28H/AoXnCpygkErYRyjaos4hJH/
 1tHB2XGqcCPdXLtX66tWInUAB6PHtczeOKNS5WKjFO2wbdHi8hdy+MShQ5LKnLcy
 5zDRAnu4VfY64Ng7R74LnBCV/FKSDcb4xaVFJRVhRV2hlTsYN3S6drwb6fGDkFM/
 eOZuq/u+Fx+LB25NK9Xpr0e2FjRqq+xdqyu+DrhgQ6bl2iiBsXsMzilXJUTYVOR0
 fUJjyMHftzF3zxw2X6Zu8yo/DrTtPkYJD1MwWDeWabezo9gJzXUwRkJCCyZ7EmG8
 3K/F9tXPg1QtDZP3THepKNQBg9TRjlBI7MlvZyFEgkk9HjWj4pFR7FTCsLk6eso=
 =edTI
 -----END PGP SIGNATURE-----
 
 --------------030300050000060106070404
 Content-Type: text/plain;
  name="fusefs_kmod_patch.txt"
 Content-Transfer-Encoding: 7bit
 Content-Disposition: attachment;
  filename="fusefs_kmod_patch.txt"
 
 Index: Makefile
 ===================================================================
 RCS file: /home/pcvs/ports/sysutils/fusefs-kmod/Makefile,v
 retrieving revision 1.31
 diff -u -r1.31 Makefile
 --- Makefile	14 Oct 2010 11:44:10 -0000	1.31
 +++ Makefile	19 Sep 2011 00:38:43 -0000
 @@ -7,7 +7,7 @@
  
  PORTNAME=	fusefs
  DISTVERSION=	0.3.9-pre1.20080208
 -PORTREVISION=	7
 +PORTREVISION=	8
  CATEGORIES=	sysutils kld
  MASTER_SITES=	http://mercurial.creo.hu/repos/fuse4bsd-hg/index.cgi/archive/
  PKGNAMESUFFIX=	-kmod
 @@ -58,6 +58,10 @@
  
  .include <bsd.port.pre.mk>
  
 +.if ${OSVERSION} >= 900040
 +EXTRA_PATCHES+=	${FILESDIR}/extra-patch-fuse_module__fuse_vnops.c
 +.endif
 +
  .if !exists(${SRC_BASE}/sys/Makefile)
  IGNORE=		requires the Kernel source to be installed. Set SRC_BASE if it is not in /usr/src
  .endif
 Index: files/extra-patch-fuse_module__fuse_vnops.c
 ===================================================================
 RCS file: files/extra-patch-fuse_module__fuse_vnops.c
 diff -N files/extra-patch-fuse_module__fuse_vnops.c
 --- /dev/null	1 Jan 1970 00:00:00 -0000
 +++ files/extra-patch-fuse_module__fuse_vnops.c	19 Sep 2011 00:38:43 -0000
 @@ -0,0 +1,11 @@
 +--- fuse_module/fuse_vfsops.c.orig	2008-02-05 07:25:57.000000000 +0200
 ++++ fuse_module/fuse_vfsops.c	2011-09-08 10:27:43.000000000 +0300
 +@@ -224,7 +231,7 @@
 + 	struct cdev *fdev;
 + 	struct sx *slock;
 + 	struct fuse_data *data;
 +-	int mntopts = 0, __mntopts = 0, max_read_set = 0, secondary = 0;
 ++	uint64_t mntopts = 0, __mntopts = 0, max_read_set = 0, secondary = 0;
 + 	unsigned max_read = ~0;
 + 	struct vnode *rvp;
 + 	struct fuse_vnode_data *fvdat;
 
 --------------030300050000060106070404
 Content-Type: application/octet-stream;
  name="fusefs_kmod_patch.txt.sig"
 Content-Transfer-Encoding: base64
 Content-Disposition: attachment;
  filename="fusefs_kmod_patch.txt.sig"
 
 iQEcBAABAgAGBQJOdpCLAAoJEPXPYrMgexuhL+0H/RLdUFF5XEcRGC/ZUDixaCqlUL52wHR/
 +MzA0EPi1VOC5z+VXO7Gq7DFSi1M/LcNxVa2l44vOBxKGtvH0iTmYqVhD6RgQIKCJryimQuq
 /2GqM2/soW4Gjg3frsfXtMf2mKWZOiHZdfveLKuy1xGDrEexeLO8V10fZ2WghniP352Pdn0R
 JCQMVILKyHfh9sCtMMCAcylXKSghJOYsCMMHLj6eK1b9rTOH6mcA6QYuhjk8/ALrI/lacyjK
 JgK0AE3pH5wn1XZZEX2LkzNoADHSk2TXtdy43SvBwOZLM+8ZhgW3RDgd0GB+88BoEHAq/0pG
 tIy+XZctbUPrSktqhuCLRKI=
 --------------030300050000060106070404--

From: =?KOI8-R?B?4czFy9PBzsTSIOXG0sXNz9c=?= <mr.efrem@gmail.com>
To: bug-followup@freebsd.org, kob6558@gmail.com
Cc:  
Subject: Re: ports/160608: sysutils/fusefs-kmod fails to build on amd64
Date: Wed, 21 Sep 2011 21:19:07 +0400

 --20cf3005da260dd8fe04ad76c691
 Content-Type: text/plain; charset=ISO-8859-1
 
 Hello!
 
 This problem too is present in i386 to architecture. Please correct it there
 too.
 
 --20cf3005da260dd8fe04ad76c691
 Content-Type: text/html; charset=ISO-8859-1
 
 <meta name="qrichtext" content="1"><meta http-equiv="Content-Type" content="text/html; charset=utf-8"><style type="text/css">
 p, li { white-space: pre-wrap; }
 </style>
 <p style=" margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; -qt-user-state:0;">Hello!</p>
 <p style=" margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; -qt-user-state:0;">This problem too is present in i386 to architecture. Please correct it there too.</p>
 
 <p style="-qt-paragraph-type:empty; margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px;"></p>
 
 --20cf3005da260dd8fe04ad76c691--

From: Kevin Oberman <kob6558@gmail.com>
To: =?UTF-8?B?0JDQu9C10LrRgdCw0L3QtNGAINCV0YTRgNC10LzQvtCy?= <mr.efrem@gmail.com>
Cc: bug-followup@freebsd.org
Subject: Re: ports/160608: sysutils/fusefs-kmod fails to build on amd64
Date: Wed, 21 Sep 2011 10:57:02 -0700

 On Wed, Sep 21, 2011 at 10:19 AM, =D0=90=D0=BB=D0=B5=D0=BA=D1=81=D0=B0=D0=
 =BD=D0=B4=D1=80 =D0=95=D1=84=D1=80=D0=B5=D0=BC=D0=BE=D0=B2 <mr.efrem@gmail.=
 com> wrote:
 > Hello!
 >
 > This problem too is present in i386 to architecture. Please correct it th=
 ere
 > too.
 
 I see that the port was re-assigned to heap last night. Can someone
 please commit either
 Steve's or my fix?
 
 I really prefer mine as it only re-types the two variables that need it,
 although my read of the code leads me to believe that re-typing of the
 remaining variables
 will make no difference as they are only used internally and never
 passed as arguments.
 It is possible that making them unsigned might cause a problem, but it
 looks unlikely to me.
 
 Still, I tend to always lean to the more conservative side unless I am
 really sure I fully understand hte code.
 --=20
 R. Kevin Oberman, Network Engineer - Retired
 E-mail: kob6558@gmail.com

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/160608: commit references a PR
Date: Wed, 21 Sep 2011 20:29:43 +0000 (UTC)

 swills      2011-09-21 20:29:34 UTC
 
   FreeBSD ports repository
 
   Modified files:
     sysutils/fusefs-kmod Makefile 
   Added files:
     sysutils/fusefs-kmod/files 
                                extra-patch-fuse_module__fuse_vnops.c 
   Log:
   - Fix build on 9-CURRENT
   
   PR:             ports/160608 (plus many other)
   Submitted by:   Kevin Oberman <kob6558@gmail.com> (based on)
   
   Revision  Changes    Path
   1.33      +5 -1      ports/sysutils/fusefs-kmod/Makefile
   1.1       +11 -0     ports/sysutils/fusefs-kmod/files/extra-patch-fuse_module__fuse_vnops.c (new)
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: feedback->closed 
State-Changed-By: swills 
State-Changed-When: Wed Sep 21 20:30:28 UTC 2011 
State-Changed-Why:  
Thanks for the info and feedback. Fix committed. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=160608 
>Unformatted:
