From jilles@stack.nl  Fri Sep  9 19:23:20 2011
Return-Path: <jilles@stack.nl>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 0764E1065675
	for <FreeBSD-gnats-submit@freebsd.org>; Fri,  9 Sep 2011 19:23:20 +0000 (UTC)
	(envelope-from jilles@stack.nl)
Received: from mx1.stack.nl (relay02.stack.nl [IPv6:2001:610:1108:5010::104])
	by mx1.freebsd.org (Postfix) with ESMTP id 90B828FC27
	for <FreeBSD-gnats-submit@freebsd.org>; Fri,  9 Sep 2011 19:23:19 +0000 (UTC)
Received: from turtle.stack.nl (turtle.stack.nl [IPv6:2001:610:1108:5010::132])
	by mx1.stack.nl (Postfix) with ESMTP id 44A68359414
	for <FreeBSD-gnats-submit@freebsd.org>; Fri,  9 Sep 2011 21:23:17 +0200 (CEST)
Received: by turtle.stack.nl (Postfix, from userid 1677)
	id 33B7017515; Fri,  9 Sep 2011 21:23:17 +0200 (CEST)
Message-Id: <20110909192317.33B7017515@turtle.stack.nl>
Date: Fri,  9 Sep 2011 21:23:17 +0200 (CEST)
From: Jilles Tjoelker <jilles@stack.nl>
Reply-To: Jilles Tjoelker <jilles@stack.nl>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: x11/xset: missing dependencies
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         160595
>Category:       ports
>Synopsis:       x11/xset: missing dependencies
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    eadler
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Fri Sep 09 19:30:09 UTC 2011
>Closed-Date:    Sat Sep 10 23:09:58 UTC 2011
>Last-Modified:  Sat Sep 10 23:10:08 UTC 2011
>Originator:     Jilles Tjoelker
>Release:        FreeBSD 8.2-STABLE i386
>Organization:
The FreeBSD Project
>Environment:
FreeBSD 8.2-STABLE i386
>Description:
x11/xset depends on various libraries without declaring that in the port
Makefile.

In particular, this may cause portmaster to attempt to compile xset
against a too old version of xproto.

The modules xxf86misc and xfontcache are used iff they happen to be
present. This means that the centrally built packages do not have them
but a version built from ports will probably have them.
>How-To-Repeat:
Inspect the port Makefile and the configure.ac file.
>Fix:
Add the missing dependencies to USE_XORG=.

The below patch assumes that xxf86misc and xfontcache are desired.
Alternatively, they could be disabled via configure options.
(xorg-server-1.7.7_2,1 does not appear to support xfontcache.)

The PORTREVISION should be bumped as well.

--- xset-deps.patch begins here ---
--- /usr/ports/x11/xset/Makefile.orig	2011-09-07 23:19:05.000000000 +0200
+++ /usr/ports/x11/xset/Makefile	2011-09-09 19:29:08.000000000 +0200
@@ -13,7 +13,7 @@
 COMMENT=	User preference utility for X
 
 XORG_CAT=	app
-USE_XORG=	xmuu
+USE_XORG=	xmuu xproto x11 xext xxf86misc xfontcache
 
 PLIST_FILES=	bin/xset
 
--- xset-deps.patch ends here ---


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->freebsd-x11 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Fri Sep 9 19:30:21 UTC 2011 
Responsible-Changed-Why:  
Over to maintainer (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=160595 
Responsible-Changed-From-To: freebsd-x11->eadler 
Responsible-Changed-By: eadler 
Responsible-Changed-When: Fri Sep 9 19:51:27 UTC 2011 
Responsible-Changed-Why:  
I'll take it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=160595 
State-Changed-From-To: open->closed 
State-Changed-By: eadler 
State-Changed-When: Sat Sep 10 23:09:57 UTC 2011 
State-Changed-Why:  
Committed, requires PORTREVISION bump because the default package 
changes. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=160595 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/160595: commit references a PR
Date: Sat, 10 Sep 2011 23:05:15 +0000 (UTC)

 eadler      2011-09-10 23:04:57 UTC
 
   FreeBSD ports repository
 
   Modified files:
     x11/xset             Makefile 
   Log:
   - forced commit to correct log
   - add deps unconditionally
   
   PR:             ports/160595
   Submitted by:   Jilles Tjoelker <jilles@stack.nl>
   Reviewed by:    kwm, nox
   Approved by:    bapt (mentor)
   
   Revision  Changes    Path
   1.8       +0 -0      ports/x11/xset/Makefile
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
