From aakuusta@gmail.com  Mon Sep  5 20:08:52 2011
Return-Path: <aakuusta@gmail.com>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 4F4CB106564A
	for <FreeBSD-gnats-submit@freebsd.org>; Mon,  5 Sep 2011 20:08:52 +0000 (UTC)
	(envelope-from aakuusta@gmail.com)
Received: from mail-pz0-f45.google.com (mail-pz0-f45.google.com [209.85.210.45])
	by mx1.freebsd.org (Postfix) with ESMTP id 2B0A68FC16
	for <FreeBSD-gnats-submit@freebsd.org>; Mon,  5 Sep 2011 20:08:51 +0000 (UTC)
Received: by pzk33 with SMTP id 33so15195478pzk.18
        for <FreeBSD-gnats-submit@freebsd.org>; Mon, 05 Sep 2011 13:08:51 -0700 (PDT)
Received: by 10.68.34.6 with SMTP id v6mr8494697pbi.33.1315253331661;
        Mon, 05 Sep 2011 13:08:51 -0700 (PDT)
Received: from nil (tor-exit-readme-1wh1.kromyon.net. [209.236.66.108])
        by mx.google.com with ESMTPS id f6sm24357867pbp.2.2011.09.05.13.08.46
        (version=SSLv3 cipher=OTHER);
        Mon, 05 Sep 2011 13:08:50 -0700 (PDT)
Message-Id: <86sjoada62.fsf@gmail.com>
Date: Tue, 06 Sep 2011 00:08:37 +0400
From: h h <aakuusta@gmail.com>
To: FreeBSD-gnats-submit@freebsd.org
Subject: [patch] lang/ocaml: respect CC

>Number:         160492
>Category:       ports
>Synopsis:       [patch] lang/ocaml: respect CC
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    bf
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon Sep 05 20:10:01 UTC 2011
>Closed-Date:    Thu Feb 23 01:27:11 UTC 2012
>Last-Modified:  Thu Feb 23 01:27:11 UTC 2012
>Originator:     h h
>Release:        FreeBSD 9.0-BETA2 r225402M amd64
>Organization:
>Environment:
$ export PATH=~/.bin:$PATH
$ for cc in CC cc c++ gcc g++; do ln -s /usr/bin/false ~/.bin/${cc}; done
>Description:
The port tries to use `gcc' unless `-cc' option is specified.
When `gcc' is not in PATH it unconditionally falls back to `cc',
without even testing whether the latter command is also in PATH.
>How-To-Repeat:
http://pointyhat.freebsd.org/errorlogs/amd64-errorlogs/e.9-exp.20110723205754/ocaml-3.12.0_1.log
>Fix:
--- a.diff begins here ---
Index: lang/ocaml/Makefile
===================================================================
RCS file: /a/.csup/ports/lang/ocaml/Makefile,v
retrieving revision 1.71
diff -u -p -r1.71 Makefile
--- lang/ocaml/Makefile	4 Apr 2011 02:29:25 -0000	1.71
+++ lang/ocaml/Makefile	5 Sep 2011 19:49:17 -0000
@@ -27,7 +27,7 @@ ALL_TARGET=	world.opt
 STRIP=
 MAKE_JOBS_UNSAFE=	yes
 
-CONFIGURE_ARGS=	-prefix ${PREFIX}
+CONFIGURE_ARGS=	-prefix ${PREFIX} -cc ${CC}
 OPTIONS=	X11	"Build with X11 support" on \
 		TK	"Build LablTk library (requires X11 support)" on \
 		THREADS	"Build with Posix threads support" on \
--- a.diff ends here ---
>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->stas 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Mon Sep 5 20:11:48 UTC 2011 
Responsible-Changed-Why:  
Over to maintainer (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=160492 
Responsible-Changed-From-To: stas->tabthorpe 
Responsible-Changed-By: tabthorpe 
Responsible-Changed-When: Sat Nov 5 03:41:12 UTC 2011 
Responsible-Changed-Why:  
- back to the heap 

http://www.freebsd.org/cgi/query-pr.cgi?pr=160492 
Responsible-Changed-From-To: tabthorpe->freebsd-ports-bugs 
Responsible-Changed-By: tabthorpe 
Responsible-Changed-When: Wed Nov 9 18:59:28 UTC 2011 
Responsible-Changed-Why:  
Really give back to the heap 

http://www.freebsd.org/cgi/query-pr.cgi?pr=160492 

From: =?ISO-8859-15?Q?Michael_Gr=FCnewald?=
 <michael.grunewald@laposte.net>
To: bug-followup@FreeBSD.org, aakuusta@gmail.com
Cc:  
Subject: Re: ports/160492: [patch] lang/ocaml: respect CC
Date: Fri, 09 Dec 2011 09:08:01 +0100

 Being the new maintainer of lang/ocaml, I recently received notification 
 of this PR.
 
 Did you compile OCaml with something different that gcc?  While OCaml 
 should be compiled by any ANSI C compiler, examination of the 
 ./configure script in source displays many gcc-specific behaviors.  I 
 would appreciate details you can supply there.
 
 BTW I think this fix belongs the upstream ./configure script, so I will 
 submit a bug report or a patch on the OCaml bug tracking system.
Responsible-Changed-From-To: freebsd-ports-bugs->bf 
Responsible-Changed-By: bf 
Responsible-Changed-When: Fri Dec 9 14:48:14 UTC 2011 
Responsible-Changed-Why:  
I'll take it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=160492 

Date: Sat, 17 Dec 2011 08:55:22 -0500
From: Jan Beich <jbeich@tormail.net>
To: bug-followup@freebsd.org
Cc: michael.grunewald@laposte.net
Subject: Re: [patch] lang/ocaml: respect CC

 It's incomplete and broken on gcc46. Try the attached one.
 
   $ make CC=gcc46
   ===>  Building for ocaml-notk-3.12.1
   [...]
   gcc46 -DCAML_NAME_SPACE -O -fno-defer-pop -Wall -D_FILE_OFFSET_BITS=64 -D_REENTRANT -D_THREAD_SAFE -O2 -pipe  -c prims.c
   gcc4646 -Wl,-E -o ocamlrun  prims.o libcamlrun.a -lm  -lcurses -pthread
   gcc4646: No such file or directory
   *** [ocamlrun] Error code 1
 
   Stop in /usr/ports/lang/ocaml/work/ocaml-3.12.1/byterun.
   *** [coldstart] Error code 1
 
 --- cc.diff begins here ---
 Index: lang/ocaml/Makefile
 ===================================================================
 RCS file: /a/.csup/ports/lang/ocaml/Makefile,v
 retrieving revision 1.74
 diff -u -p -r1.74 Makefile
 --- lang/ocaml/Makefile	28 Nov 2011 11:42:03 -0000	1.74
 +++ lang/ocaml/Makefile	17 Dec 2011 13:42:12 -0000
 @@ -26,7 +26,7 @@ ALL_TARGET=	world.opt
  STRIP=
  MAKE_JOBS_UNSAFE=	yes
  
 -CONFIGURE_ARGS=	-prefix ${PREFIX}
 +CONFIGURE_ARGS=	-prefix '${PREFIX}' -cc '${CC}' -as '${AS}' -aspp '${CC} -c'
  OPTIONS=	X11	"Build with X11 support" on \
  		TK	"Build LablTk library (requires X11 support)" on \
  		THREADS	"Build with Posix threads support" on \
 @@ -101,13 +101,18 @@ post-extract:
  	${MV} ${WRKSRC}/asmrun/power-elf.S ${WRKSRC}/asmrun/power-bsd.S
  .endif
  
 +post-patch:
 +# don't hardcode gcc for depend target
 +	@${REINPLACE_CMD} -e 's|gcc|$$(CC)|' \
 +		${WRKSRC}/*/Makefile \
 +		${WRKSRC}/*/*/Makefile
 +
  post-configure:
  # CFLAGS safeness
  	@${REINPLACE_CMD} -E \
  		-e 's|(BYTECCCOMPOPTS[ \t]*=.*)|\1 ${CFLAGS} ${THR_CPP}|' \
  		-e 's|(NATIVECCCOMPOPTS[ \t]*=.*)|\1 ${CFLAGS} ${THR_CPP}|' \
  		-e '/^PTHREAD_LINK/s,-pthread,${THR_LD},g' \
 -		-e 's|gcc|${CC}|g'	\
  		${WRKSRC}/config/Makefile
  
  # INSTALL* safeness (which preserves the correct permissions despite
 --- cc.diff ends here ---

From: =?ISO-8859-15?Q?Michael_Gr=FCnewald?=
 <michael.grunewald@laposte.net>
To: bug-followup@FreeBSD.org, aakuusta@gmail.com
Cc: jbeich@tormail.net
Subject: Re: ports/160492: [patch] lang/ocaml: respect CC
Date: Mon, 06 Feb 2012 23:43:06 +0100

 This is a multi-part message in MIME format.
 --------------000505030106020201010101
 Content-Type: text/plain; charset=ISO-8859-15; format=flowed
 Content-Transfer-Encoding: 7bit
 
 Dear Jan,
 
 Thank you for your patch.
 
 I tested your patch at home on amd64, it works fine and the ocaml 
 compiler prepared with gcc=46 (your suggested test) succesfully does its 
 job (until now!).
 
 I think we can have your patch in FreeBSD, I prepared an updated version 
 that also bumps PORTREVISION.
 
 I also raised the issue upstream:
   http://caml.inria.fr/mantis/view.php?id=5418
 
 Best,
 Michael
 
 --------------000505030106020201010101
 Content-Type: text/plain;
  name="patch-Makefile"
 Content-Transfer-Encoding: 7bit
 Content-Disposition: attachment;
  filename="patch-Makefile"
 
 --- lang/ocaml/Makefile.orig	2012-02-06 22:49:46.000000000 +0100
 +++ lang/ocaml/Makefile		2012-02-06 23:09:25.000000000 +0100
 @@ -7,6 +7,7 @@
  
  PORTNAME=	ocaml
  PORTVERSION=	3.12.1
 +PORTREVISION=	1
  CATEGORIES=	lang
  MASTER_SITES=	http://caml.inria.fr/distrib/${DISTNAME:R}/ \
  		ftp://ftp.inria.fr/INRIA/caml-light/${DISTNAME:R}/ \
 @@ -26,7 +27,7 @@
  STRIP=
  MAKE_JOBS_UNSAFE=	yes
  
 -CONFIGURE_ARGS=	-prefix ${PREFIX}
 +CONFIGURE_ARGS=	-prefix '${PREFIX}' -cc '${CC}' -as '${AS}' -aspp '${CC} -c'
  OPTIONS=	X11	"Build with X11 support" on \
  		TK	"Build LablTk library (requires X11 support)" on \
  		THREADS	"Build with Posix threads support" on \
 @@ -99,13 +100,18 @@
  	${MV} ${WRKSRC}/asmrun/power-elf.S ${WRKSRC}/asmrun/power-bsd.S
  .endif
  
 +post-patch:
 +# don't hardcode gcc for depend target
 +	@${REINPLACE_CMD} -e 's|gcc|$$(CC)|' \
 +		${WRKSRC}/*/Makefile \
 +		${WRKSRC}/*/*/Makefile
 +
  post-configure:
  # CFLAGS safeness
  	@${REINPLACE_CMD} -E \
  		-e 's|(BYTECCCOMPOPTS[ \t]*=.*)|\1 ${CFLAGS} ${THR_CPP}|' \
  		-e 's|(NATIVECCCOMPOPTS[ \t]*=.*)|\1 ${CFLAGS} ${THR_CPP}|' \
  		-e '/^PTHREAD_LINK/s,-pthread,${THR_LD},g' \
 -		-e 's|gcc|${CC}|g'	\
  		${WRKSRC}/config/Makefile
  
  # INSTALL* safeness (which preserves the correct permissions despite
 
 --------------000505030106020201010101--

From: "b. f." <bf1783@googlemail.com>
To: bug-followup@FreeBSD.org, michael.grunewald@laposte.net
Cc:  
Subject: Re: ports/160492: [patch] lang/ocaml: respect CC
Date: Wed, 22 Feb 2012 02:34:21 +0000

 --0016e6d7e0a0883c0004b9845d75
 Content-Type: text/plain; charset=ISO-8859-1
 
 When looking over this patch, I found a number of other problems that
 need to be fixed:
 
 -- There is no need to set USE_LDCONFIG=yes, because we don't expose
 versioned shared libraries in ${PREFIX}/lib to rtld for general use.
 
 -- After revision 1.54 of the port Makefile, it was intended that
 ocaml should use a threaded tcl/tk, and to this end, DEPENDS_ARGS sets
 WITH_THREADS.  But this is risky, and it is not having the desired
 effect, partly because the ocaml configure script looks for the wrong
 libraries in the right directories.  Remove it, and set USE_TK_THREADS
 instead when needed, while explicitly including the desired library
 names in CONFIGURE_ARGS.  While here, remove the obsolete
 "-with-pthread" from CONFIGURE_ARGS, which is ignored by the ocaml
 configure script.  Also, explicitly disallow tcl/tk 8.6, which causes
 the configure script to fail; and adjust the wish shebang line in an
 example script (we can't use PATCH_TK_SCRIPTS from bsd.tcl.mk for this
 because its replacements are not sufficiently general, and it
 interferes with post-patch).
 
 -- Through a logic error in the port Makefile, packages built
 WITHOUT_X11 were being conflated with those built merely WITHOUT_TK.
 Fix this by not overwriting SFX and CONFLICTS for the WITHOUT_X11
 packages.
 
 -- Respect LDFLAGS when linking -- we may need to do this for LTO,
 stack protection, rpath arguments (like those in bsd.gcc.mk) that help
 the resulting binaries find the compiler shared libraries at runtime,
 etc.  Adjust the flags so that they can used indirectly, with the
 compiler, and directly, with the linker. (The adjustment in the latter
 case is not foolproof, but should work for most reasonable choices of
 flags, and that is all we need.)
 
 -- remove the hard-coded libdl that causes failures when searching for
 libbfd from the configure script (our dlopen is in libc, as the
 computation of dllib should have already established -- this will
 enable compilers using devel/binutils, like lang/gcc4*, to use this
 functionality).
 
 -- use the proper toolchain elements in the configure script, instead
 of hard-coding "ar", "ld", and "ranlib".
 
 --expose the testsuite, so we can more easily determine if ocaml has
 problems -- do this in a way so that a single test failure won't cause
 "make -k check" to grind to a halt, or issue partial logs.
 
 --use dirrmtry for lib/ocaml in pkg-plist, instead of explicitly
 defining it in the Makefile
 
 If you agree, I will commit these changes.
 
 Regards,
                  b.
 
 --0016e6d7e0a0883c0004b9845d75
 Content-Type: application/octet-stream; name="ocaml.diff"
 Content-Disposition: attachment; filename="ocaml.diff"
 Content-Transfer-Encoding: base64
 X-Attachment-Id: file0
 
 SW5kZXg6IE1ha2VmaWxlCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
 PT09PT09PT09PT09PT09PT09PT09PT09PT0KUkNTIGZpbGU6IC9ob21lL3BjdnMvcG9ydHMvbGFu
 Zy9vY2FtbC9NYWtlZmlsZSx2CnJldHJpZXZpbmcgcmV2aXNpb24gMS43NQpkaWZmIC11IC1yMS43
 NSBNYWtlZmlsZQotLS0gTWFrZWZpbGUJMjkgRGVjIDIwMTEgMjA6MzM6MjYgLTAwMDAJMS43NQor
 KysgTWFrZWZpbGUJMjEgRmViIDIwMTIgMTg6MDQ6MzEgLTAwMDAKQEAgLTcsNiArNyw3IEBACiAK
 IFBPUlROQU1FPQlvY2FtbAogUE9SVFZFUlNJT049CTMuMTIuMQorUE9SVFJFVklTSU9OPQkxCiBD
 QVRFR09SSUVTPQlsYW5nCiBNQVNURVJfU0lURVM9CWh0dHA6Ly9jYW1sLmlucmlhLmZyL2Rpc3Ry
 aWIvJHtESVNUTkFNRTpSfS8gXAogCQlmdHA6Ly9mdHAuaW5yaWEuZnIvSU5SSUEvY2FtbC1saWdo
 dC8ke0RJU1ROQU1FOlJ9LyBcCkBAIC0yMSwxMiArMjIsMTIgQEAKIFVTRV9CWklQMj0JeWVzCiBS
 RUlOUExBQ0VfQVJHUz0JLWkgIiIKIEhBU19DT05GSUdVUkU9CXllcwotVVNFX0xEQ09ORklHPQl5
 ZXMKIEFMTF9UQVJHRVQ9CXdvcmxkLm9wdAogU1RSSVA9CiBNQUtFX0pPQlNfVU5TQUZFPQl5ZXMK
 IAotQ09ORklHVVJFX0FSR1M9CS1wcmVmaXggJHtQUkVGSVh9CitDT05GSUdVUkVfQVJHUz0JLXZl
 cmJvc2UgLXByZWZpeCAiJHtQUkVGSVh9IiAtY2MgIiR7Q0N9IiAtYXMgIiR7QVN9IiBcCisJCS1h
 c3BwICIke0NDfSAtYyIgLXBhcnRpYWxsZCAiJHtMRH0gLXIiCiBPUFRJT05TPQlYMTEJIkJ1aWxk
 IHdpdGggWDExIHN1cHBvcnQiIG9uIFwKIAkJVEsJIkJ1aWxkIExhYmxUayBsaWJyYXJ5IChyZXF1
 aXJlcyBYMTEgc3VwcG9ydCkiIG9uIFwKIAkJVEhSRUFEUwkiQnVpbGQgd2l0aCBQb3NpeCB0aHJl
 YWRzIHN1cHBvcnQiIG9uIFwKQEAgLTUyLDggKzUzLDYgQEAKIAogLmlmICFkZWZpbmVkKFdJVEhP
 VVRfVEhSRUFEUykKIFBMSVNUX1NVQis9CVRIUkVBRFM9IiIKLURFUEVORFNfQVJHUys9CVdJVEhf
 VEhSRUFEUz15ZXMKLUNPTkZJR1VSRV9BUkdTKz0td2l0aC1wdGhyZWFkCiBUSFJfQ1BQPQkke1BU
 SFJFQURfQ0ZMQUdTfQogVEhSX0xEPQkJJHtQVEhSRUFEX0xJQlN9CiAuZWxzZQpAQCAtNzcsMTcg
 Kzc2LDI0IEBACiAKIC5pZiBkZWZpbmVkKFdJVEhPVVRfVEspCiBQTElTVF9TVUIrPQlUSz0iQGNv
 bW1lbnQgIgorLmlmICFkZWZpbmVkKFdJVEhPVVRfWDExKQogU0ZYPQkJLW5vdGsKIENPTkZMSUNU
 Uys9CW9jYW1sLVswLTldKiBvY2FtbC1ub3gxMS1bMC05XSoKKy5lbmRpZgogQ09ORklHVVJFX0FS
 R1MrPS1uby10awogLmVsc2UKIFVTRV9USz0JCTg0KworSU5WQUxJRF9US19WRVIgPQk4NgorLmlm
 IGRlZmluZWQoV0lUSF9USFJFQURTKQorVVNFX1RLX1RIUkVBRFMgPQl5ZXMKKy5lbmRpZgogLmlu
 Y2x1ZGUgIiR7UE9SVFNESVJ9L01rL2JzZC50Y2wubWsiCiBQTElTVF9TVUIrPQlUSz0iIgogQ09O
 RkxJQ1RTKz0Jb2NhbWwtbm94MTEtWzAtOV0qIG9jYW1sLW5vdGstWzAtOV0qCiBDT05GSUdVUkVf
 QVJHUys9CS10a2RlZnMgXAogCQkJIi1JJHtUQ0xfSU5DTFVERURJUn0gLUkke1RLX0lOQ0xVREVE
 SVJ9ICR7VEhSX0NQUH0iIFwKLQkJCS10a2xpYnMgIi1MJHtMT0NBTEJBU0V9L2xpYiAke1RIUl9M
 RH0iCisJCQktdGtsaWJzICItTCR7TE9DQUxCQVNFfS9saWIgLWx0ayR7VEtfVkVSOlN8Lnx8fSR7
 X1RDTF9USFJFQURTX1NVRkZJWH0gXAorCQkJLWx0Y2wke1RDTF9WRVI6U3wufHx9JHtfVENMX1RI
 UkVBRFNfU1VGRklYfSAke1RIUl9MRH0iCiAuZW5kaWYKIAogLmlmICR7QVJDSH0gPT0gc3BhcmM2
 NApAQCAtOTksMTMgKzEwNSwzMCBAQAogCSR7TVZ9ICR7V1JLU1JDfS9hc21ydW4vcG93ZXItZWxm
 LlMgJHtXUktTUkN9L2FzbXJ1bi9wb3dlci1ic2QuUwogLmVuZGlmCiAKK3Bvc3QtcGF0Y2g6CisJ
 QCR7UkVJTlBMQUNFX0NNRH0gXAorCQktZSAnXHxNS0xJQj18c3xhciByY3wke0FSfSByY3wnIFwK
 KwkJLWUgJ1x8UkFOTElCfHN8cmFubGlifCR7UkFOTElCfXwnIFwKKwkJLWUgJ1x8Ynl0ZWNjbGlu
 a29wdHM9fHN8IiJ8IiR7TERGTEFHU30ifCcgXAorCQktZSAiXHxuYXRpdmVjY2xpbmtvcHRzPXxz
 fCcnfFwiJHtMREZMQUdTOkMvLVdsLC8vfVwifCIgXAorCQktZSAnXHxta3NoYXJlZGxpYj18c3wk
 JGJ5dGVjY3wmICQkYnl0ZWNjbGlua29wdHN8JyBcCisJCS1lICdzfC1sYmZkIC1sZGx8LWxiZmQg
 JCRkbGxpYnwnIFwKKwkJJHtXUktTUkN9L2NvbmZpZ3VyZQorIyBkb24ndCBoYXJkY29kZSBnY2Mg
 Zm9yIGRlcGVuZCB0YXJnZXQKKwlAJHtSRUlOUExBQ0VfQ01EfSAtZSAnc3xnY2N8JCQoQ0MpfCcg
 XAorCQkke1dSS1NSQ30vKi9NYWtlZmlsZSBcCisJCSR7V1JLU1JDfS8qLyovTWFrZWZpbGUKKy5p
 ZiBkZWZpbmVkKFdJVEhfVEspCisJQCR7UkVJTlBMQUNFX0NNRH0gLWUgJ3N8L3Vzci9iaW4vd2lz
 aHwke1dJU0h9fCcgXAorCQkke1dSS1NSQ30vb3RoZXJsaWJzL2xhYmx0ay9leGFtcGxlc19sYWJs
 dGsvaGVsbG8udGNsCisuZW5kaWYKKwogcG9zdC1jb25maWd1cmU6CiAjIENGTEFHUyBzYWZlbmVz
 cwogCUAke1JFSU5QTEFDRV9DTUR9IC1FIFwKIAkJLWUgJ3N8KEJZVEVDQ0NPTVBPUFRTWyBcdF0q
 PS4qKXxcMSAke0NGTEFHU30gJHtUSFJfQ1BQfXwnIFwKIAkJLWUgJ3N8KE5BVElWRUNDQ09NUE9Q
 VFNbIFx0XSo9LiopfFwxICR7Q0ZMQUdTfSAke1RIUl9DUFB9fCcgXAogCQktZSAnL15QVEhSRUFE
 X0xJTksvcywtcHRocmVhZCwke1RIUl9MRH0sZycgXAotCQktZSAnc3xnY2N8JHtDQ318ZycJXAog
 CQkke1dSS1NSQ30vY29uZmlnL01ha2VmaWxlCiAKICMgSU5TVEFMTCogc2FmZW5lc3MgKHdoaWNo
 IHByZXNlcnZlcyB0aGUgY29ycmVjdCBwZXJtaXNzaW9ucyBkZXNwaXRlCkBAIC0xMTgsNiArMTQx
 LDEyIEBACiAJCS1lICdzLF4oJHtQQVRURVJOfSsuKkxJQkRJUiksXDFcJCR7QlNEX0lOU1RBTExf
 REFUQX0gXDQsJyBcCiAJCS1lICdzLCgke1BBVFRFUk59Ky4qKE1BTkRJUnxNQU5PRElSfE1BTkVY
 VCkpLFwxXCQke0JTRF9JTlNUQUxMX01BTn0gXDQsJwogCitjaGVjayB0ZXN0OiBpbnN0YWxsCisJ
 QGNkICR7V1JLU1JDfS90ZXN0c3VpdGU7ICR7Uk19IC1mIF9sb2c7IGZvciBkIGluIHRlc3RzLyog
 OyBkbyBcCisJJHtTRVRFTlZ9ICR7TUFLRV9FTlZ9ICR7TUFLRX0gJHtfTUFLRV9KT0JTfSAke01B
 S0VfQVJHU30gb25lIERJUj0kJHtkfSBcCisJMj4mMSB8IHRlZSAtYSBfbG9nIHx8ICR7VFJVRX0g
 OyBkb25lIDsgXAorCSR7U0VURU5WfSAke01BS0VfRU5WfSAke01BS0V9ICR7X01BS0VfSk9CU30g
 JHtNQUtFX0FSR1N9IHJlcG9ydAorCiBwb3N0LWluc3RhbGw6CiAJQCR7VE9VQ0h9ICR7UFJFRklY
 fS9saWIvb2NhbWwvb2NhbWxkb2MvY3VzdG9tLy5rZWVwCiAuaWYgIWRlZmluZWQoV0lUSE9VVF9U
 SykKQEAgLTE2Myw2ICsxOTIsNSBAQAogCQkke1NFRH0gInMsXiR7UFJFRklYfS8sLCIgPj4gJHtU
 TVBQTElTVH0KIAlAJHtFQ0hPX0NNRH0gIkBkaXJybSBsaWIvb2NhbWwvY29tcGlsZXItbGliIiA+
 PiAke1RNUFBMSVNUfQogLmVuZGlmCi0JQCR7RUNIT19DTUR9ICJAdW5leGVjIHJtZGlyICIlRC9s
 aWIvb2NhbWwiIDI+L2Rldi9udWxsIHx8IHRydWUiID4+ICR7VE1QUExJU1R9CiAKIC5pbmNsdWRl
 IDxic2QucG9ydC5wb3N0Lm1rPgpJbmRleDogcGtnLXBsaXN0Cj09PT09PT09PT09PT09PT09PT09
 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KUkNTIGZpbGU6
 IC9ob21lL3BjdnMvcG9ydHMvbGFuZy9vY2FtbC9wa2ctcGxpc3QsdgpyZXRyaWV2aW5nIHJldmlz
 aW9uIDEuMzcKZGlmZiAtdSAtcjEuMzcgcGtnLXBsaXN0Ci0tLSBwa2ctcGxpc3QJMjUgT2N0IDIw
 MTEgMDg6MTQ6MzEgLTAwMDAJMS4zNworKysgcGtnLXBsaXN0CTIxIEZlYiAyMDEyIDAwOjQ5OjUz
 IC0wMDAwCkBAIC0xMDAzLDMgKzEwMDMsNCBAQAogQGRpcnJtIGxpYi9vY2FtbC9jYW1scDQKIEBk
 aXJybSBsaWIvb2NhbWwvY2FtbAogQGNvbW1lbnQgbGliL29jYW1sIHdpbGwgYmUgYWRkZWQgYnkg
 TWFrZWZpbGUKK0BkaXJybXRyeSBsaWIvb2NhbWwK
 --0016e6d7e0a0883c0004b9845d75--

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/160492: commit references a PR
Date: Thu, 23 Feb 2012 00:21:28 +0000 (UTC)

 bf          2012-02-23 00:21:15 UTC
 
   FreeBSD ports repository
 
   Modified files:
     lang/ocaml           Makefile pkg-plist 
   Log:
   respect CC [1]; fix Tcl/Tk dependencies; don't conflate -nox11 and
   -notk; add a test target; clean up
   
   PR:             160492 [1]
   Submitted by:   J. Beich (partial patch; under various pseudonyms?) [1]
   Approved by:    maintainer
   
   Revision  Changes    Path
   1.76      +35 -7     ports/lang/ocaml/Makefile
   1.38      +1 -0      ports/lang/ocaml/pkg-plist
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: open->closed 
State-Changed-By: bf 
State-Changed-When: Thu Feb 23 01:27:10 UTC 2012 
State-Changed-Why:  
Committed, with minor changes. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=160492 
>Unformatted:
