From amdmi3@amdmi3.ru  Fri Sep  2 19:45:55 2011
Return-Path: <amdmi3@amdmi3.ru>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 31B49106564A
	for <freebsd-gnats-submit@freebsd.org>; Fri,  2 Sep 2011 19:45:55 +0000 (UTC)
	(envelope-from amdmi3@amdmi3.ru)
Received: from smtp.timeweb.ru (smtp.timeweb.ru [92.53.116.15])
	by mx1.freebsd.org (Postfix) with ESMTP id E15B48FC08
	for <freebsd-gnats-submit@freebsd.org>; Fri,  2 Sep 2011 19:45:54 +0000 (UTC)
Received: from [213.148.20.85] (helo=hive.panopticon)
	by smtp.timeweb.ru with esmtpsa (TLSv1:CAMELLIA256-SHA:256)
	(Exim 4.76)
	(envelope-from <amdmi3@amdmi3.ru>)
	id 1QzZgV-0003HA-Ve; Fri, 02 Sep 2011 23:45:51 +0400
Received: from hades.panopticon (hades.panopticon [192.168.0.32])
	by hive.panopticon (Postfix) with ESMTP id 4DB2FB866;
	Fri,  2 Sep 2011 23:45:51 +0400 (MSD)
Received: by hades.panopticon (Postfix, from userid 1000)
	id 4055FB845; Fri,  2 Sep 2011 23:45:51 +0400 (MSD)
Message-Id: <20110902194551.4055FB845@hades.panopticon>
Date: Fri,  2 Sep 2011 23:45:51 +0400 (MSD)
From: Dmitry Marakasov <amdmi3@amdmi3.ru>
To: FreeBSD-gnats-submit@freebsd.org
Cc: konstantin@saurbier.net
Subject: [PATCH] graphics/geos: add option to enable python bindings
X-Send-Pr-Version: 3.113
X-GNATS-Notify: konstantin@saurbier.net

>Number:         160406
>Category:       ports
>Synopsis:       [PATCH] graphics/geos: add option to enable python bindings
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    beech
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Fri Sep 02 19:50:09 UTC 2011
>Closed-Date:    Tue Sep 13 16:51:47 UTC 2011
>Last-Modified:  Tue Sep 13 17:00:21 UTC 2011
>Originator:     Dmitry Marakasov
>Release:        FreeBSD 8.2-RELEASE i386
>Organization:
>Environment:
System: FreeBSD hades.panopticon 8.2-RELEASE FreeBSD 8.2-RELEASE #0: Tue Mar  8 09:48:52 MSK
>Description:
geos has an option to enable python bindings, so add support for it in the port.

While here, canonicalize case in the Makefile, add explicit GNU_CONFIGURE (though USE_AUTOTOOLS=libtool implies it, its unapparent and confusing) and sort plist.

Port maintainer (konstantin@saurbier.net) is cc'd.

Generated with FreeBSD Port Tools 0.99
>How-To-Repeat:
>Fix:

--- geos-3.3.0_2.patch begins here ---
Index: Makefile
===================================================================
RCS file: /home/amdmi3/projects/freebsd/FreeBSD.cvs/ports/graphics/geos/Makefile,v
retrieving revision 1.28
diff -u -u -r1.28 Makefile
--- Makefile	29 Jun 2011 17:19:18 -0000	1.28
+++ Makefile	2 Sep 2011 19:41:25 -0000
@@ -7,7 +7,7 @@
 
 PORTNAME=	geos
 PORTVERSION=	3.3.0
-PORTREVISION=	1
+PORTREVISION=	2
 CATEGORIES=	graphics geography
 MASTER_SITES=	http://download.osgeo.org/geos/
 
@@ -17,9 +17,24 @@
 LICENSE=	LGPL21
 
 USE_AUTOTOOLS=	libtool
-USE_BZIP2=	YES
-USE_GMAKE=	YES
-USE_LDCONFIG=	YES
+USE_BZIP2=	yes
+USE_GMAKE=	yes
+USE_LDCONFIG=	yes
+GNU_CONFIGURE=	yes
+
+OPTIONS=	PYTHON "Enable python bindings" off
+
+.include <bsd.port.options.mk>
+
+.if defined(WITH_PYTHON)
+USE_PYTHON=	yes
+CONFIGURE_ARGS+=--enable-python
+PLIST_SUB+=	PYTHON=""
+BUILD_DEPENDS+=	swig:${PORTSDIR}/devel/swig13
+PKGNAMESUFFIX=	-python
+.else
+PLIST_SUB+=	PYTHON="@comment "
+.endif
 
 post-install:
 		@${LN} -s ${PREFIX}/lib/libgeos-${PORTVERSION}.so ${PREFIX}/lib/libgeos.so.0
Index: pkg-plist
===================================================================
RCS file: /home/amdmi3/projects/freebsd/FreeBSD.cvs/ports/graphics/geos/pkg-plist,v
retrieving revision 1.14
diff -u -u -r1.14 pkg-plist
--- pkg-plist	29 Jun 2011 17:19:18 -0000	1.14
+++ pkg-plist	2 Sep 2011 19:41:25 -0000
@@ -357,14 +357,23 @@
 include/geos/version.h
 include/geos_c.h
 lib/libgeos-3.3.0.so
-lib/libgeos.so.0
 lib/libgeos.a
 lib/libgeos.la
 lib/libgeos.so
+lib/libgeos.so.0
 lib/libgeos_c.a
 lib/libgeos_c.la
 lib/libgeos_c.so
 lib/libgeos_c.so.8
+%%PYTHON%%%%PYTHON_SITELIBDIR%%/geos.pth
+%%PYTHON%%%%PYTHON_SITELIBDIR%%/geos/_geos.a
+%%PYTHON%%%%PYTHON_SITELIBDIR%%/geos/_geos.la
+%%PYTHON%%%%PYTHON_SITELIBDIR%%/geos/_geos.so
+%%PYTHON%%%%PYTHON_SITELIBDIR%%/geos/geos.py
+%%PYTHON%%%%PYTHON_SITELIBDIR%%/geos/geos.pyc
+%%PYTHON%%%%PYTHON_SITELIBDIR%%/geos/geos.pyo
+%%PYTHON%%@dirrm %%PYTHON_SITELIBDIR%%/geos
+%%PYTHON%%@dirrm %%PYTHON_SITELIBDIR%%
 @dirrm lib/geos
 @dirrm include/geos/util
 @dirrm include/geos/simplify
--- geos-3.3.0_2.patch ends here ---

>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->feedback 
State-Changed-By: edwin 
State-Changed-When: Fri Sep 2 19:50:21 UTC 2011 
State-Changed-Why:  
Awaiting maintainers feedback (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=160406 

From: Edwin Groothuis <edwin@FreeBSD.org>
To: konstantin@saurbier.net
Cc: bug-followup@FreeBSD.org
Subject: Re: ports/160406: [PATCH] graphics/geos: add option to enable python bindings
Date: Fri, 2 Sep 2011 19:50:19 UT

 Maintainer of graphics/geos,
 
 Please note that PR ports/160406 has just been submitted.
 
 If it contains a patch for an upgrade, an enhancement or a bug fix
 you agree on, reply to this email stating that you approve the patch
 and a committer will take care of it.
 
 The full text of the PR can be found at:
     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/160406
 
 -- 
 Edwin Groothuis via the GNATS Auto Assign Tool
 edwin@FreeBSD.org
Responsible-Changed-From-To: freebsd-ports-bugs->beech 
Responsible-Changed-By: beech 
Responsible-Changed-When: Fri Sep 2 20:38:46 UTC 2011 
Responsible-Changed-Why:  
I'll take it 

http://www.freebsd.org/cgi/query-pr.cgi?pr=160406 

From: Konstantin Saurbier <konstantin@saurbier.net>
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/160406: [PATCH] graphics/geos: add option to enable python bindings
Date: Tue, 13 Sep 2011 17:38:08 +0200

 --Apple-Mail=_A642C319-FB4C-431D-BBD7-A8FFF6DEBB97
 Content-Transfer-Encoding: 7bit
 Content-Type: text/plain;
 	charset=us-ascii
 
 Hi,
 
 I approve the patch, please commit it!
 
 Best regards,
 Konstantin Saurbier
 
 
 --Apple-Mail=_A642C319-FB4C-431D-BBD7-A8FFF6DEBB97
 Content-Transfer-Encoding: 7bit
 Content-Disposition: inline;
 	filename=signature.asc
 Content-Type: application/pgp-signature;
 	name=signature.asc
 Content-Description: Message signed with OpenPGP using GPGMail
 
 -----BEGIN PGP SIGNATURE-----
 
 iEYEARECAAYFAk5veOAACgkQWkvQTx5k+y79jwCdGW2M6wwuXWm0/l1kYmXxFmnm
 DQ0An0yUYVxl9ijnISZ9qrqadH9OMVxM
 =StTF
 -----END PGP SIGNATURE-----
 
 --Apple-Mail=_A642C319-FB4C-431D-BBD7-A8FFF6DEBB97--
State-Changed-From-To: feedback->open 
State-Changed-By: beech 
State-Changed-When: Tue Sep 13 15:58:59 UTC 2011 
State-Changed-Why:  
Maintainer approved 

http://www.freebsd.org/cgi/query-pr.cgi?pr=160406 
State-Changed-From-To: open->closed 
State-Changed-By: beech 
State-Changed-When: Tue Sep 13 16:51:33 UTC 2011 
State-Changed-Why:  
Committed, Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=160406 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/160406: commit references a PR
Date: Tue, 13 Sep 2011 16:51:26 +0000 (UTC)

 beech       2011-09-13 16:51:12 UTC
 
   FreeBSD ports repository
 
   Modified files:
     graphics/geos        Makefile pkg-plist 
   Log:
   - Enable python bindings.
   - Canonicalize case in Makefile.
   - Add explicit GNU_CONFIGURE (though USE_AUTOTOOLS=libtool implies it, it's
     unapparent and confusing).
   - Sort plist.
   - Bump portrevision.
   
   PR:             ports/160406
   Submitted by:   Dmitry Marakasov <amdmi3@amdmi3.ru>
   Approved by:    Konstantin Saurbier <konstantin@saurbier.net> (maintainer)
   
   Revision  Changes    Path
   1.29      +19 -4     ports/graphics/geos/Makefile
   1.15      +10 -1     ports/graphics/geos/pkg-plist
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
