From Peter.Jeremy@alcatel-lucent.com  Thu Sep  1 05:15:20 2011
Return-Path: <Peter.Jeremy@alcatel-lucent.com>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 0C3C71065FD6
	for <FreeBSD-gnats-submit@freebsd.org>; Thu,  1 Sep 2011 05:14:48 +0000 (UTC)
	(envelope-from Peter.Jeremy@alcatel-lucent.com)
Received: from ihemail1.lucent.com (ihemail1.lucent.com [135.245.0.33])
	by mx1.freebsd.org (Postfix) with ESMTP id B9CF28FC08
	for <FreeBSD-gnats-submit@freebsd.org>; Thu,  1 Sep 2011 05:14:47 +0000 (UTC)
Received: from usnavsmail3.ndc.alcatel-lucent.com (usnavsmail3.ndc.alcatel-lucent.com [135.3.39.11])
	by ihemail1.lucent.com (8.13.8/IER-o) with ESMTP id p815EkSK019678
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <FreeBSD-gnats-submit@freebsd.org>; Thu, 1 Sep 2011 00:14:47 -0500 (CDT)
Received: from unixmail.au.alcatel-lucent.com (unixmail.au.alcatel-lucent.com [139.188.42.130])
	by usnavsmail3.ndc.alcatel-lucent.com (8.14.3/8.14.3/GMO) with ESMTP id p815EgGv022116
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT)
	for <FreeBSD-gnats-submit@freebsd.org>; Thu, 1 Sep 2011 00:14:46 -0500
Received: from insmb.au.alcatel-lucent.com (insmb.au.alcatel-lucent.com [139.188.42.184])
	by unixmail.au.alcatel-lucent.com (8.13.8+Sun/8.13.3) with ESMTP id p815EgBo010262
	for <FreeBSD-gnats-submit@freebsd.org>; Thu, 1 Sep 2011 15:14:42 +1000 (EST)
Received: from pjdesk.au.alcatel-lucent.com (pjdesk.au.alcatel-lucent.com [139.188.2.2])
	by insmb.au.alcatel-lucent.com (8.13.8+Sun/8.13.8) with ESMTP id p8157BKB019335
	for <FreeBSD-gnats-submit@freebsd.org>; Thu, 1 Sep 2011 15:07:11 +1000 (EST)
Received: from pjdesk.au.alcatel-lucent.com (localhost [127.0.0.1])
	by pjdesk.au.alcatel-lucent.com (8.14.4/8.14.4) with ESMTP id p81575er093217;
	Thu, 1 Sep 2011 15:07:05 +1000 (EST)
	(envelope-from pjeremy@pjdesk.au.alcatel-lucent.com)
Received: (from pjeremy@localhost)
	by pjdesk.au.alcatel-lucent.com (8.14.4/8.14.4/Submit) id p81575hM093216;
	Thu, 1 Sep 2011 15:07:05 +1000 (EST)
	(envelope-from pjeremy)
Message-Id: <201109010507.p81575hM093216@pjdesk.au.alcatel-lucent.com>
Date: Thu, 1 Sep 2011 15:07:05 +1000 (EST)
From: Peter Jeremy <Peter.Jeremy@alcatel-lucent.com>
Reply-To: Peter Jeremy <Peter.Jeremy@alcatel-lucent.com>
To: FreeBSD-gnats-submit@freebsd.org
Subject: net-im/pidgin-sipe has undocumented NSS dependency
X-Send-Pr-Version: 3.113
X-GNATS-Notify: john.c.prather@gmail.com

>Number:         160352
>Category:       ports
>Synopsis:       net-im/pidgin-sipe has undocumented NSS dependency
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    pawel
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Thu Sep 01 05:20:08 UTC 2011
>Closed-Date:    Tue Oct 18 20:02:01 UTC 2011
>Last-Modified:  Tue Oct 18 20:10:10 UTC 2011
>Originator:     Peter Jeremy
>Release:        FreeBSD 8.2-STABLE amd64
>Organization:
n/a
>Environment:
System: FreeBSD pjdesk.au.alcatel-lucent.com 8.2-STABLE FreeBSD 8.2-STABLE #6: Mon Feb 28 10:09:48 EST 2011 root@C2B0004103.au.alcatel-lucent.com:/var/obj/usr/src/sys/pjdesk amd64

pidgin-sipe-1.11.2_3

>Description:
	By default, pidgin-sipe uses pkg-config to include the first of
	"nss" (security/nss), "mozilla-nss" (www/libxul) or "microb-engine-nss"
	(not a FreeBSD port AFAIK) to provide NSS functionality.  None of
	these are listed as dependencies.

	By default, net-im/libpurple and net-im/pidgin both include a
	dependency on security/nss (via a config option) and this will
	be inherited by pidgin-sipe.  If this dependency is disabled but
	either security/nss or www/libxul are installed for other reasons,
	pidgin-sipe will have an unlisted dependency on that package.

	Note that if libxul-1.9.2.17_1 is installed without security/nss
	being installed, pidgin-sipe will fail to build because mozilla-nss
	is currently broken (see ports/160351).

	It's possible there are other undocumented implicit dependencies,
	I only noticed this one due to the mozilla-nss breakage.

>How-To-Repeat:
	Build and install net-im/libpurple and net-im/pidgin with NSS disabled.
	Build and install security/nss
	Build and install pidgin-sipe

	pkg_info -r pidgin-sipe-1.11.2_3 | grep nss
	pkg_info -R nss-\* | grep pidgin
	show no dependency is recorded.

	ldd /usr/local/lib/purple-2/libsipe.so | grep nss
	shows pidgin-sipe depends on files in security/nss

>Fix:
	The NSS dependency in pidgin-sipe cannot be disabled via a
	configure knob so pidgin-sipe should probably have a LIB_DEPENDS
	on security/nss.
>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->feedback 
State-Changed-By: edwin 
State-Changed-When: Thu Sep 1 05:26:03 UTC 2011 
State-Changed-Why:  
Awaiting maintainers feedback (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=160352 

From: Edwin Groothuis <edwin@FreeBSD.org>
To: john.c.prather@gmail.com
Cc: bug-followup@FreeBSD.org
Subject: Re: ports/160352: net-im/pidgin-sipe has undocumented NSS dependency
Date: Thu, 1 Sep 2011 05:26:01 UT

 Maintainer of net-im/pidgin-sipe,
 
 Please note that PR ports/160352 has just been submitted.
 
 If it contains a patch for an upgrade, an enhancement or a bug fix
 you agree on, reply to this email stating that you approve the patch
 and a committer will take care of it.
 
 The full text of the PR can be found at:
     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/160352
 
 -- 
 Edwin Groothuis via the GNATS Auto Assign Tool
 edwin@FreeBSD.org

From: John Prather <john.c.prather@gmail.com>
To: bug-followup@freebsd.org
Cc:  
Subject: Re: ports/160352: net-im/pidgin-sipe has undocumented NSS dependency
Date: Wed, 31 Aug 2011 23:32:40 -0700

 Good find, thanks!  I can provide an actual patch if needed.  Go ahead
 and commit it if you have one ready.
 
 -john
 
 On Wed, Aug 31, 2011 at 10:26 PM, Edwin Groothuis <edwin@freebsd.org> wrote=
 :
 > Maintainer of net-im/pidgin-sipe,
 >
 > Please note that PR ports/160352 has just been submitted.
 >
 > If it contains a patch for an upgrade, an enhancement or a bug fix
 > you agree on, reply to this email stating that you approve the patch
 > and a committer will take care of it.
 >
 > The full text of the PR can be found at:
 > =A0 =A0http://www.freebsd.org/cgi/query-pr.cgi?pr=3Dports/160352
 >
 > --
 > Edwin Groothuis via the GNATS Auto Assign Tool
 > edwin@FreeBSD.org
 >
Responsible-Changed-From-To: freebsd-ports-bugs->pawel 
Responsible-Changed-By: pawel 
Responsible-Changed-When: Tue Oct 18 14:02:00 UTC 2011 
Responsible-Changed-Why:  
I'll take it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=160352 
State-Changed-From-To: feedback->closed 
State-Changed-By: pawel 
State-Changed-When: Tue Oct 18 20:01:59 UTC 2011 
State-Changed-Why:  
Committed. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=160352 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/160352: commit references a PR
Date: Tue, 18 Oct 2011 20:01:18 +0000 (UTC)

 pawel       2011-10-18 20:01:09 UTC
 
   FreeBSD ports repository
 
   Modified files:
     net-im/pidgin-sipe   Makefile 
   Log:
   Depend on security/nss, fixes misssing dep when net-im/libpurple and
   net-im/pidgin are build without NSS support - this port still links
   to it when it's available and this behaviour can be disabled.
   
   PR:             ports/160352
   Reported by:    Peter Jeremy <Peter.Jeremy@alcatel-lucent.com>
   Approved by:    maintainer
   
   Revision  Changes    Path
   1.31      +3 -2      ports/net-im/pidgin-sipe/Makefile
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
