From nobody@FreeBSD.org  Tue Aug 30 14:43:03 2011
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 38E70106564A
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 30 Aug 2011 14:43:03 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22])
	by mx1.freebsd.org (Postfix) with ESMTP id 1E52B8FC0A
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 30 Aug 2011 14:43:03 +0000 (UTC)
Received: from red.freebsd.org (localhost [127.0.0.1])
	by red.freebsd.org (8.14.4/8.14.4) with ESMTP id p7UEh2dC026421
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 30 Aug 2011 14:43:02 GMT
	(envelope-from nobody@red.freebsd.org)
Received: (from nobody@localhost)
	by red.freebsd.org (8.14.4/8.14.4/Submit) id p7UEh2Bg026416;
	Tue, 30 Aug 2011 14:43:02 GMT
	(envelope-from nobody)
Message-Id: <201108301443.p7UEh2Bg026416@red.freebsd.org>
Date: Tue, 30 Aug 2011 14:43:02 GMT
From: David Robertson <david.robertson@adestra.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: net-snmp UCD-SNMP-MIB::dskTable does not report correct disk usage
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         160314
>Category:       ports
>Synopsis:       net-mgmt/net-snmp: UCD-SNMP-MIB::dskTable does not report correct disk usage
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    sylvio
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Aug 30 14:50:05 UTC 2011
>Closed-Date:    Wed Sep 07 01:50:20 UTC 2011
>Last-Modified:  Wed Sep 07 01:50:20 UTC 2011
>Originator:     David Robertson
>Release:        FreeBSD 8.2
>Organization:
Adestra Ltd
>Environment:
FreeBSD bloater.adestra.com 8.2-RELEASE FreeBSD 8.2-RELEASE #0: Thu Feb 17 02:41:51 UTC 2011     root@mason.cse.buffalo.edu:/usr/obj/usr/src/sys/GENERIC  amd64
>Description:
Hi,

As of net-snmp 5.7 - 5.7_2 disk space is incorrectly reported.  Any ideas
what is going wrong here.  The /usr partition is being reported as having
-8% free.

FreeBSD 8.2

net-snmp 5.7_2

snmpd.conf contains

disk    /     10%
disk    /tmp  10%
disk    /var  10%
disk    /usr  10%

df -h

Filesystem       Size    Used   Avail Capacity  Mounted on
/dev/mfid0s1a    989M    315M    595M    35%    /
/dev/mfid0s1e    9.7G     12K    8.9G     0%    /tmp
/dev/mfid0s1f    209G     46G    147G    24%    /usr
/dev/mfid0s1d     19G    1.4G     16G     8%    /var

snmpwalk -v 2c -c public localhost UCD-SNMP-MIB::dskTable

UCD-SNMP-MIB::dskIndex.1 = INTEGER: 0
UCD-SNMP-MIB::dskIndex.2 = INTEGER: 1
UCD-SNMP-MIB::dskIndex.3 = INTEGER: 2
UCD-SNMP-MIB::dskIndex.4 = INTEGER: 3
UCD-SNMP-MIB::dskPath.1 = STRING: /
UCD-SNMP-MIB::dskPath.2 = STRING: /tmp
UCD-SNMP-MIB::dskPath.3 = STRING: /var
UCD-SNMP-MIB::dskPath.4 = STRING: /usr
UCD-SNMP-MIB::dskDevice.1 = STRING: /dev/mfid0s1a
UCD-SNMP-MIB::dskDevice.2 = STRING: /dev/mfid0s1e
UCD-SNMP-MIB::dskDevice.3 = STRING: /dev/mfid0s1d
UCD-SNMP-MIB::dskDevice.4 = STRING: /dev/mfid0s1f
UCD-SNMP-MIB::dskMinimum.1 = INTEGER: -1
UCD-SNMP-MIB::dskMinimum.2 = INTEGER: -1
UCD-SNMP-MIB::dskMinimum.3 = INTEGER: -1
UCD-SNMP-MIB::dskMinimum.4 = INTEGER: -1
UCD-SNMP-MIB::dskMinPercent.1 = INTEGER: 10
UCD-SNMP-MIB::dskMinPercent.2 = INTEGER: 10
UCD-SNMP-MIB::dskMinPercent.3 = INTEGER: 10
UCD-SNMP-MIB::dskMinPercent.4 = INTEGER: 10
UCD-SNMP-MIB::dskTotal.1 = INTEGER: 1012974
UCD-SNMP-MIB::dskTotal.2 = INTEGER: 10154158
UCD-SNMP-MIB::dskTotal.3 = INTEGER: 20308398
UCD-SNMP-MIB::dskTotal.4 = INTEGER: 219227030
UCD-SNMP-MIB::dskAvail.1 = INTEGER: 609596
UCD-SNMP-MIB::dskAvail.2 = INTEGER: 9341814
UCD-SNMP-MIB::dskAvail.3 = INTEGER: 17233700
UCD-SNMP-MIB::dskAvail.4 = INTEGER: 153871682
UCD-SNMP-MIB::dskUsed.1 = INTEGER: 322342
UCD-SNMP-MIB::dskUsed.2 = INTEGER: 12
UCD-SNMP-MIB::dskUsed.3 = INTEGER: 1450028
UCD-SNMP-MIB::dskUsed.4 = INTEGER: 47817186
UCD-SNMP-MIB::dskPercent.1 = INTEGER: 31
UCD-SNMP-MIB::dskPercent.2 = INTEGER: 0
UCD-SNMP-MIB::dskPercent.3 = INTEGER: 7
UCD-SNMP-MIB::dskPercent.4 = INTEGER: -17
UCD-SNMP-MIB::dskPercentNode.1 = INTEGER: 1
UCD-SNMP-MIB::dskPercentNode.2 = INTEGER: 0
UCD-SNMP-MIB::dskPercentNode.3 = INTEGER: 4
UCD-SNMP-MIB::dskPercentNode.4 = INTEGER: 1
UCD-SNMP-MIB::dskTotalLow.1 = Gauge32: 1012974
UCD-SNMP-MIB::dskTotalLow.2 = Gauge32: 10154158
UCD-SNMP-MIB::dskTotalLow.3 = Gauge32: 20308398
UCD-SNMP-MIB::dskTotalLow.4 = Gauge32: 219227030
UCD-SNMP-MIB::dskTotalHigh.1 = Gauge32: 0
UCD-SNMP-MIB::dskTotalHigh.2 = Gauge32: 0
UCD-SNMP-MIB::dskTotalHigh.3 = Gauge32: 0
UCD-SNMP-MIB::dskTotalHigh.4 = Gauge32: 0
UCD-SNMP-MIB::dskAvailLow.1 = Gauge32: 609596
UCD-SNMP-MIB::dskAvailLow.2 = Gauge32: 9341814
UCD-SNMP-MIB::dskAvailLow.3 = Gauge32: 17233700
UCD-SNMP-MIB::dskAvailLow.4 = Gauge32: 153871682
UCD-SNMP-MIB::dskAvailHigh.1 = Gauge32: 0
UCD-SNMP-MIB::dskAvailHigh.2 = Gauge32: 0
UCD-SNMP-MIB::dskAvailHigh.3 = Gauge32: 0
UCD-SNMP-MIB::dskAvailHigh.4 = Gauge32: 0
UCD-SNMP-MIB::dskUsedLow.1 = Gauge32: 322342
UCD-SNMP-MIB::dskUsedLow.2 = Gauge32: 12
UCD-SNMP-MIB::dskUsedLow.3 = Gauge32: 1450028
UCD-SNMP-MIB::dskUsedLow.4 = Gauge32: 47817186
UCD-SNMP-MIB::dskUsedHigh.1 = Gauge32: 0
UCD-SNMP-MIB::dskUsedHigh.2 = Gauge32: 0
UCD-SNMP-MIB::dskUsedHigh.3 = Gauge32: 0
UCD-SNMP-MIB::dskUsedHigh.4 = Gauge32: 0
UCD-SNMP-MIB::dskErrorFlag.1 = INTEGER: noError(0)
UCD-SNMP-MIB::dskErrorFlag.2 = INTEGER: noError(0)
UCD-SNMP-MIB::dskErrorFlag.3 = INTEGER: noError(0)
UCD-SNMP-MIB::dskErrorFlag.4 = INTEGER: error(1)
UCD-SNMP-MIB::dskErrorMsg.1 = STRING:
UCD-SNMP-MIB::dskErrorMsg.2 = STRING:
UCD-SNMP-MIB::dskErrorMsg.3 = STRING:
UCD-SNMP-MIB::dskErrorMsg.4 = STRING: /usr: less than 10% free (= -8%)

Many thanks for any assistance.

Regards

David 
>How-To-Repeat:

>Fix:


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->sylvio 
Responsible-Changed-By: linimon 
Responsible-Changed-When: Tue Aug 30 17:20:29 UTC 2011 
Responsible-Changed-Why:  
Fix synopsis and assign. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=160314 

From: David <david.robertson@adestra.com>
To: bug-followup@FreeBSD.org, david.robertson@adestra.com
Cc:  
Subject: Re: ports/160314: net-mgmt/net-snmp: UCD-SNMP-MIB::dskTable does
 not report correct disk usage
Date: Wed, 31 Aug 2011 12:20:02 +0100

 Sorry, I think that patch should have looked more like this.
 
 --- agent/mibgroup/ucd-snmp/disk_hw.c.orig      2011-08-31 
 11:22:10.000000000 +0
 +++ agent/mibgroup/ucd-snmp/disk_hw.c   2011-08-31 11:28:27.000000000 +0100
 @@ -245,7 +245,7 @@
 
 
   static int _percent( int value, int total ) {
 -    return (int)( value * 100 ) / total;
 +    return (int)( value / (total / 100));
   }
 
   static netsnmp_fsys_info **
 
 Regards
 
 David Robertson

From: David <david.robertson@adestra.com>
To: bug-followup@FreeBSD.org, david.robertson@adestra.com
Cc:  
Subject: Re: ports/160314: net-mgmt/net-snmp: UCD-SNMP-MIB::dskTable does
 not report correct disk usage
Date: Wed, 31 Aug 2011 11:53:58 +0100

 Hi,
 
 This is due to the way percentages are calculated.
 Here is a patch that fixes the problem.
 
 --- agent/mibgroup/ucd-snmp/disk_hw.c   2011-08-31 11:22:10.000000000 +0100
 +++ agent/mibgroup/ucd-snmp/disk_hw.c   2011-08-31 11:28:27.000000000 +0100
 @@ -245,7 +245,7 @@
 
 
   static int _percent( int value, int total ) {
 -    return (int)( value * 100 ) / total;
 +    return (int)( value / (total / 100));
   }
 
   static netsnmp_fsys_info **
 
 Many thanks
 
 David
State-Changed-From-To: open->closed 
State-Changed-By: sylvio 
State-Changed-When: Wed Sep 7 01:50:18 UTC 2011 
State-Changed-Why:  
Committed. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=160314 
>Unformatted:
