From takefu@airport.fm  Thu Aug 25 07:42:09 2011
Return-Path: <takefu@airport.fm>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id A82031065672;
	Thu, 25 Aug 2011 07:42:09 +0000 (UTC)
	(envelope-from takefu@airport.fm)
Received: from ae-osaka.co.jp (unknown [IPv6:2001:3e0:4ec:a000::1])
	by mx1.freebsd.org (Postfix) with ESMTP id 592B78FC08;
	Thu, 25 Aug 2011 07:42:09 +0000 (UTC)
Received: from ae-osaka.co.jp (localhost.ae-osaka.co.jp [127.0.0.1])
	by ae-osaka.co.jp (Postfix) with ESMTP id C01AC1145A;
	Thu, 25 Aug 2011 16:42:08 +0900 (JST)
Received: from ae-osaka.co.jp ([127.0.0.1])
	by ae-osaka.co.jp (ae-osaka.co.jp [127.0.0.1]) (amavisd-new, port 10024)
	with LMTP id nK8l-CtxkR8n; Thu, 25 Aug 2011 16:42:08 +0900 (JST)
Received: from [IPv6:2001:3e0:4ec:a011:441d:1c52:5a02:73c] (unknown [IPv6:2001:3e0:4ec:a011:441d:1c52:5a02:73c])
	by ae-osaka.co.jp (Postfix) with ESMTPSA id 7A29D1144C;
	Thu, 25 Aug 2011 16:42:08 +0900 (JST)
Message-Id: <4E55FCCF.70401@airport.fm>
Date: Thu, 25 Aug 2011 16:42:07 +0900
From: Takefu <takefu@airport.fm>
Reply-To: takefu@airport.fm
To: freebsd-gnats-submit@freebsd.org, ports@FreeBSD.org
In-Reply-To: <201108250706.p7P76Uun077737@unbound.local.ae-osaka.co.jp>
Subject: [PATCH] japanese/jcode.pl Fix defined(%hash) is deprecated
References: <201108250706.p7P76Uun077737@unbound.local.ae-osaka.co.jp>

>Number:         160174
>Category:       ports
>Synopsis:       [PATCH] japanese/jcode.pl Fix defined(%hash) is deprecated
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    tota
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Thu Aug 25 07:50:09 UTC 2011
>Closed-Date:    Mon Oct 03 21:51:26 UTC 2011
>Last-Modified:  Sun Mar 17 04:53:35 UTC 2013
>Originator:     Takefu
>Release:        FreeBSD 8.2 amd64
>Organization:
FOX Amateur Radio Club
>Environment:
>Description:
  lang/perl5.12 or lang/perl5.14 problems occur in combination.
  z2h_euc z2h_sjis and was out of the way to improve call and message.

# fined(%hash) is deprecated at /usr/local/lib/perl5/site_perl/5.12.1/jcode.pl line 684.
# 	(Maybe you should just omit the defined()?)
# defined(%hash) is deprecated at /usr/local/lib/perl5/site_perl/5.12.1/jcode.pl line 693.
# 	(Maybe you should just omit the defined()?)

  see PR#149544

>How-To-Repeat:
#!/usr/local/bin/perl
require "jcode.pl";
$data = "";
jcode::z2h_sjis(\$data);
exit;

>Fix:
--- ja-jcode.pl.patch begins here ---
diff -ruN /usr/ports/japanese/jcode.pl/Makefile japanese/jcode.pl/Makefile
--- /usr/ports/japanese/jcode.pl/Makefile	2011-05-30 10:51:40.000000000 +0900
+++ japanese/jcode.pl/Makefile	2011-08-24 15:10:04.000000000 +0900
@@ -7,26 +7,27 @@

 PORTNAME=	jcode.pl
 PORTVERSION=	2.13
+PORTREVISION=	1
 CATEGORIES=	japanese perl5
 MASTER_SITES=	ftp://ftp.iij.ad.jp/pub/IIJ/dist/utashiro/perl/ \
-		ftp://ftp.sra.co.jp/pub/lang/perl/sra-scripts/ \
-		http://srekcah.org/jcode/
-EXTRACT_SUFX=	# none
+		ftp://ftp.sra.co.jp/pub/lang/perl/sra-scripts/
+EXTRACT_SUFX=

 MAINTAINER=	ports@FreeBSD.org
 COMMENT=	Perl library for Japanese character code conversion

+CONFLICTS=	ja-p5-jcode.pl-[0-9]*
+
 USE_PERL5_RUN=		yes
 NO_WRKSUBDIR=		yes
 NO_BUILD=		yes
 EXTRACT_CMD=		${CP}
 EXTRACT_BEFORE_ARGS=
-EXTRACT_AFTER_ARGS=	.
-
-PLIST_FILES=	%%SITE_PERL%%/${PORTNAME}
+EXTRACT_AFTER_ARGS=	${WRKDIR}
+PLIST_FILES=		${SITE_PERL_REL}/${PORTNAME}

 do-install:
-	${MKDIR} ${PREFIX}/${SITE_PERL_REL}/
+	${MKDIR} ${PREFIX}/${SITE_PERL_REL}
 	${INSTALL_DATA} ${WRKDIR}/${DISTNAME} ${PREFIX}/${SITE_PERL_REL}/${PORTNAME}

 .include <bsd.port.mk>
diff -ruN /usr/ports/japanese/jcode.pl/files/patch-aa japanese/jcode.pl/files/patch-aa
--- /usr/ports/japanese/jcode.pl/files/patch-aa	1970-01-01 09:00:00.000000000 +0900
+++ japanese/jcode.pl/files/patch-aa	2010-10-08 12:19:58.000000000 +0900
@@ -0,0 +1,20 @@
+--- jcode.pl-2.13.orig	2010-07-28 14:46:52.000000000 +0900
++++ jcode.pl-2.13	2010-07-28 14:51:52.000000000 +0900
+@@ -681,7 +681,7 @@
+
+ sub z2h_euc {
+     local(*s, $n) = @_;
+-    &init_z2h_euc unless defined %z2h_euc;
++    &init_z2h_euc unless %z2h_euc;
+     $s =~ s/($re_euc_c|$re_euc_kana)/
+ 	$z2h_euc{$1} ? ($n++, $z2h_euc{$1}) : $1
+     /geo;
+@@ -690,7 +690,7 @@
+
+ sub z2h_sjis {
+     local(*s, $n) = @_;
+-    &init_z2h_sjis unless defined %z2h_sjis;
++    &init_z2h_sjis unless %z2h_sjis;
+     $s =~ s/($re_sjis_c)/$z2h_sjis{$1} ? ($n++, $z2h_sjis{$1}) : $1/geo;
+     $n;
+ }
--- ja-jcode.pl.patch ends here ---
>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->tota 
Responsible-Changed-By: tota 
Responsible-Changed-When: Sat Oct 1 11:49:17 UTC 2011 
Responsible-Changed-Why:  
I'll take it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=160174 

From: TAKATSU Tomonari <tota@FreeBSD.org>
To: bug-followup@FreeBSD.org, takefu@airport.fm
Cc:  
Subject: Re: ports/160174: [PATCH] japanese/jcode.pl Fix defined(%hash) is deprecated
Date: Sat, 1 Oct 2011 21:51:14 +0900

 --0015175cff767c4cbf04ae3c3200
 Content-Type: text/plain; charset=ISO-8859-1
 
 Hi, Takefu-san
 
 I have modified your patch.
 
 - Remove CONFLICTS because ja-p5-jcode.pl was removed from ports tree [1]
 - Rename patch-aa to patch-jcode.pl [2]
 
 Please confirm it.
 
 [1] http://www.freebsd.org/cgi/cvsweb.cgi/ports/japanese/p5-jcode.pl/?hideattic=0#dirlist
 [2] see 4.4 Patching FreeBSD Porter's Handbook
      http://www.freebsd.org/doc/en/books/porters-handbook/slow-patch.html
 
 Thanks,
 
 -- 
 TAKATSU Tomonari
 
 --0015175cff767c4cbf04ae3c3200
 Content-Type: application/octet-stream; name="ja-jcode.pl-2.13_1.patch"
 Content-Disposition: attachment; filename="ja-jcode.pl-2.13_1.patch"
 Content-Transfer-Encoding: base64
 X-Attachment-Id: f_gt8ld0me0
 
 SW5kZXg6IE1ha2VmaWxlCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
 PT09PT09PT09PT09PT09PT09PT09PT09PT0KUkNTIGZpbGU6IC9ob21lL25jdnMvcG9ydHMvamFw
 YW5lc2UvamNvZGUucGwvTWFrZWZpbGUsdgpyZXRyaWV2aW5nIHJldmlzaW9uIDEuMTIKZGlmZiAt
 dSAtcjEuMTIgTWFrZWZpbGUKLS0tIE1ha2VmaWxlCTI4IE1heSAyMDExIDAxOjM4OjA0IC0wMDAw
 CTEuMTIKKysrIE1ha2VmaWxlCTEgT2N0IDIwMTEgMTI6MzM6MjYgLTAwMDAKQEAgLTcsMTAgKzcs
 MTAgQEAKIAogUE9SVE5BTUU9CWpjb2RlLnBsCiBQT1JUVkVSU0lPTj0JMi4xMworUE9SVFJFVklT
 SU9OPQkxCiBDQVRFR09SSUVTPQlqYXBhbmVzZSBwZXJsNQogTUFTVEVSX1NJVEVTPQlmdHA6Ly9m
 dHAuaWlqLmFkLmpwL3B1Yi9JSUovZGlzdC91dGFzaGlyby9wZXJsLyBcCi0JCWZ0cDovL2Z0cC5z
 cmEuY28uanAvcHViL2xhbmcvcGVybC9zcmEtc2NyaXB0cy8gXAotCQlodHRwOi8vc3Jla2NhaC5v
 cmcvamNvZGUvCisJCWZ0cDovL2Z0cC5zcmEuY28uanAvcHViL2xhbmcvcGVybC9zcmEtc2NyaXB0
 cy8KIEVYVFJBQ1RfU1VGWD0JIyBub25lCiAKIE1BSU5UQUlORVI9CXBvcnRzQEZyZWVCU0Qub3Jn
 CkBAIC0yMCwxMyArMjAsMTIgQEAKIE5PX1dSS1NVQkRJUj0JCXllcwogTk9fQlVJTEQ9CQl5ZXMK
 IEVYVFJBQ1RfQ01EPQkJJHtDUH0KLUVYVFJBQ1RfQkVGT1JFX0FSR1M9Ci1FWFRSQUNUX0FGVEVS
 X0FSR1M9CS4KLQotUExJU1RfRklMRVM9CSUlU0lURV9QRVJMJSUvJHtQT1JUTkFNRX0KK0VYVFJB
 Q1RfQkVGT1JFX0FSR1M9CSMgbm9uZQorRVhUUkFDVF9BRlRFUl9BUkdTPQkke1dSS0RJUn0vJHtQ
 T1JUTkFNRX0KK1BMSVNUX0ZJTEVTPQkJJHtTSVRFX1BFUkxfUkVMfS8ke1BPUlROQU1FfQogCiBk
 by1pbnN0YWxsOgotCSR7TUtESVJ9ICR7UFJFRklYfS8ke1NJVEVfUEVSTF9SRUx9LwotCSR7SU5T
 VEFMTF9EQVRBfSAke1dSS0RJUn0vJHtESVNUTkFNRX0gJHtQUkVGSVh9LyR7U0lURV9QRVJMX1JF
 TH0vJHtQT1JUTkFNRX0KKwkke01LRElSfSAke1BSRUZJWH0vJHtTSVRFX1BFUkxfUkVMfQorCSR7
 SU5TVEFMTF9EQVRBfSAke1dSS0RJUn0vJHtQT1JUTkFNRX0gJHtQUkVGSVh9LyR7U0lURV9QRVJM
 X1JFTH0vCiAKIC5pbmNsdWRlIDxic2QucG9ydC5taz4KSW5kZXg6IGZpbGVzL3BhdGNoLWpjb2Rl
 LnBsCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
 PT09PT09PT09PT09PT0KUkNTIGZpbGU6IGZpbGVzL3BhdGNoLWpjb2RlLnBsCmRpZmYgLU4gZmls
 ZXMvcGF0Y2gtamNvZGUucGwKLS0tIC9kZXYvbnVsbAkxIEphbiAxOTcwIDAwOjAwOjAwIC0wMDAw
 CisrKyBmaWxlcy9wYXRjaC1qY29kZS5wbAkxIE9jdCAyMDExIDEyOjM3OjQ3IC0wMDAwCkBAIC0w
 LDAgKzEsMjAgQEAKKy0tLSBqY29kZS5wbC5vcmlnCTIwMTAtMDctMjggMTQ6NDY6NTIuMDAwMDAw
 MDAwICswOTAwCisrKysgamNvZGUucGwJMjAxMC0wNy0yOCAxNDo1MTo1Mi4wMDAwMDAwMDAgKzA5
 MDAKK0BAIC02ODEsNyArNjgxLDcgQEAKKworIHN1YiB6MmhfZXVjIHsKKyAgICAgbG9jYWwoKnMs
 ICRuKSA9IEBfOworLSAgICAmaW5pdF96MmhfZXVjIHVubGVzcyBkZWZpbmVkICV6MmhfZXVjOwor
 KyAgICAmaW5pdF96MmhfZXVjIHVubGVzcyAlejJoX2V1YzsKKyAgICAgJHMgPX4gcy8oJHJlX2V1
 Y19jfCRyZV9ldWNfa2FuYSkvCisgCSR6MmhfZXVjeyQxfSA/ICgkbisrLCAkejJoX2V1Y3skMX0p
 IDogJDEKKyAgICAgL2dlbzsKK0BAIC02OTAsNyArNjkwLDcgQEAKKworIHN1YiB6Mmhfc2ppcyB7
 CisgICAgIGxvY2FsKCpzLCAkbikgPSBAXzsKKy0gICAgJmluaXRfejJoX3NqaXMgdW5sZXNzIGRl
 ZmluZWQgJXoyaF9zamlzOworKyAgICAmaW5pdF96Mmhfc2ppcyB1bmxlc3MgJXoyaF9zamlzOwor
 ICAgICAkcyA9fiBzLygkcmVfc2ppc19jKS8kejJoX3NqaXN7JDF9ID8gKCRuKyssICR6Mmhfc2pp
 c3skMX0pIDogJDEvZ2VvOworICAgICAkbjsKKyB9Cg==
 --0015175cff767c4cbf04ae3c3200--

From: Takefu <takefu@airport.fm>
To: TAKATSU Tomonari <tota@FreeBSD.org>
Cc: bug-followup@FreeBSD.org
Subject: Re: ports/160174: [PATCH] japanese/jcode.pl Fix defined(%hash) is
 deprecated
Date: Mon, 03 Oct 2011 09:35:57 +0900

 $B$?$1$U!wBg:eK-Cf$G$9!#(B
 
 It consented to the full text.
 Rework, thank you.
 
 TAKATSU Tomonari $B$5$s$O=q$-$^$7$?(B (2011/10/01 21:51):
 > Hi, Takefu-san
 > 
 > I have modified your patch.
 > 
 > - Remove CONFLICTS because ja-p5-jcode.pl was removed from ports tree [1]
 > - Rename patch-aa to patch-jcode.pl [2]
 > 
 > Please confirm it.
 > 
 > [1] http://www.freebsd.org/cgi/cvsweb.cgi/ports/japanese/p5-jcode.pl/?hideattic=0#dirlist
 > [2] see 4.4 Patching FreeBSD Porter's Handbook
 >      http://www.freebsd.org/doc/en/books/porters-handbook/slow-patch.html
 > 
 > Thanks,
 > 
 
 
 -- 
State-Changed-From-To: open->closed 
State-Changed-By: tota 
State-Changed-When: Mon Oct 3 21:50:06 UTC 2011 
State-Changed-Why:  
Committed. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=160174 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/160174: commit references a PR
Date: Mon,  3 Oct 2011 21:48:50 +0000 (UTC)

 tota        2011-10-03 21:48:36 UTC
 
   FreeBSD ports repository
 
   Modified files:
     japanese/jcode.pl    Makefile 
   Added files:
     japanese/jcode.pl/files patch-jcode.pl 
   Log:
   - Add a patch to fix deprecated defined(%hash) issue
   
   PR:             ports/160174
   Submitted by:   Takefu <takefu_AT_airport_DOT_fm>
   
   Revision  Changes    Path
   1.13      +7 -8      ports/japanese/jcode.pl/Makefile
   1.1       +20 -0     ports/japanese/jcode.pl/files/patch-jcode.pl (new)
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
