From nobody@FreeBSD.org  Thu Aug 25 04:38:21 2011
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 4009D106566C
	for <freebsd-gnats-submit@FreeBSD.org>; Thu, 25 Aug 2011 04:38:21 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22])
	by mx1.freebsd.org (Postfix) with ESMTP id 16B128FC14
	for <freebsd-gnats-submit@FreeBSD.org>; Thu, 25 Aug 2011 04:38:21 +0000 (UTC)
Received: from red.freebsd.org (localhost [127.0.0.1])
	by red.freebsd.org (8.14.4/8.14.4) with ESMTP id p7P4cKTj024457
	for <freebsd-gnats-submit@FreeBSD.org>; Thu, 25 Aug 2011 04:38:20 GMT
	(envelope-from nobody@red.freebsd.org)
Received: (from nobody@localhost)
	by red.freebsd.org (8.14.4/8.14.4/Submit) id p7P4cKkq024456;
	Thu, 25 Aug 2011 04:38:20 GMT
	(envelope-from nobody)
Message-Id: <201108250438.p7P4cKkq024456@red.freebsd.org>
Date: Thu, 25 Aug 2011 04:38:20 GMT
From: Anon <dkeav04@gmail.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: [PATCH] x11/kdebase4-workspace - make astro/gpsd dependency optional
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         160164
>Category:       ports
>Synopsis:       [PATCH] x11/kdebase4-workspace - make astro/gpsd dependency optional
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    kde
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Thu Aug 25 04:40:08 UTC 2011
>Closed-Date:    Mon Oct 17 00:26:04 UTC 2011
>Last-Modified:  Mon Oct 17 00:26:04 UTC 2011
>Originator:     Anon
>Release:        9.0-BETA1
>Organization:
Anon
>Environment:
FreeBSD fbsd-dev01 9.0-BETA1 FreeBSD 9.0-BETA1 #0: Thu Jul 28 17:15:31 UTC 2011     root@farrell.cse.buffalo.edu:/usr/obj/usr/src/sys/GENERIC  amd64
>Description:
KDE4 pulls in astro/gpsd by default which is most likely not needed for most desktop/workstation/server users.  This dependency does not take up much space or cause a problem currently (unless libgps gets too old) but its just one more piece of bloat that few people need in the default install.
>How-To-Repeat:

>Fix:
*** Makefile.orig       Mon May 16 14:26:42 2011
--- Makefile    Wed Aug 24 23:26:25 2011
***************
*** 26,32 ****
                pci.3:${PORTSDIR}/devel/libpci \
                hal.1:${PORTSDIR}/sysutils/hal \
                xklavier.12:${PORTSDIR}/x11/libxklavier \
-               gps.20:${PORTSDIR}/astro/gpsd \
                qalculate.5:${PORTSDIR}/math/libqalculate \
                dmtx.0:${PORTSDIR}/graphics/libdmtx
  RUN_DEPENDS=  ${KDE4_PREFIX}/env/xdg-env.sh:${PORTSDIR}/misc/kde4-xdg-env \
--- 26,31 ----
***************
*** 67,76 ****
                -DWITH_Xmms:BOOL=OFF \
                -DWITH_Googlegadgets:BOOL=OFF \
                -DWITH_PyKDE4:BOOL=OFF
  #PyKDE4, Xmms and Googlegadgets could be enabled,
  
  OPTIONS=      PLASMA_PYTHON "Support for plasmoids written in Python" off \
!               PLASMA_RUBY "Support for plasmoids written in Ruby" off
  
  .include <bsd.port.options.mk>
  
--- 66,77 ----
                -DWITH_Xmms:BOOL=OFF \
                -DWITH_Googlegadgets:BOOL=OFF \
                -DWITH_PyKDE4:BOOL=OFF
+                 
  #PyKDE4, Xmms and Googlegadgets could be enabled,
  
  OPTIONS=      PLASMA_PYTHON "Support for plasmoids written in Python" off \
!                   PLASMA_RUBY "Support for plasmoids written in Ruby" off \
!             LIBGPS "Support for Geolocation Plasmoids" off
  
  .include <bsd.port.options.mk>
  
***************
*** 82,87 ****
--- 83,95 ----
  RUN_DEPENDS+= ${KDE4_PREFIX}/share/apps/plasma_scriptengine_ruby/applet.rb:${PORTSDIR}/x11/plasma-scriptengine-ruby
  .endif
  
+ .if defined(WITH_LIBGPS)
+ LIB_DEPENDS+=  gps.20:${PORTSDIR}/astro/gpsd

+ CMAKE_ARGS+= -DWITH_libgps:BOOL=ON
+ .else
+ CMAKE_ARGS+= -DWITH_libgps:BOOL=OFF
+ .endif
+ 
  .if ${OSVERSION} < 800069
  LIB_DEPENDS+= usb-0.1.8:${PORTSDIR}/devel/libusb
  .endif


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->kde 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Thu Aug 25 04:40:20 UTC 2011 
Responsible-Changed-Why:  
Over to maintainer (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=160164 
State-Changed-From-To: open->analyzed 
State-Changed-By: avilla 
State-Changed-When: Mon Aug 29 23:47:34 UTC 2011 
State-Changed-Why:  
I will test it. To avoid violating POLA, the option will be on by 
default. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=160164 
State-Changed-From-To: analyzed->patched 
State-Changed-By: avilla 
State-Changed-When: Tue Aug 30 00:21:10 UTC 2011 
State-Changed-Why:  
Committed to area51, with some changes. Will come to ports along with 
KDE 4.7. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=160164 
State-Changed-From-To: patched->closed 
State-Changed-By: avilla 
State-Changed-When: Mon Oct 17 00:26:03 UTC 2011 
State-Changed-Why:  
Committed, with minor changes. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=160164 
>Unformatted:
