From pgollucci@frieza.p6m7g8.net  Fri Aug  5 15:53:11 2011
Return-Path: <pgollucci@frieza.p6m7g8.net>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id A6C2E1065670;
	Fri,  5 Aug 2011 15:53:11 +0000 (UTC)
	(envelope-from pgollucci@frieza.p6m7g8.net)
Received: from frieza.p6m7g8.net (wsip-174-79-184-239.dc.dc.cox.net [174.79.184.239])
	by mx1.freebsd.org (Postfix) with ESMTP id 60F428FC0A;
	Fri,  5 Aug 2011 15:53:11 +0000 (UTC)
Received: from frieza.p6m7g8.net (localhost [127.0.0.1])
	by frieza.p6m7g8.net (8.14.4/8.14.4) with ESMTP id p75FUZdF014977;
	Fri, 5 Aug 2011 15:30:35 GMT
	(envelope-from pgollucci@frieza.p6m7g8.net)
Received: (from pgollucci@localhost)
	by frieza.p6m7g8.net (8.14.4/8.14.4/Submit) id p75FUZxC014976;
	Fri, 5 Aug 2011 15:30:35 GMT
	(envelope-from pgollucci)
Message-Id: <201108051530.p75FUZxC014976@frieza.p6m7g8.net>
Date: Fri, 5 Aug 2011 15:30:35 GMT
From: "Philip M. Gollucci" <pgollucci@p6m7g8.com>
To: FreeBSD-gnats-submit@freebsd.org
Cc: ashish@freebsd.org
Subject: [PATCH] editors/emacs: INSTALL_ICONS breaks WITHOUT_X11 completely
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         159530
>Category:       ports
>Synopsis:       [PATCH] editors/emacs: INSTALL_ICONS breaks WITHOUT_X11 completely
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    ashish
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Fri Aug 05 16:00:17 UTC 2011
>Closed-Date:    Mon Aug 08 14:26:30 UTC 2011
>Last-Modified:  Mon Aug  8 19:00:37 UTC 2011
>Originator:     Philip M. Gollucci
>Release:        FreeBSD 9.0-CURRENT amd64
>Organization:
RideCharge Inc / TaxiMagic
>Environment:
System: FreeBSD frieza.p6m7g8.net 9.0-CURRENT FreeBSD 9.0-CURRENT #0: Tue Oct 12 00:51:25 UTC 2010
>Description:

Port maintainer (ashish@FreeBSD.org) is cc'd.

Generated with FreeBSD Port Tools 0.99
>How-To-Repeat:
>Fix:

--- emacs-23.3_2,2.patch begins here ---
Index: Makefile
===================================================================
RCS file: /home/ncvs/ports/editors/emacs/Makefile,v
retrieving revision 1.102
diff -u -u -r1.102 Makefile
--- Makefile	16 May 2011 12:27:12 -0000	1.102
+++ Makefile	5 Aug 2011 15:29:15 -0000
@@ -7,7 +7,7 @@
 
 PORTNAME=	emacs
 PORTVERSION=	${EMACS_VER}
-PORTREVISION=	1
+PORTREVISION=	2
 PORTEPOCH=	2
 CATEGORIES=	editors ipv6
 MASTER_SITES=	${MASTER_SITE_GNU}
@@ -23,8 +23,6 @@
 		xemacs-mule-[0-9]* xemacs-devel-mule-[0-9]* \
 		emacs-nox11-[0-9]*
 
-INSTALLS_ICONS=	yes
-
 EMACS_VER=	23.3
 GNU_CONFIGURE=	yes
 USE_GMAKE=	yes
@@ -71,7 +69,8 @@
 		SCROLLBARS	"Without toolkit scroll-bars"			ON \
 		XFT	"Freetype fonts support"	ON \
 		XIM	"X Input Method support"	ON \
-		XPM	"XPM images support"		ON
+		XPM	"XPM images support"		ON \
+		X11 "X11 Support"				ON
 
 .include <bsd.port.options.mk>
 
@@ -81,6 +80,7 @@
 CONFIGURE_ARGS+=	--without-x
 
 .else
+INSTALLS_ICONS=	yes
 USE_XORG=	x11
 USE_GNOME=
 
@@ -209,7 +209,7 @@
 LIB_DEPENDS+=		canna.1:${PORTSDIR}/japanese/canna-lib
 .endif
 
-.endif
+.endif ## WITH_X11
 
 .if defined(WITHOUT_SOUND)
 CONFIGURE_ARGS+=	--without-sound
--- emacs-23.3_2,2.patch ends here ---

>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->ashish 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Fri Aug 5 16:00:32 UTC 2011 
Responsible-Changed-Why:  
Over to maintainer (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=159530 

From: ashish@freebsd.org (Ashish SHUKLA)
To: "Philip M. Gollucci" <pgollucci@p6m7g8.com>
Cc: FreeBSD-gnats-submit@freebsd.org,  ashish@freebsd.org
Subject: Re: [PATCH] editors/emacs: INSTALL_ICONS breaks WITHOUT_X11 completely

 --=-=-=
 Content-Type: text/plain
 Content-Transfer-Encoding: quoted-printable
 
 olgeni@ already mailed similar diff about this issue, but atm I'm out of
 country and don't have a FreeBSD box to test this and commit. I'm coming back
 on Sunday, then I'll take care of this.
 
 Sorry for the inconvenience.
 
 Thanks
 =2D-=20
 Ashish SHUKLA      | GPG: F682 CDCC 39DC 0FEA E116  20B6 C746 CFA9 E74F A4B0
 freebsd.org!ashish | http://people.freebsd.org/~ashish/
 
 Avoid Success At All Costs !!
 
 --=-=-=
 Content-Type: application/pgp-signature
 
 -----BEGIN PGP SIGNATURE-----
 Version: GnuPG v2.0.17 (GNU/Linux)
 
 iQIcBAEBCgAGBQJOPDdWAAoJEMdGz6nnT6SwhpgP/Rolmv8+MSMSjMYydLNczFXM
 /Y+/FswKyGcxxSH3niDyVUvnjDm3+UI0nCc8NlMScb2QjvkrnXJr36ByaQnqC7TB
 lZdn97VynlecON8DOSwX3oEDhq0/WMekl1fWkPxcAFsWBzlTNsH9J0cIs7cLwKaf
 5TRswq010DYrbsdcfBofRUR7zx6Kb7LqUMgPREanC38lzp8Qa4R3BXXQZ024ee05
 t2N8CH+GXK2uoeq+3gSXxL+aOsDCZzkND6FY1fkpdEKXRBBMTLyF9o84Q8iVSGov
 bTAzA4TPT2JgL1L78ByADR+eMgb7B7VJVr4pyfIQPab9Mm2eB6nof9ke+E2uWXSb
 hWr4SJF3zEWfeY8HGvP0ybQr81AbHvJtDb/9qm+l5ZlXIHOwJUKI4yeAHczkaOMh
 /+qDaU1VvzguCtvT/g69G8sft3RIBVYN8HAikAgBytihxtQXHL52Xb5/JEWj3ORM
 38ia3BtH51Enxpj72EUTPiYHAHtbX+hOURn/HZkILNZUDPOm8DiNP5FTVvprjMZE
 QZd5bwy6tYPWoLlEJCxeDC1+CTz64rQGX4i2/G/8xGgO5Nnab7nyTxvD9NjZfU9j
 qe1MZLY4t9TlNa/6kDM5f2lH/fD3jyCOjX0DfVb+zbo3GrTdcWUp8ckdsra4AoYj
 QgMC74j+cHpEnrFm0D1i
 =yqQ2
 -----END PGP SIGNATURE-----
 --=-=-=--
State-Changed-From-To: open->closed 
State-Changed-By: ashish 
State-Changed-When: Mon Aug 8 14:26:29 UTC 2011 
State-Changed-Why:  
Fix applied. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=159530 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/159530: commit references a PR
Date: Mon,  8 Aug 2011 14:24:54 +0000 (UTC)

 ashish      2011-08-08 14:24:40 UTC
 
   FreeBSD ports repository
 
   Modified files:
     editors/emacs        Makefile 
   Log:
   - Apply INSTALLS_ICONS fix to prevent editors/emacs from installing X11
     when WITHOUT_X11 is defined
   
   PR:             ports/159594, ports/159530
   Submitted by:   olgeni (via private email)
   
   Revision  Changes    Path
   1.103     +1 -2      ports/editors/emacs/Makefile
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/159530: commit references a PR
Date: Mon,  8 Aug 2011 18:56:24 +0000 (UTC)

 ashish      2011-08-08 18:56:14 UTC
 
   FreeBSD ports repository
 
   Modified files:
     editors/emacs        Makefile 
   Log:
   - Bump PORTREVISION
   
   PR:             ports/159594, ports/159530
   Reported by:    pgolluci
   
   Revision  Changes    Path
   1.104     +1 -1      ports/editors/emacs/Makefile
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
