From nobody@FreeBSD.org  Mon Jul 25 03:19:39 2011
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id DDACD106566B
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 25 Jul 2011 03:19:38 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22])
	by mx1.freebsd.org (Postfix) with ESMTP id C3A638FC12
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 25 Jul 2011 03:19:38 +0000 (UTC)
Received: from red.freebsd.org (localhost [127.0.0.1])
	by red.freebsd.org (8.14.4/8.14.4) with ESMTP id p6P3Jcxa096463
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 25 Jul 2011 03:19:38 GMT
	(envelope-from nobody@red.freebsd.org)
Received: (from nobody@localhost)
	by red.freebsd.org (8.14.4/8.14.4/Submit) id p6P3Jcms096462;
	Mon, 25 Jul 2011 03:19:38 GMT
	(envelope-from nobody)
Message-Id: <201107250319.p6P3Jcms096462@red.freebsd.org>
Date: Mon, 25 Jul 2011 03:19:38 GMT
From: Pedro Giffuni <giffunip@tutopia.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: cad/spice: more CLANG fixes
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         159173
>Category:       ports
>Synopsis:       cad/spice: more CLANG fixes
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    zi
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          update
>Submitter-Id:   current-users
>Arrival-Date:   Mon Jul 25 03:20:10 UTC 2011
>Closed-Date:    Thu Jul 28 22:22:15 UTC 2011
>Last-Modified:  Thu Jul 28 22:22:15 UTC 2011
>Originator:     Pedro Giffuni
>Release:        9.0-CURRENT
>Organization:
>Environment:
FreeBSD mogwai.giffuni.net 9.0-CURRENT FreeBSD 9.0-CURRENT #6: Sat Apr 30 01:37:57 PDT 2011     root@build9x64.pcbsd.org:/usr/obj/pcbsd-build90/fbsd-source/9.0/sys/PCBSD  amd64

>Description:
Second round of clang fixes from latest pointyhat build:
- add "void" as the return type for some functions
- no functional change (still builds with gcc) 
>How-To-Repeat:

>Fix:
Patch attached.

Patch attached with submission follows:

diff -ruN spice.orig/files/patch-src_lib_fte_device_c spice/files/patch-src_lib_fte_device_c
--- spice.orig/files/patch-src_lib_fte_device_c	2011-07-24 21:49:01.000000000 +0000
+++ spice/files/patch-src_lib_fte_device_c	2011-07-24 21:58:31.000000000 +0000
@@ -1,6 +1,14 @@
---- src/lib/fte/device.c.orig	Thu Jul 29 19:09:59 1993
-+++ src/lib/fte/device.c	Thu Sep 30 13:16:51 2004
-@@ -619,7 +619,7 @@
+--- src/lib/fte/device.c.orig	1993-07-30 02:09:59.000000000 +0000
++++ src/lib/fte/device.c	2011-07-24 21:57:11.000000000 +0000
+@@ -576,6 +576,7 @@
+     com_alter_common(wl, 1);
+ }
+ 
++void
+ com_alter_common(wl, do_model)
+     wordlist *wl;
+     int	do_model;
+@@ -619,7 +620,7 @@
  	n2 = names;
      }
  
@@ -9,7 +17,7 @@
  	fprintf(cp_err, "alter: don't understand \"%s\"\n", names->pn_name);
  	fprintf(cp_err, "usage: alter dev param = expression\n");
  	fprintf(cp_err, "  or   alter @dev[param] = expression\n");
-@@ -661,7 +661,9 @@
+@@ -661,7 +662,9 @@
      }
  
      dv = ft_evaluate(n2->pn_right);
diff -ruN spice.orig/files/patch-src_lib_fte_x11_c spice/files/patch-src_lib_fte_x11_c
--- spice.orig/files/patch-src_lib_fte_x11_c	2011-07-24 21:49:01.000000000 +0000
+++ spice/files/patch-src_lib_fte_x11_c	2011-07-24 22:06:03.000000000 +0000
@@ -1,5 +1,5 @@
---- src/lib/fte/x11.c.orig	Wed Apr 14 21:44:56 1993
-+++ src/lib/fte/x11.c	Sun Aug 15 19:06:31 2004
+--- src/lib/fte/x11.c.orig	1993-04-14 19:44:56.000000000 +0000
++++ src/lib/fte/x11.c	2011-07-24 22:04:30.000000000 +0000
 @@ -120,7 +120,10 @@
  	/* "invert" works better than "xor" for B&W */
  
@@ -41,7 +41,15 @@
  
  }
  
-@@ -942,7 +946,8 @@
+@@ -915,6 +919,7 @@
+ }
+ #  endif
+ 
++void
+ X11_Input(request, response)
+     REQUEST *request;
+     RESPONSE *response;
+@@ -942,7 +947,8 @@
  	            1 << ConnectionNumber(display);
  
  	      /* block on ConnectionNumber and request->fp */
@@ -51,7 +59,7 @@
  
  	      /* handle X events first */
  	      if (readfds & (1 << ConnectionNumber(display))) {
-@@ -995,7 +1000,8 @@
+@@ -995,7 +1001,8 @@
  
  }
  
diff -ruN spice.orig/files/patch-src_lib_mfb_mfbgnc_c spice/files/patch-src_lib_mfb_mfbgnc_c
--- spice.orig/files/patch-src_lib_mfb_mfbgnc_c	1970-01-01 00:00:00.000000000 +0000
+++ spice/files/patch-src_lib_mfb_mfbgnc_c	2011-07-24 22:13:31.000000000 +0000
@@ -0,0 +1,10 @@
+--- src/lib/mfb/mfbgnc.c.orig	2011-07-24 22:09:03.000000000 +0000
++++ src/lib/mfb/mfbgnc.c	2011-07-24 22:12:08.000000000 +0000
+@@ -100,6 +100,7 @@
+  * all other characters are ``self-inserting''.
+  */
+ 
++void
+ MFBGenCode(PM)
+     char *PM;
+     {


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->zi 
Responsible-Changed-By: zi 
Responsible-Changed-When: Tue Jul 26 22:34:40 UTC 2011 
Responsible-Changed-Why:  
I'll take it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=159173 
Class-Changed-From-To: change-request->update 
Class-Changed-By: zi 
Class-Changed-When: Tue Jul 26 22:36:26 UTC 2011 
Class-Changed-Why:  
Fix class 

http://www.freebsd.org/cgi/query-pr.cgi?pr=159173 

From: "Pedro F. Giffuni" <giffunip@tutopia.com>
To: bug-followup@FreeBSD.org
Cc: Ryan Steinmetz <zi@FreeBSD.org>
Subject: Re: ports/159173: cad/spice: more CLANG fixes
Date: Tue, 26 Jul 2011 21:27:35 -0700 (PDT)

 --0-675289507-1311740855=:67241
 Content-Type: text/plain; charset=us-ascii
 
 Thank you for the feedback Ryan!
 
 Here is an updated patch.
 
 cheers,
 
 Pedro.
 --0-675289507-1311740855=:67241
 Content-Type: text/plain; name="patch-spice.txt"
 Content-Transfer-Encoding: base64
 Content-Disposition: attachment; filename="patch-spice.txt"
 
 ZGlmZiAtcnVOIHNwaWNlLm9yaWcvZmlsZXMvcGF0Y2gtc3JjX2xpYl9mdGVf
 ZGV2aWNlX2Mgc3BpY2UvZmlsZXMvcGF0Y2gtc3JjX2xpYl9mdGVfZGV2aWNl
 X2MKLS0tIHNwaWNlLm9yaWcvZmlsZXMvcGF0Y2gtc3JjX2xpYl9mdGVfZGV2
 aWNlX2MJMjAxMS0wNy0yNCAyMTo0OTowMS4wMDAwMDAwMDAgKzAwMDAKKysr
 IHNwaWNlL2ZpbGVzL3BhdGNoLXNyY19saWJfZnRlX2RldmljZV9jCTIwMTEt
 MDctMjYgMjM6MTg6MDYuMDAwMDAwMDAwICswMDAwCkBAIC0xLDYgKzEsMjMg
 QEAKLS0tLSBzcmMvbGliL2Z0ZS9kZXZpY2UuYy5vcmlnCVRodSBKdWwgMjkg
 MTk6MDk6NTkgMTk5MwotKysrIHNyYy9saWIvZnRlL2RldmljZS5jCVRodSBT
 ZXAgMzAgMTM6MTY6NTEgMjAwNAotQEAgLTYxOSw3ICs2MTksNyBAQAorLS0t
 IHNyYy9saWIvZnRlL2RldmljZS5jLm9yaWcJMTk5My0wNy0zMCAwMjowOTo1
 OS4wMDAwMDAwMDAgKzAwMDAKKysrKyBzcmMvbGliL2Z0ZS9kZXZpY2UuYwky
 MDExLTA3LTI2IDIzOjE3OjU4LjAwMDAwMDAwMCArMDAwMAorQEAgLTE0LDYg
 KzE0LDggQEAKKyAjaW5jbHVkZSAiZnRlZGVmcy5oIgorICNpbmNsdWRlICJk
 Z2VuLmgiCisgCisrdm9pZCBjb21fYWx0ZXJfY29tbW9uKHdvcmRsaXN0ICp3
 bCwgaW50IGRvX21vZGVsKTsKKysKKyBzdGF0aWMgd29yZGxpc3QgKmRldmV4
 cGFuZCgpOworIAorIC8qCitAQCAtNTc2LDYgKzU3OCw3IEBACisgICAgIGNv
 bV9hbHRlcl9jb21tb24od2wsIDEpOworIH0KKyAKKyt2b2lkCisgY29tX2Fs
 dGVyX2NvbW1vbih3bCwgZG9fbW9kZWwpCisgICAgIHdvcmRsaXN0ICp3bDsK
 KyAgICAgaW50CWRvX21vZGVsOworQEAgLTYxOSw3ICs2MjIsNyBAQAogIAlu
 MiA9IG5hbWVzOwogICAgICB9CiAgCkBAIC05LDcgKzI2LDcgQEAKICAJZnBy
 aW50ZihjcF9lcnIsICJhbHRlcjogZG9uJ3QgdW5kZXJzdGFuZCBcIiVzXCJc
 biIsIG5hbWVzLT5wbl9uYW1lKTsKICAJZnByaW50ZihjcF9lcnIsICJ1c2Fn
 ZTogYWx0ZXIgZGV2IHBhcmFtID0gZXhwcmVzc2lvblxuIik7CiAgCWZwcmlu
 dGYoY3BfZXJyLCAiICBvciAgIGFsdGVyIEBkZXZbcGFyYW1dID0gZXhwcmVz
 c2lvblxuIik7Ci1AQCAtNjYxLDcgKzY2MSw5IEBACitAQCAtNjYxLDcgKzY2
 NCw5IEBACiAgICAgIH0KICAKICAgICAgZHYgPSBmdF9ldmFsdWF0ZShuMi0+
 cG5fcmlnaHQpOwpkaWZmIC1ydU4gc3BpY2Uub3JpZy9maWxlcy9wYXRjaC1z
 cmNfbGliX2Z0ZV94MTFfYyBzcGljZS9maWxlcy9wYXRjaC1zcmNfbGliX2Z0
 ZV94MTFfYwotLS0gc3BpY2Uub3JpZy9maWxlcy9wYXRjaC1zcmNfbGliX2Z0
 ZV94MTFfYwkyMDExLTA3LTI0IDIxOjQ5OjAxLjAwMDAwMDAwMCArMDAwMAor
 Kysgc3BpY2UvZmlsZXMvcGF0Y2gtc3JjX2xpYl9mdGVfeDExX2MJMjAxMS0w
 Ny0yNiAyMzoxNjo1NS4wMDAwMDAwMDAgKzAwMDAKQEAgLTEsNiArMSwxNyBA
 QAotLS0tIHNyYy9saWIvZnRlL3gxMS5jLm9yaWcJV2VkIEFwciAxNCAyMTo0
 NDo1NiAxOTkzCi0rKysgc3JjL2xpYi9mdGUveDExLmMJU3VuIEF1ZyAxNSAx
 OTowNjozMSAyMDA0Ci1AQCAtMTIwLDcgKzEyMCwxMCBAQAorLS0tIHNyYy9s
 aWIvZnRlL3gxMS5jLm9yaWcJMTk5My0wNC0xNCAxOTo0NDo1Ni4wMDAwMDAw
 MDAgKzAwMDAKKysrKyBzcmMvbGliL2Z0ZS94MTEuYwkyMDExLTA3LTI2IDIz
 OjE2OjQ4LjAwMDAwMDAwMCArMDAwMAorQEAgLTM2LDYgKzM2LDEwIEBACisg
 ZXh0ZXJuIGludCBfWGRlYnVnOworICMgIGVuZGlmCisgCisrdm9pZCBpbml0
 bGluZXN0eWxlcyh2b2lkKTsKKyt2b2lkIGluaXRjb2xvcnMoR1JBUEggKmdy
 YXBoKTsKKyt2b2lkIHNsb3BlbG9jYXRpb24oR1JBUEggKmdyYXBoLCBpbnQg
 eDAsIGludCB5MDspOworKworIC8qIGZvcndhcmQgZGVjbGFyYXRpb25zICov
 CisgZXh0ZXJuIHZvaWQgaGFuZGxlYnV0dG9uZXYoKSwgaGFuZGxla2V5cHJl
 c3NlZCgpLCBraWxsd2luKCksIGhhcmRjb3B5KCksCisgCSAgICByZWRyYXco
 KSwgcmVzaXplKCk7CitAQCAtMTIwLDcgKzEyNCwxMCBAQAogIAkvKiAiaW52
 ZXJ0IiB3b3JrcyBiZXR0ZXIgdGhhbiAieG9yIiBmb3IgQiZXICovCiAgCiAg
 CS8qIHhvciBnYyBzaG91bGQgYmUgYSBmdW5jdGlvbiBvZiB0aGUgcGl4ZWxz
 IHRoYXQgYXJlIHdyaXR0ZW4gb24gKi8KQEAgLTEyLDI1ICsyMyw1MiBAQAog
 IAlnY3ZhbHVlcy5saW5lX3dpZHRoID0gMTsKICAJZ2N2YWx1ZXMuZm9yZWdy
 b3VuZCA9IDE7CiAgCWdjdmFsdWVzLmJhY2tncm91bmQgPSAwOwotQEAgLTMw
 Miw3ICszMDUsNyBAQAorQEAgLTE1Miw3ICsxNTksNyBAQAorIHsKKyAJWEdl
 dEVycm9yVGV4dChkaXNwbGF5LCBlcnJvcmV2LT5lcnJvcl9jb2RlLCBFcnJv
 ck1lc3NhZ2UsIDEwMjQpOworIAlleHRlcm5hbGVycm9yKEVycm9yTWVzc2Fn
 ZSk7CistCXJldHVybjsKKysJcmV0dXJuICgwKTsKKyB9CisgCisgLyogUmVj
 b3ZlciBmcm9tIGJhZCBOZXdWaWV3UG9ydCBjYWxsLiAqLworQEAgLTMwMiw3
 ICszMDksOCBAQAogIAlyZXR1cm4gKDApOwogIH0KICAKIC1zdGF0aWMKICsv
 KiBQTiBzdGF0aWMgKi8KKyt2b2lkCiAgaW5pdGxpbmVzdHlsZXMoKQogIHsK
 ICAKLUBAIC0zMTgsNyArMzIxLDcgQEAKK0BAIC0zMTgsNyArMzI2LDggQEAK
 ICAJcmV0dXJuOwogIH0KICAKIC1zdGF0aWMKICsvKiBQTiBzdGF0aWMgKi8K
 Kyt2b2lkCiAgaW5pdGNvbG9ycyhncmFwaCkKICAgICAgR1JBUEggKmdyYXBo
 OwogIHsKLUBAIC04MDUsOCArODA4LDkgQEAKK0BAIC00MDUsNiArNDE0LDcg
 QEAKKyB9CisgCisgLypBUkdTVVNFRCovCisrdm9pZAorIFgxMV9BcmMoeDAs
 IHkwLCByYWRpdXMsIHRoZXRhMSwgdGhldGEyKQorIGludCB4MCwgeTAsIHJh
 ZGl1czsKKyBkb3VibGUgdGhldGExLCB0aGV0YTI7CitAQCAtNjEyLDYgKzYy
 Miw3IEBACisgfQorICMgIGVuZGlmCisgCisrdm9pZAorIHNsb3BlbG9jYXRp
 b24oZ3JhcGgsIHgwLCB5MCkKKyBHUkFQSCAqZ3JhcGg7CisgaW50IHgwLCB5
 MDsgICAgICAgICAvKiBpbml0aWFsIHBvc2l0aW9uIG9mIG1vdXNlICovCitA
 QCAtODA1LDggKzgxNiw5IEBACiAgCiAgCS8qIElwbG90cyBhcmUgZG9uZSBh
 c3luY2hyb25vdXNseSAqLwogIAlERVZERVAoZ3JhcGgpLmlzb3BlbiA9IDA7
 CkBAIC00MSw3ICs3OSwxNSBAQAogIAogIH0KICAKLUBAIC05NDIsNyArOTQ2
 LDggQEAKK0BAIC05MTUsNiArOTI3LDcgQEAKKyB9CisgIyAgZW5kaWYKKyAK
 Kyt2b2lkCisgWDExX0lucHV0KHJlcXVlc3QsIHJlc3BvbnNlKQorICAgICBS
 RVFVRVNUICpyZXF1ZXN0OworICAgICBSRVNQT05TRSAqcmVzcG9uc2U7CitA
 QCAtOTQyLDcgKzk1NSw4IEBACiAgCSAgICAgICAgICAgIDEgPDwgQ29ubmVj
 dGlvbk51bWJlcihkaXNwbGF5KTsKICAKICAJICAgICAgLyogYmxvY2sgb24g
 Q29ubmVjdGlvbk51bWJlciBhbmQgcmVxdWVzdC0+ZnAgKi8KQEAgLTUxLDcg
 Kzk3LDcgQEAKICAKICAJICAgICAgLyogaGFuZGxlIFggZXZlbnRzIGZpcnN0
 ICovCiAgCSAgICAgIGlmIChyZWFkZmRzICYgKDEgPDwgQ29ubmVjdGlvbk51
 bWJlcihkaXNwbGF5KSkpIHsKLUBAIC05OTUsNyArMTAwMCw4IEBACitAQCAt
 OTk1LDcgKzEwMDksOCBAQAogIAogIH0KICAKZGlmZiAtcnVOIHNwaWNlLm9y
 aWcvZmlsZXMvcGF0Y2gtc3JjX2xpYl9tZmJfbWZiZ25jX2Mgc3BpY2UvZmls
 ZXMvcGF0Y2gtc3JjX2xpYl9tZmJfbWZiZ25jX2MKLS0tIHNwaWNlLm9yaWcv
 ZmlsZXMvcGF0Y2gtc3JjX2xpYl9tZmJfbWZiZ25jX2MJMTk3MC0wMS0wMSAw
 MDowMDowMC4wMDAwMDAwMDAgKzAwMDAKKysrIHNwaWNlL2ZpbGVzL3BhdGNo
 LXNyY19saWJfbWZiX21mYmduY19jCTIwMTEtMDctMjQgMjI6MTM6MzEuMDAw
 MDAwMDAwICswMDAwCkBAIC0wLDAgKzEsMTAgQEAKKy0tLSBzcmMvbGliL21m
 Yi9tZmJnbmMuYy5vcmlnCTIwMTEtMDctMjQgMjI6MDk6MDMuMDAwMDAwMDAw
 ICswMDAwCisrKysgc3JjL2xpYi9tZmIvbWZiZ25jLmMJMjAxMS0wNy0yNCAy
 MjoxMjowOC4wMDAwMDAwMDAgKzAwMDAKK0BAIC0xMDAsNiArMTAwLDcgQEAK
 KyAgKiBhbGwgb3RoZXIgY2hhcmFjdGVycyBhcmUgYGBzZWxmLWluc2VydGlu
 ZycnLgorICAqLworIAorK3ZvaWQKKyBNRkJHZW5Db2RlKFBNKQorICAgICBj
 aGFyICpQTTsKKyAgICAgewo=
 
 --0-675289507-1311740855=:67241--

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/159173: commit references a PR
Date: Thu, 28 Jul 2011 21:58:23 +0000 (UTC)

 zi          2011-07-28 21:58:16 UTC
 
   FreeBSD ports repository
 
   Modified files:
     cad/spice            Makefile pkg-plist 
     cad/spice/files      patch-src_lib_fte_device_c 
                          patch-src_lib_fte_x11_c 
   Added files:
     cad/spice/files      patch-src_lib_mfb_mfbgnc_c 
   Log:
   Fix build under clang [1]
   Add LICENSE
   Fix usage of PORTDOCS in plist, no bump required
   
   PR:             ports/159173
   Submitted by:   Pedro Giffuni <giffunip@tutopia.com> [1]
   Approved by:    tabthorpe (mentor)
   
   Revision  Changes    Path
   1.41      +3 -1      ports/cad/spice/Makefile
   1.3       +21 -4     ports/cad/spice/files/patch-src_lib_fte_device_c
   1.3       +54 -8     ports/cad/spice/files/patch-src_lib_fte_x11_c
   1.1       +10 -0     ports/cad/spice/files/patch-src_lib_mfb_mfbgnc_c (new)
   1.10      +21 -21    ports/cad/spice/pkg-plist
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: open->closed 
State-Changed-By: zi 
State-Changed-When: Thu Jul 28 22:22:14 UTC 2011 
State-Changed-Why:  
Committed. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=159173 
>Unformatted:
