From nobody@FreeBSD.org  Fri Jul 22 21:45:26 2011
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 851D210657AF
	for <freebsd-gnats-submit@FreeBSD.org>; Fri, 22 Jul 2011 21:45:26 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22])
	by mx1.freebsd.org (Postfix) with ESMTP id 5BB0B8FC16
	for <freebsd-gnats-submit@FreeBSD.org>; Fri, 22 Jul 2011 21:45:26 +0000 (UTC)
Received: from red.freebsd.org (localhost [127.0.0.1])
	by red.freebsd.org (8.14.4/8.14.4) with ESMTP id p6MLjQZY096144
	for <freebsd-gnats-submit@FreeBSD.org>; Fri, 22 Jul 2011 21:45:26 GMT
	(envelope-from nobody@red.freebsd.org)
Received: (from nobody@localhost)
	by red.freebsd.org (8.14.4/8.14.4/Submit) id p6MLjQHr096143;
	Fri, 22 Jul 2011 21:45:26 GMT
	(envelope-from nobody)
Message-Id: <201107222145.p6MLjQHr096143@red.freebsd.org>
Date: Fri, 22 Jul 2011 21:45:26 GMT
From: Michael Scheidell <scheidell@secnap.net>
To: freebsd-gnats-submit@FreeBSD.org
Subject: databases/php-adodb-ext compile problem
X-Send-Pr-Version: www-3.1
X-GNATS-Notify: joehorn@gmail.com

>Number:         159125
>Category:       ports
>Synopsis:       databases/php-adodb-ext compile problem
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    gabor
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Fri Jul 22 21:50:12 UTC 2011
>Closed-Date:    Mon Aug 08 11:06:42 UTC 2011
>Last-Modified:  Mon Aug  8 11:10:11 UTC 2011
>Originator:     Michael Scheidell
>Release:        7.3 amd
>Organization:
SECNAP Network Security
>Environment:
>Description:
make 
===>  Building for php-adodb-ext-5.04_1
/bin/sh /usr/ports/databases/php-adodb-ext/work/adodb-504/libtool --mode=compile cc  -I. -I/usr/ports/databases/php-adodb-ext/work/adodb-504 -DPHP_ATOM_INC -I/usr/ports/databases/php-adodb-ext/work/adodb-504/include -I/usr/ports/databases/php-adodb-ext/work/adodb-504/main -I/usr/ports/databases/php-adodb-ext/work/adodb-504 -I/usr/local/include/php -I/usr/local/include/php/main -I/usr/local/include/php/TSRM -I/usr/local/include/php/Zend -I/usr/local/include/php/ext -I/usr/local/include/php/ext/date/lib  -DHAVE_CONFIG_H  -O2 -fno-strict-aliasing -pipe -march=nocona   -c /usr/ports/databases/php-adodb-ext/work/adodb-504/adodb.c -o adodb.lo
 cc -I. -I/usr/ports/databases/php-adodb-ext/work/adodb-504 -DPHP_ATOM_INC -I/usr/ports/databases/php-adodb-ext/work/adodb-504/include -I/usr/ports/databases/php-adodb-ext/work/adodb-504/main -I/usr/ports/databases/php-adodb-ext/work/adodb-504 -I/usr/local/include/php -I/usr/local/include/php/main -I/usr/local/include/php/TSRM -I/usr/local/include/php/Zend -I/usr/local/include/php/ext -I/usr/local/include/php/ext/date/lib -DHAVE_CONFIG_H -O2 -fno-strict-aliasing -pipe -march=nocona -c /usr/ports/databases/php-adodb-ext/work/adodb-504/adodb.c  -fPIC -DPIC -o .libs/adodb.o
/usr/ports/databases/php-adodb-ext/work/adodb-504/adodb.c: In function 'adodb_call_fetch':
/usr/ports/databases/php-adodb-ext/work/adodb-504/adodb.c:280: error: 'zend_fcall_info' has no member named 'object_ptr'
*** Error code 1

Stop in /usr/ports/databases/php-adodb-ext/work/adodb-504.
*** Error code 1

Stop in /usr/ports/databases/php-adodb-ext.


confirmed:

file /usr/local/include/php/Zend/zend_API.h does NOT have a member 'object_ptr' in zend_fcall_info
(it does have an object_pp:

typedef struct _zend_fcall_info {
        size_t size;
        HashTable *function_table;
        zval *function_name;
        HashTable *symbol_table;
        zval **retval_ptr_ptr;
        zend_uint param_count;
        zval ***params;
        zval **object_pp;
        zend_bool no_separation;
} zend_fcall_info;


from <https://github.com/sebastianbergmann/php-test-helpers/issues/7>

not sure if this means that this will only work on php-5.3 or not. maybe mark this port broken on php < 5.3




>How-To-Repeat:

>Fix:
mark port broken if php < 5.3?
hack a cast to the wrapper?


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->gabor 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Fri Jul 22 21:50:23 UTC 2011 
Responsible-Changed-Why:  
gabor@ wants his PRs (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=159125 
State-Changed-From-To: open->feedback 
State-Changed-By: edwin 
State-Changed-When: Fri Jul 22 21:50:28 UTC 2011 
State-Changed-Why:  
Awaiting maintainers feedback (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=159125 

From: Edwin Groothuis <edwin@FreeBSD.org>
To: joehorn@gmail.com
Cc: bug-followup@FreeBSD.org
Subject: Re: ports/159125: databases/php-adodb-ext compile problem
Date: Fri, 22 Jul 2011 21:50:26 UT

 Maintainer of databases/php-adodb-ext,
 
 Please note that PR ports/159125 has just been submitted.
 
 If it contains a patch for an upgrade, an enhancement or a bug fix
 you agree on, reply to this email stating that you approve the patch
 and a committer will take care of it.
 
 The full text of the PR can be found at:
     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/159125
 
 -- 
 Edwin Groothuis via the GNATS Auto Assign Tool
 edwin@FreeBSD.org

From: Joe Horn <joehorn@gmail.com>
To: bug-followup@freebsd.org
Cc: scheidell@secnap.net
Subject: Re: ports/159125: databases/php-adodb-ext compile problem
Date: Sun, 24 Jul 2011 04:09:18 +0800

 --0015175cdfd037786704a8c228b0
 Content-Type: text/plain; charset=UTF-8
 
 Dear ports committer,
 
 Please change fiile name from
 /usr/ports/databases/php-adodb-ext/files/patch-adodb.c to
 /usr/ports/databases/php-adodb-ext/files/extra-patch-adodb.c , and commit
 following patch file :
 
 diff -ruN --exclude=CVS /usr/ports/databases/php-adodb-ext/Makefile
 /home/admin/joehorn/php-adodb-ext/Makefile
 --- /usr/ports/databases/php-adodb-ext/Makefile 2010-04-12
 21:56:14.000000000 +0800
 +++ /home/admin/joehorn/php-adodb-ext/Makefile  2011-07-23
 20:40:23.000000000 +0800
 @@ -7,7 +7,7 @@
 
  PORTNAME=      adodb-ext
  PORTVERSION=   5.04
 -PORTREVISION=  1
 +PORTREVISION=  2
  CATEGORIES=    databases
  MASTER_SITES=  http://phplens.com/lens/dl/
  PKGNAMEPREFIX= php-
 @@ -29,7 +29,13 @@
  PLIST_SUB=     PHP_EXT_DIR=${PHP_EXT_DIR}
  USE_DOS2UNIX=  yes
 
 +.include <bsd.port.pre.mk>
 +
 +.if ${PHP_VER} != "52"
 +EXTRA_PATCHES= ${PATCHDIR}/extra-patch-adodb.c
 +.endif
 +
  post-install:
         @${CAT} ${PKGMESSAGE}
 
 -.include <bsd.port.mk>
 +.include <bsd.port.post.mk>
 
 --0015175cdfd037786704a8c228b0
 Content-Type: text/html; charset=UTF-8
 Content-Transfer-Encoding: quoted-printable
 
 Dear ports committer,<br><br>Please change fiile name from /usr/ports/datab=
 ases/php-adodb-ext/files/patch-adodb.c to /usr/ports/databases/php-adodb-ex=
 t/files/extra-patch-adodb.c , and commit following patch file :<br><br>diff=
  -ruN --exclude=3DCVS /usr/ports/databases/php-adodb-ext/Makefile /home/adm=
 in/joehorn/php-adodb-ext/Makefile<br>
 --- /usr/ports/databases/php-adodb-ext/Makefile 2010-04-12 21:56:14.0000000=
 00 +0800<br>+++ /home/admin/joehorn/php-adodb-ext/Makefile=C2=A0 2011-07-23=
  20:40:23.000000000 +0800<br>@@ -7,7 +7,7 @@<br><br>=C2=A0PORTNAME=3D=C2=A0=
 =C2=A0=C2=A0=C2=A0=C2=A0 adodb-ext<br>
 =C2=A0PORTVERSION=3D=C2=A0=C2=A0 5.04<br>-PORTREVISION=3D=C2=A0 1<br>+PORTR=
 EVISION=3D=C2=A0 2<br>=C2=A0CATEGORIES=3D=C2=A0=C2=A0=C2=A0 databases<br>=
 =C2=A0MASTER_SITES=3D=C2=A0 <a href=3D"http://phplens.com/lens/dl/">http://=
 phplens.com/lens/dl/</a><br>=C2=A0PKGNAMEPREFIX=3D php-<br>@@ -29,7 +29,13 =
 @@<br>
 =C2=A0PLIST_SUB=3D=C2=A0=C2=A0=C2=A0=C2=A0 PHP_EXT_DIR=3D${PHP_EXT_DIR}<br>=
 =C2=A0USE_DOS2UNIX=3D=C2=A0 yes<br><br>+.include &lt;<a href=3D"http://bsd.=
 port.pre.mk">bsd.port.pre.mk</a>&gt;<br>+<br>+.if ${PHP_VER} !=3D &quot;52&=
 quot;<br>+EXTRA_PATCHES=3D ${PATCHDIR}/extra-patch-adodb.c<br>
 +.endif<br>+<br>=C2=A0post-install:<br>=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
 =C2=A0 @${CAT} ${PKGMESSAGE}<br><br>-.include &lt;<a href=3D"http://bsd.por=
 t.mk">bsd.port.mk</a>&gt;<br>+.include &lt;<a href=3D"http://bsd.port.post.=
 mk">bsd.port.post.mk</a>&gt;<br>
 
 --0015175cdfd037786704a8c228b0--

From: Michael Scheidell <scheidell@secnap.net>
To: Joe Horn <joehorn@gmail.com>
Cc: <bug-followup@freebsd.org>
Subject: Re: ports/159125: databases/php-adodb-ext compile problem
Date: Sat, 23 Jul 2011 16:24:10 -0400

 --------------030809080404050409040801
 Content-Type: text/plain; charset="UTF-8"; format=flowed
 Content-Transfer-Encoding: 7bit
 
 for completeness attached is a patch.txt file.  I tested this, and it 
 fixes the issue!
 
 Thanks Joe!
 
 (silly me for staying on 5.2 :-)
 
 
 ______________________________________________________________________
 This email has been scanned and certified safe by SpammerTrap(r). 
 For Information please see http://www.secnap.com/products/spammertrap/
 ______________________________________________________________________  
 --------------030809080404050409040801
 Content-Type: text/plain; name="patch.txt"
 Content-Transfer-Encoding: base64
 Content-Disposition: attachment; filename="patch.txt"
 
 ZGlmZiAtYkJydSAvdG1wL3BocC1hZG9kYi1leHQvTWFrZWZpbGUgcGhwLWFkb2RiLWV4dC9N
 YWtlZmlsZQotLS0gL3RtcC9waHAtYWRvZGItZXh0L01ha2VmaWxlCTIwMTAtMDQtMTIgMDk6
 NTY6MTQuMDAwMDAwMDAwIC0wNDAwCisrKyBwaHAtYWRvZGItZXh0L01ha2VmaWxlCTIwMTEt
 MDctMjMgMTY6MTg6MTEuMDAwMDAwMDAwIC0wNDAwCkBAIC03LDcgKzcsNyBAQAogCiBQT1JU
 TkFNRT0JYWRvZGItZXh0CiBQT1JUVkVSU0lPTj0JNS4wNAotUE9SVFJFVklTSU9OPQkxCitQ
 T1JUUkVWSVNJT049CTIKIENBVEVHT1JJRVM9CWRhdGFiYXNlcwogTUFTVEVSX1NJVEVTPQlo
 dHRwOi8vcGhwbGVucy5jb20vbGVucy9kbC8KIFBLR05BTUVQUkVGSVg9CXBocC0KQEAgLTI5
 LDYgKzI5LDEyIEBACiBQTElTVF9TVUI9CVBIUF9FWFRfRElSPSR7UEhQX0VYVF9ESVJ9CiBV
 U0VfRE9TMlVOSVg9CXllcwogCisuaW5jbHVkZSA8YnNkLnBvcnQucHJlLm1rPgorCisuaWYg
 JHtQSFBfVkVSfSAhPSAiNTIiCitFWFRSQV9QQVRDSEVTPQkke1BBVENIRElSfS9leHRyYS1w
 YXRjaC1hZG9kYi5jCisuZW5kaWYKKwogcG9zdC1pbnN0YWxsOgogCUAke0NBVH0gJHtQS0dN
 RVNTQUdFfQogCmRpZmYgLWJCcnUgL3RtcC9waHAtYWRvZGItZXh0L2ZpbGVzL2V4dHJhLXBh
 dGNoLWFkb2RiLmMgcGhwLWFkb2RiLWV4dC9maWxlcy9leHRyYS1wYXRjaC1hZG9kYi5jCi0t
 LSAvdG1wL3BocC1hZG9kYi1leHQvZmlsZXMvZXh0cmEtcGF0Y2gtYWRvZGIuYwkyMDExLTA3
 LTIzIDE2OjE2OjMzLjAwMDAwMDAwMCAtMDQwMAorKysgcGhwLWFkb2RiLWV4dC9maWxlcy9l
 eHRyYS1wYXRjaC1hZG9kYi5jCTIwMTAtMDQtMTIgMDk6NTY6MTQuMDAwMDAwMDAwIC0wNDAw
 CkBAIC0wLDAgKzEsMjggQEAKKy0tLSBhZG9kYi5jLm9yaWcJMjAxMC0wNC0xMiAyMDowMDo0
 My4wMDAwMDAwMDAgKzA4MDAKKysrKyBhZG9kYi5jCTIwMTAtMDQtMTIgMjA6MDU6MjAuMDAw
 MDAwMDAwICswODAwCitAQCAtMTU5LDExICsxNTksMTEgQEAKKyAKKyBzdGF0aWMgdm9pZCBh
 ZG9kYl9pbml0X3p2YWwoenZhbCAqdiwgY2hhciAqcykKKyB7CistCXYtPnR5cGUgPSBJU19T
 VFJJTkc7CistCXYtPnZhbHVlLnN0ci52YWwgPSBzOworLQl2LT52YWx1ZS5zdHIubGVuID0g
 c3RybGVuKHMpOworLQl2LT5pc19yZWYgPSAwOworLQl2LT5yZWZjb3VudCA9IDE7CisrCVpf
 VFlQRV9QKHYpID0gSVNfU1RSSU5HOworKwlaX1NUUlZBTF9QKHYpID0gczsKKysJWl9TVFJM
 RU5fUCh2KSA9IHN0cmxlbihzKTsKKysJWl9VTlNFVF9JU1JFRl9QKHYpOworKwlaX1NFVF9S
 RUZDT1VOVF9QKHYsIDEpOworIH0KKyAKKyAvKiB7e3sgUEhQX01JTklUX0ZVTkNUSU9OCitA
 QCAtMjc3LDcgKzI3Nyw3IEBACisgCWZjaS5mdW5jdGlvbl90YWJsZSA9IEVHKGZ1bmN0aW9u
 X3RhYmxlKTsKKyAJZmNpLmZ1bmN0aW9uX25hbWUgPSAmYWRvZGJfenZhbHNbenZhbF9vY2lm
 ZXRjaF07CisgCWZjaS5zeW1ib2xfdGFibGUgPSBOVUxMOworLQlmY2kub2JqZWN0X3BwID0g
 TlVMTDsKKysJZmNpLm9iamVjdF9wdHIgPSBOVUxMOworIAlmY2kucmV0dmFsX3B0cl9wdHIg
 PSAmcmV0dmFsOworIAlmY2kucGFyYW1fY291bnQgPSAyOworIAlmY2kucGFyYW1zID0gJnBh
 cmFtc1sxXTsKZGlmZiAtYkJydSAvdG1wL3BocC1hZG9kYi1leHQvZmlsZXMvcGF0Y2gtYWRv
 ZGIuYyBwaHAtYWRvZGItZXh0L2ZpbGVzL3BhdGNoLWFkb2RiLmMKLS0tIC90bXAvcGhwLWFk
 b2RiLWV4dC9maWxlcy9wYXRjaC1hZG9kYi5jCTIwMTAtMDQtMTIgMDk6NTY6MTQuMDAwMDAw
 MDAwIC0wNDAwCisrKyBwaHAtYWRvZGItZXh0L2ZpbGVzL3BhdGNoLWFkb2RiLmMJMjAxMS0w
 Ny0yMyAxNjoxNjoyMy4wMDAwMDAwMDAgLTA0MDAKQEAgLTEsMjggKzAsMCBAQAotLS0tIGFk
 b2RiLmMub3JpZwkyMDEwLTA0LTEyIDIwOjAwOjQzLjAwMDAwMDAwMCArMDgwMAotKysrIGFk
 b2RiLmMJMjAxMC0wNC0xMiAyMDowNToyMC4wMDAwMDAwMDAgKzA4MDAKLUBAIC0xNTksMTEg
 KzE1OSwxMSBAQAotIAotIHN0YXRpYyB2b2lkIGFkb2RiX2luaXRfenZhbCh6dmFsICp2LCBj
 aGFyICpzKQotIHsKLS0Jdi0+dHlwZSA9IElTX1NUUklORzsKLS0Jdi0+dmFsdWUuc3RyLnZh
 bCA9IHM7Ci0tCXYtPnZhbHVlLnN0ci5sZW4gPSBzdHJsZW4ocyk7Ci0tCXYtPmlzX3JlZiA9
 IDA7Ci0tCXYtPnJlZmNvdW50ID0gMTsKLSsJWl9UWVBFX1AodikgPSBJU19TVFJJTkc7Ci0r
 CVpfU1RSVkFMX1AodikgPSBzOwotKwlaX1NUUkxFTl9QKHYpID0gc3RybGVuKHMpOwotKwla
 X1VOU0VUX0lTUkVGX1Aodik7Ci0rCVpfU0VUX1JFRkNPVU5UX1AodiwgMSk7Ci0gfQotIAot
 IC8qIHt7eyBQSFBfTUlOSVRfRlVOQ1RJT04KLUBAIC0yNzcsNyArMjc3LDcgQEAKLSAJZmNp
 LmZ1bmN0aW9uX3RhYmxlID0gRUcoZnVuY3Rpb25fdGFibGUpOwotIAlmY2kuZnVuY3Rpb25f
 bmFtZSA9ICZhZG9kYl96dmFsc1t6dmFsX29jaWZldGNoXTsKLSAJZmNpLnN5bWJvbF90YWJs
 ZSA9IE5VTEw7Ci0tCWZjaS5vYmplY3RfcHAgPSBOVUxMOwotKwlmY2kub2JqZWN0X3B0ciA9
 IE5VTEw7Ci0gCWZjaS5yZXR2YWxfcHRyX3B0ciA9ICZyZXR2YWw7Ci0gCWZjaS5wYXJhbV9j
 b3VudCA9IDI7Ci0gCWZjaS5wYXJhbXMgPSAmcGFyYW1zWzFdOwo=
 --------------030809080404050409040801--
State-Changed-From-To: feedback->closed 
State-Changed-By: gabor 
State-Changed-When: Mon Aug 8 11:06:26 UTC 2011 
State-Changed-Why:  
Committed, thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=159125 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/159125: commit references a PR
Date: Mon,  8 Aug 2011 11:04:59 +0000 (UTC)

 gabor       2011-08-08 11:04:45 UTC
 
   FreeBSD ports repository
 
   Modified files:
     databases/php-adodb-ext Makefile 
   Added files:
     databases/php-adodb-ext/files extra-patch-adodb.c 
   Removed files:
     databases/php-adodb-ext/files patch-adodb.c 
   Log:
   - Fix build for newer PHP versions by making PHP 5.2-specific patch optional
   
   PR:             ports/159125
   Submitted by:   Michael Scheidell <scheidell@secnap.net>
   Approved by:    Joe Horn <joehorn@gmail.com> (maintainer)
   
   Revision  Changes    Path
   1.3       +7 -1      ports/databases/php-adodb-ext/Makefile
   1.1       +28 -0     ports/databases/php-adodb-ext/files/extra-patch-adodb.c (new)
   1.2       +0 -28     ports/databases/php-adodb-ext/files/patch-adodb.c (dead)
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
