From nobody@FreeBSD.org  Tue Jul 19 04:07:37 2011
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 5206C106566B
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 19 Jul 2011 04:07:37 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22])
	by mx1.freebsd.org (Postfix) with ESMTP id 41B4A8FC1C
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 19 Jul 2011 04:07:37 +0000 (UTC)
Received: from red.freebsd.org (localhost [127.0.0.1])
	by red.freebsd.org (8.14.4/8.14.4) with ESMTP id p6J47aDl008007
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 19 Jul 2011 04:07:36 GMT
	(envelope-from nobody@red.freebsd.org)
Received: (from nobody@localhost)
	by red.freebsd.org (8.14.4/8.14.4/Submit) id p6J47akn008006;
	Tue, 19 Jul 2011 04:07:36 GMT
	(envelope-from nobody)
Message-Id: <201107190407.p6J47akn008006@red.freebsd.org>
Date: Tue, 19 Jul 2011 04:07:36 GMT
From: Ari Sovijrvi <listat2011@apz.fi>
To: freebsd-gnats-submit@FreeBSD.org
Subject: sysutils/smartmontools periodic script enhancement
X-Send-Pr-Version: www-3.1
X-GNATS-Notify: samm@os2.kiev.ua

>Number:         159022
>Category:       ports
>Synopsis:       sysutils/smartmontools periodic script enhancement
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    sunpoet
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Tue Jul 19 04:10:11 UTC 2011
>Closed-Date:    Fri Jul 22 06:42:30 UTC 2011
>Last-Modified:  Fri Jul 22 06:42:30 UTC 2011
>Originator:     Ari Sovijrvi
>Release:        8.2
>Organization:
>Environment:
FreeBSD server3 8.2-RELEASE-p1 FreeBSD 8.2-RELEASE-p1 #0: Wed Apr 27 19:27:33 EEST 2011     root@server3:/usr/obj/usr/src/sys/LOL-OK  amd64
>Description:
Majority of the periodic scripts output an empty line, following by a line that tells what they're doing before the actual program output. Smartctl's script is missing this part and atleast in all of my setups the output is right after NTP script's output.

I've included a small patch that makes smartmontools's periodic script output the empty line and title before running smartctl.
>How-To-Repeat:
Install sysutils/smartmontools, daily_status_smart_enable=y and see the daily run output mail.
>Fix:
Patch /usr/local/etc/periodic/daily/smart with attached patch.

Patch attached with submission follows:

diff -cB old/smart new/smart
*** old/smart	Tue Jul 19 06:43:26 2011
--- new/smart	Tue Jul 19 06:45:49 2011
***************
*** 35,40 ****
--- 35,42 ----
  rc=0
  case "${daily_status_smart_enable}" in
  	[Yy][Ee][Ss])
+ 		echo
+ 		echo 'SMART status:'
  		cd /dev
  		for device in ${daily_status_smart_devices}; do
  			device="${device#/dev/}"


>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->feedback 
State-Changed-By: edwin 
State-Changed-When: Tue Jul 19 04:10:21 UTC 2011 
State-Changed-Why:  
Awaiting maintainers feedback (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=159022 

From: Edwin Groothuis <edwin@FreeBSD.org>
To: samm@os2.kiev.ua
Cc: bug-followup@FreeBSD.org
Subject: Re: ports/159022: sysutils/smartmontools periodic script enhancement
Date: Tue, 19 Jul 2011 04:10:19 UT

 Maintainer of sysutils/smartmontools,
 
 Please note that PR ports/159022 has just been submitted.
 
 If it contains a patch for an upgrade, an enhancement or a bug fix
 you agree on, reply to this email stating that you approve the patch
 and a committer will take care of it.
 
 The full text of the PR can be found at:
     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/159022
 
 -- 
 Edwin Groothuis via the GNATS Auto Assign Tool
 edwin@FreeBSD.org

From: Alex Samorukov <samm@os2.kiev.ua>
To: bug-followup@FreeBSD.org, listat2011@apz.fi
Cc:  
Subject: Re: ports/159022: sysutils/smartmontools periodic script enhancement
Date: Wed, 20 Jul 2011 17:02:43 +0200

 Thank you,
 i have nothing against this patch, please commit.
Responsible-Changed-From-To: freebsd-ports-bugs->sunpoet 
Responsible-Changed-By: sunpoet 
Responsible-Changed-When: Fri Jul 22 06:27:50 UTC 2011 
Responsible-Changed-Why:  
I'll take it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=159022 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/159022: commit references a PR
Date: Fri, 22 Jul 2011 06:39:03 +0000 (UTC)

 sunpoet     2011-07-22 06:38:53 UTC
 
   FreeBSD ports repository
 
   Modified files:
     sysutils/smartmontools Makefile 
     sysutils/smartmontools/files smart.in 
   Log:
   - Update periodic script output
   - Bump PORTREVISION for PLIST change
   
   PR:             ports/159022
   Submitted by:   Ari <listat2011@apz.fi>
   Approved by:    Alex Samorukov <samm@os2.kiev.ua> (maintainer)
   
   Revision  Changes    Path
   1.52      +1 -1      ports/sysutils/smartmontools/Makefile
   1.11      +3 -1      ports/sysutils/smartmontools/files/smart.in
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: feedback->closed 
State-Changed-By: sunpoet 
State-Changed-When: Fri Jul 22 06:42:29 UTC 2011 
State-Changed-Why:  
Committed. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=159022 
>Unformatted:
