From nobody@FreeBSD.org  Sun Jul 17 16:34:09 2011
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 161C6106564A
	for <freebsd-gnats-submit@FreeBSD.org>; Sun, 17 Jul 2011 16:34:09 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22])
	by mx1.freebsd.org (Postfix) with ESMTP id 067F98FC0A
	for <freebsd-gnats-submit@FreeBSD.org>; Sun, 17 Jul 2011 16:34:09 +0000 (UTC)
Received: from red.freebsd.org (localhost [127.0.0.1])
	by red.freebsd.org (8.14.4/8.14.4) with ESMTP id p6HGY8GH037598
	for <freebsd-gnats-submit@FreeBSD.org>; Sun, 17 Jul 2011 16:34:08 GMT
	(envelope-from nobody@red.freebsd.org)
Received: (from nobody@localhost)
	by red.freebsd.org (8.14.4/8.14.4/Submit) id p6HGY8Vx037568;
	Sun, 17 Jul 2011 16:34:08 GMT
	(envelope-from nobody)
Message-Id: <201107171634.p6HGY8Vx037568@red.freebsd.org>
Date: Sun, 17 Jul 2011 16:34:08 GMT
From: David Demelier <demelier.david@gmail.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: [patch] audio/musicpd: libsndfile auto activation feature
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         158999
>Category:       ports
>Synopsis:       [patch] audio/musicpd: libsndfile auto activation feature
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    crees
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Sun Jul 17 16:40:09 UTC 2011
>Closed-Date:    Sun Jul 17 19:36:06 UTC 2011
>Last-Modified:  Sun Jul 17 19:40:07 UTC 2011
>Originator:     David Demelier
>Release:        8.2-STABLE
>Organization:
>Environment:
FreeBSD Melon.malikania.fr 8.2-STABLE FreeBSD 8.2-STABLE #0: Sat Jul 16 10:17:29 CEST 2011     root@Melon.malikania.fr:/usr/obj/usr/src/sys/Melon  amd64

>Description:
audio/musicpd automatically links to libsndfile if the library is installed on the system. This is a autoconf feature but it also means that libsndfile will not be pulled as musicpd dependency.

This Makefile diff use a static option that links to libsndfile following the option SNDFILE enabled by default (I chose this by default but it can be discussed)


>How-To-Repeat:

>Fix:
--- musicpd.diff begins here ---
--- Makefile.orig	2011-07-17 18:24:04.000000000 +0200
+++ Makefile	2011-07-17 18:27:25.000000000 +0200
@@ -58,6 +58,7 @@
 		PULSEAUDIO	"Support PulseAudio sound server"	off \
 		JACK		"Support JACK audio server"		off \
 		SHOUTCAST	"Support for OGG Icecast and Shoutcast"	off \
+		SNDFILE		"Adds support for libsndfile"		on \
 		LAME		"Support for MP3 Icecast Streams"	off \
 		HTTPD		"Support for httpd output streaming"	off \
 		SAMPLERATE	"Support sample rate conversion"	off
@@ -224,6 +225,13 @@
 CONFIGURE_ARGS+=--disable-shout
 .endif
 
+.if defined(WITH_SNDFILE)
+LIB_DEPENDS+=	sndfile.1:${PORTSDIR}/audio/libsndfile
+CONFIGURE_ARGS+=	--enable-sndfile
+.else
+CONFIGURE_ARGS+=	--disable-sndfile
+.endif
+
 .if defined(WITHOUT_SAMPLERATE)
 CONFIGURE_ARGS+=--disable-lsr
 .else
--- musicpd.diff ends here ---

>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->crees 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Sun Jul 17 16:40:19 UTC 2011 
Responsible-Changed-Why:  
Over to maintainer (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=158999 
State-Changed-From-To: open->closed 
State-Changed-By: crees 
State-Changed-When: Sun Jul 17 19:36:04 UTC 2011 
State-Changed-Why:  
Committed. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=158999 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/158999: commit references a PR
Date: Sun, 17 Jul 2011 19:35:59 +0000 (UTC)

 crees       2011-07-17 19:35:48 UTC
 
   FreeBSD ports repository
 
   Modified files:
     audio/musicpd        Makefile 
   Log:
   Stop autodetecting libsndfile --> now an OPTION, on by default
   
   PR:             ports/158999
   Submitted by:   David Demelier <demelier.david@gmail.com>
   Approved by:    rene (mentor, implicit)
   
   Revision  Changes    Path
   1.68      +9 -0      ports/audio/musicpd/Makefile
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
