From nobody@FreeBSD.org  Fri Jul 15 06:16:46 2011
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 42502106564A
	for <freebsd-gnats-submit@FreeBSD.org>; Fri, 15 Jul 2011 06:16:46 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22])
	by mx1.freebsd.org (Postfix) with ESMTP id 321848FC08
	for <freebsd-gnats-submit@FreeBSD.org>; Fri, 15 Jul 2011 06:16:46 +0000 (UTC)
Received: from red.freebsd.org (localhost [127.0.0.1])
	by red.freebsd.org (8.14.4/8.14.4) with ESMTP id p6F6GjHW030427
	for <freebsd-gnats-submit@FreeBSD.org>; Fri, 15 Jul 2011 06:16:45 GMT
	(envelope-from nobody@red.freebsd.org)
Received: (from nobody@localhost)
	by red.freebsd.org (8.14.4/8.14.4/Submit) id p6F6GjA8030426;
	Fri, 15 Jul 2011 06:16:45 GMT
	(envelope-from nobody)
Message-Id: <201107150616.p6F6GjA8030426@red.freebsd.org>
Date: Fri, 15 Jul 2011 06:16:45 GMT
From: Scot Hetzel <swhetze.l@gmail.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: Mk/bsd.ports.mk: Add a filename field to DESKTOP_ENTRIES
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         158936
>Category:       ports
>Synopsis:       [bsd.port.mk] Add a filename field to DESKTOP_ENTRIES
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    portmgr
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Fri Jul 15 06:20:07 UTC 2011
>Closed-Date:    
>Last-Modified:  Fri Jul 15 19:03:53 UTC 2011
>Originator:     Scot Hetzel
>Release:        
>Organization:
>Environment:
>Description:
Currently, DESKTOP_ENTRIES creates a filename for the .desktop file from the Exec field.  The problem with this approach is that you can't specify arguments to the command, otherwise you will get strangely name .desktop files.
>How-To-Repeat:
install any one of these 3 ports that use arguments in their Exec field:

www/links
misc/metalink-editor
games/tome
>Fix:
Create a new DESKTOP_ENTRIES variable that has a field for the filename.  The attached patch adds a new DESKTOP_ENTRIESv2 variable that handles this.





Patch attached with submission follows:

Index: bsd.port.mk
===================================================================
RCS file: /home/ncvs/ports/Mk/bsd.port.mk,v
retrieving revision 1.687
diff -u -r1.687 bsd.port.mk
--- bsd.port.mk	3 Jul 2011 15:51:18 -0000	1.687
+++ bsd.port.mk	15 Jul 2011 00:46:44 -0000
@@ -1046,7 +1046,20 @@
 # DESKTOP_ENTRIES
 #				- List of desktop entry files to generate and install in
 #				  ${DESKTOPDIR}. The format is
+#
 #				  "Name" "Comment" "Icon" "Exec" "Categories" StartupNotify
+#
+#				  Notes:
+#					* Exec will also be used to name the .desktop file.
+#					  If you need to use arguments in your .desktop file, then
+#					  use the DESKTOP_ENTRIESv2 format.
+#				- See DESKTOP_ENTRIESv2 for additional info.
+# DESKTOP_ENTRIESv2
+#				- List of desktop entry files to generate and install in
+#				  ${DESKTOPDIR}. The format is
+#
+#				  "Filename" "Name" "Comment" "Icon" "Exec" "Categories" StartupNotify
+#
 #				  Rules:
 #					* Only add desktop entries for applications which do not
 #					  require a terminal (ie. X applications).
@@ -1064,9 +1077,10 @@
 #					  If the deduction fails, you will have to set Categories
 #					  manually. You should check the generated value using
 #					  "make desktop-categories", and override it if necessary.
-#					* Exec will also be used to name the .desktop file.
+#					* Exec can also include arguments (DESKTOP_ENTRIESv2 Only).
 #					* The files will be automatically added to ${PLIST}.
 #				  Example:
+#					"wininfo" \
 #					"X Window Information" \
 #					"Get information about X windows" \
 #					"wininfo.png" \
@@ -6368,7 +6382,61 @@
 	GNOME GTK Qt Motif Java ConsoleOnly AdvancedSettings
 
 check-desktop-entries:
-.if defined(DESKTOP_ENTRIES)
+.if defined(DESKTOP_ENTRIESv2)
+	@set -- ${DESKTOP_ENTRIESv2} XXX; \
+	if [ `${EXPR} \( $$# - 1 \) % 7` -ne 0 ]; then \
+		${ECHO_MSG} "${PKGNAME}: Makefile error: the DESKTOP_ENTRIES list must contain one or more groups of 7 elements"; \
+		exit 1; \
+	fi; \
+	num=1; \
+	while [ $$# -gt 7 ]; do \
+		entry="#$$num"; \
+		if [ -n "$$5" ]; then \
+			entry="$$entry ($$4)"; \
+		elif [ -n "$$2" ]; then \
+			entry="$$entry ($$2)"; \
+		fi; \
+		if [ -z "$$1" ]; then \
+			${ECHO_MSG} "${PKGNAME}: Makefile error: in desktop entry $$entry: field 1 (Filename) is empty"; \
+			exit 1; \
+		fi
+		if [ -z "$$2" ]; then \
+			${ECHO_MSG} "${PKGNAME}: Makefile error: in desktop entry $$entry: field 2 (Name) is empty"; \
+			exit 1; \
+		fi; \
+		if [ -z "$$5" ]; then \
+			${ECHO_MSG} "${PKGNAME}: Makefile error: in desktop entry $$entry: field 5 (Exec) is empty"; \
+			exit 1; \
+		fi; \
+		if [ -n "$$6" ]; then \
+			for c in `${ECHO_CMD} "$$6" | ${TR} ';' ' '`; do \
+				if ! ${ECHO_CMD} ${VALID_DESKTOP_CATEGORIES} | ${GREP} -wq $$c; then \
+					${ECHO_CMD} "${PKGNAME}: Makefile error: in desktop entry $$entry: category $$c is not a valid desktop category"; \
+					exit 1; \
+				fi; \
+			done; \
+			if ! ${ECHO_CMD} "$$6" | ${GREP} -q ';$$'; then \
+				${ECHO_MSG} "${PKGNAME}: Makefile error: in desktop entry $$entry: field 6 (Categories) does not end with a semicolon"; \
+				exit 1; \
+			fi; \
+		else \
+			if [ -z "`cd ${.CURDIR} && ${MAKE} ${__softMAKEFLAGS} desktop-categories`" ]; then \
+				${ECHO_MSG} "${PKGNAME}: Makefile error: in desktop entry $$entry: field 6 (Categories) is empty and could not be deduced from the CATEGORIES variable"; \
+				exit 1; \
+			fi; \
+		fi; \
+		if [ -z "$$7" ]; then \
+			${ECHO_MSG} "${PKGNAME}: Makefile error: in desktop entry $$entry: field 7 (StartupNotify) is empty"; \
+			exit 1; \
+		fi; \
+		if [ "x$$7" != "xtrue" ] && [ "x$$7" != "xfalse" ]; then \
+			${ECHO_MSG} "${PKGNAME}: Makefile error: in desktop entry $$entry: field 7 (StartupNotify) is not \"true\" or \"false\""; \
+			exit 1; \
+		fi; \
+		shift 7; \
+		num=`${EXPR} $$num + 1`; \
+	done
+.elif defined(DESKTOP_ENTRIES)
 	@set -- ${DESKTOP_ENTRIES} XXX; \
 	if [ `${EXPR} \( $$# - 1 \) % 6` -ne 0 ]; then \
 		${ECHO_MSG} "${PKGNAME}: Makefile error: the DESKTOP_ENTRIES list must contain one or more groups of 6 elements"; \
@@ -6424,7 +6492,42 @@
 
 .if !target(install-desktop-entries)
 install-desktop-entries:
-.if defined(DESKTOP_ENTRIES)
+.if defined(DESKTOP_ENTRIESv2)
+	@(${MKDIR} "${DESKTOPDIR}" 2> /dev/null) || \
+		(${ECHO_MSG} "===> Cannot create ${DESKTOPDIR}, check permissions"; exit 1)
+	@set -- ${DESKTOP_ENTRIESv2} XXX; \
+	if [ -z "${_DESKTOPDIR_REL}" ]; then \
+		${ECHO_CMD} "@cwd ${DESKTOPDIR}" >> ${TMPPLIST}; \
+	fi; \
+	while [ $$# -gt 7 ]; do \
+		filename="`${ECHO_CMD} "$$1" | ${SED} -E 's/[[:space:]]+.*//'`.desktop"; \
+		pathname="${DESKTOPDIR}/$$filename"; \
+		categories="$$6"; \
+		if [ -z "$$categories" ]; then \
+			categories="`cd ${.CURDIR} && ${MAKE} ${__softMAKEFLAGS} desktop-categories`"; \
+		fi; \
+		${ECHO_CMD} "${_DESKTOPDIR_REL}$$filename" >> ${TMPPLIST}; \
+		${ECHO_CMD} "[Desktop Entry]" > $$pathname; \
+		${ECHO_CMD} "Type=Application" >> $$pathname; \
+		${ECHO_CMD} "Version=0.9.4" >> $$pathname; \
+		${ECHO_CMD} "Encoding=UTF-8" >> $$pathname; \
+		${ECHO_CMD} "Name=$$2" >> $$pathname; \
+		if [ -n "$$3" ]; then \
+			${ECHO_CMD} "Comment=$$3" >> $$pathname; \
+		fi; \
+		if [ -n "$$4" ]; then \
+			${ECHO_CMD} "Icon=$$4" >> $$pathname; \
+		fi; \
+		${ECHO_CMD} "Exec=$$5" >> $$pathname; \
+		${ECHO_CMD} "Categories=$$categories" >> $$pathname; \
+		${ECHO_CMD} "StartupNotify=$$7" >> $$pathname; \
+		shift 7; \
+	done; \
+	${ECHO_CMD} "@unexec rmdir ${DESKTOPDIR} 2>/dev/null || true" >> ${TMPPLIST}; \
+	if [ -z "${_DESKTOPDIR_REL}" ]; then \
+		${ECHO_CMD} "@cwd ${PREFIX}" >> ${TMPPLIST}; \
+	fi
+.elif defined(DESKTOP_ENTRIES)
 	@(${MKDIR} "${DESKTOPDIR}" 2> /dev/null) || \
 		(${ECHO_MSG} "===> Cannot create ${DESKTOPDIR}, check permissions"; exit 1)
 	@set -- ${DESKTOP_ENTRIES} XXX; \


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->portmgr 
Responsible-Changed-By: sunpoet 
Responsible-Changed-When: Fri Jul 15 06:48:01 UTC 2011 
Responsible-Changed-Why:  
portmgr territory. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=158936 
State-Changed-From-To: open->feedback 
State-Changed-By: pav 
State-Changed-When: Fri Jul 15 08:15:04 UTC 2011 
State-Changed-Why:  
In principle this looks good, but can you provide patches to a couple of ports 
that would convert them to the new variable? Just to see it in action.. Thank 
you. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=158936 

From: Scot Hetzel <swhetzel@gmail.com>
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/158936: [bsd.port.mk] Add a filename field to DESKTOP_ENTRIES
Date: Fri, 15 Jul 2011 11:41:03 -0500

 --001517478b50b2927304a81e50e7
 Content-Type: text/plain; charset=ISO-8859-1
 
 Just noticed that I had forgotten a '; \' after the check to make sure
 that the filename is defined in check-desktop-entries for
 DESKTOP_ENTRIESv2.
 
 The attached patch fixes this.
 
 Scot
 
 --001517478b50b2927304a81e50e7
 Content-Type: text/plain; charset=US-ASCII; name="bsd.port.mk-diff2.txt"
 Content-Disposition: attachment; filename="bsd.port.mk-diff2.txt"
 Content-Transfer-Encoding: base64
 X-Attachment-Id: f_gq5dgqon0
 
 LS0tIC91c3IvcG9ydHMvTWsvYnNkLnBvcnQubWstREVTS1RPUF9FTlRSSUVTMQkyMDExLTA3LTE1
 IDEwOjQ5OjI5LjI1MTY2NzI5MyArMDAwMAorKysgL3Vzci9wb3J0cy9Nay9ic2QucG9ydC5tawky
 MDExLTA3LTE1IDExOjA0OjQxLjQxMjQ0OTE4MCArMDAwMApAQCAtNjQ0Myw3ICs2NDQzLDcgQEAK
 IAkJaWYgWyAteiAiJCQxIiBdOyB0aGVuIFwKIAkJCSR7RUNIT19NU0d9ICIke1BLR05BTUV9OiBN
 YWtlZmlsZSBlcnJvcjogaW4gZGVza3RvcCBlbnRyeSAkJGVudHJ5OiBmaWVsZCAxIChGaWxlbmFt
 ZSkgaXMgZW1wdHkiOyBcCiAJCQlleGl0IDE7IFwKLQkJZmkKKwkJZmk7IFwKIAkJaWYgWyAteiAi
 JCQyIiBdOyB0aGVuIFwKIAkJCSR7RUNIT19NU0d9ICIke1BLR05BTUV9OiBNYWtlZmlsZSBlcnJv
 cjogaW4gZGVza3RvcCBlbnRyeSAkJGVudHJ5OiBmaWVsZCAyIChOYW1lKSBpcyBlbXB0eSI7IFwK
 IAkJCWV4aXQgMTsgXAo=
 --001517478b50b2927304a81e50e7--

From: Scot Hetzel <swhetzel@gmail.com>
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/158936: Mk/bsd.ports.mk: Add a filename field to DESKTOP_ENTRIES
Date: Fri, 15 Jul 2011 11:44:15 -0500

 --001517478b50244a9604a81e5cfc
 Content-Type: text/plain; charset=ISO-8859-1
 
 On Fri, Jul 15, 2011 at 3:16 AM,  <pav@freebsd.org> wrote:
 > Synopsis: Mk/bsd.ports.mk: Add a filename field to DESKTOP_ENTRIES
 >
 > State-Changed-From-To: open->feedback
 > State-Changed-By: pav
 > State-Changed-When: Fri Jul 15 08:15:04 UTC 2011
 > State-Changed-Why:
 > In principle this looks good, but can you provide patches to a couple of ports
 > that would convert them to the new variable? Just to see it in action.. Thank
 > you.
 >
 > http://www.freebsd.org/cgi/query-pr.cgi?pr=158936
 >
 
 The attached patch is for the games/tome, misc/metalink-editor and
 www/links ports.
 
 Scot
 
 --001517478b50244a9604a81e5cfc
 Content-Type: application/octet-stream; name="DESKTOP_ENTRIESv2-ports.diff"
 Content-Disposition: attachment; filename="DESKTOP_ENTRIESv2-ports.diff"
 Content-Transfer-Encoding: base64
 X-Attachment-Id: f_gq5dhzkm0
 
 SW5kZXg6IGdhbWVzL3RvbWUvTWFrZWZpbGUKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQpSQ1MgZmlsZTogL2hvbWUvbmN2
 cy9wb3J0cy9nYW1lcy90b21lL01ha2VmaWxlLHYKcmV0cmlldmluZyByZXZpc2lvbiAxLjIxCmRp
 ZmYgLXUgLXIxLjIxIE1ha2VmaWxlCi0tLSBnYW1lcy90b21lL01ha2VmaWxlCTI1IEphbiAyMDEw
 IDIyOjQ5OjQ0IC0wMDAwCTEuMjEKKysrIGdhbWVzL3RvbWUvTWFrZWZpbGUJMTUgSnVsIDIwMTEg
 MTE6MTg6MDQgLTAwMDAKQEAgLTI0LDcgKzI0LDggQEAKIFdSS1NSQz0JCSR7V1JLRElSfS8ke0RJ
 U1ROQU1FfS9zcmMKIAogT1BUSU9OUz0JCVgxMSAiVHVybiBvbiBzdXBwb3J0IGZvciBYIiBvbgot
 REVTS1RPUF9FTlRSSUVTPQkiVG9NRSIgIlJvZ3VlbGlrZSBnYW1lIGJhc2VkIG9uIEpSUiBUb2xr
 aWVuJ3Mgd29yayIgXAorREVTS1RPUF9FTlRSSUVTdjI9CSJ0b21lIiBcCisJCQkiVG9NRSIgIlJv
 Z3VlbGlrZSBnYW1lIGJhc2VkIG9uIEpSUiBUb2xraWVuJ3Mgd29yayIgXAogCQkJIiR7REFUQURJ
 Un0veHRyYS9ncmFmL3RvbWUtMTI4LnBuZyIgXAogCQkJInRvbWUgLXYgLWciICJBcHBsaWNhdGlv
 bjtHYW1lO1JvbGVQbGF5aW5nOyIgXAogCQkJZmFsc2UKSW5kZXg6IG1pc2MvbWV0YWxpbmstZWRp
 dG9yL01ha2VmaWxlCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
 PT09PT09PT09PT09PT09PT09PT09PT0KUkNTIGZpbGU6IC9ob21lL25jdnMvcG9ydHMvbWlzYy9t
 ZXRhbGluay1lZGl0b3IvTWFrZWZpbGUsdgpyZXRyaWV2aW5nIHJldmlzaW9uIDEuNgpkaWZmIC11
 IC1yMS42IE1ha2VmaWxlCi0tLSBtaXNjL21ldGFsaW5rLWVkaXRvci9NYWtlZmlsZQkxMyBKdW4g
 MjAxMCAxMjo0MTozMSAtMDAwMAkxLjYKKysrIG1pc2MvbWV0YWxpbmstZWRpdG9yL01ha2VmaWxl
 CTE1IEp1bCAyMDExIDExOjE1OjQ1IC0wMDAwCkBAIC0zMSw3ICszMSw4IEBACiAKIERBVEFESVI9
 CSR7UFJFRklYfS9zaGFyZS8ke1BPUlROQU1FfSR7UEtHTkFNRVNVRkZJWH0KIAotREVTS1RPUF9F
 TlRSSUVTPQkiTWV0YWxpbmsgZWRpdG9yIiBcCitERVNLVE9QX0VOVFJJRVN2Mj0JIm1ldGFsaW5r
 X2VkaXRvciIgXAorCQkJIk1ldGFsaW5rIGVkaXRvciIgXAogCQkJIkdVSSBlZGl0b3IgdG8gY3Jl
 YXRlIGFuZCBlZGl0IG1ldGFsaW5rcyIgXAogCQkJIiR7REFUQURJUn0vbWV0YWxpbmsucG5nIiBc
 CiAJCQkibWV0YWxpbmtfZWRpdG9yLnB5IiBcCkluZGV4OiB3d3cvbGlua3MvTWFrZWZpbGUKPT09
 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
 PT09PT09PQpSQ1MgZmlsZTogL2hvbWUvbmN2cy9wb3J0cy93d3cvbGlua3MvTWFrZWZpbGUsdgpy
 ZXRyaWV2aW5nIHJldmlzaW9uIDEuNjkKZGlmZiAtdSAtcjEuNjkgTWFrZWZpbGUKLS0tIHd3dy9s
 aW5rcy9NYWtlZmlsZQk4IERlYyAyMDEwIDE0OjQ3OjM0IC0wMDAwCTEuNjkKKysrIHd3dy9saW5r
 cy9NYWtlZmlsZQkxNSBKdWwgMjAxMSAxMTowMzoxMCAtMDAwMApAQCAtNzIsNyArNzIsOCBAQAog
 LmlmICFkZWZpbmVkKFdJVEhPVVRfWDExKQogVVNFX1hPUkc9CXgxMSB4cHJvdG8KIENPTkZJR1VS
 RV9BUkdTKz0JLS13aXRoLXgKLURFU0tUT1BfRU5UUklFUz0ibGlua3MiIFwKK0RFU0tUT1BfRU5U
 UklFU3YyPSJsaW5rcyIgXAorCQkibGlua3MiIFwKIAkJIkx5bngtbGlrZSB0ZXh0IFdXVyBicm93
 c2VyIiBcCiAJCSJsaW5rcyIgXAogCQkibGlua3MgLWciIFwK
 --001517478b50244a9604a81e5cfc--

From: Scot Hetzel <swhetzel@gmail.com>
To: bug-followup@freebsd.org
Cc:  
Subject: Re: ports/158936: [bsd.port.mk] Add a filename field to DESKTOP_ENTRIES
Date: Fri, 15 Jul 2011 13:12:27 -0500

 --0015174c408095c69e04a81f9794
 Content-Type: text/plain; charset=ISO-8859-1
 
 On Fri, Jul 15, 2011 at 11:41 AM, Scot Hetzel <swhetzel@gmail.com> wrote:
 > Just noticed that I had forgotten a '; \' after the check to make sure
 > that the filename is defined in check-desktop-entries for
 > DESKTOP_ENTRIESv2.
 >
 > The attached patch fixes this.
 >
 ignore the previous patch to fix the missing '; \', instead use this one.
 
 Scot
 
 --0015174c408095c69e04a81f9794
 Content-Type: application/octet-stream; name="bsd.port.mk-diff2"
 Content-Disposition: attachment; filename="bsd.port.mk-diff2"
 Content-Transfer-Encoding: base64
 X-Attachment-Id: f_gq5godgg1
 
 LS0tIE1rL2JzZC5wb3J0Lm1rLW9yaWcJMjAxMS0wNy0xNSAxMTowNDo0MS40MTI0NDkxODAgKzAw
 MDAKKysrIE1rL2JzZC5wb3J0Lm1rCTIwMTEtMDctMTUgMTE6NTQ6MzAuOTYxNzA1ODU5ICswMDAw
 CkBAIC02NDM1LDE1ICs2NDM1LDE1IEBACiAJbnVtPTE7IFwKIAl3aGlsZSBbICQkIyAtZ3QgNyBd
 OyBkbyBcCiAJCWVudHJ5PSIjJCRudW0iOyBcCi0JCWlmIFsgLW4gIiQkNSIgXTsgdGhlbiBcCi0J
 CQllbnRyeT0iJCRlbnRyeSAoJCQ0KSI7IFwKKwkJaWYgWyAtbiAiJCQxIiBdOyB0aGVuIFwKKwkJ
 CWVudHJ5PSIkJGVudHJ5ICgkJDEpIjsgXAogCQllbGlmIFsgLW4gIiQkMiIgXTsgdGhlbiBcCiAJ
 CQllbnRyeT0iJCRlbnRyeSAoJCQyKSI7IFwKIAkJZmk7IFwKIAkJaWYgWyAteiAiJCQxIiBdOyB0
 aGVuIFwKIAkJCSR7RUNIT19NU0d9ICIke1BLR05BTUV9OiBNYWtlZmlsZSBlcnJvcjogaW4gZGVz
 a3RvcCBlbnRyeSAkJGVudHJ5OiBmaWVsZCAxIChGaWxlbmFtZSkgaXMgZW1wdHkiOyBcCiAJCQll
 eGl0IDE7IFwKLQkJZmkKKwkJZmk7IFwKIAkJaWYgWyAteiAiJCQyIiBdOyB0aGVuIFwKIAkJCSR7
 RUNIT19NU0d9ICIke1BLR05BTUV9OiBNYWtlZmlsZSBlcnJvcjogaW4gZGVza3RvcCBlbnRyeSAk
 JGVudHJ5OiBmaWVsZCAyIChOYW1lKSBpcyBlbXB0eSI7IFwKIAkJCWV4aXQgMTsgXAo=
 --0015174c408095c69e04a81f9794--

From: Scot Hetzel <swhetzel@gmail.com>
To: bug-followup@freebsd.org
Cc:  
Subject: Re: ports/158936: [bsd.port.mk] Add a filename field to DESKTOP_ENTRIES
Date: Fri, 15 Jul 2011 13:32:23 -0500

 Not sure why my replies are not showing up properly in the PR.
 
 When applying the patch use patch.txt and the last bsd.port.mk-diff2 patch.
 
 The DESKTOP_ENTRIESv2-ports-diff is a patch for the games/tome,
 misc/metalink-editor and www/links to show that the DESKTOP_ENTRIESv2
 patch works.
 
 Scot.
State-Changed-From-To: feedback->open 
State-Changed-By: pav 
State-Changed-When: Fri Jul 15 19:03:46 UTC 2011 
State-Changed-Why:  
Feedback received 

http://www.freebsd.org/cgi/query-pr.cgi?pr=158936 
>Unformatted:
