From nobody@FreeBSD.org  Fri Jul  8 16:39:21 2011
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id B9B75106564A
	for <freebsd-gnats-submit@FreeBSD.org>; Fri,  8 Jul 2011 16:39:21 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22])
	by mx1.freebsd.org (Postfix) with ESMTP id A8F838FC12
	for <freebsd-gnats-submit@FreeBSD.org>; Fri,  8 Jul 2011 16:39:21 +0000 (UTC)
Received: from red.freebsd.org (localhost [127.0.0.1])
	by red.freebsd.org (8.14.4/8.14.4) with ESMTP id p68GdLqO045005
	for <freebsd-gnats-submit@FreeBSD.org>; Fri, 8 Jul 2011 16:39:21 GMT
	(envelope-from nobody@red.freebsd.org)
Received: (from nobody@localhost)
	by red.freebsd.org (8.14.4/8.14.4/Submit) id p68GdLjh045004;
	Fri, 8 Jul 2011 16:39:21 GMT
	(envelope-from nobody)
Message-Id: <201107081639.p68GdLjh045004@red.freebsd.org>
Date: Fri, 8 Jul 2011 16:39:21 GMT
From: Scot Hetzel <swhetzel@gmail.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: deskutils/ical: Allow ical to depend on any version to tk
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         158737
>Category:       ports
>Synopsis:       deskutils/ical: Allow ical to depend on any version to tk
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    obrien
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Fri Jul 08 16:40:00 UTC 2011
>Closed-Date:    Tue Jul 12 06:08:33 UTC 2011
>Last-Modified:  Tue Jul 12 06:10:08 UTC 2011
>Originator:     Scot Hetzel
>Release:        9.0-CURRENT
>Organization:
>Environment:
FreeBSD vbox.hetzel.local 9.0-CURRENT FreeBSD9.0-CURRENT#4 r218985:220965M: Sat Apr 23 01:58:28 UTC 2011
>Description:
Currently, ical has a hard dependancy on tk84, change the port to use USE_TK to allow it to depend on any version of tk.
>How-To-Repeat:
Install tk 8.5
cd /usr/ports/deskutils/ical
make install

Port will install tk 8.4.
>Fix:
The attached patch allows the port to depend on any version of tk.

Patch attached with submission follows:

Index: Makefile
===================================================================
RCS file: /home/ncvs/ports/deskutils/ical/Makefile,v
retrieving revision 1.38
diff -u -r1.38 Makefile
--- Makefile	9 Apr 2008 13:41:58 -0000	1.38
+++ Makefile	8 Jul 2011 11:11:13 -0000
@@ -9,20 +9,20 @@
 PORTNAME=	ical
 PORTVERSION=	2.2
 PORTREVISION=	3
-CATEGORIES=	deskutils tk
+CATEGORIES?=	deskutils tk
 MASTER_SITES=	ftp://ftp.sunet.se/pub/vendor/sco/skunkware/src/shellutil/
 
-MAINTAINER=	obrien@FreeBSD.org
-COMMENT=	A calendar application
+MAINTAINER?=	obrien@FreeBSD.org
+COMMENT?=	A calendar application
 
-LIB_DEPENDS=	tk84.1:${PORTSDIR}/x11-toolkits/tk84
+USE_TK=		yes
 
 GNU_CONFIGURE=	yes
-CONFIGURE_ARGS=	--with-tclconfig=${PREFIX}/lib/tcl8.4 \
-		--with-tclhdir=${PREFIX}/include/tcl8.4 \
-		--with-tclsh=${PREFIX}/bin/tclsh8.4 \
-		--with-tkconfig=${PREFIX}/lib/tk8.4 \
-		--with-tkhdir=${PREFIX}/include/tk8.4
+CONFIGURE_ARGS=	--with-tclconfig=${TCL_LIBDIR} \
+		--with-tclhdir=${TCL_INCLUDEDIR} \
+		--with-tclsh=${TCLSH} \
+		--with-tkconfig=${TK_LIBDIR} \
+		--with-tkhdir=${TK_INCLUDEDIR}
 
 MAN1=		ical.1
 


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->obrien 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Fri Jul 8 16:40:10 UTC 2011 
Responsible-Changed-Why:  
Over to maintainer (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=158737 
State-Changed-From-To: open->closed 
State-Changed-By: obrien 
State-Changed-When: Tue Jul 12 06:08:21 UTC 2011 
State-Changed-Why:  
Committed.  THANKS for the patch! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=158737 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/158737: commit references a PR
Date: Tue, 12 Jul 2011 06:08:31 +0000 (UTC)

 obrien      2011-07-12 06:08:17 UTC
 
   FreeBSD ports repository
 
   Modified files:
     deskutils/ical       Makefile 
   Log:
   + Change to using USE_TK in order to allow depending on any version of Tk.
   + Easier allowance to be a MASTERPORT.
   
   PR:             158737
   Submitted by:   Scot Hetzel <swhetzel@gmail.com>
   
   Revision  Changes    Path
   1.39      +9 -9      ports/deskutils/ical/Makefile
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
