From nobody@FreeBSD.org  Fri Jul  8 08:41:42 2011
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 93E731065670
	for <freebsd-gnats-submit@FreeBSD.org>; Fri,  8 Jul 2011 08:41:42 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22])
	by mx1.freebsd.org (Postfix) with ESMTP id 83BFB8FC12
	for <freebsd-gnats-submit@FreeBSD.org>; Fri,  8 Jul 2011 08:41:42 +0000 (UTC)
Received: from red.freebsd.org (localhost [127.0.0.1])
	by red.freebsd.org (8.14.4/8.14.4) with ESMTP id p688ffYZ052386
	for <freebsd-gnats-submit@FreeBSD.org>; Fri, 8 Jul 2011 08:41:41 GMT
	(envelope-from nobody@red.freebsd.org)
Received: (from nobody@localhost)
	by red.freebsd.org (8.14.4/8.14.4/Submit) id p688ffAZ052385;
	Fri, 8 Jul 2011 08:41:41 GMT
	(envelope-from nobody)
Message-Id: <201107080841.p688ffAZ052385@red.freebsd.org>
Date: Fri, 8 Jul 2011 08:41:41 GMT
From: Quentin Stievenart <acieroid@awesom.eu>
To: freebsd-gnats-submit@FreeBSD.org
Subject: [PATCH] lang/sbcl: don't require graphviz if not needed for build
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         158723
>Category:       ports
>Synopsis:       [PATCH] lang/sbcl: don't require graphviz if not needed for build
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    stas
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Fri Jul 08 08:50:01 UTC 2011
>Closed-Date:    Wed Jul 13 19:14:27 UTC 2011
>Last-Modified:  Wed Jul 13 19:20:08 UTC 2011
>Originator:     Quentin Stievenart
>Release:        FreeBSD 8.2-STABLE i386
>Organization:
>Environment:
System: FreeBSD daemon 8.2-STABLE FreeBSD 8.2-STABLE #5: Tue Mar  1 19:45:55 CET
>Description:
graphviz (which adds a lot of dependencies, especially on x11-less servers) should not be required if the user doesn't want to build sbcl's doc (ie. NOPORTDOCS is set, and the PDF and PS options aren't selected). This patch fixes that.
>How-To-Repeat:

>Fix:


Patch attached with submission follows:

diff -ruN --exclude=CVS /usr/ports/lang/sbcl/Makefile /tmp/sbcl/Makefile
--- /usr/ports/lang/sbcl/Makefile	2011-06-18 18:13:31.000000000 +0200
+++ /tmp/sbcl/Makefile	2011-07-08 09:41:57.000000000 +0200
@@ -23,8 +23,6 @@
 MAINTAINER=	stas@FreeBSD.org
 COMMENT=	A Common Lisp development system derived from the CMU CL system
 
-BUILD_DEPENDS=	dot:${PORTSDIR}/graphics/graphviz
-
 # More platforms are supported, but on Linux.
 ONLY_FOR_ARCHS=	i386 amd64
 ONLY_FOR_ARCHS_REASON=	is a native code compiler, and has not been ported to this architecture yet
@@ -90,6 +88,10 @@
 
 .include <bsd.port.pre.mk>
 
+.if !defined(NOPORTDOCS) || !defined(WITHOUT_PDF) || !defined(WITHOUT_PS)
+BUILD_DEPENDS=	dot:${PORTSDIR}/graphics/graphviz
+.endif
+
 .if !defined(WITHOUT_PDF)
 BUILD_DEPENDS+=	latex:${PORTSDIR}/print/teTeX-base \
 		texi2dvi:${PORTSDIR}/print/texinfo


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->stas 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Fri Jul 8 08:50:11 UTC 2011 
Responsible-Changed-Why:  
Over to maintainer (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=158723 
State-Changed-From-To: open->feedback 
State-Changed-By: stas 
State-Changed-When: Fri Jul 8 18:35:36 UTC 2011 
State-Changed-Why:  
Ask for sumbitter feedback. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=158723 

From: Stanislav Sedov <stas@FreeBSD.org>
To: Quentin Stievenart <acieroid@awesom.eu>
Cc: FreeBSD PR followup <bug-followup@FreeBSD.org>
Subject: Re: ports/158723: [PATCH] lang/sbcl: don't require graphviz if not
 needed for build
Date: Fri, 8 Jul 2011 11:33:35 -0700

 Hi!
 
 The `dot` utility is actually used to build texinfo documentation
 as well which is conditionless (see Makefile in sbcl-internal).
 So we cannot disable it if PDF/PS documentation is disabled.
 
 The right solution might be to make the build of sbcl-internal
 documentation optional and make sbcl build depend on dot only
 in that case.
 
 -- 
 Stanislav Sedov
 ST4096-RIPE
 
 ()  ascii ribbon campaign - against html e-mail 
 /\  www.asciiribbon.org   - against proprietary attachments

From: Quentin Stievenart <quentin.stievenart@gmail.com>
To: bug-followup@FreeBSD.org, acieroid@awesom.eu
Cc:  
Subject: Re: ports/158723: [PATCH] lang/sbcl: don't require graphviz if not
 needed for build
Date: Wed, 13 Jul 2011 15:18:48 +0200

 Yes, dot is needed to build texinfo documentation, but texinfo
 documentation isn't build if NOPORTDOCS is specified. And dot is
 necessary if we build the PDF or PS documentation, and it's because of
 that that I added the three conditions in the patch. So the build of
 sbcl-internal is already optional (and depends on the value of
 NOPORTDOCS), or I missed something.
State-Changed-From-To: feedback->closed 
State-Changed-By: stas 
State-Changed-When: Wed Jul 13 19:14:25 UTC 2011 
State-Changed-Why:  
You're right, my bad.  Just committed your patch.  Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=158723 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/158723: commit references a PR
Date: Wed, 13 Jul 2011 19:13:43 +0000 (UTC)

 stas        2011-07-13 19:13:29 UTC
 
   FreeBSD ports repository
 
   Modified files:
     lang/sbcl            Makefile 
   Log:
   - Graphviz is not required for the build if all the documentation is disabled.
   
   PR:             ports/158723
   Submitted by:   Quentin Stievenart <acieroid@awesom.eu>
   
   Revision  Changes    Path
   1.88      +4 -2      ports/lang/sbcl/Makefile
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
