From nobody@FreeBSD.org  Wed Jul  6 18:10:36 2011
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id F37F8106566C
	for <freebsd-gnats-submit@FreeBSD.org>; Wed,  6 Jul 2011 18:10:35 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22])
	by mx1.freebsd.org (Postfix) with ESMTP id E48318FC0A
	for <freebsd-gnats-submit@FreeBSD.org>; Wed,  6 Jul 2011 18:10:35 +0000 (UTC)
Received: from red.freebsd.org (localhost [127.0.0.1])
	by red.freebsd.org (8.14.4/8.14.4) with ESMTP id p66IAZca022951
	for <freebsd-gnats-submit@FreeBSD.org>; Wed, 6 Jul 2011 18:10:35 GMT
	(envelope-from nobody@red.freebsd.org)
Received: (from nobody@localhost)
	by red.freebsd.org (8.14.4/8.14.4/Submit) id p66IAZLr022950;
	Wed, 6 Jul 2011 18:10:35 GMT
	(envelope-from nobody)
Message-Id: <201107061810.p66IAZLr022950@red.freebsd.org>
Date: Wed, 6 Jul 2011 18:10:35 GMT
From: Jason Bacon <jwbacon@tds.net>
To: freebsd-gnats-submit@FreeBSD.org
Subject: port bug: lang/sdcc RUN_DEPENDS update
X-Send-Pr-Version: www-3.1
X-GNATS-Notify: tijl@coosemans.org

>Number:         158691
>Category:       ports
>Synopsis:       port bug: lang/sdcc RUN_DEPENDS update
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    beech
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed Jul 06 18:20:07 UTC 2011
>Closed-Date:    Sat Jul 09 16:23:33 UTC 2011
>Last-Modified:  Sat Jul  9 16:30:08 UTC 2011
>Originator:     Jason Bacon
>Release:        8.2-RELEASE
>Organization:
Acadix Consulting, LLC
>Environment:
FreeBSD sculpin.jbacon.dyndns.org 8.2-RELEASE FreeBSD 8.2-RELEASE #0: Thu Feb 17 02:41:51 UTC 2011     root@mason.cse.buffalo.edu:/usr/obj/usr/src/sys/GENERIC  amd64
>Description:
gputils is required by sdcc for working with PIC processors, and hence should be included in RUN_DEPENDS as well as BUILD_DEPENDS.

>How-To-Repeat:
1. Install sdcc port/package
2. pkg_delete /var/db/pkg/gputils-*
3. Attempt to compile and link PIC code

>Fix:
Patch attached.

Patch attached with submission follows:

diff -ruN /usr/ports/lang/sdcc/Makefile sdcc/Makefile
--- /usr/ports/lang/sdcc/Makefile	2011-03-21 17:24:00.000000000 -0500
+++ sdcc/Makefile	2011-06-26 22:20:54.000000000 -0500
@@ -85,6 +85,7 @@
 PLIST_SUB+=		PIC="@comment "
 .else
 BUILD_DEPENDS+=		gpasm:${PORTSDIR}/devel/gputils
+RUN_DEPENDS+=		gpasm:${PORTSDIR}/devel/gputils
 PLIST_SUB+=		PIC=""
 .endif
 


>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->feedback 
State-Changed-By: edwin 
State-Changed-When: Wed Jul 6 18:20:17 UTC 2011 
State-Changed-Why:  
Awaiting maintainers feedback (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=158691 

From: Edwin Groothuis <edwin@FreeBSD.org>
To: tijl@coosemans.org
Cc: bug-followup@FreeBSD.org
Subject: Re: ports/158691: port bug: lang/sdcc RUN_DEPENDS update
Date: Wed, 6 Jul 2011 18:20:15 UT

 Maintainer of lang/sdcc,
 
 Please note that PR ports/158691 has just been submitted.
 
 If it contains a patch for an upgrade, an enhancement or a bug fix
 you agree on, reply to this email stating that you approve the patch
 and a committer will take care of it.
 
 The full text of the PR can be found at:
     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/158691
 
 -- 
 Edwin Groothuis via the GNATS Auto Assign Tool
 edwin@FreeBSD.org
Responsible-Changed-From-To: freebsd-ports-bugs->beech 
Responsible-Changed-By: beech 
Responsible-Changed-When: Wed Jul 6 22:39:02 UTC 2011 
Responsible-Changed-Why:  
I'll take it 

http://www.freebsd.org/cgi/query-pr.cgi?pr=158691 

From: Tijl Coosemans <tijl@coosemans.org>
To: bug-followup@freebsd.org
Cc:  
Subject: Re: ports/158691: port bug: lang/sdcc RUN_DEPENDS update
Date: Thu, 7 Jul 2011 09:31:03 +0200

 --Boundary-00=_5CWFOZXoRj6xZ/q
 Content-Type: Text/Plain;
   charset="iso-8859-15"
 Content-Transfer-Encoding: 7bit
 
 Approved, but it also needs to be applied to the pic16 target. I've
 attached an updated patch.
 
 --Boundary-00=_5CWFOZXoRj6xZ/q
 Content-Type: text/plain;
   charset="ISO-8859-15";
   name="patch.txt"
 Content-Transfer-Encoding: 7bit
 Content-Disposition: attachment;
 	filename="patch.txt"
 
 --- Makefile.orig	2011-07-07 09:24:53.000000000 +0200
 +++ Makefile	2011-07-07 09:26:12.000000000 +0200
 @@ -85,6 +85,7 @@
  PLIST_SUB+=		PIC="@comment "
  .else
  BUILD_DEPENDS+=		gpasm:${PORTSDIR}/devel/gputils
 +RUN_DEPENDS+=		gpasm:${PORTSDIR}/devel/gputils
  PLIST_SUB+=		PIC=""
  .endif
  
 @@ -93,6 +94,7 @@
  PLIST_SUB+=		PIC16="@comment "
  .else
  BUILD_DEPENDS+=		gpasm:${PORTSDIR}/devel/gputils
 +RUN_DEPENDS+=		gpasm:${PORTSDIR}/devel/gputils
  PLIST_SUB+=		PIC16=""
  .endif
  
 
 --Boundary-00=_5CWFOZXoRj6xZ/q--
State-Changed-From-To: feedback->closed 
State-Changed-By: beech 
State-Changed-When: Sat Jul 9 16:23:18 UTC 2011 
State-Changed-Why:  
Committed, Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=158691 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/158691: commit references a PR
Date: Sat,  9 Jul 2011 16:22:51 +0000 (UTC)

 beech       2011-07-09 16:22:42 UTC
 
   FreeBSD ports repository
 
   Modified files:
     lang/sdcc            Makefile 
   Log:
   - gputils is required by sdcc for working with PIC processors,
     and hence should be included in RUN_DEPENDS as well as BUILD_DEPENDS
   
   PR:             ports/158691
   Submitted by:   Jason Bacon <jwbacon@tds.net>
   Approved by:    Tijl Coosemans <tijl@coosemans.org> (maintainer)
   
   Revision  Changes    Path
   1.23      +2 -0      ports/lang/sdcc/Makefile
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
