From utisoft@hotmail.com  Thu Jun 16 19:38:15 2011
Return-Path: <utisoft@hotmail.com>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 04D321065674
	for <FreeBSD-gnats-submit@freebsd.org>; Thu, 16 Jun 2011 19:38:15 +0000 (UTC)
	(envelope-from utisoft@hotmail.com)
Received: from blu0-omc1-s5.blu0.hotmail.com (blu0-omc1-s5.blu0.hotmail.com [65.55.116.16])
	by mx1.freebsd.org (Postfix) with ESMTP id B0DFD8FC0C
	for <FreeBSD-gnats-submit@freebsd.org>; Thu, 16 Jun 2011 19:38:14 +0000 (UTC)
Received: from BLU0-SMTP43 ([65.55.116.9]) by blu0-omc1-s5.blu0.hotmail.com with Microsoft SMTPSVC(6.0.3790.4675);
	 Thu, 16 Jun 2011 12:38:13 -0700
Received: from zeus.bayofrum.net ([90.216.242.219]) by BLU0-SMTP43.phx.gbl over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675);
	 Thu, 16 Jun 2011 12:38:13 -0700
Received: from zeus.bayofrum.net (crees@localhost [127.0.0.1])
	by zeus.bayofrum.net (8.14.4/8.14.4) with ESMTP id p5GJZxw4029932
	(version=TLSv1/SSLv3 cipher=DHE-DSS-AES256-SHA bits=256 verify=NO)
	for <FreeBSD-gnats-submit@freebsd.org>; Thu, 16 Jun 2011 20:35:59 +0100 (BST)
	(envelope-from crees@zeus.bayofrum.net)
Received: (from crees@localhost)
	by zeus.bayofrum.net (8.14.4/8.14.4/Submit) id p5GJZxWp029931;
	Thu, 16 Jun 2011 20:35:59 +0100 (BST)
	(envelope-from crees)
Message-Id: <BLU0-SMTP43FC8E6ED6E210730913CEA96A0@phx.gbl>
Date: Thu, 16 Jun 2011 20:35:59 +0100
From: Chris Rees <crees@freebsd.org>
Sender: <utisoft@hotmail.com>
Reply-To: Chris Rees <crees@freebsd.org>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: Fix port: irc/undernet-ircu Direct use of pw in pkg-install
X-Send-Pr-Version: 3.113
X-GNATS-Notify: weaseal@users.sourceforge.net

>Number:         157927
>Category:       ports
>Synopsis:       Fix port: irc/undernet-ircu Direct use of pw in pkg-install
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    crees
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Thu Jun 16 19:40:06 UTC 2011
>Closed-Date:    Fri Jun 17 20:19:07 UTC 2011
>Last-Modified:  Fri Jun 17 20:20:12 UTC 2011
>Originator:     Chris Rees
>Release:        FreeBSD 8.2-RELEASE-p1 i386
>Organization:
bayofrum
>Environment:
System: FreeBSD zeus.bayofrum.net 8.2-RELEASE-p1 FreeBSD 8.2-RELEASE-p1 #0: Sat Apr 30 15:09:06 BST 2011 root@zeus.bayofrum.net:/usr/obj/usr/src/sys/ZEUS i386


	
>Description:
	

	This port uses pkg-install to create new users instead of using USERS= and GROUPS=

>How-To-Repeat:
	
>Fix:

	

	- Use USERS and GROUPS


--- irc-undernet-ircu.patch begins here ---
Index: Makefile
===================================================================
RCS file: /exports/cvsroot-freebsd/ports/irc/undernet-ircu/Makefile,v
retrieving revision 1.8
diff -u -r1.8 Makefile
--- Makefile	22 Aug 2009 00:24:18 -0000	1.8
+++ Makefile	16 Jun 2011 19:24:55 -0000
@@ -15,6 +15,9 @@
 
 CONFLICTS=	ircd-hybrid-7.[0-9]*
 
+USERS=		undernet
+GROUPS=		${USERS}
+
 GNU_CONFIGURE=		yes
 USE_RC_SUBR=		undernet.sh
 CONFIGURE_ARGS=		--with-dpath=${PREFIX}/etc/ --with-symlink=no
@@ -86,9 +89,6 @@
 CONFIGURE_ARGS+=	--with-leak-detect
 .endif
 
-pre-install:
-	@${SH} ${PKGINSTALL} ${PKGNAME} PRE-INSTALL
-
 post-install:
 	@${ECHO_MSG}    ""
 	@${ECHO_MSG}    "	To run undernet ircu you must add 'undernet_enable=\"YES\" to"
Index: pkg-install
===================================================================
RCS file: pkg-install
diff -N pkg-install
--- pkg-install	1 May 2008 00:31:56 -0000	1.1
+++ /dev/null	1 Jan 1970 00:00:00 -0000
@@ -1,40 +0,0 @@
-#!/bin/sh
-
-if [ "x$2" != "xPRE-INSTALL" ]; then
-       exit 0;
-fi
-
-	USER=undernet
-	GROUP=${USER}
-	UID=134
-	GID=${UID}
-	if pw group show "${GROUP}" 2>/dev/null; then
-		echo "You already have a group \"${GROUP}\", so I will use it."
-	else
-		if pw groupadd ${GROUP} -g ${GID}; then
-			echo "Added group \"${GROUP}\"."
-		else
-			echo "Adding group \"${GROUP}\" failed..."
-			exit 1
-		fi
-	fi
-
-	if pw user show "${USER}" 2>/dev/null; then
-		echo "You already have a user \"${USER}\", so I will use it."
-		if pw usermod ${USER} -d "/nonexistant"
-		then
-			echo "Changed home directory of \"${USER}\" to \"${NONEXISTENT}\""
-		else
-			echo "Changing home directory of \"${USER}\" to \"${NONEXISTENT}\" failed..."
-			exit 1
-		fi
-	else
-		if pw useradd ${USER} -u ${UID} -g ${GROUP} -h - \
-			-d "/nonexistant" -s "/sbin/nologin" -c "Undernet ircu Daemon"
-		then
-			echo "Added user \"${USER}\"."
-		else
-			echo "Adding user \"${USER}\" failed..."
-			exit 1
-		fi
-	fi
--- irc-undernet-ircu.patch ends here ---



-- 
This message has been scanned for viruses and
dangerous content by MailScanner, and is
believed to be clean.

>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->crees 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Thu Jun 16 19:40:53 UTC 2011 
Responsible-Changed-Why:  
Submitter has GNATS access (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=157927 
State-Changed-From-To: open->feedback 
State-Changed-By: edwin 
State-Changed-When: Thu Jun 16 19:40:57 UTC 2011 
State-Changed-Why:  
Awaiting maintainers feedback (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=157927 

From: Edwin Groothuis <edwin@FreeBSD.org>
To: weaseal@users.sourceforge.net
Cc: bug-followup@FreeBSD.org
Subject: Re: ports/157927: Fix port: irc/undernet-ircu Direct use of pw in pkg-install
Date: Thu, 16 Jun 2011 19:40:55 UT

 Maintainer of irc/undernet-ircu,
 
 Please note that PR ports/157927 has just been submitted.
 
 If it contains a patch for an upgrade, an enhancement or a bug fix
 you agree on, reply to this email stating that you approve the patch
 and a committer will take care of it.
 
 The full text of the PR can be found at:
     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/157927
 
 -- 
 Edwin Groothuis via the GNATS Auto Assign Tool
 edwin@FreeBSD.org

From: Walter Venable <weaseal@gmail.com>
To: bug-followup@freebsd.org
Cc:  
Subject: Re: ports/157927: Fix port: irc/undernet-ircu Direct use of pw in pkg-install
Date: Thu, 16 Jun 2011 16:19:40 -0400

 --00151747869a51ef3a04a5d9fe4e
 Content-Type: text/plain; charset=ISO-8859-1
 
 Well doesn't that just make it all very simple!
 Looks good!
 Thanks for your patch,
 Walt
 
 On Thu, Jun 16, 2011 at 3:40 PM, Edwin Groothuis <edwin@freebsd.org> wrote:
 
 > Maintainer of irc/undernet-ircu,
 >
 > Please note that PR ports/157927 has just been submitted.
 >
 > If it contains a patch for an upgrade, an enhancement or a bug fix
 > you agree on, reply to this email stating that you approve the patch
 > and a committer will take care of it.
 >
 > The full text of the PR can be found at:
 >    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/157927
 >
 > --
 > Edwin Groothuis via the GNATS Auto Assign Tool
 > edwin@FreeBSD.org
 >
 
 --00151747869a51ef3a04a5d9fe4e
 Content-Type: text/html; charset=ISO-8859-1
 Content-Transfer-Encoding: quoted-printable
 
 Well doesn&#39;t that just make it all very simple!<div>Looks good!</div><d=
 iv>Thanks for your patch,</div><div>Walt</div><div><br><div class=3D"gmail_=
 quote">On Thu, Jun 16, 2011 at 3:40 PM, Edwin Groothuis <span dir=3D"ltr">&=
 lt;<a href=3D"mailto:edwin@freebsd.org">edwin@freebsd.org</a>&gt;</span> wr=
 ote:<br>
 
 <blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1p=
 x #ccc solid;padding-left:1ex;">Maintainer of irc/undernet-ircu,<br>
 <br>
 Please note that PR ports/157927 has just been submitted.<br>
 <br>
 If it contains a patch for an upgrade, an enhancement or a bug fix<br>
 you agree on, reply to this email stating that you approve the patch<br>
 and a committer will take care of it.<br>
 <br>
 The full text of the PR can be found at:<br>
  =A0 =A0<a href=3D"http://www.freebsd.org/cgi/query-pr.cgi?pr=3Dports/15792=
 7" target=3D"_blank">http://www.freebsd.org/cgi/query-pr.cgi?pr=3Dports/157=
 927</a><br>
 <font color=3D"#888888"><br>
 --<br>
 Edwin Groothuis via the GNATS Auto Assign Tool<br>
 edwin@FreeBSD.org<br>
 </font></blockquote></div><br></div>
 
 --00151747869a51ef3a04a5d9fe4e--
State-Changed-From-To: feedback->open 
State-Changed-By: crees 
State-Changed-When: Fri Jun 17 16:27:59 UTC 2011 
State-Changed-Why:  
Maintainer has approved. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=157927 
State-Changed-From-To: open->closed 
State-Changed-By: crees 
State-Changed-When: Fri Jun 17 20:19:06 UTC 2011 
State-Changed-Why:  
Committed. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=157927 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/157927: commit references a PR
Date: Fri, 17 Jun 2011 20:19:04 +0000 (UTC)

 crees       2011-06-17 20:18:55 UTC
 
   FreeBSD ports repository
 
   Modified files:
     irc/undernet-ircu    Makefile 
   Removed files:
     irc/undernet-ircu    pkg-install 
   Log:
   - Use USERS and GROUPS
   
   PR:             ports/157927
   Submitted by:   crees
   Approved by:    Maintainer, rene (mentor)
   
   Revision  Changes    Path
   1.9       +3 -3      ports/irc/undernet-ircu/Makefile
   1.2       +0 -40     ports/irc/undernet-ircu/pkg-install (dead)
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
