From nobody@FreeBSD.org  Sun Jun 12 03:43:29 2011
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 9D41E106564A
	for <freebsd-gnats-submit@FreeBSD.org>; Sun, 12 Jun 2011 03:43:29 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22])
	by mx1.freebsd.org (Postfix) with ESMTP id 8E1E98FC08
	for <freebsd-gnats-submit@FreeBSD.org>; Sun, 12 Jun 2011 03:43:29 +0000 (UTC)
Received: from red.freebsd.org (localhost [127.0.0.1])
	by red.freebsd.org (8.14.4/8.14.4) with ESMTP id p5C3hTnI080695
	for <freebsd-gnats-submit@FreeBSD.org>; Sun, 12 Jun 2011 03:43:29 GMT
	(envelope-from nobody@red.freebsd.org)
Received: (from nobody@localhost)
	by red.freebsd.org (8.14.4/8.14.4/Submit) id p5C3hTSf080688;
	Sun, 12 Jun 2011 03:43:29 GMT
	(envelope-from nobody)
Message-Id: <201106120343.p5C3hTSf080688@red.freebsd.org>
Date: Sun, 12 Jun 2011 03:43:29 GMT
From: Stephen Hurd <shurd@sasktel.net>
To: freebsd-gnats-submit@FreeBSD.org
Subject: [PATCH] comms/xmorse broken
X-Send-Pr-Version: www-3.1
X-GNATS-Notify: sunrychen@gmail.com

>Number:         157784
>Category:       ports
>Synopsis:       [PATCH] comms/xmorse broken
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    db
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sun Jun 12 03:50:06 UTC 2011
>Closed-Date:    Thu Jul 21 16:25:05 UTC 2011
>Last-Modified:  Thu Jul 21 16:30:10 UTC 2011
>Originator:     Stephen Hurd
>Release:        8.2-RELEASE
>Organization:
>Environment:
FreeBSD stephen.hurd.local 8.2-RELEASE FreeBSD 8.2-RELEASE #0: Fri Feb 18 02:24:46 UTC 2011     root@almeida.cse.buffalo.edu:/usr/obj/usr/src/sys/GENERIC  i386

>Description:
The last patch while fixing the build broke the program.  The program is supposed to start playing morse when the text box is clicked... the patch-m.pl prevented this from happening breaking the entire point of the program.
>How-To-Repeat:
Install port
>Fix:
Instead of commenting out the line, change it to:
  code {Morse->show(argc, argv);

This just requires diddling the patch to:
--- m.fl.orig   2008-08-28 14:00:49.000000000 +0200
+++ m.fl        2008-08-28 14:00:58.000000000 +0200
@@ -231,7 +231,7 @@
       }
     }
   }
-  code {w->show(argc, argv);
+  code {Morse->show(argc, argv);
 while (1) {
   int c = Lesson->select();    // Select random letter
   bool pass = Teacher->teach(c);// Teach/test student


>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->feedback 
State-Changed-By: edwin 
State-Changed-When: Sun Jun 12 03:50:16 UTC 2011 
State-Changed-Why:  
Awaiting maintainers feedback (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=157784 

From: Edwin Groothuis <edwin@FreeBSD.org>
To: sunrychen@gmail.com
Cc: bug-followup@FreeBSD.org
Subject: Re: ports/157784: [PATCH] comms/xmorse broken
Date: Sun, 12 Jun 2011 03:50:15 UT

 Maintainer of comms/xmorse,
 
 Please note that PR ports/157784 has just been submitted.
 
 If it contains a patch for an upgrade, an enhancement or a bug fix
 you agree on, reply to this email stating that you approve the patch
 and a committer will take care of it.
 
 The full text of the PR can be found at:
     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/157784
 
 -- 
 Edwin Groothuis via the GNATS Auto Assign Tool
 edwin@FreeBSD.org
Responsible-Changed-From-To: freebsd-ports-bugs->db 
Responsible-Changed-By: db 
Responsible-Changed-When: Sun Jun 12 16:02:29 UTC 2011 
Responsible-Changed-Why:  
I'll take it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=157784 

From: Sunry Chen <sunrychen@gmail.com>
To: bug-followup@freebsd.org
Cc:  
Subject: Re: ports/157784: [PATCH] comms/xmorse broken
Date: Fri, 8 Jul 2011 11:17:53 +0800

 --00504502d18c808a6d04a78647ee
 Content-Type: text/plain; charset=ISO-8859-1
 
 While I can't reproduce this bug.
 
 FreeBSD freebsd.changsha 8.2-RELEASE FreeBSD 8.2-RELEASE #0: Fri Feb 18
 02:24:46 UTC 2011    root@almeida.cse.buffalo.ed:/usr/lbj/sr/src/sys/GENERIC
 i386
 
 --00504502d18c808a6d04a78647ee
 Content-Type: text/html; charset=ISO-8859-1
 Content-Transfer-Encoding: quoted-printable
 
 While I can&#39;t reproduce this bug.<br><br>FreeBSD freebsd.changsha 8.2-R=
 ELEASE FreeBSD 8.2-RELEASE #0: Fri Feb 18 02:24:46 UTC 2011=A0=A0=A0 root@a=
 lmeida.cse.buffalo.ed:/usr/lbj/sr/src/sys/GENERIC=A0=A0 i386<br>
 <div style=3D"visibility: hidden; left: -5000px; position: absolute; z-inde=
 x: 9999; padding: 0px; margin-left: 0px; margin-top: 0px; overflow: hidden;=
  word-wrap: break-word; color: black; font-size: 10px; text-align: left; li=
 ne-height: 130%;" id=3D"avg_ls_inline_popup">
 </div>
 
 --00504502d18c808a6d04a78647ee--

From: Sunry Chen <sunrychen@gmail.com>
To: bug-followup@freebsd.org
Cc:  
Subject: Re: ports/157784: [PATCH] comms/xmorse broken
Date: Thu, 21 Jul 2011 16:32:23 +0800

 There is problem while running the program, no problem compile it.
 
 xmorse should produce morse sound white click in the white space bar.
 The problem is that no sound out! With the patch it works.
 
 So I approve the patch.
State-Changed-From-To: feedback->closed 
State-Changed-By: db 
State-Changed-When: Thu Jul 21 16:25:04 UTC 2011 
State-Changed-Why:  
Committed. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=157784 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/157784: commit references a PR
Date: Thu, 21 Jul 2011 16:24:41 +0000 (UTC)

 db          2011-07-21 16:24:26 UTC
 
   FreeBSD ports repository
 
   Modified files:
     comms/xmorse/files   patch-m.fl 
   Log:
   - The last patch while fixing the build broke the program.  The program is
     supposed to start playing morse when the text box is clicked... the
     patch-m.pl prevented this from happening breaking the entire point
     of the program.
   
   PR:             ports/157784
   Submitted by:   Stephen Hurd <shurd@sasktel.net>
   
   Revision  Changes    Path
   1.2       +3 -3      ports/comms/xmorse/files/patch-m.fl
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
