From utisoft@hotmail.com  Sat Jun  4 10:56:07 2011
Return-Path: <utisoft@hotmail.com>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id F16ED106566B
	for <FreeBSD-gnats-submit@freebsd.org>; Sat,  4 Jun 2011 10:56:06 +0000 (UTC)
	(envelope-from utisoft@hotmail.com)
Received: from blu0-omc1-s1.blu0.hotmail.com (blu0-omc1-s1.blu0.hotmail.com [65.55.116.12])
	by mx1.freebsd.org (Postfix) with ESMTP id B210D8FC13
	for <FreeBSD-gnats-submit@freebsd.org>; Sat,  4 Jun 2011 10:56:06 +0000 (UTC)
Received: from BLU0-SMTP110 ([65.55.116.7]) by blu0-omc1-s1.blu0.hotmail.com with Microsoft SMTPSVC(6.0.3790.4675);
	 Sat, 4 Jun 2011 03:56:06 -0700
Received: from zeus.bayofrum.net ([90.221.7.100]) by BLU0-SMTP110.phx.gbl over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675);
	 Sat, 4 Jun 2011 03:56:04 -0700
Received: from zeus.bayofrum.net (crees@localhost [127.0.0.1])
	by zeus.bayofrum.net (8.14.4/8.14.4) with ESMTP id p54AtbOb027045
	(version=TLSv1/SSLv3 cipher=DHE-DSS-AES256-SHA bits=256 verify=NO)
	for <FreeBSD-gnats-submit@freebsd.org>; Sat, 4 Jun 2011 11:55:38 +0100 (BST)
	(envelope-from chris@zeus.bayofrum.net)
Received: (from crees@localhost)
	by zeus.bayofrum.net (8.14.4/8.14.4/Submit) id p54Atb0m027044;
	Sat, 4 Jun 2011 11:55:37 +0100 (BST)
	(envelope-from chris)
Message-Id: <BLU0-SMTP110E7F5BB1E57E83C79E385A97E0@phx.gbl>
Date: Sat, 4 Jun 2011 11:55:37 +0100
From: Chris Rees <utisoft@gmail.com>
Sender: <utisoft@hotmail.com>
Reply-To: Chris Rees <utisoft@gmail.com>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: [PATCH] Fix port: dns/dhid should use USERS, distfile needs checking
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         157603
>Category:       ports
>Synopsis:       [PATCH] Fix port: dns/dhid should use USERS, distfile needs checking
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    crees
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Sat Jun 04 11:00:21 UTC 2011
>Closed-Date:    Tue Aug 09 11:22:27 UTC 2011
>Last-Modified:  Tue Aug 09 11:22:27 UTC 2011
>Originator:     Chris Rees
>Release:        FreeBSD 8.2-RELEASE-p1 i386
>Organization:
bayofrum
>Environment:
System: FreeBSD zeus.bayofrum.net 8.2-RELEASE-p1 FreeBSD 8.2-RELEASE-p1 #0: Sat Apr 30 15:09:06 BST 2011 root@zeus.bayofrum.net:/usr/obj/usr/src/sys/ZEUS i386


	
>Description:
	

	This port uses pkg-install to create new users instead of using USERS= and GROUPS=

	The distfile on the server has changed, ports@ emailed to ask if anyone is interested in maintaining -- port is unusable as-is

>How-To-Repeat:
	
>Fix:

	

	- Use USERS and GROUPS

	Submitted by: Chris Rees (utisoft@gmail.com)

	Please bear in mind that pkg-install has been removed.


--- dns-dhid.patch begins here ---
Index: Makefile
===================================================================
RCS file: /exports/cvsroot-freebsd/ports/dns/dhid/Makefile,v
retrieving revision 1.22
diff -u -r1.22 Makefile
--- Makefile	19 Apr 2010 10:43:23 -0000	1.22
+++ Makefile	2 Jun 2011 15:10:30 -0000
@@ -24,17 +24,14 @@
 PORTDOCS=	AUTHORS CONTRIBUTORS COPYRIGHT INSTALL README WHATSNEW
 PLIST_FILES=	sbin/dhid bin/genkeys etc/dhid.conf.sample
 
-DHID_USER=	dhis
-DHID_GROUP=	dhis
+USERS=		dhis
+GROUPS=		dhis
 DHID_PID_DIR=	/var/run/dhis
 
 post-patch:
 	@${ECHO} "===>   Patching dhid.h"
 	@${REINPLACE_CMD} -e "s^__PREFIX__^${PREFIX}^g" ${WRKSRC}/dhid.h
 
-pre-install:
-	@${SETENV} PKG_PREFIX=${PREFIX} ${SH} ${PKGINSTALL} ${PKGNAME} PRE-INSTALL
-
 do-install:
 	${INSTALL_PROGRAM} ${WRKSRC}/dhid ${PREFIX}/sbin
 	${INSTALL_PROGRAM} ${WRKSRC}/genkeys ${PREFIX}/bin
@@ -54,7 +51,6 @@
 	${MKDIR} ${DOCSDIR}
 	cd ${WRKSRC} && ${INSTALL_DATA} ${PORTDOCS} ${DOCSDIR}
 .endif
-	@${SETENV} ${SCRIPTS_ENV} PKG_PREFIX="${PREFIX}" ${SH} ${PKGINSTALL} ${PKGNAME} POST-INSTALL
 	@${CAT} ${PKGMESSAGE}
 
 .include <bsd.port.mk>
Index: pkg-install
===================================================================
RCS file: pkg-install
diff -N pkg-install
--- pkg-install	19 Feb 2005 20:42:39 -0000	1.1
+++ /dev/null	1 Jan 1970 00:00:00 -0000
@@ -1,37 +0,0 @@
-#! /bin/sh
-
-# $FreeBSD: ports/dns/dhid/pkg-install,v 1.1 2005/02/19 20:42:39 pav Exp $
-
-PATH=/bin:/usr/sbin
-
-case $2 in
-PRE-INSTALL)
-       USER=dhis
-       GROUP=${USER}
-
-       if pw group show "${GROUP}" 2>/dev/null; then
-               echo "You already have a group \"${GROUP}\", so I will use it."
-       else
-               if pw groupadd ${GROUP} -g 114 -h -; then
-                       echo "Added group \"${GROUP}\"."
-               else
-                       echo "Adding group \"${GROUP}\" failed..."
-                       exit 1
-               fi
-       fi
-
-       if pw user show "${USER}" 2>/dev/null; then
-               echo "You already have a user \"${USER}\", so I will use it."
-       else
-               if pw useradd ${USER} -u 114 -g ${GROUP} -h - \
-                       -d /nonexistent -s /sbin/nologin \
-                       -c "DHIS Daemon"
-               then
-                       echo "Added user \"${USER}\"."
-               else
-                       echo "Adding user \"${USER}\" failed..."
-                       exit 1
-               fi
-       fi
-       ;;
-esac
--- dns-dhid.patch ends here ---



-- 
This message has been scanned for viruses and
dangerous content by MailScanner, and is
believed to be clean.

>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->pgollucci 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Sat Jun 4 11:01:07 UTC 2011 
Responsible-Changed-Why:  
pgollucci@ wants his PRs (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=157603 
Responsible-Changed-From-To: pgollucci->crees 
Responsible-Changed-By: crees 
Responsible-Changed-When: Wed Jun 22 16:54:18 UTC 2011 
Responsible-Changed-Why:  
Invalid autoassignment 

http://www.freebsd.org/cgi/query-pr.cgi?pr=157603 
Responsible-Changed-From-To: crees->freebsd-ports-bugs 
Responsible-Changed-By: crees 
Responsible-Changed-When: Wed Jun 22 17:02:26 UTC 2011 
Responsible-Changed-Why:  
To pool to correct assign message 

http://www.freebsd.org/cgi/query-pr.cgi?pr=157603 
Responsible-Changed-From-To: freebsd-ports-bugs->crees 
Responsible-Changed-By: crees 
Responsible-Changed-When: Wed Jun 22 17:24:51 UTC 2011 
Responsible-Changed-Why:  
Invalid autoassignment to pgollucci 

http://www.freebsd.org/cgi/query-pr.cgi?pr=157603 
State-Changed-From-To: open->closed 
State-Changed-By: crees 
State-Changed-When: Sat Jun 25 20:27:21 UTC 2011 
State-Changed-Why:  
Deprecated -- no interest in fixing the port from p 

http://www.freebsd.org/cgi/query-pr.cgi?pr=157603 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/157603: commit references a PR
Date: Sat, 25 Jun 2011 20:26:55 +0000 (UTC)

 crees       2011-06-25 20:26:47 UTC
 
   FreeBSD ports repository
 
   Modified files:
     dns/dhid             Makefile 
   Log:
   - Deprecate; Unmaintained, distfile has changed with no explanation, uses pw directly
   
   Expires in one month
   
   PR:             ports/157603
   Approved by:    rene (mentor)
   
   Revision  Changes    Path
   1.23      +3 -0      ports/dns/dhid/Makefile
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: closed->patched 
State-Changed-By: crees 
State-Changed-When: Tue Jun 28 19:18:44 UTC 2011 
State-Changed-Why:  
Not actually deleted yet, back in queue 

http://www.freebsd.org/cgi/query-pr.cgi?pr=157603 
State-Changed-From-To: patched->closed 
State-Changed-By: crees 
State-Changed-When: Tue Aug 9 11:22:26 UTC 2011 
State-Changed-Why:  
Port removed. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=157603 
>Unformatted:
