From utisoft@hotmail.com  Sat Jun  4 09:42:48 2011
Return-Path: <utisoft@hotmail.com>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 12658106567E
	for <FreeBSD-gnats-submit@freebsd.org>; Sat,  4 Jun 2011 09:42:48 +0000 (UTC)
	(envelope-from utisoft@hotmail.com)
Received: from blu0-omc1-s11.blu0.hotmail.com (blu0-omc1-s11.blu0.hotmail.com [65.55.116.22])
	by mx1.freebsd.org (Postfix) with ESMTP id C6E4C8FC08
	for <FreeBSD-gnats-submit@freebsd.org>; Sat,  4 Jun 2011 09:42:47 +0000 (UTC)
Received: from BLU0-SMTP149 ([65.55.116.9]) by blu0-omc1-s11.blu0.hotmail.com with Microsoft SMTPSVC(6.0.3790.4675);
	 Sat, 4 Jun 2011 02:42:47 -0700
Received: from zeus.bayofrum.net ([90.221.7.100]) by BLU0-SMTP149.phx.gbl over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675);
	 Sat, 4 Jun 2011 02:42:45 -0700
Received: from zeus.bayofrum.net (crees@localhost [127.0.0.1])
	by zeus.bayofrum.net (8.14.4/8.14.4) with ESMTP id p549gKaS015152
	(version=TLSv1/SSLv3 cipher=DHE-DSS-AES256-SHA bits=256 verify=NO)
	for <FreeBSD-gnats-submit@freebsd.org>; Sat, 4 Jun 2011 10:42:20 +0100 (BST)
	(envelope-from chris@zeus.bayofrum.net)
Received: (from crees@localhost)
	by zeus.bayofrum.net (8.14.4/8.14.4/Submit) id p549gJ1x015151;
	Sat, 4 Jun 2011 10:42:19 +0100 (BST)
	(envelope-from chris)
Message-Id: <BLU0-SMTP1492A827C82762DD4B3F3F2A97E0@phx.gbl>
Date: Sat, 4 Jun 2011 10:42:19 +0100
From: Chris Rees <utisoft@gmail.com>
Sender: <utisoft@hotmail.com>
Reply-To: Chris Rees <utisoft@gmail.com>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: Fix port: devel/py-gitosis should use USERS
X-Send-Pr-Version: 3.113
X-GNATS-Notify: douglas@douglasthrift.net

>Number:         157594
>Category:       ports
>Synopsis:       Fix port: devel/py-gitosis should use USERS
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    crees
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Sat Jun 04 09:50:10 UTC 2011
>Closed-Date:    Sun Jul 03 15:19:32 UTC 2011
>Last-Modified:  Sun Jul  3 15:20:21 UTC 2011
>Originator:     Chris Rees
>Release:        FreeBSD 8.2-RELEASE-p1 i386
>Organization:
bayofrum
>Environment:
System: FreeBSD zeus.bayofrum.net 8.2-RELEASE-p1 FreeBSD 8.2-RELEASE-p1 #0: Sat Apr 30 15:09:06 BST 2011 root@zeus.bayofrum.net:/usr/obj/usr/src/sys/ZEUS i386


	
>Description:
	

	This port uses pkg-install to create new users instead of using USERS= and GROUPS=

>How-To-Repeat:
	
>Fix:

	

	- Use USERS and GROUPS

	Submitted by: Chris Rees (utisoft@gmail.com)

	Please note that pkg-install has been removed


--- devel-py-gitosis.patch begins here ---
Index: Makefile
===================================================================
RCS file: /exports/cvsroot-freebsd/ports/devel/py-gitosis/Makefile,v
retrieving revision 1.5
diff -u -r1.5 Makefile
--- Makefile	15 Jan 2011 15:33:32 -0000	1.5
+++ Makefile	2 Jun 2011 14:55:56 -0000
@@ -22,15 +22,12 @@
 USE_BZIP2=	yes
 USE_PYTHON=	yes
 USE_PYDISTUTILS=	easy_install
+USERS=		git
+GROUPS=		${USERS}
 
 WRKSRC=		${WRKDIR}/${PORTNAME}
 PYDISTUTILS_PKGVERSION=	${PORTVERSION:R}
 
-pre-su-install:
-	@${SETENV} PKG_PREFIX=${PREFIX} GITUSER=${GITUSER} \
-		GITGROUP=${GITGROUP} GITHOME=${GITHOME} \
-		${SH} ${PKGINSTALL} ${PKGNAME} PRE-INSTALL
-
 post-install:
 	${CHMOD} +x ${PYTHON_SITELIBDIR}/${PYEASYINSTALL_EGG}/gitosis/templates/admin/hooks/post-update
 	@${CAT} ${PKGMESSAGE}
Index: pkg-install
===================================================================
RCS file: pkg-install
diff -N pkg-install
--- pkg-install	15 Sep 2009 08:23:25 -0000	1.1
+++ /dev/null	1 Jan 1970 00:00:00 -0000
@@ -1,43 +0,0 @@
-#!/bin/sh
-
-# $FreeBSD: ports/devel/py-gitosis/pkg-install,v 1.1 2009/09/15 08:23:25 nivit Exp $
-
-PATH=/bin:/usr/bin:/usr/sbin
-
-case $2 in
-PRE-INSTALL)
-	GITUSER=${GITUSER:-git}
-	GITGROUP=${GITGROUP:-git}
-	GITHOME=${GITHOME:-${PKG_PREFIX}/${GITUSER}}
-	UID=211
-	GID=211
-
-	if pw group show "${GITGROUP}" 2>/dev/null; then
-		echo "You already have a group \"${GITGROUP}\", so I will use it."
-	else
-		if pw groupadd ${GITGROUP} -g ${GID}; then
-			echo "Added group \"${GITGROUP}\"."
-		else
-			echo "Adding group \"${GITGROUP}\" failed..."
-			exit 1
-		fi
-	fi
-
-	if pw user show "${GITUSER}" 2>/dev/null; then
-		echo "You already have a user \"${GITUSER}\", so I will use it."
-	else
-		if pw useradd ${GITUSER} -u ${UID} -g ${GITGROUP} -h - -d ${GITHOME} \
-			-c "gitosis user"
-		then
-			echo "Added user \"${GITUSER}\"."
-		else
-			echo "Adding user \"${GITUSER}\" failed..."
-			exit 1
-		fi
-	fi
-
-	if ! [ -x ~${GITUSER} ] ; then
-		install -m 755 -o ${GITUSER} -g ${GITGROUP} -d ${GITHOME}
-	fi
-	;;
-esac
--- devel-py-gitosis.patch ends here ---



-- 
This message has been scanned for viruses and
dangerous content by MailScanner, and is
believed to be clean.

>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->pgollucci 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Sat Jun 4 09:50:28 UTC 2011 
Responsible-Changed-Why:  
pgollucci@ wants his PRs (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=157594 
State-Changed-From-To: open->feedback 
State-Changed-By: edwin 
State-Changed-When: Sat Jun 4 09:50:33 UTC 2011 
State-Changed-Why:  
Awaiting maintainers feedback (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=157594 

From: Edwin Groothuis <edwin@FreeBSD.org>
To: douglas@douglasthrift.net
Cc: bug-followup@FreeBSD.org
Subject: Re: ports/157594: Fix port: devel/py-gitosis should use USERS
Date: Sat, 4 Jun 2011 09:50:31 UT

 Maintainer of devel/py-gitosis,
 
 Please note that PR ports/157594 has just been submitted.
 
 If it contains a patch for an upgrade, an enhancement or a bug fix
 you agree on, reply to this email stating that you approve the patch
 and a committer will take care of it.
 
 The full text of the PR can be found at:
     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/157594
 
 -- 
 Edwin Groothuis via the GNATS Auto Assign Tool
 edwin@FreeBSD.org

From: Douglas Thrift <douglas@douglasthrift.net>
To: bug-followup@FreeBSD.ORG
Cc:  
Subject: Re: ports/157594: Fix port: devel/py-gitosis should use USERS
Date: Sat, 04 Jun 2011 03:16:09 -0700

 On 6/4/2011 2:50 AM, Edwin Groothuis wrote:
 > Maintainer of devel/py-gitosis,
 > 
 > Please note that PR ports/157594 has just been submitted.
 > 
 > If it contains a patch for an upgrade, an enhancement or a bug fix
 > you agree on, reply to this email stating that you approve the patch
 > and a committer will take care of it.
 > 
 > The full text of the PR can be found at:
 >     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/157594
 > 
 
 Looks good to me. I approve.
 
 Thanks!
 -- 
 Douglas William Thrift
 <douglas@douglasthrift.net>
 <http://douglasthrift.net/>
Responsible-Changed-From-To: pgollucci->crees 
Responsible-Changed-By: crees 
Responsible-Changed-When: Wed Jun 22 16:54:06 UTC 2011 
Responsible-Changed-Why:  
Invalid autoassignment 

http://www.freebsd.org/cgi/query-pr.cgi?pr=157594 
Responsible-Changed-From-To: crees->freebsd-ports-bugs 
Responsible-Changed-By: crees 
Responsible-Changed-When: Wed Jun 22 17:02:12 UTC 2011 
Responsible-Changed-Why:  
To pool to correct assign message 

http://www.freebsd.org/cgi/query-pr.cgi?pr=157594 
Responsible-Changed-From-To: freebsd-ports-bugs->crees 
Responsible-Changed-By: crees 
Responsible-Changed-When: Wed Jun 22 17:24:43 UTC 2011 
Responsible-Changed-Why:  
Invalid autoassignment to pgollucci 

http://www.freebsd.org/cgi/query-pr.cgi?pr=157594 
State-Changed-From-To: feedback->open 
State-Changed-By: crees 
State-Changed-When: Sun Jun 26 16:34:54 UTC 2011 
State-Changed-Why:  
Maintainer has approved. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=157594 
State-Changed-From-To: open->closed 
State-Changed-By: crees 
State-Changed-When: Sun Jul 3 15:19:31 UTC 2011 
State-Changed-Why:  
Committed. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=157594 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/157594: commit references a PR
Date: Sun,  3 Jul 2011 15:19:29 +0000 (UTC)

 crees       2011-07-03 15:19:15 UTC
 
   FreeBSD ports repository
 
   Modified files:
     devel/py-gitosis     Makefile 
   Removed files:
     devel/py-gitosis     pkg-install 
   Log:
   - Use USERS and GROUPS
   
   PR:             ports/157594
   Submitted by:   Chris Rees <utisoft@gmail.com>
   Approved by:    rene (mentor), maintainer (Douglas Thrift)
   
   Revision  Changes    Path
   1.6       +2 -5      ports/devel/py-gitosis/Makefile
   1.2       +0 -43     ports/devel/py-gitosis/pkg-install (dead)
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
