From nobody@FreeBSD.org  Tue May 31 17:49:21 2011
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 7D93E1065672
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 31 May 2011 17:49:21 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22])
	by mx1.freebsd.org (Postfix) with ESMTP id 6DB9F8FC0C
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 31 May 2011 17:49:21 +0000 (UTC)
Received: from red.freebsd.org (localhost [127.0.0.1])
	by red.freebsd.org (8.14.4/8.14.4) with ESMTP id p4VHnLFh091011
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 31 May 2011 17:49:21 GMT
	(envelope-from nobody@red.freebsd.org)
Received: (from nobody@localhost)
	by red.freebsd.org (8.14.4/8.14.4/Submit) id p4VHnLb0091010;
	Tue, 31 May 2011 17:49:21 GMT
	(envelope-from nobody)
Message-Id: <201105311749.p4VHnLb0091010@red.freebsd.org>
Date: Tue, 31 May 2011 17:49:21 GMT
From: Todd Rinaldo <toddr@cpanel.net>
To: freebsd-gnats-submit@FreeBSD.org
Subject: textproc/expat2 provides the incorrect upstream patch for CVE-2009-3560 
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         157469
>Category:       ports
>Synopsis:       textproc/expat2 provides the incorrect upstream patch for CVE-2009-3560
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    kuriyama
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue May 31 17:50:08 UTC 2011
>Closed-Date:    Mon Aug 29 14:33:54 UTC 2011
>Last-Modified:  Mon Aug 29 14:40:07 UTC 2011
>Originator:     Todd Rinaldo
>Release:        8.2
>Organization:
cPanel, Inc.
>Environment:
FreeBSD free82x64 8.2-RELEASE FreeBSD 8.2-RELEASE #0: Thu Feb 17 02:41:51 UTC 2011     root@mason.cse.buffalo.edu:/usr/obj/usr/src/sys/GENERIC  amd64

>Description:
textproc/expat2/files/patch-xmlparse.c is incomplete. It does not match the upstream patch provided for this at:
http://expat.cvs.sourceforge.net/viewvc/expat/expat/lib/xmlparse.c?r1=1.165&r2=1.166&view=patch

As a result, the test suite for perl's XML::Parser is universally failing on Free BSD:
http://www.cpantesters.org/distro/X/XML-Parser.html#XML-Parser-2.40_01?grade=1&perlmat=1&patches=1&oncpan=2&distmat=3&perlver=ALL&osname=ALL&version=2.40_01

This is being tracked in RT for XML::Parser via https://rt.cpan.org/Ticket/Display.html?id=55729

I plan to TODO these tests for Free BSD, referencing this PR until the problem is fixed. 
>How-To-Repeat:
1. install textproc/expat2
2. wget/unzip http://search.cpan.org/CPAN/authors/id/C/CH/CHORNY/XML-Parser-2.40.tar.gz
3. perl Makefile.PL 
4. gmake test



>Fix:
Change textproc/expat2/files/patch-xmlparse.c  to match upstream:

http://expat.cvs.sourceforge.net/viewvc/expat/expat/lib/xmlparse.c?r1=1.165&r2=1.166&view=patch

>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->kuriyama 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Tue May 31 17:50:17 UTC 2011 
Responsible-Changed-Why:  
Over to maintainer (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=157469 
State-Changed-From-To: open->closed 
State-Changed-By: kuriyama 
State-Changed-When: Mon Aug 29 14:33:36 UTC 2011 
State-Changed-Why:  
Committed, thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=157469 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/157469: commit references a PR
Date: Mon, 29 Aug 2011 14:33:35 +0000 (UTC)

 kuriyama    2011-08-29 14:33:26 UTC
 
   FreeBSD ports repository
 
   Modified files:
     textproc/expat2      Makefile 
     textproc/expat2/files patch-xmlparse.c 
   Log:
   Apply updated (correct) fix for xmlparse.c (r1.166 in expat CVS).
   
   PR:             ports/157469
   Submitted by:   Todd Rinaldo <toddr@cpanel.net>
   
   Revision  Changes    Path
   1.37      +1 -1      ports/textproc/expat2/Makefile
   1.2       +12 -10    ports/textproc/expat2/files/patch-xmlparse.c
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
