From g.olgeni@colby.it  Mon May 23 10:11:34 2011
Return-Path: <g.olgeni@colby.it>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 319791065675
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 23 May 2011 10:11:34 +0000 (UTC)
	(envelope-from g.olgeni@colby.it)
Received: from mail.colby.tv (93-62-141-58.ip22.fastwebnet.it [93.62.141.58])
	by mx1.freebsd.org (Postfix) with ESMTP id 943548FC14
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 23 May 2011 10:11:32 +0000 (UTC)
Received: from server.colby.local (localhost [127.0.0.1])
	by server.colby.local (8.14.4/8.14.4) with ESMTP id p4NABV4B035924;
	Mon, 23 May 2011 12:11:31 +0200 (CEST)
	(envelope-from g.olgeni@colby.it)
Received: from exchange.colby.local ([192.168.1.11] helo=exchange.colby.local)
	with IPv4:25 by server.colby.local; 23 May 2011 12:11:31 +0200
Received: from backoffice.colby.local ([192.168.1.56]) by exchange.colby.local over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675);
	 Mon, 23 May 2011 12:11:31 +0200
Received: from backoffice.colby.local (localhost [127.0.0.1])
	by backoffice.colby.local (8.14.4/8.14.4) with ESMTP id p4NABVos003624;
	Mon, 23 May 2011 12:11:31 +0200 (CEST)
	(envelope-from olgeni@backoffice.colby.local)
Received: (from olgeni@localhost)
	by backoffice.colby.local (8.14.4/8.14.4/Submit) id p4NABVQk003623;
	Mon, 23 May 2011 12:11:31 +0200 (CEST)
	(envelope-from olgeni)
Message-Id: <201105231011.p4NABVQk003623@backoffice.colby.local>
Date: Mon, 23 May 2011 12:11:31 +0200 (CEST)
From: Jimmy Olgeni <olgeni@freebsd.org>
To: FreeBSD-gnats-submit@freebsd.org
Cc: ohauer@freebsd.org
Subject: [PATCH] mail/spamd: respect BATCH
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         157266
>Category:       ports
>Synopsis:       [PATCH] mail/spamd: respect BATCH
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    ohauer
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Mon May 23 10:20:10 UTC 2011
>Closed-Date:    Sat Jun 04 22:13:22 UTC 2011
>Last-Modified:  Sat Jun 04 22:13:22 UTC 2011
>Originator:     Jimmy Olgeni
>Release:        FreeBSD 8.2-STABLE amd64
>Organization:
>Environment:
System: FreeBSD backoffice 8.2-STABLE FreeBSD 8.2-STABLE #1: Sun May 15 20:37:17 CEST 2011
>Description:
[DESCRIBE CHANGES]
The "ask" function in pkg-install.in checks if PACKAGE_BUILDING is
defined to avoid asking questions.

It should also check for BATCH, else custom installation scripts
may fail.

Port maintainer (ohauer@FreeBSD.org) is cc'd.

Generated with FreeBSD Port Tools 0.99
>How-To-Repeat:
>Fix:

--- spamd-4.8.0_1.patch begins here ---
Index: Makefile
===================================================================
RCS file: /home/pcvs/ports/mail/spamd/Makefile,v
retrieving revision 1.22
diff -u -u -r1.22 Makefile
--- Makefile	29 Dec 2010 20:04:23 -0000	1.22
+++ Makefile	23 May 2011 10:09:05 -0000
@@ -7,6 +7,7 @@
 
 PORTNAME=	spamd
 PORTVERSION=	4.8.0
+PORTREVISION=	1
 CATEGORIES=	mail
 MASTER_SITES=	BERLIOS
 MASTER_SITE_SUBDIR=freebsdspamd
Index: files/pkg-install.in
===================================================================
RCS file: /home/pcvs/ports/mail/spamd/files/pkg-install.in,v
retrieving revision 1.3
diff -u -u -r1.3 pkg-install.in
--- files/pkg-install.in	31 Oct 2010 22:10:52 -0000	1.3
+++ files/pkg-install.in	23 May 2011 10:09:05 -0000
@@ -13,7 +13,7 @@
 
   question=$1
   default=$2
-  if [ -z "${PACKAGE_BUILDING}" ]; then
+  if [ -z "${PACKAGE_BUILDING}" -a -z "${BATCH}" ]; then
     read -p "${question} [${default}]? " answer
   fi
   if [ "x${answer}" = "x" ]; then
--- spamd-4.8.0_1.patch ends here ---

>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->ohauer 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Mon May 23 10:20:20 UTC 2011 
Responsible-Changed-Why:  
Over to maintainer (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=157266 
State-Changed-From-To: open->analyzed 
State-Changed-By: ohauer 
State-Changed-When: Mon May 30 19:48:22 UTC 2011 
State-Changed-Why:  
Thanks for the hint! 

I will respect BATCH with the next bugfix version (4.9.x) 
the next days. 


http://www.freebsd.org/cgi/query-pr.cgi?pr=157266 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/157266: commit references a PR
Date: Sat,  4 Jun 2011 21:52:07 +0000 (UTC)

 ohauer      2011-06-04 21:51:59 UTC
 
   FreeBSD ports repository
 
   Modified files:
     mail/spamd           Makefile distinfo 
     mail/spamd/files     pkg-install.in pkg-message.in 
   Added files:
     mail/spamd           pkg-deinstall 
   Removed files:
     mail/spamd/files     pkg-deinstall.in 
   Log:
   - update to version 4.9.1
   - always add required entries to /etc/services [1]
   - use USER framework (PR ports/152498 was committed)
   
   PR:             [1] ports/157266
   Submitted by:   [1] Jimmy Olgeni olgeni@
   
   Revision  Changes    Path
   1.23      +13 -28    ports/mail/spamd/Makefile
   1.10      +2 -2      ports/mail/spamd/distinfo
   1.3       +0 -23     ports/mail/spamd/files/pkg-deinstall.in (dead)
   1.4       +55 -133   ports/mail/spamd/files/pkg-install.in
   1.4       +8 -3      ports/mail/spamd/files/pkg-message.in
   1.1       +16 -0     ports/mail/spamd/pkg-deinstall (new)
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: analyzed->closed 
State-Changed-By: ohauer 
State-Changed-When: Sat Jun 4 22:10:49 UTC 2011 
State-Changed-Why:  
Thanks for the Hint! 

For version 4.9.1 I've rewritten pkg-install so it always 
add the entries to /etc/services. 


http://www.freebsd.org/cgi/query-pr.cgi?pr=157266 
>Unformatted:
