From nobody@FreeBSD.org  Tue May 17 22:23:42 2011
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id AD3D51065673
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 17 May 2011 22:23:42 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22])
	by mx1.freebsd.org (Postfix) with ESMTP id 9BD8E8FC15
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 17 May 2011 22:23:42 +0000 (UTC)
Received: from red.freebsd.org (localhost [127.0.0.1])
	by red.freebsd.org (8.14.4/8.14.4) with ESMTP id p4HMNgGh062154
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 17 May 2011 22:23:42 GMT
	(envelope-from nobody@red.freebsd.org)
Received: (from nobody@localhost)
	by red.freebsd.org (8.14.4/8.14.4/Submit) id p4HMNgbx062123;
	Tue, 17 May 2011 22:23:42 GMT
	(envelope-from nobody)
Message-Id: <201105172223.p4HMNgbx062123@red.freebsd.org>
Date: Tue, 17 May 2011 22:23:42 GMT
From: Benjamin Lee <ben@b1c1l1.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: net-mgmt/collectd BIND plugin dependency check is invalid
X-Send-Pr-Version: www-3.1
X-GNATS-Notify: ports@bsdserwis.com

>Number:         157130
>Category:       ports
>Synopsis:       net-mgmt/collectd BIND plugin dependency check is invalid
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue May 17 22:30:12 UTC 2011
>Closed-Date:    Sun Jun 26 05:03:21 UTC 2011
>Last-Modified:  Sun Jun 26 05:10:11 UTC 2011
>Originator:     Benjamin Lee
>Release:        8.2-RELEASE
>Organization:
>Environment:
FreeBSD eclipse.b1c1l1.com 8.2-RELEASE FreeBSD 8.2-RELEASE #0: Fri Feb 18 02:24:46 UTC 2011     root@almeida.cse.buffalo.edu:/usr/obj/usr/src/sys/GENERIC  i386
>Description:
The BIND plugin for net-mgmt/collectd only uses libcurl and libxml2 to parse BIND XML statistics over HTTP.  This is documented upstream: http://www.collectd.org/wiki/index.php/Plugin:BIND#Dependencies

At some point, the net-mgmt/collectd began checking for the presence of BIND, which is invalid.  Additionally, it no longer registers dependencies against libcurl and libxml2.  The change should be reverted back to the former port behavior.
>How-To-Repeat:

>Fix:
Apply the attached patch.

Patch attached with submission follows:

diff -ruN /usr/ports/net-mgmt/collectd/Makefile collectd/Makefile
--- /usr/ports/net-mgmt/collectd/Makefile	2011-05-16 18:06:46.000000000 -0700
+++ collectd/Makefile	2011-05-17 15:22:51.000000000 -0700
@@ -144,20 +144,11 @@
 .endif
 
 .if defined(WITH_BIND)
-.if ${OSVERSION} < 800000
-BROKEN=		Need bind 9.5+
-.endif
-# check if MK_BIND is set to no (by /etc/src.conf or /etc/make.conf)
-.if exists(${DESTDIR}/usr/lib/libbind9.a) || exists(${LOCALBASE}/lib/libbind9.a)
 CONFIGURE_ARGS+=--enable-bind
+LIB_DEPENDS+=	curl:${PORTSDIR}/ftp/curl
+LIB_DEPENDS+=	xml2:${PORTSDIR}/textproc/libxml2
 PLIST_SUB+=	BIND=""
 .else
-# libind9 does not exists
-CONFIGURE_ARGS+=--disable-bind
-PLIST_SUB+=	BIND="@comment "
-.endif
-.else
-# WITHOUT_BIND
 CONFIGURE_ARGS+=--disable-bind
 PLIST_SUB+=	BIND="@comment "
 .endif


>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->feedback 
State-Changed-By: edwin 
State-Changed-When: Tue May 17 22:30:24 UTC 2011 
State-Changed-Why:  
Awaiting maintainers feedback (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=157130 

From: Edwin Groothuis <edwin@FreeBSD.org>
To: ports@bsdserwis.com
Cc: bug-followup@FreeBSD.org
Subject: Re: ports/157130: net-mgmt/collectd BIND plugin dependency check is invalid
Date: Tue, 17 May 2011 22:30:21 UT

 Maintainer of net-mgmt/collectd,
 
 Please note that PR ports/157130 has just been submitted.
 
 If it contains a patch for an upgrade, an enhancement or a bug fix
 you agree on, reply to this email stating that you approve the patch
 and a committer will take care of it.
 
 The full text of the PR can be found at:
     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/157130
 
 -- 
 Edwin Groothuis via the GNATS Auto Assign Tool
 edwin@FreeBSD.org

From: Krzysztof Stryjek <ports@bsdserwis.com>
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: Re: ports/157130: net-mgmt/collectd BIND plugin dependency check
 is invalid
Date: Wed, 18 May 2011 09:47:29 +0200

 Hello,
 
 On Tue, May 17, 2011 at 10:30:21PM +0000, Edwin Groothuis wrote:
 > Maintainer of net-mgmt/collectd,
 > 
 > Please note that PR ports/157130 has just been submitted.
 > 
 > If it contains a patch for an upgrade, an enhancement or a bug fix
 > you agree on, reply to this email stating that you approve the patch
 > and a committer will take care of it.
 > 
 > The full text of the PR can be found at:
 >     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/157130
 > 
 Yes, I approve this patch. It was discussed between me and Mr. Benjamin
 :)
 
 Greetings,
 -- 
 Krzysztof Stryjek
 UNIX administrator/Juniper Networks Specialist
 email: wtp (at) bsdserwis (dot) com
 http://www.linkedin.com/in/KrzysztofStryjek
 GPG fingerprint: 8BD7 40CE 8994 0BBE CE6C  91CD 1292 8959 DC61 0E76
 
 In theory, there is no difference between theory and practice.
 In practice, there is.
State-Changed-From-To: feedback->open 
State-Changed-By: linimon 
State-Changed-When: Thu May 19 11:18:26 UTC 2011 
State-Changed-Why:  
Maintainer approved. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=157130 
State-Changed-From-To: open->closed 
State-Changed-By: miwi 
State-Changed-When: Sun Jun 26 05:03:19 UTC 2011 
State-Changed-Why:  
Committed. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=157130 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/157130: commit references a PR
Date: Sun, 26 Jun 2011 05:03:18 +0000 (UTC)

 miwi        2011-06-26 05:03:09 UTC
 
   FreeBSD ports repository
 
   Modified files:
     net-mgmt/collectd    Makefile 
   Log:
   - Reenable BIND support
   
   PR:             ports/157130
   Submitted by:   Benjamin Lee <ben@b1c1l1.com>
   Approved by:    maintainer
   
   Revision  Changes    Path
   1.27      +3 -12     ports/net-mgmt/collectd/Makefile
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
