From nobody@FreeBSD.org  Mon May 16 23:58:07 2011
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 897D2106566C
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 16 May 2011 23:58:07 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22])
	by mx1.freebsd.org (Postfix) with ESMTP id 79FCE8FC17
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 16 May 2011 23:58:07 +0000 (UTC)
Received: from red.freebsd.org (localhost [127.0.0.1])
	by red.freebsd.org (8.14.4/8.14.4) with ESMTP id p4GNw7V3088169
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 16 May 2011 23:58:07 GMT
	(envelope-from nobody@red.freebsd.org)
Received: (from nobody@localhost)
	by red.freebsd.org (8.14.4/8.14.4/Submit) id p4GNw7Tn088168;
	Mon, 16 May 2011 23:58:07 GMT
	(envelope-from nobody)
Message-Id: <201105162358.p4GNw7Tn088168@red.freebsd.org>
Date: Mon, 16 May 2011 23:58:07 GMT
From: Warren Block <wblock@wonkity.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: [patch] add option to build devel/gvfs without HAL support
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         157096
>Category:       ports
>Synopsis:       [patch] add option to build devel/gvfs without HAL support
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    gnome
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          update
>Submitter-Id:   current-users
>Arrival-Date:   Tue May 17 00:00:18 UTC 2011
>Closed-Date:    Sat Jun 04 22:38:27 UTC 2011
>Last-Modified:  Sat Jun  4 22:40:06 UTC 2011
>Originator:     Warren Block
>Release:        8-STABLE
>Organization:
>Environment:
FreeBSD lightning 8.2-STABLE FreeBSD 8.2-STABLE #0: Sun May 15 21:02:21 MDT 2011     root@lightning:/usr/obj/usr/src/sys/LIGHTNING  i386
>Description:
devel/gvfs currently requires HAL.  This patch adds a user option to build with or without HAL support.  Lightly tested, the port may need pkg-plist updates or other changes also.
>How-To-Repeat:
Try to pkg_delete hal while devel/gvfs is installed.
>Fix:
Apply patch.

Patch attached with submission follows:

--- devel/gvfs/Makefile.orig	2011-05-16 13:11:28.000000000 -0600
+++ devel/gvfs/Makefile	2011-05-16 13:22:44.000000000 -0600
@@ -17,10 +17,8 @@
 COMMENT=	GNOME virtual file system
 
 LIB_DEPENDS=	dbus-1.3:${PORTSDIR}/devel/dbus \
-    		hal.1:${PORTSDIR}/sysutils/hal \
 		soup-gnome-2.4.1:${PORTSDIR}/devel/libsoup-gnome \
 		gnome-keyring:${PORTSDIR}/security/libgnome-keyring
-RUN_DEPENDS=	gnome-mount:${PORTSDIR}/sysutils/gnome-mount
 
 USE_BZIP2=	yes
 USE_GNOME=	glib20 gnomehack gnomeprefix intlhack gconf2
@@ -35,7 +33,8 @@
 		AVAHI "Enable AVAHI" on \
 		SAMBA "Enable Samba" on \
 		GPHOTO2 "Enable Gphoto 2 camera support" on \
-		CDDA "Enable CDDA" on
+		CDDA "Enable CDDA" on \
+		HAL "Enable HAL" on
 
 .include <bsd.port.pre.mk>
 
@@ -80,4 +79,10 @@
 PLIST_SUB+=	AVAHI="@comment "
 .endif
 
+.if defined(WITH_HAL)
+RUN_DEPENDS=	gnome-mount:${PORTSDIR}/sysutils/gnome-mount
+.else
+CONFIGURE_ARGS+=	--disable-hal
+.endif
+
 .include <bsd.port.post.mk>


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->gnome 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Tue May 17 00:00:36 UTC 2011 
Responsible-Changed-Why:  
Over to maintainer (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=157096 

From: Chip Camden <sterling@camdensoftware.com>
To: bug-followup@FreeBSD.org, wblock@wonkity.com
Cc:  
Subject: Re: ports/157096: [patch] add option to build devel/gvfs without HAL support
Date: Tue, 17 May 2011 08:48:35 -0700

 --CE+1k2dSO48ffgeK
 Content-Type: text/plain; charset=us-ascii
 Content-Disposition: inline
 Content-Transfer-Encoding: quoted-printable
 
 Tested on (uname -a):
 
 FreeBSD libertas.local.camdensoftware.com 8.2-STABLE FreeBSD 8.2-STABLE #58=
 : Sun May 15 13:37:24 PDT 2011     sterling@libertas.local.camdensoftware.c=
 om:/usr/obj/usr/src/sys/LIBERTAS  amd64
 
 Fully eliminated the dependency on gnome-mount, and thus hal.  Good job!
 
 --=20
 =2EO. | Sterling (Chip) Camden      | http://camdensoftware.com
 =2E.O | sterling@camdensoftware.com | http://chipsquips.com
 OOO | 2048R/D6DBAF91              | http://chipstips.com
 
 --CE+1k2dSO48ffgeK
 Content-Type: application/pgp-signature
 Content-Disposition: inline
 
 -----BEGIN PGP SIGNATURE-----
 Version: GnuPG v1.4.11 (FreeBSD)
 
 iQEcBAEBAgAGBQJN0pjTAAoJEIpckszW26+R0aMH/0rFXVxPns5PwqnKAT05MQCD
 qD20NWxlzqXgTMXhF3nL46x5W+ySYQ2KPRVMLeeLxk/j1bACmPMCzCk50qTGN7Ca
 IVgPgksPFJSgY7KaSNcCsEAZraRZd5qz2VjjOrE0fqQZlNDBXceAf8c8u2eMogtu
 m8Z593WdN0iaysEmEBgLTw3MfPeQcnmwWxNnsQ/pqoTP1vovchyk5phzywYXSw77
 4pDrAOHATnJJtWRsdGjKUeRDUoqeCl/Nii8G20B9teLucdi57P1faTwO5QLWHCI6
 ixbhy+GFdpAOdOsocnDc44galKyo35n+ce/mWsX9nia9MN8h4i2Xiy89vTdFN+Q=
 =RfLV
 -----END PGP SIGNATURE-----
 
 --CE+1k2dSO48ffgeK--
State-Changed-From-To: open->closed 
State-Changed-By: mezz 
State-Changed-When: Sat Jun 4 22:38:13 UTC 2011 
State-Changed-Why:  
Committed, thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=157096 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/157096: commit references a PR
Date: Sat,  4 Jun 2011 22:38:09 +0000 (UTC)

 mezz        2011-06-04 22:38:01 UTC
 
   FreeBSD ports repository
 
   Modified files:
     devel/gvfs           Makefile pkg-plist 
   Log:
   Turn HAL support into optional.
   
   PR:             ports/157096
   Submitted by:   Warren Block <wblock@wonkity.com>
   
   Revision  Changes    Path
   1.35      +14 -6     ports/devel/gvfs/Makefile
   1.14      +3 -3      ports/devel/gvfs/pkg-plist
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
