From nobody@FreeBSD.org  Mon May  9 19:02:54 2011
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 6A2B9106564A
	for <freebsd-gnats-submit@FreeBSD.org>; Mon,  9 May 2011 19:02:54 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22])
	by mx1.freebsd.org (Postfix) with ESMTP id 5BBEB8FC14
	for <freebsd-gnats-submit@FreeBSD.org>; Mon,  9 May 2011 19:02:54 +0000 (UTC)
Received: from red.freebsd.org (localhost [127.0.0.1])
	by red.freebsd.org (8.14.4/8.14.4) with ESMTP id p49J2slp031166
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 9 May 2011 19:02:54 GMT
	(envelope-from nobody@red.freebsd.org)
Received: (from nobody@localhost)
	by red.freebsd.org (8.14.4/8.14.4/Submit) id p49J2skB031164;
	Mon, 9 May 2011 19:02:54 GMT
	(envelope-from nobody)
Message-Id: <201105091902.p49J2skB031164@red.freebsd.org>
Date: Mon, 9 May 2011 19:02:54 GMT
From: Chris Rees <utisoft@gmail.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: Fix port: mail/thunderbird occasionally breaks with gmake-3.82
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         156912
>Category:       ports
>Synopsis:       Fix port: mail/thunderbird occasionally breaks with gmake-3.82
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    crees
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon May 09 19:10:07 UTC 2011
>Closed-Date:    Tue Jul 05 21:14:42 UTC 2011
>Last-Modified:  Tue Jul  5 21:20:07 UTC 2011
>Originator:     Chris Rees
>Release:        
>Organization:
>Environment:
>Description:
Described at [1] is a build failure, which has been tracked down to a change in allowed syntax by gmake between 3.81 and 3.82 (I tested this using both versions).

Buried under some weird ifndefs in ${WRKSRC}/mailnews/extensions/smime/build/Makefile.in is the line:

SHARED_LIBRARY_LIBS + = ../../../base/util/$(LIB_PREFIX)msgbsutl_s.$(LIB_SUFFIX)

using the (now invalid) + = syntax. This patch corrects this, thus solving the build problem for this minority of users.


[1] http://www.mail-archive.com/freebsd-questions@freebsd.org/msg246017.html
>How-To-Repeat:

>Fix:


Patch attached with submission follows:

Index: files/patch-mailnews-extensions-smime-build-Makefile.in
===================================================================
RCS file: files/patch-mailnews-extensions-smime-build-Makefile.in
diff -N files/patch-mailnews-extensions-smime-build-Makefile.in
--- /dev/null	1 Jan 1970 00:00:00 -0000
+++ files/patch-mailnews-extensions-smime-build-Makefile.in	9 May 2011 19:01:08 -0000
@@ -0,0 +1,11 @@
+--- mailnews/extensions/smime/build/Makefile.in.orig	2011-05-09 18:49:18.458634807 +0100
++++ mailnews/extensions/smime/build/Makefile.in	2011-05-09 18:50:07.015309434 +0100
+@@ -81,7 +81,7 @@
+ 		$(NULL)
+ 
+ ifndef MOZ_STATIC_MAIL_BUILD
+-SHARED_LIBRARY_LIBS + = ../../../base/util/$(LIB_PREFIX)msgbsutl_s.$(LIB_SUFFIX)
++SHARED_LIBRARY_LIBS += ../../../base/util/$(LIB_PREFIX)msgbsutl_s.$(LIB_SUFFIX)
+ endif
+ 
+ ifdef MOZILLA_INTERNAL_API


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->gecko 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Mon May 9 19:10:17 UTC 2011 
Responsible-Changed-Why:  
Over to maintainer (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=156912 
Responsible-Changed-From-To: gecko->crees 
Responsible-Changed-By: crees 
Responsible-Changed-When: Thu Jun 30 20:56:50 UTC 2011 
Responsible-Changed-Why:  
I'll take it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=156912 
State-Changed-From-To: open->closed 
State-Changed-By: crees 
State-Changed-When: Tue Jul 5 21:14:41 UTC 2011 
State-Changed-Why:  
Committed. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=156912 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/156912: commit references a PR
Date: Tue,  5 Jul 2011 21:14:29 +0000 (UTC)

 crees       2011-07-05 21:14:20 UTC
 
   FreeBSD ports repository
 
   Added files:
     mail/thunderbird3/files 
                             patch-mailnews-extensions-smime-build-Makefile.in 
   Log:
   Fix for gmake-3.82 issues suffered by a small minority of users
   
   PR:             ports/156912
   Submitted by:   crees (me)
   Approved by:    rene (mentor), maintainer (gecko; flo@ over IRC)
   
   Revision  Changes    Path
   1.1       +16 -0     ports/mail/thunderbird3/files/patch-mailnews-extensions-smime-build-Makefile.in (new)
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
