From nobody@FreeBSD.org  Fri May  6 09:47:37 2011
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 7AF06106564A
	for <freebsd-gnats-submit@FreeBSD.org>; Fri,  6 May 2011 09:47:37 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22])
	by mx1.freebsd.org (Postfix) with ESMTP id 4F9F18FC18
	for <freebsd-gnats-submit@FreeBSD.org>; Fri,  6 May 2011 09:47:37 +0000 (UTC)
Received: from red.freebsd.org (localhost [127.0.0.1])
	by red.freebsd.org (8.14.4/8.14.4) with ESMTP id p469lahl060613
	for <freebsd-gnats-submit@FreeBSD.org>; Fri, 6 May 2011 09:47:36 GMT
	(envelope-from nobody@red.freebsd.org)
Received: (from nobody@localhost)
	by red.freebsd.org (8.14.4/8.14.4/Submit) id p469la93060612;
	Fri, 6 May 2011 09:47:36 GMT
	(envelope-from nobody)
Message-Id: <201105060947.p469la93060612@red.freebsd.org>
Date: Fri, 6 May 2011 09:47:36 GMT
From: Frank Wall <fw@moov.de>
To: freebsd-gnats-submit@FreeBSD.org
Subject: [PATCH] net/p5-Net-ext: fix CPAN Bug #43071
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         156844
>Category:       ports
>Synopsis:       [PATCH] net/p5-Net-ext: fix CPAN Bug #43071
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    culot
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Fri May 06 09:50:12 UTC 2011
>Closed-Date:    Sat May 28 10:59:03 UTC 2011
>Last-Modified:  Sat May 28 11:00:20 UTC 2011
>Originator:     Frank Wall
>Release:        7.3-RELEASE-p2
>Organization:
>Environment:
FreeBSD 7.3-RELEASE-p2 FreeBSD 7.3-RELEASE-p2 #0: Mon Jul 12 19:23:19 UTC 2010     root@amd64-builder.daemonology.net:/usr/obj/usr/src/sys/GENERIC  amd64

>Description:
The current version of net/p5-Net-ext has a bug that makes it partial incompatible with perl 5.10. A patch exists since 2009, but was not applied yet.

Since perl 5.10 is our default version we should apply the patch.

References:
http://rt.cpan.org/Public/Bug/Display.html?id=43071
http://lists.opensuse.org/opensuse-bugs/2009-09/msg04661.html

>How-To-Repeat:
1. make sure you have perl 5.10 installed: pkg_info -xI perl-5.10
2. install net/p5-Net-ext
3. issue the command: perl -w and then:
use Net::TCP;

Result:

panic: no address for 'Net::TCP::TCP_RPTR2RXT' in 'Gen.c' at /usr/local/lib/perl5/5.10.1/mach/DynaLoader.pm line 223.
BEGIN failed--compilation aborted at /usr/local/lib/perl5/site_perl/5.10.1/mach/Net/Gen.pm line 194.
Compilation failed in require at /usr/local/lib/perl5/site_perl/5.10.1/mach/Net/Inet.pm line 33.
BEGIN failed--compilation aborted at /usr/local/lib/perl5/site_perl/5.10.1/mach/Net/Inet.pm line 33.
Compilation failed in require at /usr/local/lib/perl5/site_perl/5.10.1/mach/Net/UDP.pm line 32.
BEGIN failed--compilation aborted at /usr/local/lib/perl5/site_perl/5.10.1/mach/Net/UDP.pm line 32.

>Fix:
- apply the attached patch

Patch attached with submission follows:

--- net/p5-Net-ext/files/does_not_exist	1970-01-01 01:00:00.000000000 +0100
+++ net/p5-Net-ext/files/patch-Gen.xs	2011-05-06 11:33:07.000000000 +0200
@@ -0,0 +1,11 @@
+--- Gen.xs.orig	2002-04-10 13:05:58.000000000 +0200
++++ Gen.xs	2011-05-06 11:32:45.000000000 +0200
+@@ -146,7 +146,7 @@
+     CV *cv;
+     klen = strlen(name);
+     (void) hv_fetch(missing, name, klen, TRUE);
+-    cv = newXS(name, NULL, file); /* newSUB with no block */
++    cv = newXS(name, Perl_cv_undef, file); /* newSUB with no block */
+     sv_setsv((SV*)cv, &PL_sv_no); /* prototype it as "()" */
+ }
+ 
--- net/p5-Net-ext/Makefile.orig	2008-04-17 16:27:42.000000000 +0200
+++ net/p5-Net-ext/Makefile	2011-05-06 11:35:26.000000000 +0200
@@ -7,6 +7,7 @@
 
 PORTNAME=	Net-ext
 PORTVERSION=	1.011
+PORTREVISION=	1
 CATEGORIES=	net perl5
 MASTER_SITES=	CPAN
 PKGNAMEPREFIX=	p5-


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->perl 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Fri May 6 09:50:27 UTC 2011 
Responsible-Changed-Why:  
Over to maintainer (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=156844 
Responsible-Changed-From-To: perl->culot 
Responsible-Changed-By: culot 
Responsible-Changed-When: Sat May 28 09:39:14 UTC 2011 
Responsible-Changed-Why:  
I'll take it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=156844 
State-Changed-From-To: open->closed 
State-Changed-By: culot 
State-Changed-When: Sat May 28 10:59:01 UTC 2011 
State-Changed-Why:  
Committed. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=156844 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/156844: commit references a PR
Date: Sat, 28 May 2011 10:58:41 +0000 (UTC)

 culot       2011-05-28 10:58:28 UTC
 
   FreeBSD ports repository
 
   Modified files:
     net/p5-Net-ext       Makefile 
   Added files:
     net/p5-Net-ext/files patch-Gen.xs 
   Log:
   - Add patch to make p5-Net-ext compatible with perl 5.10
   
   Reference:      http://rt.cpan.org/Public/Bug/Display.html?id=43071
   PR:             ports/156844
   Submitted by:   Frank Wall <fw@moov.de>
   
   Revision  Changes    Path
   1.10      +1 -0      ports/net/p5-Net-ext/Makefile
   1.1       +11 -0     ports/net/p5-Net-ext/files/patch-Gen.xs (new)
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
