From nobody@FreeBSD.org  Thu May  5 17:48:23 2011
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 94A861065670
	for <freebsd-gnats-submit@FreeBSD.org>; Thu,  5 May 2011 17:48:23 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22])
	by mx1.freebsd.org (Postfix) with ESMTP id 6731A8FC12
	for <freebsd-gnats-submit@FreeBSD.org>; Thu,  5 May 2011 17:48:23 +0000 (UTC)
Received: from red.freebsd.org (localhost [127.0.0.1])
	by red.freebsd.org (8.14.4/8.14.4) with ESMTP id p45HmNeE066443
	for <freebsd-gnats-submit@FreeBSD.org>; Thu, 5 May 2011 17:48:23 GMT
	(envelope-from nobody@red.freebsd.org)
Received: (from nobody@localhost)
	by red.freebsd.org (8.14.4/8.14.4/Submit) id p45HmN7M066442;
	Thu, 5 May 2011 17:48:23 GMT
	(envelope-from nobody)
Message-Id: <201105051748.p45HmN7M066442@red.freebsd.org>
Date: Thu, 5 May 2011 17:48:23 GMT
From: Kalten <kalten@gmx.at>
To: freebsd-gnats-submit@FreeBSD.org
Subject: games/fairymax: O-Flags option and preparing change into masterport
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         156833
>Category:       ports
>Synopsis:       games/fairymax: O-Flags option and preparing change into masterport
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    crees
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          maintainer-update
>Submitter-Id:   current-users
>Arrival-Date:   Thu May 05 17:50:07 UTC 2011
>Closed-Date:    Sun Jul 24 18:38:44 UTC 2011
>Last-Modified:  Sun Jul 24 18:40:08 UTC 2011
>Originator:     Kalten
>Release:        8.2-RELEASE
>Organization:
>Environment:
FreeBSD freeHugin.Walhalla.Leben 8.2-RELEASE FreeBSD 8.2-RELEASE #0: Thu Feb 17 02:41:51 UTC 2011     root@mason.cse.buffalo.edu:/usr/obj/usr/src/sys/GENERIC  amd64
>Description:
I had removed the -O2 option as mentioned in Porter's Handbook[1] earlier. Now there is an option to re enable it (on by default).

And it is being prepared to be changed into a master port, as my next PR with the title ``New port: games/fairymax-devel latest version of games/fairymax'' (hen egg problem: can not tell you its number yet) will introduce a slave port.

(See attachment.)

[1] http://www.freebsd.org/doc/en/books/porters-handbook/dads-cflags.html

>How-To-Repeat:

>Fix:


Patch attached with submission follows:

--- Makefile.orig	2011-05-05 00:47:54.000000000 +0200
+++ Makefile	2011-05-05 01:55:54.000000000 +0200
@@ -1,4 +1,4 @@
-# New ports collection makefile for:	fairy-max
+# New ports collection makefile for:	fairymax
 # Date created:				22 April 2011
 # Whom:					Kalten <kalten@gmx.at>
 #
@@ -6,15 +6,20 @@
 #
 
 PORTNAME=	fairymax
-PORTVERSION=	4.8Q
+PORTVERSION?=	4.8Q
+PORTREVISION?=	1
 CATEGORIES=	games
 MASTER_SITES=	http://freeheimdall.homeunix.org/files/
-DISTNAME=	${PORTNAME}-c7a129e
+DISTNAME?=	${PORTNAME}-c7a129e
 # http://hgm.nubati.net/cgi-bin/gitweb.cgi?p=fairymax.git;a=snapshot;h=c7a129ead81286990efb8409f238c48c7109c83b;sf=tgz
 
 MAINTAINER=	kalten@gmx.at
 COMMENT=	Chess engine (e.g. xboard) for shatranj, courier chess, ...
 
+CONFLICTS?=	fairymax-4.8Q.[0-9]* fairymax-4.8Q.[0-9]*_[0-9]*
+
+OPTIONS+=	OCFLAGS "Use optimized compiler flags" on
+
 DIST_SUBDIR=	${PORTNAME}
 
 PLIST_FILES=	bin/fairymax \
@@ -33,6 +38,14 @@
 MAKE_ARGS+=	INI_FILE_fmax=${DATADIR}/fmax.ini \
 		INI_FILE_qmax=${DATADIR}/qmax.ini
 
+.include <bsd.port.options.mk>
+
+.if defined(WITHOUT_OCFLAGS)
+CFLAGS=
+.else
+CFLAGS=		-O2
+.endif
+
 post-patch:
 	@${CP} ${WRKSRC}/fairymax.pod ${WRKSRC}/fairymax.pod.ori
 	@${SED} -e 's|%%PREFIX%%|${PREFIX}|g;s|%%DATADIR%%|${DATADIR}|g' \
--- distinfo.orig	2011-05-05 01:51:04.000000000 +0200
+++ distinfo	2011-05-05 01:52:03.000000000 +0200
@@ -1,2 +1,4 @@
 SHA256 (fairymax/fairymax-c7a129e.tar.gz) = ec8e75c92e345e0f0db56095ac576156f54fb9320af05e86f8e589a8300c5a9a
 SIZE (fairymax/fairymax-c7a129e.tar.gz) = 34229
+SHA256 (fairymax/fairymax-507c6ba.tar.gz) = 18727b04bf4a3a9d1e3bac55a2729727735a9103f3beb03afb8bbbfd21a6112a
+SIZE (fairymax/fairymax-507c6ba.tar.gz) = 34289


>Release-Note:
>Audit-Trail:
Class-Changed-From-To: change-request->maintainer-update 
Class-Changed-By: edwin 
Class-Changed-When: Thu May 5 17:50:16 UTC 2011 
Class-Changed-Why:  
Fix category (submitter is maintainer) (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=156833 

From: Kalten <kalten@gmx.at>
To: bug-followup@FreeBSD.org,kalten@gmx.at
Cc:  
Subject: Re: ports/156833: games/fairymax: O-Flags option and preparing change into masterport
Date: Fri, 06 May 2011 01:14:37 +0200

 After a little conversation with johans I have given up the system of a
 master- and a slave port.
 Furthermore he meant, that the optimisation flags should be set
 globally, not by the port: well--as the original program uses them, I
 stick to this option (maybe better not on but off by default?) (as other
 ports have them too).
 
 I hope, it's OK now?
 
 New patch--replacing old one--attached here.
 
 --- patch.txt begins here ---
 --- Makefile.orig	2011-05-05 00:47:54.000000000 +0200
 +++ Makefile	2011-05-06 00:43:39.000000000 +0200
 @@ -1,4 +1,4 @@
 -# New ports collection makefile for:	fairy-max
 +# New ports collection makefile for:	fairymax
  # Date created:				22 April 2011
  # Whom:					Kalten <kalten@gmx.at>
  #
 @@ -7,6 +7,7 @@
  
  PORTNAME=	fairymax
  PORTVERSION=	4.8Q
 +PORTREVISION=	1
  CATEGORIES=	games
  MASTER_SITES=	http://freeheimdall.homeunix.org/files/
  DISTNAME=	${PORTNAME}-c7a129e
 @@ -15,6 +16,10 @@
  MAINTAINER=	kalten@gmx.at
  COMMENT=	Chess engine (e.g. xboard) for shatranj, courier chess, ...
  
 +CONFLICTS=	fairymax-4.8Q.[0-9]* fairymax-4.8Q.[0-9]*_[0-9]*
 +
 +OPTIONS+=	OCFLAGS "Use optimized compiler flags" on
 +
  DIST_SUBDIR=	${PORTNAME}
  
  PLIST_FILES=	bin/fairymax \
 @@ -33,6 +38,14 @@
  MAKE_ARGS+=	INI_FILE_fmax=${DATADIR}/fmax.ini \
  		INI_FILE_qmax=${DATADIR}/qmax.ini
  
 +.include <bsd.port.options.mk>
 +
 +.if defined(WITHOUT_OCFLAGS)
 +CFLAGS+=
 +.else
 +CFLAGS+=	-O2
 +.endif
 +
  post-patch:
  	@${CP} ${WRKSRC}/fairymax.pod ${WRKSRC}/fairymax.pod.ori
  	@${SED} -e 's|%%PREFIX%%|${PREFIX}|g;s|%%DATADIR%%|${DATADIR}|g' \
 --- patch.txt ends here ---
 -- 
Responsible-Changed-From-To: freebsd-ports-bugs->crees 
Responsible-Changed-By: crees 
Responsible-Changed-When: Thu Jul 14 16:42:03 UTC 2011 
Responsible-Changed-Why:  
I'll take it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=156833 
State-Changed-From-To: open->feedback 
State-Changed-By: crees 
State-Changed-When: Thu Jul 14 16:44:09 UTC 2011 
State-Changed-Why:  
Ask for submitter approval. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=156833 

From: Chris Rees <crees@FreeBSD.org>
To: bug-followup@FreeBSD.org, kalten@gmx.at
Cc:  
Subject: Re: ports/156833: games/fairymax: O-Flags option and preparing change
 into masterport
Date: Thu, 14 Jul 2011 17:44:11 +0100

 Made a few changes to pet portlint, and other sanity/efficiency changes.
 
 Are they OK?
 
 http://www.bayofrum.net/~crees/patches/fairymax-fixes.diff
 
 -- 
 This message has been scanned for viruses and
 dangerous content by MailScanner, and is
 believed to be clean.
 
State-Changed-From-To: feedback->closed 
State-Changed-By: crees 
State-Changed-When: Sun Jul 24 18:38:43 UTC 2011 
State-Changed-Why:  
Committed, with minor changes. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=156833 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/156833: commit references a PR
Date: Sun, 24 Jul 2011 18:35:01 +0000 (UTC)

 crees       2011-07-24 18:34:51 UTC
 
   FreeBSD ports repository
 
   Modified files:
     games/fairymax       Makefile 
   Log:
   - Add optimized compilation option [1]
   - Pet portlint and tidy style, small efficiency savings
   
   PR:             ports/156833
   Submitted by:   Kalten <kalten@gmx.at> [1]
   Approved by:    rene (mentor)
   
   Revision  Changes    Path
   1.2       +27 -17    ports/games/fairymax/Makefile
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
