From scott@sabunix.rresearch.com  Fri Dec 24 14:19:47 1999
Return-Path: <scott@sabunix.rresearch.com>
Received: from sabmail.rresearch.com (ip18.gte13.rb1.bel.nwlink.com [207.202.150.18])
	by hub.freebsd.org (Postfix) with ESMTP id 94F7214D3A
	for <FreeBSD-gnats-submit@freebsd.org>; Fri, 24 Dec 1999 14:19:46 -0800 (PST)
	(envelope-from scott@sabunix.rresearch.com)
Received: (from scott@localhost)
          by sabmail.rresearch.com (8.9.3/8.9.3) id OAA78145;
          Fri, 24 Dec 1999 14:19:45 -0800 (PST)
          (envelope-from scott)
Message-Id: <199912242219.OAA78145@sabmail.rresearch.com>
Date: Fri, 24 Dec 1999 14:19:45 -0800 (PST)
From: Scott Blachowicz <scott@sabunix.rresearch.com>
Reply-To: scott@sabunix.rresearch.com
To: FreeBSD-gnats-submit@freebsd.org
Subject: mail/nmh: fix spoolfile locking method
X-Send-Pr-Version: 3.2

>Number:         15674
>Category:       ports
>Synopsis:       fix spoolfile locking method in mail/nmh-1.0.2 port
>Confidential:   no
>Severity:       serious
>Priority:       high
>Responsible:    freebsd-ports
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Fri Dec 24 14:20:00 PST 1999
>Closed-Date:    Sat Dec 25 10:56:31 PST 1999
>Last-Modified:  Sat Dec 25 10:57:40 PST 1999
>Originator:     Scott Blachowicz
>Release:        FreeBSD 3.2-RELEASE i386
>Organization:
none
>Environment:

	FreeBSD 3.x & nmh-1.0.2 port

>Description:

	[not sure how to rate severity or priority...the 'inc' command that
	reads email from mail spool is basically busted]

	I was confused creating the most recent nmh port patch and
	reverted the locking to "dot locking" as I'd thought that sendmail
	used that.  Upon using the new 'inc' command and closer
	examination of sendmail, then mail.local, it looks like "flock"
	locking is more appropriate (to match mail.local's behavior).

>How-To-Repeat:

	

>Fix:
	
	Apply patch to port:

diff -urN ../nmh-curr/patches/patch-aa ./patches/patch-aa
--- ../nmh-curr/patches/patch-aa	Wed Dec 22 19:40:30 1999
+++ ./patches/patch-aa	Fri Dec 24 13:50:32 1999
@@ -1,6 +1,18 @@
-diff -ur ../../nmh-1.0.2-DIST/acconfig.h ./acconfig.h
---- ../../nmh-1.0.2-DIST/acconfig.h	Thu Oct 21 11:58:09 1999
-+++ ./acconfig.h	Sat Dec 11 11:54:28 1999
+--- ../../../nmh-1.0.2-DIST/acconfig.h	Thu Oct 21 11:58:09 1999
++++ ./acconfig.h	Fri Dec 24 13:50:12 1999
+@@ -22,10 +22,10 @@
+  * other programs which may modify your maildrops.
+  * Currently you can only use one type.
+  */
+-#define DOT_LOCKING   1
++/* #define DOT_LOCKING   1 */
+ /* #define FCNTL_LOCKING 1 */
+ /* #define LOCKF_LOCKING 1 */
+-/* #define FLOCK_LOCKING 1 */
++#define FLOCK_LOCKING 1
+ 
+ /*
+  * If you have defined DOT_LOCKING, then the default is to
 @@ -104,7 +104,7 @@
   * The prefix which is prepended to the name of messages when they
   * are "removed" by rmm.  This should typically be `,' or `#'


>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->closed 
State-Changed-By: steve 
State-Changed-When: Sat Dec 25 10:56:31 PST 1999 
State-Changed-Why:  
Committed, thanks! 
>Unformatted:
