From ehaupt@FreeBSD.org  Fri Apr 15 13:15:21 2011
Return-Path: <ehaupt@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 0F074106566B
	for <FreeBSD-gnats-submit@freebsd.org>; Fri, 15 Apr 2011 13:15:21 +0000 (UTC)
	(envelope-from ehaupt@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id D61C88FC08
	for <FreeBSD-gnats-submit@freebsd.org>; Fri, 15 Apr 2011 13:15:20 +0000 (UTC)
Received: from freefall.freebsd.org (localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id p3FDFKhX020608
	for <FreeBSD-gnats-submit@freebsd.org>; Fri, 15 Apr 2011 13:15:20 GMT
	(envelope-from ehaupt@freefall.freebsd.org)
Received: (from ehaupt@localhost)
	by freefall.freebsd.org (8.14.4/8.14.4/Submit) id p3FDFKs2020607;
	Fri, 15 Apr 2011 15:15:20 +0200 (CEST)
	(envelope-from ehaupt)
Message-Id: <201104151315.p3FDFKs2020607@freefall.freebsd.org>
Date: Fri, 15 Apr 2011 15:15:20 +0200 (CEST)
From: Emanuel Haupt <ehaupt@FreeBSD.org>
Reply-To: Emanuel Haupt <ehaupt@FreeBSD.org>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: [update] dns/ldns - add an option to install python bindings
X-Send-Pr-Version: 3.113
X-GNATS-Notify: jaap@NLnetLabs.nl

>Number:         156419
>Category:       ports
>Synopsis:       [update] dns/ldns - add an option to install python bindings
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    ehaupt
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          update
>Submitter-Id:   current-users
>Arrival-Date:   Fri Apr 15 13:20:05 UTC 2011
>Closed-Date:    Sat Apr 16 22:40:10 CEST 2011
>Last-Modified:  Sat Apr 16 20:50:02 UTC 2011
>Originator:     Emanuel Haupt
>Release:        FreeBSD 8.1-STABLE i386
>Organization:
>Environment:
System: FreeBSD freefall.freebsd.org 8.1-STABLE FreeBSD 8.1-STABLE #2 r215627: Sun Nov 21 13:36:51 UTC 2010 simon@freefall.freebsd.org:/usr/obj/usr/src/sys/FREEFALL i386


	
>Description:
I need the python bindings for updating one of my ports. The following
tinderbox-tested patch provides an OPTIONS flag to install the python bindings
for dns/ldns.

Also add an additional distfile mirror.

>How-To-Repeat:
	
>Fix:

	

--- ldns.patch begins here ---
Index: Makefile
===================================================================
RCS file: /home/pcvs/ports/dns/ldns/Makefile,v
retrieving revision 1.23
diff -u -r1.23 Makefile
--- Makefile	17 Mar 2011 09:30:22 -0000	1.23
+++ Makefile	15 Apr 2011 13:11:43 -0000
@@ -8,7 +8,8 @@
 PORTNAME=	ldns
 PORTVERSION=	1.6.9
 CATEGORIES=	dns
-MASTER_SITES=	http://www.nlnetlabs.nl/downloads/ldns/
+MASTER_SITES=	http://www.nlnetlabs.nl/downloads/ldns/ \
+		CRITICAL
 
 MAINTAINER=	jaap@NLnetLabs.nl
 COMMENT=	A library for programs conforming to DNS RFCs and drafts
@@ -24,7 +25,8 @@
 		EXAMPLES "With example programs" Off \
 		DRILL "With drill program" Off \
 		GOST "GOST signatures enabled (requires openssl >= 1.0.0)" Off \
-		ECDSA "With highly experimental ECDSA support" Off
+		ECDSA "With highly experimental ECDSA support" Off \
+		PYLDNS "Build python bindings" Off
 
 .include <bsd.port.pre.mk>
 
@@ -255,6 +257,17 @@
 CONFIGURE_ARGS+=	--enable-ecdsa
 .endif
 
+.if defined(WITH_PYLDNS)
+USE_PYTHON=		yes
+.include "${PORTSDIR}/Mk/bsd.python.mk"
+CONFIGURE_ARGS+=	--with-pyldns
+BUILD_DEPENDS+=		${LOCALBASE}/bin/swig:${PORTSDIR}/devel/swig13
+INSTALL_TARGET+=	install-pyldns
+PLIST_SUB+=		PYLDNS=""
+.else
+PLIST_SUB+=		PYLDNS="@comment "
+.endif
+
 .if ${OSVERSION} < 700000
 NO_SHA2=		--disable-sha2
 CONFIGURE_ARGS+=	${NO_SHA2}
Index: pkg-plist
===================================================================
RCS file: /home/pcvs/ports/dns/ldns/pkg-plist,v
retrieving revision 1.9
diff -u -r1.9 pkg-plist
--- pkg-plist	26 Jan 2011 11:28:03 -0000	1.9
+++ pkg-plist	15 Apr 2011 13:11:43 -0000
@@ -55,4 +55,10 @@
 lib/libldns.la
 lib/libldns.so
 lib/libldns.so.1
+%%PYLDNS%%%%PYTHON_SITELIBDIR%%/_ldns.so.1
+%%PYLDNS%%%%PYTHON_SITELIBDIR%%/ldns.py
+%%PYLDNS%%%%PYTHON_SITELIBDIR%%/_ldns.so
+%%PYLDNS%%%%PYTHON_SITELIBDIR%%/_ldns.la
+%%PYLDNS%%%%PYTHON_SITELIBDIR%%/_ldns.a
+%%PYLDNS%%@dirrm %%PYTHON_SITELIBDIR%%/ldns
 @dirrm include/ldns
--- ldns.patch ends here ---


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->ehaupt 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Fri Apr 15 13:20:15 UTC 2011 
Responsible-Changed-Why:  
Submitter has GNATS access (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=156419 
State-Changed-From-To: open->feedback 
State-Changed-By: edwin 
State-Changed-When: Fri Apr 15 13:20:20 UTC 2011 
State-Changed-Why:  
Awaiting maintainers feedback (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=156419 

From: Edwin Groothuis <edwin@FreeBSD.org>
To: jaap@NLnetLabs.nl
Cc: bug-followup@FreeBSD.org
Subject: Re: ports/156419: [update] dns/ldns - add an option to install python bindings
Date: Fri, 15 Apr 2011 13:20:18 UT

 Maintainer of dns/ldns,
 
 Please note that PR ports/156419 has just been submitted.
 
 If it contains a patch for an upgrade, an enhancement or a bug fix
 you agree on, reply to this email stating that you approve the patch
 and a committer will take care of it.
 
 The full text of the PR can be found at:
     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/156419
 
 -- 
 Edwin Groothuis via the GNATS Auto Assign Tool
 edwin@FreeBSD.org

From: Jaap Akkerhuis <jaap@NLnetLabs.nl>
To: bug-followup@FreeBSD.ORG
Cc:  
Subject: Re: ports/156419: [update] dns/ldns - add an option to install python bindings 
Date: Sat, 16 Apr 2011 20:20:28 +0200

 Edwin,
 
     Maintainer of dns/ldns,
     
     Please note that PR ports/156419 has just been submitted.
 
 Noted. Why do these things always happen on my vacation :-)? I have more
 time to deal with that in a couple of days if you want to wait on that.
     
     If it contains a patch for an upgrade, an enhancement or a bug fix
     you agree on, reply to this email stating that you approve the patch
     and a committer will take care of it.
 
 It seems fine in principle. However:
     
     The full text of the PR can be found at:
         http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/156419
 
 The PR description says:
 
 	> I need the python bindings for updating one of my ports. The following
 	> tinderbox-tested patch provides an OPTIONS flag to install the python
 	> bindings for dns/ldns.
 
 Note that the patch doesn't work on the non-supported 6.4 and older so it
 should probably have an dependency on OSVERSION as well as in
 
 	.if defined(WITH_PYLDNS) && ${OSVERSION} > 700000
 
 Also, the PORTREVISION needs to be raised.
 
 	> Also add an additional distfile mirror.
 
 We are working on that.  I'm waiting for the mirror to come up.
 
 	jaap
State-Changed-From-To: feedback->open 
State-Changed-By: ehaupt 
State-Changed-When: Sat Apr 16 22:32:33 CEST 2011 
State-Changed-Why:  
Feedback received. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=156419 
State-Changed-From-To: open->closed 
State-Changed-By: ehaupt 
State-Changed-When: Sat Apr 16 22:36:09 CEST 2011 
State-Changed-Why:  
A PORTREVISION bump is not necessary since the new option is not affecing 
default option configuration (default off). There is no need to add additional 
makefile glue for non supported OSVERSIONS. 

Patch committed. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=156419 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/156419: commit references a PR
Date: Sat, 16 Apr 2011 20:36:15 +0000 (UTC)

 ehaupt      2011-04-16 20:36:06 UTC
 
   FreeBSD ports repository
 
   Modified files:
     dns/ldns             Makefile pkg-plist 
   Log:
   Add an option for installing python bindings.
   
   PR:             156419
   Approved by:    Jaap Akkerhuis <jaap@NLnetLabs.nl> (maintainer)
   
   Revision  Changes    Path
   1.24      +15 -2     ports/dns/ldns/Makefile
   1.10      +6 -0      ports/dns/ldns/pkg-plist
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
