From nobody@FreeBSD.org  Thu Mar 31 10:57:35 2011
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 6C734106566C
	for <freebsd-gnats-submit@FreeBSD.org>; Thu, 31 Mar 2011 10:57:35 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22])
	by mx1.freebsd.org (Postfix) with ESMTP id 5C8F88FC16
	for <freebsd-gnats-submit@FreeBSD.org>; Thu, 31 Mar 2011 10:57:35 +0000 (UTC)
Received: from red.freebsd.org (localhost [127.0.0.1])
	by red.freebsd.org (8.14.4/8.14.4) with ESMTP id p2VAvYX5083930
	for <freebsd-gnats-submit@FreeBSD.org>; Thu, 31 Mar 2011 10:57:34 GMT
	(envelope-from nobody@red.freebsd.org)
Received: (from nobody@localhost)
	by red.freebsd.org (8.14.4/8.14.4/Submit) id p2VAvYAw083929;
	Thu, 31 Mar 2011 10:57:34 GMT
	(envelope-from nobody)
Message-Id: <201103311057.p2VAvYAw083929@red.freebsd.org>
Date: Thu, 31 Mar 2011 10:57:34 GMT
From: Lars <dakta@gmx.de>
To: freebsd-gnats-submit@FreeBSD.org
Subject: Segmentation fault, if opengl is the only renderer and hasn't been explicitly defined
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         156088
>Category:       ports
>Synopsis:       graphics/gnash: Segmentation fault, if opengl is the only renderer and hasn't been explicitly defined
>Confidential:   no
>Severity:       serious
>Priority:       low
>Responsible:    amdmi3
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Thu Mar 31 11:00:20 UTC 2011
>Closed-Date:    Tue Sep 06 19:23:48 UTC 2011
>Last-Modified:  Tue Sep 06 19:23:48 UTC 2011
>Originator:     Lars
>Release:        6.4
>Organization:
>Environment:
FreeBSD bsdlhers.incore 6.4-STABLE FreeBSD 6.4-STABLE #0: Mon Aug 17 18:53:58 CEST 2009     root@bsdlhers.incore:/usr/obj/usr/src/sys/BSDV6  i386
>Description:

>How-To-Repeat:
build gnash with opengl as only renderer and then run gnash without set an renderer on command line or in gnashrc
>Fix:
build gnash with patch or set renderer explicitly on command line or in gnashrc

Patch attached with submission follows:

--- gui/gtk/gtk_canvas.cpp.orig	2010-08-21 16:26:58.000000000 +0200
+++ gui/gtk/gtk_canvas.cpp	2011-03-31 11:14:35.000000000 +0200
@@ -214,8 +214,8 @@
         renderer = "agg";
 #elif defined (RENDERER_CAIRO)
         renderer = "cairo";
-#elif defined (RENDERER_OGL)
-        renderer = "ogl";
+#elif defined (RENDERER_OPENGL)
+        renderer = "opengl";
 #endif
     }
 


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->amdmi3 
Responsible-Changed-By: linimon 
Responsible-Changed-When: Fri Apr 1 19:11:20 UTC 2011 
Responsible-Changed-Why:  
Since the submitter's mbox is full, some detective work was needed, but 
it seems this is about gnash after all.  Fix synopsis and assign. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=156088 
State-Changed-From-To: open->feedback 
State-Changed-By: amdmi3 
State-Changed-When: Tue Sep 6 15:56:56 UTC 2011 
State-Changed-Why:  
Could you check whether this fix is still needed after 0.8.9 update? 
Seems like only one of two lines was changed upstream. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=156088 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/156088: commit references a PR
Date: Tue,  6 Sep 2011 19:15:19 +0000 (UTC)

 amdmi3      2011-09-06 19:15:10 UTC
 
   FreeBSD ports repository
 
   Modified files:
     graphics/gnash       Makefile 
   Added files:
     graphics/gnash/files patch-gui-gtk-gtk_canvas.cpp 
   Log:
   - Fix segfault with OpenGL selected as the only renderer
   
   PR:             156088
   Submitted by:   Lars <dakta@gmx.de>
   
   Revision  Changes    Path
   1.57      +1 -0      ports/graphics/gnash/Makefile
   1.1       +11 -0     ports/graphics/gnash/files/patch-gui-gtk-gtk_canvas.cpp (new)
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: feedback->closed 
State-Changed-By: amdmi3 
State-Changed-When: Tue Sep 6 19:23:47 UTC 2011 
State-Changed-Why:  
Committed. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=156088 
>Unformatted:
