From nobody@FreeBSD.org  Tue Mar 22 17:34:21 2011
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 534E6106564A
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 22 Mar 2011 17:34:21 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22])
	by mx1.freebsd.org (Postfix) with ESMTP id 464408FC0A
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 22 Mar 2011 17:34:21 +0000 (UTC)
Received: from red.freebsd.org (localhost [127.0.0.1])
	by red.freebsd.org (8.14.4/8.14.4) with ESMTP id p2MHYLCA097460
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 22 Mar 2011 17:34:21 GMT
	(envelope-from nobody@red.freebsd.org)
Received: (from nobody@localhost)
	by red.freebsd.org (8.14.4/8.14.4/Submit) id p2MHYLPF097459;
	Tue, 22 Mar 2011 17:34:21 GMT
	(envelope-from nobody)
Message-Id: <201103221734.p2MHYLPF097459@red.freebsd.org>
Date: Tue, 22 Mar 2011 17:34:21 GMT
From: Vitaly Magerya <vmagerya@gmail.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: sysutils/busybox: don't strip the binary when WITH_DEBUG is set
X-Send-Pr-Version: www-3.1
X-GNATS-Notify: utisoft@gmail.com

>Number:         155789
>Category:       ports
>Synopsis:       sysutils/busybox: don't strip the binary when WITH_DEBUG is set
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    sunpoet
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Tue Mar 22 17:40:01 UTC 2011
>Closed-Date:    Wed Mar 23 15:12:21 UTC 2011
>Last-Modified:  Wed Mar 23 15:20:00 UTC 2011
>Originator:     Vitaly Magerya
>Release:        FreeBSD 8.2-RELEASE i386
>Organization:
>Environment:
>Description:
Busybox build system strips the binary by default, so even if you 
build the port with WITH_DEBUG defined the resulting binary is still
stripped.

The attached patch disables the stripping that the build system
performs, and allows our port system to strip the binary when
necessary. This way WITH_DEBUG actually works.
>How-To-Repeat:

>Fix:


Patch attached with submission follows:

diff -ruN busybox.orig/Makefile busybox/Makefile
--- busybox.orig/Makefile	2011-03-13 13:56:26.000000000 +0200
+++ busybox/Makefile	2011-03-22 19:15:24.000000000 +0200
@@ -22,6 +22,8 @@
 
 PLIST_FILES=	bin/busybox
 
+MAKE_ARGS=	SKIP_STRIP=y
+
 .include <bsd.port.pre.mk>
 
 post-patch:


>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->feedback 
State-Changed-By: edwin 
State-Changed-When: Tue Mar 22 17:40:23 UTC 2011 
State-Changed-Why:  
Awaiting maintainers feedback (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=155789 

From: Edwin Groothuis <edwin@FreeBSD.org>
To: utisoft@gmail.com
Cc: bug-followup@FreeBSD.org
Subject: Re: ports/155789: sysutils/busybox: don't strip the binary when WITH_DEBUG is set
Date: Tue, 22 Mar 2011 17:40:21 UT

 Maintainer of sysutils/busybox,
 
 Please note that PR ports/155789 has just been submitted.
 
 If it contains a patch for an upgrade, an enhancement or a bug fix
 you agree on, reply to this email stating that you approve the patch
 and a committer will take care of it.
 
 The full text of the PR can be found at:
     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/155789
 
 -- 
 Edwin Groothuis via the GNATS Auto Assign Tool
 edwin@FreeBSD.org
Responsible-Changed-From-To: freebsd-ports-bugs->sunpoet 
Responsible-Changed-By: sunpoet 
Responsible-Changed-When: Tue Mar 22 17:52:36 UTC 2011 
Responsible-Changed-Why:  
I will take it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=155789 

From: Chris Rees <utisoft@gmail.com>
To: bug-followup@freebsd.org
Cc: Edwin Groothuis <edwin@freebsd.org>, vmagerya@gmail.com
Subject: Re: ports/155789: sysutils/busybox: don't strip the binary when
 WITH_DEBUG is set
Date: Tue, 22 Mar 2011 18:04:04 +0000

 Looks great, thanks!
 
 Chris
State-Changed-From-To: feedback->closed 
State-Changed-By: sunpoet 
State-Changed-When: Wed Mar 23 15:12:20 UTC 2011 
State-Changed-Why:  
Committed. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=155789 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/155789: commit references a PR
Date: Wed, 23 Mar 2011 15:11:48 +0000 (UTC)

 sunpoet     2011-03-23 15:11:33 UTC
 
   FreeBSD ports repository
 
   Modified files:
     sysutils/busybox     Makefile 
   Log:
   - Respect WITH_DEBUG: do not strip the binary by default
   - Use bsd.port.mk
   
   PR:             ports/155789
   Submitted by:   Vitaly Magerya <vmagerya@gmail.com>
   Approved by:    Chris Rees <utisoft@gmail.com> (maintainer)
   
   Revision  Changes    Path
   1.13      +2 -3      ports/sysutils/busybox/Makefile
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
