From nobody@FreeBSD.org  Sun Mar 13 13:17:14 2011
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 8F05F1065672
	for <freebsd-gnats-submit@FreeBSD.org>; Sun, 13 Mar 2011 13:17:14 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22])
	by mx1.freebsd.org (Postfix) with ESMTP id 7DEB68FC0A
	for <freebsd-gnats-submit@FreeBSD.org>; Sun, 13 Mar 2011 13:17:14 +0000 (UTC)
Received: from red.freebsd.org (localhost [127.0.0.1])
	by red.freebsd.org (8.14.4/8.14.4) with ESMTP id p2DDHEY7066312
	for <freebsd-gnats-submit@FreeBSD.org>; Sun, 13 Mar 2011 13:17:14 GMT
	(envelope-from nobody@red.freebsd.org)
Received: (from nobody@localhost)
	by red.freebsd.org (8.14.4/8.14.4/Submit) id p2DDHE9A066311;
	Sun, 13 Mar 2011 13:17:14 GMT
	(envelope-from nobody)
Message-Id: <201103131317.p2DDHE9A066311@red.freebsd.org>
Date: Sun, 13 Mar 2011 13:17:14 GMT
From: Ruslan Mahmatkhanov <cvs-src@yandex.ru>
To: freebsd-gnats-submit@FreeBSD.org
Subject: [PATCH] devel/py-elementtree: ignore if python >= 2.5
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         155526
>Category:       ports
>Synopsis:       [PATCH] devel/py-elementtree: ignore if python >= 2.5
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-python
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Sun Mar 13 13:20:11 UTC 2011
>Closed-Date:    Mon Sep 23 10:45:14 UTC 2013
>Last-Modified:  Mon Sep 23 10:50:00 UTC 2013
>Originator:     Ruslan Mahmatkhanov
>Release:        8.2-STABLE
>Organization:
>Environment:
8.2-STABLE i386
>Description:
- set IGNORE if python version is >= 2.5, because ElementTree is a part of standard library since 2.5:
http://docs.python.org/library/xml.etree.elementtree.html
http://effbot.org/zone/elementtree.html
- remove MD5

Dunno maybe we should delete this port at all, since we dropping support of 24 in the tree.
>How-To-Repeat:

>Fix:


Patch attached with submission follows:

diff -ruNa py-elementtree.orig/Makefile py-elementtree/Makefile
--- py-elementtree.orig/Makefile	2009-05-22 11:08:07.000000000 +0400
+++ py-elementtree/Makefile	2011-03-13 16:11:08.000000000 +0300
@@ -33,4 +33,10 @@
 	${CP} -R ${WRKSRC}/samples/ ${EXAMPLESDIR}
 .endif
 
-.include <bsd.port.mk>
+.include <bsd.port.pre.mk>
+
+.if ${PYTHON_REL} >= 250
+IGNORE=	elementTree ships with Python 2.5.x
+.endif
+
+.include <bsd.port.post.mk>
diff -ruNa py-elementtree.orig/distinfo py-elementtree/distinfo
--- py-elementtree.orig/distinfo	2006-11-16 00:49:18.000000000 +0300
+++ py-elementtree/distinfo	2011-03-13 16:07:59.000000000 +0300
@@ -1,3 +1,2 @@
-MD5 (elementtree-1.2.6-20050316.tar.gz) = e1b21716be8bfff8bf192fc3880ad008
 SHA256 (elementtree-1.2.6-20050316.tar.gz) = b29d5f2417cb331562c8c5f8ebef2a895ba540261c4245f526143c6a31bccb04
 SIZE (elementtree-1.2.6-20050316.tar.gz) = 41752


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->freebsd-python 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Sun Mar 13 13:20:27 UTC 2011 
Responsible-Changed-Why:  
Over to maintainer (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=155526 
State-Changed-From-To: open->closed 
State-Changed-By: miwi 
State-Changed-When: Sun Mar 13 13:26:29 UTC 2011 
State-Changed-Why:  
python24 goes to the end of month, this port is on the todo for removal. 
thx. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=155526 
State-Changed-From-To: closed->open 
State-Changed-By: pav 
State-Changed-When: Fri Jun 24 13:32:40 UTC 2011 
State-Changed-Why:  
Re-open, python24 failed to disappear 

http://www.freebsd.org/cgi/query-pr.cgi?pr=155526 

From: Marcus von Appen <mva@FreeBSD.org>
To: bug-followup@FreeBSD.org, cvs-src@yandex.ru
Cc:  
Subject: Re: ports/155526: [PATCH] devel/py-elementtree: ignore if python >=
 2.5
Date: Thu, 7 Jun 2012 17:39:32 +0200

 --BOKacYhQ+x31HxR3
 Content-Type: text/plain; charset=us-ascii
 Content-Disposition: inline
 
 As long as www/py-Products.TinyMCE depends on it, there is no way to
 delete it (without fixing www/py-Products.TinyMCE beforehand for python
 >= 2.5).
 
 Also, as it does not do any harm (no package name confusion with
 xml.etree.elementTree and _elementtree), it is not really necessary to
 force the deletion of it.
 
 Cheers
 Marcus
 
 --BOKacYhQ+x31HxR3
 Content-Type: application/pgp-signature
 
 -----BEGIN PGP SIGNATURE-----
 Version: GnuPG v2.0.19 (FreeBSD)
 
 iEYEARECAAYFAk/QyzMACgkQi68/ErJnpkfC4wCfWgKaKSQYRLTpmkFXb5H88ZW2
 MhQAoJloYhSrq0vWCKKxCJ1oxqpouVeZ
 =Vj80
 -----END PGP SIGNATURE-----
 
 --BOKacYhQ+x31HxR3--

From: Ruslan Mahmatkhanov <cvs-src@yandex.ru>
To: Marcus von Appen <mva@FreeBSD.org>
Cc: bug-followup@FreeBSD.org
Subject: Re: ports/155526: [PATCH] devel/py-elementtree: ignore if python
 >= 2.5
Date: Thu, 07 Jun 2012 20:13:42 +0400

 Marcus von Appen wrote on 07.06.2012 19:39:
 > As long as www/py-Products.TinyMCE depends on it, there is no way to
 > delete it (without fixing www/py-Products.TinyMCE beforehand for python
 >> = 2.5).
 >
 > Also, as it does not do any harm (no package name confusion with
 > xml.etree.elementTree and _elementtree), it is not really necessary to
 > force the deletion of it.
 >
 > Cheers
 > Marcus
 
 Yes, but why do we need to hold the ports, that nobody using and will 
 not be anyway? All the ports I saw, that uses elementTree, first 
 checking if they can import xml.etree and if they not, then they will 
 try to fallback to standalone _elementtree. And since python24/25 will 
 be removed soon, there is no sense to hold them.
 
 The only difference between them is HTMLTreeBuilder class that is 
 missing in xml.etree (and that py-Products.TinyMCE is using), so 
 py-elementtree should stay until Products.TinyMCE will be ported to 
 py-lxml, and py-celementtree is safe to remove (because nobody using 
 it). This ports/155526 should be closed too, because it's now impossible 
 to remove this port.
 
 PS. The same belongs to simplejson/json case. Most ports try to use 
 bundled json module first, and try to import simplejson if they fail 
 (python<2.6). But there is couple of ports that need exactly simplejson 
 implementation.
 
 -- 
 Regards,
 Ruslan
 
 Tinderboxing kills... the drives.

From: Marcus von Appen <mva@FreeBSD.org>
To: Ruslan Mahmatkhanov <cvs-src@yandex.ru>
Cc: freebsd-python@FreeBSD.org, bug-followup@FreeBSD.org
Subject: Re: ports/155526: [PATCH] devel/py-elementtree: ignore if python >=
 2.5
Date: Thu, 7 Jun 2012 19:11:50 +0200

 --3uo+9/B/ebqu+fSQ
 Content-Type: text/plain; charset=us-ascii
 Content-Disposition: inline
 
 On, Thu Jun 07, 2012, Ruslan Mahmatkhanov wrote:
 
 > The following reply was made to PR ports/155526; it has been noted by GNATS.
 >
 > From: Ruslan Mahmatkhanov <cvs-src@yandex.ru>
 > To: Marcus von Appen <mva@FreeBSD.org>
 > Cc: bug-followup@FreeBSD.org
 > Subject: Re: ports/155526: [PATCH] devel/py-elementtree: ignore if python
 >  >= 2.5
 > Date: Thu, 07 Jun 2012 20:13:42 +0400
 >
 >  Marcus von Appen wrote on 07.06.2012 19:39:
 >  > As long as www/py-Products.TinyMCE depends on it, there is no way to
 >  > delete it (without fixing www/py-Products.TinyMCE beforehand for python
 >  >> = 2.5).
 >  >
 >  > Also, as it does not do any harm (no package name confusion with
 >  > xml.etree.elementTree and _elementtree), it is not really necessary to
 >  > force the deletion of it.
 >  >
 >  > Cheers
 >  > Marcus
 >
 >  Yes, but why do we need to hold the ports, that nobody using and will
 >  not be anyway? All the ports I saw, that uses elementTree, first
 >  checking if they can import xml.etree and if they not, then they will
 >  try to fallback to standalone _elementtree. And since python24/25 will
 >  be removed soon, there is no sense to hold them.
 
 Right, but there is no need to rush things, either, at least not as long
 as the port above has a dependency on it.
 
 >  The only difference between them is HTMLTreeBuilder class that is
 >  missing in xml.etree (and that py-Products.TinyMCE is using), so
 >  py-elementtree should stay until Products.TinyMCE will be ported to
 >  py-lxml, and py-celementtree is safe to remove (because nobody using
 >  it). This ports/155526 should be closed too, because it's now impossible
 >  to remove this port.
 
 I'd rather vote for keeping it open until www/py-Products.TinyMCE has
 been updated properly and lang/python24 was removed, so we do not forget
 about deprecating and removing devel/py-elementtree later on.
 
 Cheers
 Marcus
 
 --3uo+9/B/ebqu+fSQ
 Content-Type: application/pgp-signature
 
 -----BEGIN PGP SIGNATURE-----
 Version: GnuPG v2.0.19 (FreeBSD)
 
 iEYEARECAAYFAk/Q4NYACgkQi68/ErJnpkfbpwCeJivy1KMa4mJnhIML0CZFndjs
 0a8AnjMSdFMH/8rOQ4dCW9aCI/vqDlOp
 =+Wzp
 -----END PGP SIGNATURE-----
 
 --3uo+9/B/ebqu+fSQ--
State-Changed-From-To: open->closed 
State-Changed-By: rm 
State-Changed-When: Mon Sep 23 10:45:13 UTC 2013 
State-Changed-Why:  
Port removed. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=155526 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/155526: commit references a PR
Date: Mon, 23 Sep 2013 10:41:09 +0000 (UTC)

 Author: rm
 Date: Mon Sep 23 10:41:01 2013
 New Revision: 327969
 URL: http://svnweb.freebsd.org/changeset/ports/327969
 
 Log:
   Remove since ElementTree is a part of standard library since Python 2.5.
   Last consumer of it gone today.
   
   PR:		155526
   Submitted by:	rm (myself)
 
 Deleted:
   head/devel/py-elementtree/
 Modified:
   head/MOVED
   head/devel/Makefile
 
 Modified: head/MOVED
 ==============================================================================
 --- head/MOVED	Mon Sep 23 10:23:35 2013	(r327968)
 +++ head/MOVED	Mon Sep 23 10:41:01 2013	(r327969)
 @@ -4947,3 +4947,4 @@ devel/ptlib26|devel/ptlib|2013-09-20|Rem
  net/opal3|net/opal|2013-09-20|Removed old version, update to new version and moved port
  net/ekiga|net-im/ekiga|2013-09-20|Removed old version, update to new version and moved port
  net/ekiga3|net-im/ekiga|2013-09-20|Removed old version, update to new version and moved port
 +devel/py-elementtree||2013-09-23|ElementTree is a part of standard library since Python 2.5
 
 Modified: head/devel/Makefile
 ==============================================================================
 --- head/devel/Makefile	Mon Sep 23 10:23:35 2013	(r327968)
 +++ head/devel/Makefile	Mon Sep 23 10:41:01 2013	(r327969)
 @@ -3523,7 +3523,6 @@
      SUBDIR += py-durus
      SUBDIR += py-dynrules
      SUBDIR += py-eggtestinfo
 -    SUBDIR += py-elementtree
      SUBDIR += py-epsilon
      SUBDIR += py-event
      SUBDIR += py-experimental.cssselect
 _______________________________________________
 svn-ports-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-ports-all
 To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
 
>Unformatted:
