From naddy@bigeye.rhein-neckar.de  Fri Dec 17 15:31:26 1999
Return-Path: <naddy@bigeye.rhein-neckar.de>
Received: from news-ma.rhein-neckar.de (news-ma.rhein-neckar.de [193.197.90.3])
	by hub.freebsd.org (Postfix) with ESMTP id CC3FD14C22
	for <FreeBSD-gnats-submit@freebsd.org>; Fri, 17 Dec 1999 15:31:22 -0800 (PST)
	(envelope-from naddy@bigeye.rhein-neckar.de)
Received: from bigeye.rhein-neckar.de (uucp@localhost)
	by news-ma.rhein-neckar.de (8.8.8/8.8.8) with bsmtp id AAA26750
	for FreeBSD-gnats-submit@freebsd.org; Sat, 18 Dec 1999 00:31:18 +0100 (CET)
	(envelope-from naddy@bigeye.rhein-neckar.de)
Received: (from naddy@localhost)
	by bigeye.rhein-neckar.de (8.9.3/8.9.3) id XAA02336;
	Fri, 17 Dec 1999 23:57:06 +0100 (CET)
	(envelope-from naddy)
Message-Id: <199912172257.XAA02336@bigeye.rhein-neckar.de>
Date: Fri, 17 Dec 1999 23:57:06 +0100 (CET)
From: Christian Weisgerber <naddy@mips.rhein-neckar.de>
Sender: naddy@bigeye.rhein-neckar.de
Reply-To: naddy@mips.rhein-neckar.de
To: FreeBSD-gnats-submit@freebsd.org
Subject: new port: x11/xterm
X-Send-Pr-Version: 3.2

>Number:         15545
>Category:       ports
>Synopsis:       new port: x11/xterm
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Fri Dec 17 15:40:00 PST 1999
>Closed-Date:    Mon Sep 18 11:43:57 PDT 2000
>Last-Modified:  Mon Sep 18 11:44:50 PDT 2000
>Originator:     Christian Weisgerber
>Release:        FreeBSD 4.0-CURRENT i386
>Organization:
>Environment:

X11

>Description:

In between releases of XFree86, Thomas Dickey keeps producing
updated versions of xterm. This is a port of the current version
from Thomas' home page. Its major new feature over the stock xterm
from XFree86 3.3.5 is the addition of UTF-8 support. Unicode for
the masses! It also adds flexibility to the handling of the insane
backspace/delete issue.

To avoid collisions with XFree86, this port installs into ${LOCALBASE}.

>How-To-Repeat:

n/a

>Fix:

# This is a shell archive.  Save it in a file, remove anything before
# this line, and then unpack it by entering "sh file".  Note, it may
# create directories; files and directories will be owned by you and
# have default permissions.
#
# This archive contains:
#
#	xterm
#	xterm/pkg
#	xterm/pkg/PLIST
#	xterm/pkg/DESCR
#	xterm/pkg/COMMENT
#	xterm/files
#	xterm/files/md5
#	xterm/patches
#	xterm/patches/patch-aa
#	xterm/Makefile
#
echo c - xterm
mkdir -p xterm > /dev/null 2>&1
echo c - xterm/pkg
mkdir -p xterm/pkg > /dev/null 2>&1
echo x - xterm/pkg/PLIST
sed 's/^X//' >xterm/pkg/PLIST << 'END-of-xterm/pkg/PLIST'
Xbin/xterm
Xbin/resize
Xlib/X11/app-defaults/XTerm
Xlib/X11/app-defaults/XTerm-color
END-of-xterm/pkg/PLIST
echo x - xterm/pkg/DESCR
sed 's/^X//' >xterm/pkg/DESCR << 'END-of-xterm/pkg/DESCR'
XThe xterm program is a terminal emulator for the X Window System.
XIt provides DEC VT102/VT220 (VTxxx) and Tektronix 4014 compatible
Xterminals for programs that can't use the window system directly.
XThis version adds Unicode (UTF-8) support.
X
XWWW: http://www.clark.net/pub/dickey/xterm/xterm.html
X
X- Christian "naddy" Weisgerber
X  naddy@mips.rhein-neckar.de
END-of-xterm/pkg/DESCR
echo x - xterm/pkg/COMMENT
sed 's/^X//' >xterm/pkg/COMMENT << 'END-of-xterm/pkg/COMMENT'
XA newer version of xterm
END-of-xterm/pkg/COMMENT
echo c - xterm/files
mkdir -p xterm/files > /dev/null 2>&1
echo x - xterm/files/md5
sed 's/^X//' >xterm/files/md5 << 'END-of-xterm/files/md5'
XMD5 (xterm-121.tgz) = ee165659d1f39300204a472534a2b629
END-of-xterm/files/md5
echo c - xterm/patches
mkdir -p xterm/patches > /dev/null 2>&1
echo x - xterm/patches/patch-aa
sed 's/^X//' >xterm/patches/patch-aa << 'END-of-xterm/patches/patch-aa'
X--- xterm.h.orig	Sat Sep 18 18:15:02 1999
X+++ xterm.h	Thu Sep 23 17:24:25 1999
X@@ -43,6 +43,9 @@
X 
X #ifdef HAVE_CONFIG_H
X #include <xtermcfg.h>
X+#if defined(HAVE_TERMIOS_H) && defined(HAVE_TCGETATTR)
X+#define USE_POSIX_TERMIOS
X+#endif
X #endif
X 
X #ifndef GCC_UNUSED
END-of-xterm/patches/patch-aa
echo x - xterm/Makefile
sed 's/^X//' >xterm/Makefile << 'END-of-xterm/Makefile'
X# New ports collection makefile for:	xterm
X# Version required:     Patch #121
X# Date created:         1999-07-28
X# Whom:                 Christian Weisgerber <naddy@mips.rhein-neckar.de>
X#
X# $FreeBSD$
X
XDISTNAME=	xterm-121
XCATEGORIES=	x11
XMASTER_SITES=	ftp://ftp.clark.net/pub/dickey/xterm/
XEXTRACT_SUFX=	.tgz
X
XMAINTAINER=	naddy@mips.rhein-neckar.de
X
XUSE_XLIB=	yes
XGNU_CONFIGURE=	yes
XCONFIGURE_ARGS=	--enable-wide-chars
XMAN1=		xterm.1 resize.1
X
X.include <bsd.port.mk>
END-of-xterm/Makefile
exit


>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->feedback 
State-Changed-By: ade 
State-Changed-When: Wed Mar 29 14:19:26 PST 2000 
State-Changed-Why:  
Has the functionality in this port been rolled into either 
XFree86 3.3.6 or one of the pre-4.0 snapshots? 

This port worries me in that it overwrites a couple of 
standard X11 binaries (xterm and resize), so that a 
pkg_delete would result in _no_ xterm being available, 
which is a bad thing. 

Unless a solution can be found to this problem 
(remember to deal with the app-defaults too), I 
believe that this submission should just die peacefully. 

From: Ade Lovett <ade@FreeBSD.org>
To: Christian Weisgerber <naddy@mips.rhein-neckar.de>
Cc: freebsd-gnats-submit@FreeBSD.org
Subject: Re: ports/15545: New port: x11/xterm
Date: Wed, 29 Mar 2000 19:59:31 -0600

 On Thu, Mar 30, 2000 at 02:06:06AM +0200, Christian Weisgerber wrote:
 > No, it doesn't.
 > The port installs under ${LOCALBASE}, not ${X11BASE}.
 
 Which is wrong.  xterm is most definitely an X application, and
 thus should go under ${X11BASE}.
 
 But, for the sake of argument, let's say it goes into ${LOCALBASE}.
 You then have the issue of depending how your ${PATH} is set up,
 you could get the XFree86 xterm, or this one, with all the pitfalls
 that causes.
 
 You also end up creating ${LOCALBASE}/lib/X11/app-defaults which
 as well as being somewhat unuseful (as you state), is also
 not cleaned up on package deinstall.  Another "black mark".
 
 Finally, since the author is committed to getting this xterm into
 the main XFree86 4.0 tree, it would also appear that this port
 would be fairly short-lived.
 
 So, as I see it, the advantages of having this available
 in its current state are heavily outweighed by the disadvantages,
 both in the port itself, and the way in which it pollutes
 well-known namespace, particularly with something as ubiquitous
 as "xterm".
 
 Regards,
 	-aDe
 
 -- 
 Ade Lovett, Austin, TX.
 

From: Christian Weisgerber <naddy@mips.rhein-neckar.de>
To: Ade Lovett <ade@FreeBSD.org>
Cc: freebsd-gnats-submit@FreeBSD.org
Subject: Re: ports/15545: New port: x11/xterm
Date: Thu, 30 Mar 2000 12:32:04 +0200

 Ade Lovett:
 
 > > The port installs under ${LOCALBASE}, not ${X11BASE}.
 > 
 > Which is wrong.  xterm is most definitely an X application, and
 > thus should go under ${X11BASE}.
 
 This is news to me. I've been made to believe that installing ports
 under ${X11BASE} is a side effect if they're built with imake, and
 since this can't be fixed, it has become accepted practice but not
 a feature in its own right.
 
 > You then have the issue of depending how your ${PATH} is set up,
 > you could get the XFree86 xterm, or this one, with all the pitfalls
 > that causes.
 
 Yes.
 I don't perceive this as a great problem. What do you suggest?
 Adding a MESSAGE to that purpose, or entirely renaming this xterm
 (which opens up a new can of worms)?
 
 Obviously it would be nicer if we could just substitute XFree86's
 stock xterm with the new one, but the existing package system
 doesn't allow this.
 
 > You also end up creating ${LOCALBASE}/lib/X11/app-defaults which
 > as well as being somewhat unuseful (as you state), is also
 > not cleaned up on package deinstall.  Another "black mark".
 
 What do you mean, "not cleaned up on package deinstall"? The files
 are in the PLIST and will be removed on deinstall. I'm under the
 impression that it is common practice for ports not to try to remove
 directories that they don't use exclusively (which is uncertain
 for the case above), but adding two @dirrm's to the PLIST is hardly
 an obstacle.
 
 > Finally, since the author is committed to getting this xterm into
 > the main XFree86 4.0 tree, it would also appear that this port
 > would be fairly short-lived.
 
 Quite to the contrary. The port will be frequently updated.
 
 New versions of xterm are released more frequently than XFree86
 is. The main purpose of this port is to provide convenient and
 package-clean access to the latest versions of xterm between XFree86
 releases.
 
 (At this time it also provides a much improved xterm to people who
 choose to remain with XFree86 3.3.6 because 4.0 doesn't support
 their graphics hardware, as well as an important bug fix over the
 xterm shipped with XFree86 4.0. As far as I'm concerned, this proves
 the usefulness of the port.)
 
 -- 
 Christian "naddy" Weisgerber                  naddy@mips.rhein-neckar.de
 

From: Ade Lovett <ade@FreeBSD.org>
To: jkoshy@FreeBSD.org
Cc: naddy@mips.rhein-neckar.de, freebsd-gnats-submit@FreeBSD.org
Subject: Re: ports/15545: New port: x11/xterm
Date: Thu, 30 Mar 2000 07:56:35 -0600

 On Thu, Mar 30, 2000 at 01:20:40AM -0800, jkoshy@FreeBSD.org wrote:
 > 
 > Why not have the port rename the executable and app-default file to
 > something else? (nxterm? xterm-the-next-generation :)?) and allow both
 > flavours to coexist?
 
 Precisely.  If it does this, then all my objections go away
 (though it will need a USE_X_PREFIX so that the app-defaults
 files will actually work).
 
 We already try to avoid namespace duplication and pollution with
 our current set of ports, this one should be no different.
 
 If the submitter (or someone else) wants to take this port and
 patch it so that it identifies itself as nxterm, pxterm, or
 whatever, and also adjust the app-defaults filenames, then
 it will quite happily co-exist with a regular X11 installation,
 and not violate POLA.
 
 -aDe
 
 -- 
 Ade Lovett, Austin, TX.
 
State-Changed-From-To: feedback->closed 
State-Changed-By: ade 
State-Changed-When: Mon Sep 18 11:43:57 PDT 2000 
State-Changed-Why:  
Timeout (5 months) in feedback.  See audit-trail for more reasons 
why this shouldn't go in the tree. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=15545 
>Unformatted:
