From nobody@FreeBSD.org  Sun Mar  6 18:17:45 2011
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 273261065673
	for <freebsd-gnats-submit@FreeBSD.org>; Sun,  6 Mar 2011 18:17:45 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22])
	by mx1.freebsd.org (Postfix) with ESMTP id 147218FC15
	for <freebsd-gnats-submit@FreeBSD.org>; Sun,  6 Mar 2011 18:17:45 +0000 (UTC)
Received: from red.freebsd.org (localhost [127.0.0.1])
	by red.freebsd.org (8.14.4/8.14.4) with ESMTP id p26IHiKw074004
	for <freebsd-gnats-submit@FreeBSD.org>; Sun, 6 Mar 2011 18:17:44 GMT
	(envelope-from nobody@red.freebsd.org)
Received: (from nobody@localhost)
	by red.freebsd.org (8.14.4/8.14.4/Submit) id p26IHiR4074003;
	Sun, 6 Mar 2011 18:17:44 GMT
	(envelope-from nobody)
Message-Id: <201103061817.p26IHiR4074003@red.freebsd.org>
Date: Sun, 6 Mar 2011 18:17:44 GMT
From: Yamagi Burmeister <yamagi@yamagi.org>
To: freebsd-gnats-submit@FreeBSD.org
Subject: rtorrent doesn't work with ncurses 5.8
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         155318
>Category:       ports
>Synopsis:       net-p2p/rtorrent doesn't work with ncurses 5.8
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    flz
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sun Mar 06 18:20:12 UTC 2011
>Closed-Date:    Sat May 07 16:34:54 UTC 2011
>Last-Modified:  Sat May  7 16:40:16 UTC 2011
>Originator:     Yamagi Burmeister
>Release:        FreeBSD 8.2-RELEASE
>Organization:
>Environment:
FreeBSD saya.home.yamagi.org 8.2-RELEASE FreeBSD 8.2-RELEASE #0: Sun Feb 20 18:59:52 CET 2011     root@:/usr/obj/usr/src/sys/SAYA  amd6
>Description:
After the update of devel/ncurses to 5.8 rtorrent stopped working at least on FreeBSD/amd64. The problem are invalid canvas size parameter to ncurses. The attached patch can be put into net-p2p/rtorrent/files and fixes the problem by passing legal values to ncurses.
>How-To-Repeat:
Start net-p2p/rtorrent on a FreeBSD/amd64 box with devel/ncurses 5.8 installed.
>Fix:
See the attached patch.

Patch attached with submission follows:

--- src/display/canvas.h        2011-03-03 19:10:25.000000000 +0200
+++ src/display/canvas.h        2011-03-03 19:10:10.000000000 +0200
@@ -48,7 +48,7 @@ class Canvas {
 public:
   typedef std::vector<Attributes> attributes_list;
 
-  Canvas(int x = 0, int y = 0, int width = 0, int height = 0) :
+  Canvas(int x = 0, int y = 0, int width = 1, int height = 1) :
     m_window(newwin(height, width, y, x)) {}
   ~Canvas() { delwin(m_window); }


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->flz 
Responsible-Changed-By: linimon 
Responsible-Changed-When: Sun Mar 6 20:42:33 UTC 2011 
Responsible-Changed-Why:  
Fix synopsis and assign. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=155318 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/155318: commit references a PR
Date: Sat,  7 May 2011 16:30:00 +0000 (UTC)

 flz         2011-05-07 16:29:47 UTC
 
   FreeBSD ports repository
 
   Modified files:
     net-p2p/rtorrent     Makefile 
     net-p2p/rtorrent/files pkg-message.in 
   Added files:
     net-p2p/rtorrent/files patch-src__display__canvas.h 
   Log:
   rtorrent: enabled ipv6 by default, fix with ncurses 5.8, fix link.
   
   - Enable IPV6 in OPTIONS by default. [1]
   - Remove outdated link in pkg-message. [1]
   - Add local patch to fix rtorrent with ncurses 5.8. [2,3]
   
   PR:             ports/155609 [1], ports/155318 [2], ports/156294 [3]
   Submitted by:   tom@ [1],
                   Yamagi Burmeister <yamagi@yamagi.org> [2],
                   freebsd@nagilum.org [3]
   
   Revision  Changes    Path
   1.56      +2 -1      ports/net-p2p/rtorrent/Makefile
   1.1       +11 -0     ports/net-p2p/rtorrent/files/patch-src__display__canvas.h (new)
   1.3       +1 -3      ports/net-p2p/rtorrent/files/pkg-message.in
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: open->closed 
State-Changed-By: flz 
State-Changed-When: Sat May 7 16:34:52 UTC 2011 
State-Changed-Why:  
Committed. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=155318 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/155318: commit references a PR
Date: Sat,  7 May 2011 16:33:43 +0000 (UTC)

 flz         2011-05-07 16:33:30 UTC
 
   FreeBSD ports repository
 
   Modified files:
     net-p2p/rtorrent-devel Makefile 
   Added files:
     net-p2p/rtorrent-devel/files patch-src__display__canvas.h 
   Log:
   rtorrent-devel: update to 0.8.7, enable ipv6 by default, fix with ncurses 5.8.
   
   - Enable IPV6 in OPTIONS by default. [1]
   - Add local patch to fix rtorrent with ncurses 5.8. [2,3]
   
   PR:             ports/155609 [1], ports/155318 [2], ports/156294 [3]
   Submitted by:   tom@ [1],
                   Yamagi Burmeister <yamagi@yamagi.org> [2],
                   freebsd@nagilum.org [3]
   
   Revision  Changes    Path
   1.33      +4 -4      ports/net-p2p/rtorrent-devel/Makefile
   1.1       +11 -0     ports/net-p2p/rtorrent-devel/files/patch-src__display__canvas.h (new)
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
