From nobody@FreeBSD.org  Wed Mar  2 16:33:18 2011
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 491C11065673
	for <freebsd-gnats-submit@FreeBSD.org>; Wed,  2 Mar 2011 16:33:18 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22])
	by mx1.freebsd.org (Postfix) with ESMTP id 3762F8FC1A
	for <freebsd-gnats-submit@FreeBSD.org>; Wed,  2 Mar 2011 16:33:18 +0000 (UTC)
Received: from red.freebsd.org (localhost [127.0.0.1])
	by red.freebsd.org (8.14.4/8.14.4) with ESMTP id p22GXI1D007051
	for <freebsd-gnats-submit@FreeBSD.org>; Wed, 2 Mar 2011 16:33:18 GMT
	(envelope-from nobody@red.freebsd.org)
Received: (from nobody@localhost)
	by red.freebsd.org (8.14.4/8.14.4/Submit) id p22GXHRj007042;
	Wed, 2 Mar 2011 16:33:17 GMT
	(envelope-from nobody)
Message-Id: <201103021633.p22GXHRj007042@red.freebsd.org>
Date: Wed, 2 Mar 2011 16:33:17 GMT
From: bf <bf@FreeBSD.org>
To: freebsd-gnats-submit@FreeBSD.org
Subject: [PATCH]bsd.port.mk: fix portion of CONFIGURE_ENV added WITH_BINUTILS
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         155201
>Category:       ports
>Synopsis:       [PATCH]bsd.port.mk: fix portion of CONFIGURE_ENV added WITH_BINUTILS
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    portmgr
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed Mar 02 16:40:11 UTC 2011
>Closed-Date:    
>Last-Modified:  Tue Feb 21 18:30:12 UTC 2012
>Originator:     bf
>Release:        
>Organization:
>Environment:
>Description:
Various tools from devel/binutils are supposed to be added to the
CONFIGURE_ENV when WITH_BINUTILS is defined.  However, when a port
relies on bsd.autotools.mk, bsd.php.mk, or bsd.xorg.mk to define
GNU_CONFIGURE instead of declaring this variable explicitly in the
port Makefile, these tools may not be added.
>How-To-Repeat:
>Fix:
To fix this, change the way that USE_BINUTILS modifies CONFIGURE_ENV:
like other knobs, make additions regardless of whether GNU_CONFIGURE
is defined, subject only to a new optional blacklist variable
BINUTILS_NO_CONFIGURE_ENV, which is analogous to the existing
BINUTILS_NO_MAKE_ENV. This eliminates the as-yet-unused variable
BINUTILS_CONFIGURE, and also adds the tools to the CONFIGURE_ENV for
ports that use HAS_CONFIGURE.

Patch attached with submission follows:

Index: /home/u1/pwrk/ports/Mk/bsd.port.mk
===================================================================
RCS file: /home/pcvs/ports/Mk/bsd.port.mk,v
retrieving revision 1.673
diff -u -r1.673 bsd.port.mk
--- /home/u1/pwrk/ports/Mk/bsd.port.mk	25 Feb 2011 16:52:05 -0000	1.673
+++ /home/u1/pwrk/ports/Mk/bsd.port.mk	2 Mar 2011 16:11:29 -0000
@@ -1752,10 +1752,11 @@
 BUILD_DEPENDS+=	${LOCALBASE}/bin/as:${PORTSDIR}/devel/binutils
 BINUTILS?=	ADDR2LINE AR AS CPPFILT GPROF LD NM OBJCOPY OBJDUMP RANLIB \
 	READELF SIZE STRINGS
+BINUTILS_NO_CONFIGURE_ENV?=
 BINUTILS_NO_MAKE_ENV?=
 . for b in ${BINUTILS}
 ${b}=	${LOCALBASE}/bin/${b:C/PP/++/:L}
-.  if defined(GNU_CONFIGURE) || defined(BINUTILS_CONFIGURE)
+.  if ${BINUTILS_NO_CONFIGURE_ENV:M${b}} == ""
 CONFIGURE_ENV+=	${b}="${${b}}"
 .  endif
 .  if ${BINUTILS_NO_MAKE_ENV:M${b}} == ""


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->portmgr 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Wed Mar 2 16:40:26 UTC 2011 
Responsible-Changed-Why:  
bsd.port.mk is portmgr territory (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=155201 

From: "b. f." <bf1783@googlemail.com>
To: bug-followup@FreeBSD.org, Mark Linimon <linimon@lonesome.com>, pav@FreeBSD.org
Cc:  
Subject: Re: ports/155201: [PATCH]bsd.port.mk: fix portion of CONFIGURE_ENV
 added WITH_BINUTILS
Date: Sat, 23 Jul 2011 09:33:02 +0000

 --bcaec5431784b720f904a8b9443e
 Content-Type: text/plain; charset=ISO-8859-1
 
 I've attached a revised version of the patch, to account for the
 addition of the elfedit utility in the most recent version of
 devel/binutils, and the strip(1)-related problems uncovered by Mark in
 his sparc64 builds.  It turns out that the proper version of strip(1)
 also needs to be used, both explicitly and via the "-s" flag of
 install(1), or some builds will fail. For the former, the common
 autotools variable STRIP should be set to be STRIP_CMD in
 CONFIGURE_ENV, and for the latter, STRIPBIN  should be set to be
 STRIP_CMD in both CONFIGURE_ENV and MAKE_ENV.  A few ports that use
 STRIP in a non-standard way may need to be patched.
 
 b.
 
 --bcaec5431784b720f904a8b9443e
 Content-Type: application/octet-stream; name="PR155201_3.diff"
 Content-Disposition: attachment; filename="PR155201_3.diff"
 Content-Transfer-Encoding: base64
 X-Attachment-Id: file0
 
 SW5kZXg6IGJzZC5jb21tYW5kcy5tawo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09ClJDUyBmaWxlOiAvaG9tZS9wY3ZzL3Bv
 cnRzL01rL2JzZC5jb21tYW5kcy5tayx2CnJldHJpZXZpbmcgcmV2aXNpb24gMS44CmRpZmYgLXUg
 LXIxLjggYnNkLmNvbW1hbmRzLm1rCi0tLSBic2QuY29tbWFuZHMubWsJNCBNYXkgMjAxMSAyMjoz
 MzoxMyAtMDAwMAkxLjgKKysrIGJzZC5jb21tYW5kcy5tawkyMSBKdWwgMjAxMSAyMToyNToyOSAt
 MDAwMApAQCAtNzgsNiArNzgsNyBAQAogU0g/PQkJL2Jpbi9zaAogU09SVD89CQkvdXNyL2Jpbi9z
 b3J0CiBTVFJJUF9DTUQ/PQkvdXNyL2Jpbi9zdHJpcAorU1RSSVBCSU4/PQkke1NUUklQX0NNRH0K
 ICMgQ29tbWFuZCB0byBydW4gY29tbWFuZHMgYXMgcHJpdmlsZWdlZCB1c2VyCiAjIEV4YW1wbGU6
 ICIvdXNyL2xvY2FsL2Jpbi9zdWRvIHNoIC1jIiB0byB1c2UgInN1ZG8iIGluc3RlYWQgb2YgInN1
 IgogU1VfQ01EPz0JL3Vzci9iaW4vc3Ugcm9vdCAtYwpJbmRleDogYnNkLnBvcnQubWsKPT09PT09
 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
 PT09PQpSQ1MgZmlsZTogL2hvbWUvcGN2cy9wb3J0cy9Nay9ic2QucG9ydC5tayx2CnJldHJpZXZp
 bmcgcmV2aXNpb24gMS42OTAKZGlmZiAtdSAtcjEuNjkwIGJzZC5wb3J0Lm1rCi0tLSBic2QucG9y
 dC5tawkyMSBKdWwgMjAxMSAxNToxMDo0NiAtMDAwMAkxLjY5MAorKysgYnNkLnBvcnQubWsJMjEg
 SnVsIDIwMTEgMjE6MjU6MjkgLTAwMDAKQEAgLTE3NTMsMTggKzE3NTMsMjIgQEAKIAogLmlmIGRl
 ZmluZWQoVVNFX0JJTlVUSUxTKSAmJiAhZGVmaW5lZChESVNBQkxFX0JJTlVUSUxTKQogQlVJTERf
 REVQRU5EUys9CSR7TE9DQUxCQVNFfS9iaW4vYXM6JHtQT1JUU0RJUn0vZGV2ZWwvYmludXRpbHMK
 LUJJTlVUSUxTPz0JQUREUjJMSU5FIEFSIEFTIENQUEZJTFQgR1BST0YgTEQgTk0gT0JKQ09QWSBP
 QkpEVU1QIFJBTkxJQiBcCitCSU5VVElMUz89CUFERFIyTElORSBBUiBBUyBDUFBGSUxUIEVMRkVE
 SVQgR1BST0YgTEQgTk0gT0JKQ09QWSBPQkpEVU1QIFJBTkxJQiBcCiAJUkVBREVMRiBTSVpFIFNU
 UklOR1MKK0JJTlVUSUxTX05PX0NPTkZJR1VSRV9FTlY/PQogQklOVVRJTFNfTk9fTUFLRV9FTlY/
 PQogLiBmb3IgYiBpbiAke0JJTlVUSUxTfQogJHtifT0JJHtMT0NBTEJBU0V9L2Jpbi8ke2I6Qy9Q
 UC8rKy86TH0KLS4gIGlmIGRlZmluZWQoR05VX0NPTkZJR1VSRSkgfHwgZGVmaW5lZChCSU5VVElM
 U19DT05GSUdVUkUpCisuICBpZiAke0JJTlVUSUxTX05PX0NPTkZJR1VSRV9FTlY6TSR7Yn19ID09
 ICIiCiBDT05GSUdVUkVfRU5WKz0JJHtifT0iJHske2J9fSIKIC4gIGVuZGlmCiAuICBpZiAke0JJ
 TlVUSUxTX05PX01BS0VfRU5WOk0ke2J9fSA9PSAiIgogTUFLRV9FTlYrPQkke2J9PSIkeyR7Yn19
 IgogLiAgZW5kaWYKIC4gZW5kZm9yCisuIGlmICggZGVmaW5lZChXSVRIT1VUX0RFQlVHKSB8fCAh
 ZGVmaW5lZChXSVRIX0RFQlVHKSApICYmICFkZWZpbmVkKFVTRV9MSU5VWCkKK1NUUklQX0NNRD0J
 JHtMT0NBTEJBU0V9L2Jpbi9zdHJpcAorLiBlbmRpZgogLmVuZGlmCiAKIC5pZiBkZWZpbmVkKFVT
 RV9PUEVOTERBUCkgfHwgZGVmaW5lZChXQU5UX09QRU5MREFQX1ZFUikKQEAgLTIyNzgsNyArMjI4
 Miw4IEBACiAJCQlDQz0iJHtDQ30iIENGTEFHUz0iJHtDRkxBR1N9IiBcCiAJCQlDUFA9IiR7Q1BQ
 fSIgQ1BQRkxBR1M9IiR7Q1BQRkxBR1N9IiBcCiAJCQlDWFg9IiR7Q1hYfSIgQ1hYRkxBR1M9IiR7
 Q1hYRkxBR1N9IiBcCi0JCQlNQU5QUkVGSVg9IiR7TUFOUFJFRklYfSIKKwkJCU1BTlBSRUZJWD0i
 JHtNQU5QUkVGSVh9IiBcCisJCQlTVFJJUEJJTj0iJHtTVFJJUEJJTn0iCiAKICMgQWRkIC1mbm8t
 c3RyaWN0LWFsaWFzaW5nIHRvIENGTEFHUyB3aXRoIG9wdGltaXphdGlvbiBsZXZlbCAtTzIgb3Ig
 aGlnaGVyLgogIyBnY2MgNC54IGVuYWJsZSBzdHJpY3QgYWxpYXNpbmcgb3B0aW1pemF0aW9uIHdp
 dGggLU8yIHdoaWNoIGlzIGtub3duIHRvIGJyZWFrCkBAIC0zNzg0LDYgKzM3ODksNyBAQAogCSAg
 ICBJTlNUQUxMX0xJQj0iJHtJTlNUQUxMX0xJQn0iIFwKIAkgICAgSU5TVEFMTF9QUk9HUkFNPSIk
 e0lOU1RBTExfUFJPR1JBTX0iIFwKIAkgICAgSU5TVEFMTF9TQ1JJUFQ9IiR7SU5TVEFMTF9TQ1JJ
 UFR9IiBcCisJICAgIFNUUklQPSIke1NUUklQX0NNRH0iIFNUUklQQklOPSIke1NUUklQQklOfSIg
 XAogCSAgICAke0NPTkZJR1VSRV9FTlZ9IC4vJHtDT05GSUdVUkVfU0NSSVBUfSAke0NPTkZJR1VS
 RV9BUkdTfTsgdGhlbiBcCiAJCQkgJHtFQ0hPX01TR30gIj09PT4gIFNjcmlwdCBcIiR7Q09ORklH
 VVJFX1NDUklQVH1cIiBmYWlsZWQgdW5leHBlY3RlZGx5LiI7IFwKIAkJCSAoJHtFQ0hPX0NNRH0g
 JHtDT05GSUdVUkVfRkFJTF9NRVNTQUdFfSkgfCAke0ZNVH0gNzUgNzkgOyBcCg==
 --bcaec5431784b720f904a8b9443e--

From: "b. f." <bf1783@googlemail.com>
To: bug-followup@freebsd.org, Mark Linimon <linimon@lonesome.com>
Cc:  
Subject: Re: ports/155201: [PATCH]bsd.port.mk: fix portion of CONFIGURE_ENV
 added WITH_BINUTILS
Date: Tue, 21 Feb 2012 18:27:05 +0000

 On 7/23/11, b. f. <bf1783@googlemail.com> wrote:
 > I've attached a revised version of the patch, to account for the
 > addition of the elfedit utility in the most recent version of
 > devel/binutils, and the strip(1)-related problems uncovered by Mark in
 > his sparc64 builds.  It turns out that the proper version of strip(1)
 > also needs to be used, both explicitly and via the "-s" flag of
 > install(1), or some builds will fail. For the former, the common
 > autotools variable STRIP should be set to be STRIP_CMD in
 > CONFIGURE_ENV, and for the latter, STRIPBIN  should be set to be
 > STRIP_CMD in both CONFIGURE_ENV and MAKE_ENV.  A few ports that use
 > STRIP in a non-standard way may need to be patched.
 
 I have been working on ports/160492, which is complicated by the
 absence of the patch in ports/155201.  Could portmgr arrange to test
 the patch in ports/155201, so that we can try to solve some of the
 build problems for USE_GCC?
 
 Regards,
           b.
>Unformatted:
