From ohauer@FreeBSD.org  Mon Feb 28 00:06:53 2011
Return-Path: <ohauer@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 645AB1065691;
	Mon, 28 Feb 2011 00:06:49 +0000 (UTC)
	(envelope-from ohauer@FreeBSD.org)
Received: from u18-124.dslaccess.de (unknown [194.231.39.124])
	by mx1.freebsd.org (Postfix) with ESMTP id 189B98FC08;
	Mon, 28 Feb 2011 00:06:49 +0000 (UTC)
Message-Id: <20110228000649.645AB1065691@hub.freebsd.org>
Date: Mon, 28 Feb 2011 01:06:47 +0100 (CET)
From: olli hauer <ohauer@FreeBSD.org>
Reply-To: olli hauer <ohauer@FreeBSD.org>
To: <FreeBSD-gnats-submit@freebsd.org>
Cc: <ohauer@FreeBSD.org>
Subject: [patch] devel/maven2 add JAVA_VENDOR to Makefile
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         155108
>Category:       ports
>Synopsis:       [patch] devel/maven2 add JAVA_VENDOR to Makefile
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    hq
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Mon Feb 28 00:10:10 UTC 2011
>Closed-Date:    Wed Mar 23 07:35:27 UTC 2011
>Last-Modified:  Wed Mar 23 07:35:27 UTC 2011
>Originator:     Olli Hauer
>Release:        
>Organization:
>Environment:
System: FreeBSD d24g 8.2-RELEASE FreeBSD 8.2-RELEASE #0: Thu Feb 17 02:41:51 UTC 2011     root@mason.cse.buffalo.edu:/usr/obj/usr/src/sys/GENERIC  amd64

>Description:
Add JAVA_VENDOR to the Makefile, else the ports tries 
to build java/jdk16 in tinderbox.
With this parameter it choose java/diablo-jdk16.

>How-To-Repeat:

>Fix:

--- maven2.diff begins here ---
Index: Makefile
===================================================================
RCS file: /home/pcvs/ports/devel/maven2/Makefile,v
retrieving revision 1.17
diff -u -r1.17 Makefile
--- Makefile	12 Aug 2009 05:41:36 -0000	1.17
+++ Makefile	27 Feb 2011 23:05:40 -0000
@@ -17,6 +17,7 @@
 
 USE_JAVA=	yes
 JAVA_VERSION=	1.4+
+JAVA_VENDOR?=	freebsd
 NO_BUILD=	yes
 DATADIR=	${JAVASHAREDIR}/${PORTNAME}
 SUB_FILES=	m2.sh
--- maven2.diff ends here ---

>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->hq 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Mon Feb 28 00:10:33 UTC 2011 
Responsible-Changed-Why:  
Over to maintainer (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=155108 

From: Herve Quiroz <hq@FreeBSD.org>
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/155108: [patch] devel/maven2 add JAVA_VENDOR to Makefile
Date: Mon, 28 Feb 2011 08:31:20 +0100

 IMHO it is a bad idea to set port variables according to the preferred
 settings of a tinderbox. Either the port can build with only a specific
 JDK and thus should be setup accordingly in any case, or the port can
 build and run with several JDKs and thus the tinderbox environment has
 to adapt.
 
 For instance, with Java ports we (java@) defined a way to set your
 list of "preferred" JDK ports to build ports. In /etc/make.conf (or
 anywhere you see fit on a tinderbox) you can set the following variable:
 
 _JAVA_PREFERRED_PORTS=JAVA_PORT_NATIVE_FREEBSD_JDK_1_6
 
 This will have the java/jdk16 port selected first when not explicitly
 forbidden by a port. You may also add more JDK ports to the list. For
 example if you add the java/jdk15 port as the second preferred JDK port,
 it will be selected whenever a port required a specific 1.5 version of
 Java.
 
 To get a list of all available JDK ports:
 
 $ make -V __JAVA_PORTS_ALL
 
 Herve
State-Changed-From-To: open->closed 
State-Changed-By: hq 
State-Changed-When: Wed Mar 23 07:34:16 UTC 2011 
State-Changed-Why:  
Case closed. 


http://www.freebsd.org/cgi/query-pr.cgi?pr=155108 
>Unformatted:
