From swell.k@gmail.com  Sun Feb 27 11:19:55 2011
Return-Path: <swell.k@gmail.com>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 73716106564A
	for <FreeBSD-gnats-submit@freebsd.org>; Sun, 27 Feb 2011 11:19:55 +0000 (UTC)
	(envelope-from swell.k@gmail.com)
Received: from mail-bw0-f54.google.com (mail-bw0-f54.google.com [209.85.214.54])
	by mx1.freebsd.org (Postfix) with ESMTP id 02BE78FC0C
	for <FreeBSD-gnats-submit@freebsd.org>; Sun, 27 Feb 2011 11:19:54 +0000 (UTC)
Received: by bwz12 with SMTP id 12so3403409bwz.13
        for <FreeBSD-gnats-submit@freebsd.org>; Sun, 27 Feb 2011 03:19:53 -0800 (PST)
Received: by 10.204.72.207 with SMTP id n15mr3827716bkj.62.1298805592269;
        Sun, 27 Feb 2011 03:19:52 -0800 (PST)
Received: from localhost ([46.28.108.24])
        by mx.google.com with ESMTPS id v25sm1700911bkt.6.2011.02.27.03.19.48
        (version=SSLv3 cipher=OTHER);
        Sun, 27 Feb 2011 03:19:51 -0800 (PST)
Message-Id: <86ei6tk9mr.fsf@gmail.com>
Date: Sun, 27 Feb 2011 14:19:24 +0300
From: Anonymous <swell.k@gmail.com>
To: FreeBSD-gnats-submit@freebsd.org
Subject: [rc.d][patch] net-p2p/transmission-daemon: don't override conf_dir and download_dir unconditionally

>Number:         155081
>Category:       ports
>Synopsis:       [patch] net-p2p/transmission-daemon: don't override conf_dir and download_dir unconditionally
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    mezz
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sun Feb 27 11:20:09 UTC 2011
>Closed-Date:    Sat Mar 05 04:18:16 UTC 2011
>Last-Modified:  Sat Mar  5 04:20:17 UTC 2011
>Originator:     Anonymous
>Release:        FreeBSD 9.0-CURRENT amd64
>Organization:
>Environment:
# transmission-daemon-2.21
transmission_enable=YES
transmission_conf_dir= # default
transmission_download_dir= # config or default
>Description:
Initializing value with `:=' ensures such a variable can be neither
undefined nor null. And `${foo:+-f ${foo}}' in transmission_flags always
expands with the right string, it could be reduced to just `-f ${foo}'.

So, by defining empty conf_dir and/or download_dir transmission should
infer default values from home directory, i.e. TRANSMISSION_HOME,
XDG_CONFIG_HOME, HOME in libtransmission/platform.c) and download_dir
from config file, too.

This is similar to how watch_dir is used which can be empty, too, while
at the same time it can be defined via config file.
>How-To-Repeat:
>Fix:
--- a.diff begins here ---
Index: net-p2p/transmission-cli/files/transmission.in
===================================================================
RCS file: /a/.cvsup/ports/net-p2p/transmission-cli/files/transmission.in,v
retrieving revision 1.3
diff -u -p -r1.3 transmission.in
--- net-p2p/transmission-cli/files/transmission.in	27 Mar 2010 00:14:31 -0000	1.3
+++ net-p2p/transmission-cli/files/transmission.in	27 Feb 2011 02:42:57 -0000
@@ -33,8 +33,8 @@ load_rc_config ${name}
 
 : ${transmission_enable:="NO"}
 : ${transmission_user:="transmission"}
-: ${transmission_conf_dir:="%%PREFIX%%/etc/transmission/home"}
-: ${transmission_download_dir:="%%PREFIX%%/etc/transmission/home/Downloads"}
+: ${transmission_conf_dir="%%PREFIX%%/etc/transmission/home"}
+: ${transmission_download_dir="%%PREFIX%%/etc/transmission/home/Downloads"}
 
 transmission_flags=" \
 	${transmission_watch_dir:+-c ${transmission_watch_dir}} \
--- a.diff ends here ---
>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->mezz 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Sun Feb 27 11:20:19 UTC 2011 
Responsible-Changed-Why:  
Over to maintainer (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=155081 

From: Jeremy Messenger <mezz.freebsd@gmail.com>
To: bug-followup@FreeBSD.org, swell.k@gmail.com
Cc:  
Subject: Re: ports/155081: [patch] net-p2p/transmission-daemon: don't override
 conf_dir and download_dir unconditionally
Date: Mon, 28 Feb 2011 17:27:48 -0600

 Thanks, I have patched it in my system with 2.21. Do you want to test
 transmission-daemon 2.21? I am not a transmission-daemon user, so
 probably best for someone that know more transmission-daemon to test
 it for me. Feel free to send me more patches for transmission-daemon
 if you have any.
 
 http://people.freebsd.org/~mezz/diff/transmission-2.21.diff
 
 Cheers,
 Mezz
 
 
 -- 
 mezz.freebsd@gmail.com - mezz@FreeBSD.org
 FreeBSD GNOME Team
 http://www.FreeBSD.org/gnome/ - gnome@FreeBSD.org
State-Changed-From-To: open->closed 
State-Changed-By: mezz 
State-Changed-When: Sat Mar 5 04:18:03 UTC 2011 
State-Changed-Why:  
Committed, thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=155081 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/155081: commit references a PR
Date: Sat,  5 Mar 2011 04:17:37 +0000 (UTC)

 mezz        2011-03-05 04:17:28 UTC
 
   FreeBSD ports repository
 
   Modified files:
     net-p2p/transmission Makefile 
     net-p2p/transmission-cli Makefile distinfo 
     net-p2p/transmission-cli/files patch-fix_without_ipv6 
                                    transmission.in 
   Added files:
     net-p2p/transmission-cli/files patch-daemon_remote.c 
                                    patch-gtk_tr-prefs.c 
                                    patch-libtransmission_torrent.c 
   Log:
   - Update to 2.22.
   - Don't override conf_dir and download_dir unconditionally [1]
   - Don't use localhost default by replace to 127.0.0.1 for IPv6 issue as
     transmission-remote doesn't support IPv6 yet. [2]
   
   PR:             ports/155081 [1]
                   ports/155139 [2]
   Submitted by:   Anonymous <swell.k@gmail.com> [1][2]
   
   Revision  Changes    Path
   1.74      +2 -2      ports/net-p2p/transmission-cli/Makefile
   1.53      +2 -2      ports/net-p2p/transmission-cli/distinfo
   1.1       +11 -0     ports/net-p2p/transmission-cli/files/patch-daemon_remote.c (new)
   1.2       +9 -9      ports/net-p2p/transmission-cli/files/patch-fix_without_ipv6
   1.1       +11 -0     ports/net-p2p/transmission-cli/files/patch-gtk_tr-prefs.c (new)
   1.3       +10 -0     ports/net-p2p/transmission-cli/files/patch-libtransmission_torrent.c (new)
   1.4       +3 -3      ports/net-p2p/transmission-cli/files/transmission.in
   1.70      +1 -1      ports/net-p2p/transmission/Makefile
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
