From nobody@FreeBSD.org  Sun Feb 13 21:50:07 2011
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 70FCE106564A
	for <freebsd-gnats-submit@FreeBSD.org>; Sun, 13 Feb 2011 21:50:07 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22])
	by mx1.freebsd.org (Postfix) with ESMTP id 5F86A8FC16
	for <freebsd-gnats-submit@FreeBSD.org>; Sun, 13 Feb 2011 21:50:07 +0000 (UTC)
Received: from red.freebsd.org (localhost [127.0.0.1])
	by red.freebsd.org (8.14.4/8.14.4) with ESMTP id p1DLo6E0056154
	for <freebsd-gnats-submit@FreeBSD.org>; Sun, 13 Feb 2011 21:50:06 GMT
	(envelope-from nobody@red.freebsd.org)
Received: (from nobody@localhost)
	by red.freebsd.org (8.14.4/8.14.4/Submit) id p1DLo6O9056153;
	Sun, 13 Feb 2011 21:50:06 GMT
	(envelope-from nobody)
Message-Id: <201102132150.p1DLo6O9056153@red.freebsd.org>
Date: Sun, 13 Feb 2011 21:50:06 GMT
From: Antoine Martin <antoine@nagafix.co.uk>
To: freebsd-gnats-submit@FreeBSD.org
Subject: existing pygtk patch needs to be applied
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         154755
>Category:       ports
>Synopsis:       existing x11-toolkits/py-gtk2 patch needs to be applied
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    gnome
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sun Feb 13 22:00:18 UTC 2011
>Closed-Date:    Mon Feb 28 11:32:17 UTC 2011
>Last-Modified:  Mon Feb 28 11:32:17 UTC 2011
>Originator:     Antoine Martin
>Release:        8.1
>Organization:
devloop
>Environment:
>Description:
See this upstream bug (includes the patch):

https://bugzilla.gnome.org/show_bug.cgi?id=640738
>How-To-Repeat:
import signal
import gtk

signal.signal(signal.SIGCHLD, lambda *args: None)
gtk.main()

Run it, send it SIGCHLD.  CPU usage goes to 100%.
>Fix:
diff --git a/gtk/gtk.override b/gtk/gtk.override
index 75018f4..7261d9c 100644
--- a/gtk/gtk.override
+++ b/gtk/gtk.override
@@ -1152,8 +1152,9 @@ pygtk_main_watch_check(GSource *source)
     PySignalWatchSource *real_source = (PySignalWatchSource *)source;
     GPollFD *poll_fd = &real_source->fd;
     int data_size = 0;
+    char dummy;
     if (poll_fd->revents & G_IO_IN)
-        data_size = read(poll_fd->fd, 0, 1);
+        data_size = read(poll_fd->fd, &dummy, 1);
 #endif
 
     state = pyg_gil_state_ensure();

>Release-Note:
>Audit-Trail:

From: Mark Linimon <linimon@lonesome.com>
To: Antoine Martin <antoine@nagafix.co.uk>
Cc: freebsd-gnats-submit@FreeBSD.org
Subject: Re: misc/154755: existing pygtk patch needs to be applied
Date: Sun, 13 Feb 2011 16:15:02 -0600

 To which port does this PR apply?
Responsible-Changed-From-To: freebsd-bugs->freebsd-ports-bugs 
Responsible-Changed-By: brucec 
Responsible-Changed-When: Sun Feb 13 22:32:02 UTC 2011 
Responsible-Changed-Why:  
Ports PR. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=154755 
Responsible-Changed-From-To: freebsd-ports-bugs->gnome 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Sun Feb 13 22:34:20 UTC 2011 
Responsible-Changed-Why:  
Over to maintainer (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=154755 

From: Antoine Martin <antoine@nagafix.co.uk>
To: Mark Linimon <linimon@lonesome.com>
Cc: freebsd-gnats-submit@FreeBSD.org
Subject: Re: misc/154755: existing pygtk patch needs to be applied
Date: Sun, 13 Feb 2011 23:26:37 +0100

 On 02/13/2011 11:15 PM, Mark Linimon wrote:
 > To which port does this PR apply?
 Sorry about that, I meant to include the info. doh!
 It is py-gtk2:
 
 http://www.freebsd.org/cgi/cvsweb.cgi/ports/x11-toolkits/py-gtk2/
 
 Cheers
 Antoine
State-Changed-From-To: open->closed 
State-Changed-By: kwm 
State-Changed-When: Mon Feb 28 11:32:01 UTC 2011 
State-Changed-Why:  
Committed thanks. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=154755 
>Unformatted:
