From dscheidt@shell-3.enteract.com  Sun Dec 12 14:47:05 1999
Return-Path: <dscheidt@shell-3.enteract.com>
Received: from mail.enteract.com (mail.enteract.com [207.229.143.33])
	by hub.freebsd.org (Postfix) with ESMTP id DC36614E73
	for <FreeBSD-gnats-submit@freebsd.org>; Sun, 12 Dec 1999 14:47:04 -0800 (PST)
	(envelope-from dscheidt@shell-3.enteract.com)
Received: from shell-3.enteract.com (dscheidt@shell-3.enteract.com [207.229.143.42])
	by mail.enteract.com (8.9.3/8.9.3) with ESMTP id QAA81503
	for <FreeBSD-gnats-submit@freebsd.org>; Sun, 12 Dec 1999 16:46:58 -0600 (CST)
	(envelope-from dscheidt@shell-3.enteract.com)
Received: (from dscheidt@localhost)
	by shell-3.enteract.com (8.9.3/8.9.3) id QAA45895;
	Sun, 12 Dec 1999 16:46:58 -0600 (CST)
	(envelope-from dscheidt)
Message-Id: <199912122246.QAA45895@shell-3.enteract.com>
Date: Sun, 12 Dec 1999 16:46:58 -0600 (CST)
From: dscheidt@enteract.com
Sender: dscheidt@shell-3.enteract.com
Reply-To: dscheidt@enteract.com
To: FreeBSD-gnats-submit@freebsd.org
Subject: Patch for ports/games/nethack
X-Send-Pr-Version: 3.2

>Number:         15442
>Category:       ports
>Synopsis:       upgrade of nethack port to 3.2.3, which has y2k patches,
>Confidential:   no
>Severity:       serious
>Priority:       low
>Responsible:    freebsd-ports
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Sun Dec 12 14:50:00 PST 1999
>Closed-Date:    Tue Jan 4 19:06:56 PST 2000
>Last-Modified:  Tue Jan  4 19:07:08 PST 2000
>Originator:     David Scheidt
>Release:        FreeBSD 3.3-STABLE i386
>Organization:
random FreeBSD adventure game players
>Environment:

>Description:

	nethack 3.2.2 has a y2k bug in its save game format.  Dates are saved
with  two digit years.  Bad things happen if you append to the save file
following 1 jan 2000.  

>How-To-Repeat:

	

>Fix:
	
	Apply this patch:


Index: Makefile
===================================================================
RCS file: /home/ncvs/ports/games/nethack/Makefile,v
retrieving revision 1.22
diff -u -r1.22 Makefile
--- Makefile	1999/08/31 06:44:17	1.22
+++ Makefile	1999/12/12 22:35:38
@@ -16,6 +16,8 @@
 
 LIB_DEPENDS=	Xpm.4:${PORTSDIR}/graphics/xpm
 
+PATCHFILES=	nh-3.2.2-3.2.3.diff
+PATCH_SITES=	ftp://ftp.nethack.org/pub/nethack/oldver/3.2.3/src/
 USE_GMAKE=	yes
 MAN6=		dgn_comp.6 dlb.6 lev_comp.6 nethack.6 recover.6
 
Index: files/md5
===================================================================
RCS file: /home/ncvs/ports/games/nethack/files/md5,v
retrieving revision 1.4
diff -u -r1.4 md5
--- md5	1996/12/23 02:29:36	1.4
+++ md5	1999/12/12 22:36:42
@@ -1 +1,2 @@
 MD5 (nethack-3.2.2.tar.gz) = c85de4d14453b3a2d182d1dfc2ca04df
+MD5 (nh-3.2.2-3.2.3.diff) = 440141990df326d5a973d890179cffae


>Release-Note:
>Audit-Trail:

From: Brian Handy <handy@lambic.physics.montana.edu>
To: dscheidt@enteract.com
Cc: FreeBSD-gnats-submit@FreeBSD.ORG
Subject: Re: ports/15442: Patch for ports/games/nethack
Date: Sun, 12 Dec 1999 16:11:33 -0700 (MST)

 >>Number:         15442
 >>Category:       ports
 >>Synopsis:       upgrade of nethack port to 3.2.3, which has y2k patches,
 
 3.3.0 was just released, it was announced on slashdot.  I tried upgrading
 the port to that, but the compile crash-landed and I don't yet understand
 why...something funny in the tty/termcap stuff.  Probably pilot error on
 my part, but probably worth upgrading all the way to 3.3.0 once someone
 figures it out.
 
 Regards,
 
 Brian
 
 

From: David Scheidt <dscheidt@enteract.com>
To: Brian Handy <handy@lambic.physics.montana.edu>
Cc: FreeBSD-gnats-submit@FreeBSD.ORG
Subject: Re: ports/15442: Patch for ports/games/nethack
Date: Sun, 12 Dec 1999 18:11:34 -0600 (CST)

 On Sun, 12 Dec 1999, Brian Handy wrote:
 
 > >>Number:         15442
 > >>Category:       ports
 > >>Synopsis:       upgrade of nethack port to 3.2.3, which has y2k patches,
 > 
 > 3.3.0 was just released, it was announced on slashdot.  I tried upgrading
 > the port to that, but the compile crash-landed and I don't yet understand
 > why...something funny in the tty/termcap stuff.  Probably pilot error on
 > my part, but probably worth upgrading all the way to 3.3.0 once someone
 > figures it out.
 
 3.3.0 has a bunch of changes to it.  They have seperated out character class
 from race, for instance.  The net effect is that the saved-game files are
 not compatible.  So I think there needs to be both a 3.2.3 and 3.3.0
 version.  I'll take a look at 3.3.0, and seee if I can get it built.  
 
 David Scheidt
 
 

From: asami@FreeBSD.org (Satoshi - Ports Wraith - Asami)
To: David Scheidt <dscheidt@enteract.com>
Cc: freebsd-gnats-submit@FreeBSD.org
Subject: Re: ports/15442: Patch for ports/games/nethack
Date: 12 Dec 1999 23:47:00 -0800

  * From: David Scheidt <dscheidt@enteract.com>
 
  *  3.3.0 has a bunch of changes to it.  They have seperated out character class
  *  from race, for instance.  The net effect is that the saved-game files are
  *  not compatible.  So I think there needs to be both a 3.2.3 and 3.3.0
  *  version.  I'll take a look at 3.3.0, and seee if I can get it built.  
 
 Ok.  Please let me know when you have a 3.3.0 port ready, and I'll do
 a repo copy.
 
 -PW
 

From: David Scheidt <dscheidt@enteract.com>
To: Satoshi - Ports Wraith - Asami <asami@FreeBSD.org>
Cc: freebsd-gnats-submit@FreeBSD.org
Subject: Re: ports/15442: Patch for ports/games/nethack
Date: Mon, 13 Dec 1999 14:36:29 -0600 (CST)

 On 12 Dec 1999, Satoshi - Ports Wraith - Asami wrote:
 
 >  * From: David Scheidt <dscheidt@enteract.com>
 > 
 >  *  3.3.0 has a bunch of changes to it.  They have seperated out character class
 >  *  from race, for instance.  The net effect is that the saved-game files are
 >  *  not compatible.  So I think there needs to be both a 3.2.3 and 3.3.0
 >  *  version.  I'll take a look at 3.3.0, and seee if I can get it built.  
 > 
 > Ok.  Please let me know when you have a 3.3.0 port ready, and I'll do
 > a repo copy.
 
 The port is in pr ports/15469 .
 
 I must say that I am very impressed with how slick the ports makefiles are.
 Very cool.
 
 Regards,
 
 David
 > 
 > -PW
 > 
 > 
 
 
 
State-Changed-From-To: open->closed  
State-Changed-By: cpiazza 
State-Changed-When: Tue Jan 4 19:06:56 PST 2000 
State-Changed-Why:  
Committed, thanks! 
>Unformatted:
 plus bug fixes
