From nobody@FreeBSD.org  Sun Jan 30 15:18:05 2011
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id F189F1065675
	for <freebsd-gnats-submit@FreeBSD.org>; Sun, 30 Jan 2011 15:18:05 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22])
	by mx1.freebsd.org (Postfix) with ESMTP id E28038FC19
	for <freebsd-gnats-submit@FreeBSD.org>; Sun, 30 Jan 2011 15:18:05 +0000 (UTC)
Received: from red.freebsd.org (localhost [127.0.0.1])
	by red.freebsd.org (8.14.4/8.14.4) with ESMTP id p0UFI5bT043989
	for <freebsd-gnats-submit@FreeBSD.org>; Sun, 30 Jan 2011 15:18:05 GMT
	(envelope-from nobody@red.freebsd.org)
Received: (from nobody@localhost)
	by red.freebsd.org (8.14.4/8.14.4/Submit) id p0UFI5Uc043988;
	Sun, 30 Jan 2011 15:18:05 GMT
	(envelope-from nobody)
Message-Id: <201101301518.p0UFI5Uc043988@red.freebsd.org>
Date: Sun, 30 Jan 2011 15:18:05 GMT
From: Eitan Adler <lists@eitanadler.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: [patch] remove obsolete 
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         154395
>Category:       ports
>Synopsis:       [bsd.gnustep.mk] [patch] remove obsolete variables
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    dinoex
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sun Jan 30 15:20:10 UTC 2011
>Closed-Date:    Mon Mar 14 06:32:14 CET 2011
>Last-Modified:  Mon Mar 14 06:32:14 CET 2011
>Originator:     Eitan Adler
>Release:        
>Organization:
>Environment:
>Description:
grep -ER "{(SYSTEM|SYSLIB|LOCALLIB)DIR" /usr/ports
turns up only one port which depends on the 4 obsolete variables defined in bsd.gnustep.mk

I do not use gnustep so I am unable to test the following patch but the touched port along with a few other gnustep ports seem ok.
>How-To-Repeat:

>Fix:
Index: Mk/bsd.gnustep.mk
===================================================================
RCS file: /home/ncvs/ports/Mk/bsd.gnustep.mk,v
retrieving revision 1.63
diff -u -r1.63 bsd.gnustep.mk
--- Mk/bsd.gnustep.mk	11 Jun 2010 09:12:37 -0000	1.63
+++ Mk/bsd.gnustep.mk	30 Jan 2011 14:48:27 -0000
@@ -189,12 +189,6 @@
 GNUSTEP_LOCAL_TOOLS=		${GNUSTEP_LOCAL_ROOT}/Tools
 GNUSTEP_LOCAL_SERVICES=		${GNUSTEP_LOCAL_ROOT}/Library/Services
 
-# Obsolete, for compatibility only
-SYSTEMDIR=	${GNUSTEP_SYSTEM_ROOT}
-SYSMAKEDIR=	${GNUSTEP_MAKEFILES}
-SYSLIBDIR=	${GNUSTEP_SYSTEM_LIBRARIES}
-LOCALLIBDIR=	${GNUSTEP_LOCAL_LIBRARIES}
-
 .if defined(WITH_GNUSTEP_DEVEL)
 PKGNAMESUFFIX?=	-devel${PKGNAMESUFFIX2}
 PLIST_SUB+=	GNUSTEP_DEVEL=""
Index: Makefile
===================================================================
RCS file: /home/ncvs/ports/x11-themes/etoile-camaelon/Makefile,v
retrieving revision 1.14
diff -u -r1.14 Makefile
--- Makefile	5 Jun 2010 06:14:27 -0000	1.14
+++ Makefile	30 Jan 2011 14:54:14 -0000
@@ -36,9 +36,9 @@
 	@${CAT} ${PKGMESSAGE}
 
 install-user:
-	@(. ${SYSMAKEDIR}/GNUstep.sh && defaults write Camaelon Theme Nesedah)
+	@(. ${GNUSTEP_MAKEFILES}/GNUstep.sh && defaults write Camaelon Theme Nesedah)
 
 deinstall-user:
-	@(. ${SYSMAKEDIR}/GNUstep.sh && defaults delete Camaelon Theme)
+	@(. ${GNUSTEP_MAKEFILES}/GNUstep.sh && defaults delete Camaelon Theme)
 
 .include <bsd.port.mk>


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->dinoex 
Responsible-Changed-By: linimon 
Responsible-Changed-When: Sun Jan 30 20:35:26 UTC 2011 
Responsible-Changed-Why:  
Fix synopsis and assign. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=154395 
State-Changed-From-To: open->suspended 
State-Changed-By: dinoex 
State-Changed-When: Sun Jan 30 21:43:54 CET 2011 
State-Changed-Why:  
- this needs an exp run, after the freeze is over 

http://www.freebsd.org/cgi/query-pr.cgi?pr=154395 
State-Changed-From-To: suspended->patched 
State-Changed-By: dinoex 
State-Changed-When: Thu Mar 10 06:34:24 CET 2011 
State-Changed-Why:  
in progress 

http://www.freebsd.org/cgi/query-pr.cgi?pr=154395 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/154395: commit references a PR
Date: Thu, 10 Mar 2011 05:33:29 +0000 (UTC)

 dinoex      2011-03-10 05:33:14 UTC
 
   FreeBSD ports repository
 
   Modified files:
     x11-themes/etoile-camaelon Makefile 
   Log:
   - use GNUSTEP_MAKEFILES
   PR:             154395
   Submitted by:   Eitan Adler
   
   Revision  Changes    Path
   1.15      +2 -2      ports/x11-themes/etoile-camaelon/Makefile
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/154395: commit references a PR
Date: Sun, 13 Mar 2011 20:35:21 +0000 (UTC)

 dinoex      2011-03-13 20:35:12 UTC
 
   FreeBSD ports repository
 
   Modified files:
     Mk                   bsd.gnustep.mk 
   Log:
   - remove obsolete variables
   PR:             154395
   Submitted by:   Eitan Adler
   
   Revision  Changes    Path
   1.64      +1 -7      ports/Mk/bsd.gnustep.mk
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: patched->closed 
State-Changed-By: dinoex 
State-Changed-When: Mon Mar 14 06:31:56 CET 2011 
State-Changed-Why:  
committed, thanks. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=154395 
>Unformatted:
