From nobody@FreeBSD.org  Fri Jan 28 23:48:46 2011
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id A2012106564A
	for <freebsd-gnats-submit@FreeBSD.org>; Fri, 28 Jan 2011 23:48:46 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22])
	by mx1.freebsd.org (Postfix) with ESMTP id 919938FC17
	for <freebsd-gnats-submit@FreeBSD.org>; Fri, 28 Jan 2011 23:48:46 +0000 (UTC)
Received: from red.freebsd.org (localhost [127.0.0.1])
	by red.freebsd.org (8.14.4/8.14.4) with ESMTP id p0SNmktP054311
	for <freebsd-gnats-submit@FreeBSD.org>; Fri, 28 Jan 2011 23:48:46 GMT
	(envelope-from nobody@red.freebsd.org)
Received: (from nobody@localhost)
	by red.freebsd.org (8.14.4/8.14.4/Submit) id p0SNmkts054310;
	Fri, 28 Jan 2011 23:48:46 GMT
	(envelope-from nobody)
Message-Id: <201101282348.p0SNmkts054310@red.freebsd.org>
Date: Fri, 28 Jan 2011 23:48:46 GMT
From: Stephen Fisher <steve@stephen-fisher.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: glib20 port: add support for --enable-debug=yes
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         154362
>Category:       ports
>Synopsis:       devel/glib20: add support for --enable-debug=yes
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    gnome
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Fri Jan 28 23:50:09 UTC 2011
>Closed-Date:    Mon Mar 14 21:30:20 UTC 2011
>Last-Modified:  Mon Mar 14 21:40:10 UTC 2011
>Originator:     Stephen Fisher
>Release:        8.1-RELEASE
>Organization:
>Environment:
FreeBSD xxx 8.1-RELEASE FreeBSD 8.1-RELEASE #0: Mon Jul 19 02:36:49 UTC 2010     root@mason.cse.buffalo.edu:/usr/obj/usr/src/sys/GENERIC  amd64
>Description:
This patch adds an option to the glib20 port's Makefile to pass "--enable-debug=yes" to the configure script when WITH_DEBUG is defined.  I've also added a port option to enable this.

>How-To-Repeat:
n/a
>Fix:
Apply the attached patch




Patch attached with submission follows:

--- Makefile.orig	2011-01-28 16:38:23.000000000 -0700
+++ Makefile	2011-01-28 16:32:55.000000000 -0700
@@ -52,7 +52,8 @@
 		PTHREAD_CFLAGS="${PTHREAD_CFLAGS}" \
 		PTHREAD_LIBS="${PTHREAD_LIBS}"
 
-OPTIONS=	COLLATION_FIX "fix string collation" off
+OPTIONS=	COLLATION_FIX "fix string collation" off \
+		DEBUG "Turn on debugging" off
 
 .include <bsd.port.pre.mk>
 
@@ -78,6 +79,10 @@
 #CONFIGURE_ENV+=	CFLAGS="-D__STDC_ISO_10646__"
 .endif
 
+.if defined(WITH_DEBUG)
+CONFIGURE_ARGS+=	--enable-debug=yes
+.endif
+
 post-patch:
 	@${REINPLACE_CMD} -e 's|/usr/local|${LOCALBASE}|g' \
 		${WRKSRC}/glib/gutils.c


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->gnome 
Responsible-Changed-By: linimon 
Responsible-Changed-When: Fri Jan 28 23:52:00 UTC 2011 
Responsible-Changed-Why:  
Fix synopsis and assign. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=154362 
State-Changed-From-To: open->closed 
State-Changed-By: mezz 
State-Changed-When: Mon Mar 14 21:30:03 UTC 2011 
State-Changed-Why:  
Committed, thanks! As for the WITH_DEBUG in OPTIONS. It's not need, because 
the WITH_DEBUG is a standard option in all ports by look at bsd.port.mk. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=154362 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/154362: commit references a PR
Date: Mon, 14 Mar 2011 21:30:19 +0000 (UTC)

 mezz        2011-03-14 21:29:56 UTC
 
   FreeBSD ports repository
 
   Modified files:
     devel/glib20         Makefile 
   Log:
   Add --enable-debug=yes in WITH_DEBUG to add more debug stuff.
   
   PR:             ports/154362
   Submitted by:   Stephen Fisher <steve@stephen-fisher.com>
   
   Revision  Changes    Path
   1.175     +4 -0      ports/devel/glib20/Makefile
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
