From nobody@FreeBSD.org  Sat Jan  8 14:54:11 2011
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 9C13010656D3
	for <freebsd-gnats-submit@FreeBSD.org>; Sat,  8 Jan 2011 14:54:11 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from red.freebsd.org (unknown [IPv6:2001:4f8:fff6::22])
	by mx1.freebsd.org (Postfix) with ESMTP id 8C2968FC08
	for <freebsd-gnats-submit@FreeBSD.org>; Sat,  8 Jan 2011 14:54:11 +0000 (UTC)
Received: from red.freebsd.org (localhost [127.0.0.1])
	by red.freebsd.org (8.14.4/8.14.4) with ESMTP id p08EsBhG019671
	for <freebsd-gnats-submit@FreeBSD.org>; Sat, 8 Jan 2011 14:54:11 GMT
	(envelope-from nobody@red.freebsd.org)
Received: (from nobody@localhost)
	by red.freebsd.org (8.14.4/8.14.4/Submit) id p08EsAvJ019643;
	Sat, 8 Jan 2011 14:54:10 GMT
	(envelope-from nobody)
Message-Id: <201101081454.p08EsAvJ019643@red.freebsd.org>
Date: Sat, 8 Jan 2011 14:54:10 GMT
From: Aldis Berjoza <aldis@bsdroot.lv>
To: freebsd-gnats-submit@FreeBSD.org
Subject: [PATHC] improve devel/violet port
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         153794
>Category:       ports
>Synopsis:       [patch] improve devel/violet port
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    sunpoet
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          maintainer-update
>Submitter-Id:   current-users
>Arrival-Date:   Sat Jan 08 15:00:16 UTC 2011
>Closed-Date:    Sat Jan 08 17:16:06 UTC 2011
>Last-Modified:  Sat Jan 08 17:41:21 UTC 2011
>Originator:     Aldis Berjoza
>Release:        
>Organization:
>Environment:
>Description:
In previous version violet wrapper script made violet run in background
I think it was wrong decision.
I think it's better to let user decide if he want to run violet in backround (when starting violet in shell)

Anyway look at the patch (it's very simple and explains everything) :_
>How-To-Repeat:

>Fix:


Patch attached with submission follows:

diff -u violet.bak/Makefile violet/Makefile
--- violet.bak/Makefile	2011-01-08 16:50:02.684879092 +0200
+++ violet/Makefile	2011-01-08 16:50:30.773804804 +0200
@@ -7,6 +7,7 @@
 
 PORTNAME=	violet
 PORTVERSION=	0.21.1
+PORTREVISION=	1
 CATEGORIES=	devel editors java
 MASTER_SITES=	SF/${PORTNAME}/violetumleditor/${PORTVERSION}
 DISTNAME=	com.horstmann.violet-${PORTVERSION}
@@ -28,7 +29,7 @@
 
 pre-install:
 	${ECHO} "#!/bin/sh" > ${WRKDIR}/violet.sh
-	${ECHO} "${PREFIX}/bin/java -jar ${JAVASHAREDIR}/${PORTNAME}/com.horstmann.violet.jar &" >> ${WRKDIR}/violet.sh
+	${ECHO} "${PREFIX}/bin/java -jar ${JAVASHAREDIR}/${PORTNAME}/com.horstmann.violet.jar" >> ${WRKDIR}/violet.sh
 
 do-install:
 	${MKDIR} ${JAVASHAREDIR}/${PORTNAME}


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->sunpoet 
Responsible-Changed-By: sunpoet 
Responsible-Changed-When: Sat Jan 8 16:02:55 UTC 2011 
Responsible-Changed-Why:  
I will take it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=153794 
State-Changed-From-To: open->closed 
State-Changed-By: sunpoet 
State-Changed-When: Sat Jan 8 17:16:05 UTC 2011 
State-Changed-Why:  
Committed. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=153794 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/153794: commit references a PR
Date: Sat,  8 Jan 2011 17:15:54 +0000 (UTC)

 sunpoet     2011-01-08 17:15:48 UTC
 
   FreeBSD ports repository
 
   Modified files:
     devel/violet         Makefile 
   Log:
   - Do not force violet wrapper to run in background
   - Bump PORTREVISION
   
   PR:             ports/153794
   Submitted by:   Aldis Berjoza <aldis@bsdroot.lv> (maintainer)
   
   Revision  Changes    Path
   1.2       +2 -1      ports/devel/violet/Makefile
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
