From swell.k@gmail.com  Fri Jan  7 14:56:28 2011
Return-Path: <swell.k@gmail.com>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 74B1C106566C
	for <FreeBSD-gnats-submit@freebsd.org>; Fri,  7 Jan 2011 14:56:28 +0000 (UTC)
	(envelope-from swell.k@gmail.com)
Received: from mail-ww0-f50.google.com (mail-ww0-f50.google.com [74.125.82.50])
	by mx1.freebsd.org (Postfix) with ESMTP id 0C5908FC14
	for <FreeBSD-gnats-submit@freebsd.org>; Fri,  7 Jan 2011 14:56:27 +0000 (UTC)
Received: by wwf26 with SMTP id 26so17259433wwf.31
        for <FreeBSD-gnats-submit@freebsd.org>; Fri, 07 Jan 2011 06:56:27 -0800 (PST)
Received: by 10.227.126.204 with SMTP id d12mr16015676wbs.174.1294412186896;
        Fri, 07 Jan 2011 06:56:26 -0800 (PST)
Received: from localhost ([188.72.223.162])
        by mx.google.com with ESMTPS id 11sm17724310wbj.7.2011.01.07.06.56.24
        (version=SSLv3 cipher=RC4-MD5);
        Fri, 07 Jan 2011 06:56:25 -0800 (PST)
Message-Id: <86vd20yd7y.fsf@gmail.com>
Date: Fri, 07 Jan 2011 17:56:17 +0300
From: Anonymous <swell.k@gmail.com>
To: FreeBSD-gnats-submit@freebsd.org
Subject: [patch] multimedia/vlc: don't link against librt for sem_init(3)

>Number:         153764
>Category:       ports
>Synopsis:       [patch] multimedia/vlc: don't link against librt for sem_init(3)
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    jsa
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Fri Jan 07 15:00:13 UTC 2011
>Closed-Date:    Sun Jan 30 00:52:55 UTC 2011
>Last-Modified:  Sun Jan 30 01:00:18 UTC 2011
>Originator:     Anonymous
>Release:        FreeBSD 9.0-CURRENT amd64
>Organization:
>Environment:
>Description:
>How-To-Repeat:
>Fix:
--- a.diff begins here ---
Index: multimedia/vlc/Makefile
===================================================================
RCS file: /a/.cvsup/ports/multimedia/vlc/Makefile,v
retrieving revision 1.250
diff -u -p -r1.250 Makefile
--- multimedia/vlc/Makefile	30 Dec 2010 19:19:14 -0000	1.250
+++ multimedia/vlc/Makefile	7 Jan 2011 14:48:59 -0000
@@ -661,6 +685,7 @@ CONFIGURE_ARGS+=--disable-zvbi
 
 post-patch:
 	@${REINPLACE_CMD} -e 's|/usr/local|${LOCALBASE}|g' \
+		-e '\|LIBS|s|-lrt||' \
 		${WRKSRC}/configure
 	@${REINPLACE_CMD} -e 's|/usr/share/fonts/truetype/freefont/FreeSerifBold.ttf|${WITH_VLC_DEFAULT_FONT}|' \
 		${WRKSRC}/modules/misc/freetype.c
--- a.diff ends here ---
>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->jsa 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Fri Jan 7 15:00:21 UTC 2011 
Responsible-Changed-Why:  
Over to maintainer (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=153764 
State-Changed-From-To: open->feedback 
State-Changed-By: jsa 
State-Changed-When: Wed Jan 12 01:15:07 UTC 2011 
State-Changed-Why:  
Requires more details. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=153764 

From: "Joseph S. Atkinson" <jsa@FreeBSD.org>
To: bug-followup@FreeBSD.org, swell.k@gmail.com
Cc:  
Subject: Re: ports/153764: [patch] multimedia/vlc: don't link against librt
 for sem_init(3)
Date: Tue, 11 Jan 2011 20:02:47 -0500

 Can you explain a bit while you feel this change is necessary?

From: Anonymous <swell.k@gmail.com>
To: "Joseph S. Atkinson" <jsa@FreeBSD.org>
Cc: bug-followup@FreeBSD.org
Subject: Re: ports/153764: [patch] multimedia/vlc: don't link against librt for sem_init(3)
Date: Wed, 12 Jan 2011 06:02:39 +0300

 "Joseph S. Atkinson" <jsa@FreeBSD.org> writes:
 
 > Can you explain a bit while you feel this change is necessary?
 
 AC_CHECK_LIB() unlike AC_SEARCH_LIBS() doesn't search function in
 default library first, i.e. libc.
 
   AC_CHECK_LIB(rt, clock_nanosleep, [
     VLC_ADD_LIBS([libvlccore],[-lrt])
     AC_DEFINE(HAVE_CLOCK_NANOSLEEP, 1, [Define to 1 if you have clock_nanosleep.])
   ], [
     dnl HP/UX port
     AC_CHECK_LIB(rt,sem_init, [VLC_ADD_LIBS([libvlccore],[-lrt])])
   ])
 
 But FreeBSD is neither HP/UX and doesn't have any sem_* symbols in
 librt[1] nor it has sem_overview(7) like linux that states
 
   Programs using the POSIX semaphores API must be compiled with cc
   -lrt to link against the real-time library, librt.
 
 And sem_init(3) manpage has only -lc.
 
 For example, nanosleep() check just after does it right
 
   have_nanosleep=false
   AC_CHECK_FUNCS(nanosleep,have_nanosleep=:,[
     AC_CHECK_LIB(rt,nanosleep,
       [VLC_ADD_LIBS([libvlccore],[-lrt]) have_nanosleep=:],
       [AC_CHECK_LIB(posix4,nanosleep,
           [VLC_ADD_LIBS([libvlccore],[-lposix4]) have_nanosleep=:])]
     )
   ])
 
 So, sem_init check at least could look like
 
 %%
 @@ -800,8 +800,9 @@ AC_CHECK_LIB(rt, clock_nanosleep, [
    VLC_ADD_LIBS([libvlccore],[-lrt])
    AC_DEFINE(HAVE_CLOCK_NANOSLEEP, 1, [Define to 1 if you have clock_nanosleep.])
  ], [
 -  dnl HP/UX port
 -  AC_CHECK_LIB(rt,sem_init, [VLC_ADD_LIBS([libvlccore],[-lrt])])
 +  AC_CHECK_FUNCS(sem_init,,
 +    [AC_CHECK_LIB(rt, sem_init, [VLC_ADD_LIBS([libvlccore],[-lrt])])
 +  ])
  ])
  
  have_nanosleep=false
 %%
 
 [1] OpenSolaris and NetBSD seem to have sem_* symbols in librt, too

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/153764: commit references a PR
Date: Sun, 30 Jan 2011 00:04:17 +0000 (UTC)

 jsa         2011-01-30 00:04:11 UTC
 
   FreeBSD ports repository
 
   Modified files:
     multimedia/vlc       Makefile distinfo 
   Removed files:
     multimedia/vlc/files 
                          patch-modules__gui__qt4__util__customwidgets.cpp 
   Log:
   Update VLC to 1.1.6.
   Include support for GCRYPT and REMOTEOSD [1].
   Stop linking against librt [2].
   Chase libdvbpsi shlib bump.
   
   PR:             [1] ports/153734, [2] ports/153764
   Submitted by:   Anonymous <swell.k@gmail.com>
   Approved by:    kwm (mentor)
   Feature safe:   yes
   
   Revision  Changes    Path
   1.251     +18 -3     ports/multimedia/vlc/Makefile
   1.43      +2 -2      ports/multimedia/vlc/distinfo
   1.2       +0 -11     ports/multimedia/vlc/files/patch-modules__gui__qt4__util__customwidgets.cpp (dead)
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: feedback->closed 
State-Changed-By: jsa 
State-Changed-When: Sun Jan 30 00:52:54 UTC 2011 
State-Changed-Why:  
Committed. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=153764 

From: "Joseph S. Atkinson" <jsa@FreeBSD.org>
To: bug-followup@FreeBSD.org, swell.k@gmail.com
Cc:  
Subject: Re: ports/153764: [patch] multimedia/vlc: don't link against librt
 for sem_init(3)
Date: Sat, 29 Jan 2011 19:52:21 -0500

 I intend to discuss you patch with upstream to hopefully do away with the need 
 for this in the future. This has been committed for FreeBSD with 1.1.6.
>Unformatted:
