From kimelto@gmail.com  Fri Jan  7 14:45:37 2011
Return-Path: <kimelto@gmail.com>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 4ECFF106566B
	for <FreeBSD-gnats-submit@freebsd.org>; Fri,  7 Jan 2011 14:45:37 +0000 (UTC)
	(envelope-from kimelto@gmail.com)
Received: from mail-wy0-f182.google.com (mail-wy0-f182.google.com [74.125.82.182])
	by mx1.freebsd.org (Postfix) with ESMTP id D91968FC0A
	for <FreeBSD-gnats-submit@freebsd.org>; Fri,  7 Jan 2011 14:45:36 +0000 (UTC)
Received: by wyf19 with SMTP id 19so17626090wyf.13
        for <FreeBSD-gnats-submit@freebsd.org>; Fri, 07 Jan 2011 06:45:35 -0800 (PST)
Received: by 10.216.62.143 with SMTP id y15mr2746994wec.55.1294411535656;
        Fri, 07 Jan 2011 06:45:35 -0800 (PST)
Received: from localhost (esc31-1-78-245-92-55.fbx.proxad.net [78.245.92.55])
        by mx.google.com with ESMTPS id m6sm12452977wej.10.2011.01.07.06.45.34
        (version=TLSv1/SSLv3 cipher=RC4-MD5);
        Fri, 07 Jan 2011 06:45:35 -0800 (PST)
Message-Id: <4d27270f.0690d80a.7e68.fffff246@mx.google.com>
Date: Fri, 07 Jan 2011 06:45:35 -0800 (PST)
From: Julien Laffaye <kimelto@gmail.com>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: [MAINTAINER] benchmarks/dbench: fix a race condition
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         153763
>Category:       ports
>Synopsis:       [MAINTAINER] benchmarks/dbench: fix a race condition
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    jadawin
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          maintainer-update
>Submitter-Id:   current-users
>Arrival-Date:   Fri Jan 07 14:50:04 UTC 2011
>Closed-Date:    Sat Jan 08 16:14:05 UTC 2011
>Last-Modified:  Sat Jan  8 16:20:08 UTC 2011
>Originator:     Julien Laffaye
>Release:        FreeBSD 8.1-RELEASE amd64
>Organization:
>Environment:
System: FreeBSD chulak.lan 8.1-RELEASE FreeBSD 8.1-RELEASE #0: Mon Jul 19 02:36:49 UTC 2010
>Description:
Fix a race condition:
It is possible that the semaphore is removed before it is used.

Added file(s):
- files/patch-dbench.c

Generated with FreeBSD Port Tools 0.99
>How-To-Repeat:
>Fix:

--- dbench-4.0_2.patch begins here ---
diff -ruN --exclude=CVS /usr/ports/benchmarks/dbench.orig/Makefile /usr/ports/benchmarks/dbench/Makefile
--- /usr/ports/benchmarks/dbench.orig/Makefile	2011-01-07 14:32:50.000000000 +0000
+++ /usr/ports/benchmarks/dbench/Makefile	2011-01-07 14:33:03.000000000 +0000
@@ -7,7 +7,7 @@
 
 PORTNAME=	dbench
 PORTVERSION=	4.0
-PORTREVISION=	1
+PORTREVISION=	2
 CATEGORIES=	benchmarks
 MASTER_SITES=	SAMBA
 MASTER_SITE_SUBDIR=	../../ftp/tridge/dbench
diff -ruN --exclude=CVS /usr/ports/benchmarks/dbench.orig/distinfo /usr/ports/benchmarks/dbench/distinfo
--- /usr/ports/benchmarks/dbench.orig/distinfo	2011-01-07 14:32:50.000000000 +0000
+++ /usr/ports/benchmarks/dbench/distinfo	2011-01-07 14:40:21.000000000 +0000
@@ -1,3 +1,2 @@
-MD5 (dbench-4.0.tar.gz) = 1fe56ff71b9a416f8889d7150ac54da4
 SHA256 (dbench-4.0.tar.gz) = 6001893f34e68a3cfeb5d424e1f2bfef005df96a22d86f35dc770c5bccf3aa8a
 SIZE (dbench-4.0.tar.gz) = 2055359
diff -ruN --exclude=CVS /usr/ports/benchmarks/dbench.orig/files/patch-dbench.c /usr/ports/benchmarks/dbench/files/patch-dbench.c
--- /usr/ports/benchmarks/dbench.orig/files/patch-dbench.c	1970-01-01 01:00:00.000000000 +0100
+++ /usr/ports/benchmarks/dbench/files/patch-dbench.c	2011-01-07 14:36:49.000000000 +0000
@@ -0,0 +1,20 @@
+--- ./dbench.c.orig	2011-01-07 14:33:29.000000000 +0000
++++ ./dbench.c	2011-01-07 14:36:43.000000000 +0000
+@@ -304,7 +304,7 @@
+ 				exit(1);
+ 			}
+ 
+-			semctl(barrier,0,IPC_RMID);
++			//semctl(barrier,0,IPC_RMID);
+ 
+ 			fn(&children[i*options.clients_per_process], options.loadfile);
+ 			_exit(0);
+@@ -334,7 +334,7 @@
+ 		exit(1);
+ 	}
+ 
+-	semctl(barrier,0,IPC_RMID);
++	//semctl(barrier,0,IPC_RMID);
+ 
+ 	signal(SIGALRM, sig_alarm);
+ 	alarm(PRINT_FREQ);
--- dbench-4.0_2.patch ends here ---

>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->jadawin 
Responsible-Changed-By: jadawin 
Responsible-Changed-When: Fri Jan 7 15:00:45 UTC 2011 
Responsible-Changed-Why:  
I'll take it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=153763 
State-Changed-From-To: open->closed 
State-Changed-By: jadawin 
State-Changed-When: Sat Jan 8 16:14:04 UTC 2011 
State-Changed-Why:  
Committed. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=153763 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/153763: commit references a PR
Date: Sat,  8 Jan 2011 16:13:31 +0000 (UTC)

 jadawin     2011-01-08 16:13:25 UTC
 
   FreeBSD ports repository
 
   Modified files:
     benchmarks/dbench    Makefile distinfo 
   Added files:
     benchmarks/dbench/files patch-dbench.c 
   Log:
   - Add patch to fix a race condition
   - Bump PORTREVISION
   
   PR:             ports/153763
   Submitted by:   Julien Laffaye <kimelto _AT_ gmail.com> (maintainer)
   
   Revision  Changes    Path
   1.25      +1 -1      ports/benchmarks/dbench/Makefile
   1.6       +0 -1      ports/benchmarks/dbench/distinfo
   1.1       +20 -0     ports/benchmarks/dbench/files/patch-dbench.c (new)
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
