From nobody@FreeBSD.org  Sat Jan  1 12:06:53 2011
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id B6B48106566C
	for <freebsd-gnats-submit@FreeBSD.org>; Sat,  1 Jan 2011 12:06:53 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from red.freebsd.org (unknown [IPv6:2001:4f8:fff6::22])
	by mx1.freebsd.org (Postfix) with ESMTP id A706B8FC14
	for <freebsd-gnats-submit@FreeBSD.org>; Sat,  1 Jan 2011 12:06:53 +0000 (UTC)
Received: from red.freebsd.org (localhost [127.0.0.1])
	by red.freebsd.org (8.14.4/8.14.4) with ESMTP id p01C6rZk028434
	for <freebsd-gnats-submit@FreeBSD.org>; Sat, 1 Jan 2011 12:06:53 GMT
	(envelope-from nobody@red.freebsd.org)
Received: (from nobody@localhost)
	by red.freebsd.org (8.14.4/8.14.4/Submit) id p01C6rhv028433;
	Sat, 1 Jan 2011 12:06:53 GMT
	(envelope-from nobody)
Message-Id: <201101011206.p01C6rhv028433@red.freebsd.org>
Date: Sat, 1 Jan 2011 12:06:53 GMT
From: HIROSHI OOTA <xalaxy@gmail.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: chrooted make always returns the status 0
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         153597
>Category:       ports
>Synopsis:       [bsd.destdir.mk] [patch] chrooted make always returns the status 0
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    portmgr
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Sat Jan 01 12:10:10 UTC 2011
>Closed-Date:    Tue Jan 25 13:39:55 UTC 2011
>Last-Modified:  Tue Jan 25 13:40:11 UTC 2011
>Originator:     HIROSHI OOTA
>Release:        9-current
>Organization:
>Environment:
FreeBSD aries 9.0-CURRENT FreeBSD 9.0-CURRENT #114 r216689M: Fri Dec 24 21:41:56 JST 2010     root@  amd64

>Description:
chrooted make always returns the status 0.
>How-To-Repeat:
cd /usr/ports/archivers/zip; make DESTDIR=/tmp unknown-target; echo "exit status=$?"
===>  Creating some important subdirectories
===> /tmp subdirectory has been successfully created
===> /dev subdirectory has been successfully created
===>  Starting chrooted make in /tmp...
chroot: /bin/sh: No such file or directory
===>  Chrooted make in /tmp failed
===>  Cleaning up...
exit status=0

>Fix:
--- bsd.destdir.mk.orig 2011-01-01 20:50:41.964186373 +0900
+++ bsd.destdir.mk      2011-01-01 20:53:15.239188075 +0900
@@ -208,8 +210,8 @@
        ${CHROOT} $${_destdir} ${SH} -c "\
                cd $${PORTSDIR}${.CURDIR:S|^${PORTSDIR}||}; \
                ${SETENV} -i ${DESTDIR_ENV} $${_var_path_list} ${MAKE} ${.TARGETS}" &\
& \
-               ${ECHO_MSG} "===>  Chrooted make in ${DESTDIR} succeeded" || \
-               ${ECHO_MSG} "===>  Chrooted make in ${DESTDIR} failed"; \
+               { status=$$?; ${ECHO_MSG} "===>  Chrooted make in ${DESTDIR} succeeded"; }  || \
+               { status=$$?; ${ECHO_MSG} "===>  Chrooted make in ${DESTDIR} failed"; }; \
                ${ECHO_MSG} "===>  Cleaning up..."; \
        for _entry in $${_mounted_entries_list}; do \
                ${UMOUNT} -f $${_entry} || ${TRUE}; \
@@ -217,6 +219,6 @@
        for _entry in $${_created_mountpoints_list}; do \
                ${RMDIR} $${_entry} || ${TRUE}; \
        done; \
-       exit 0
+       exit $$status


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->portmgr 
Responsible-Changed-By: arved 
Responsible-Changed-When: Mon Jan 3 13:52:50 UTC 2011 
Responsible-Changed-Why:  
over to maintainer 

http://www.freebsd.org/cgi/query-pr.cgi?pr=153597 
State-Changed-From-To: open->closed 
State-Changed-By: pav 
State-Changed-When: Tue Jan 25 13:34:31 UTC 2011 
State-Changed-Why:  
Committed, thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=153597 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/153597: commit references a PR
Date: Tue, 25 Jan 2011 13:39:48 +0000 (UTC)

 pav         2011-01-25 13:39:44 UTC
 
   FreeBSD ports repository
 
   Modified files:
     Mk                   bsd.destdir.mk 
   Log:
   - Propagate return code of the DESTDIR chrooted make
   
   PR:             ports/153597
   Submitted by:   HIROSHI OOTA <xalaxy@gmail.com>
   Feature safe:   yes
   
   Revision  Changes    Path
   1.3       +4 -4      ports/Mk/bsd.destdir.mk
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
