From swell.k@gmail.com  Thu Dec 30 10:38:21 2010
Return-Path: <swell.k@gmail.com>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id B4E54106566B
	for <FreeBSD-gnats-submit@freebsd.org>; Thu, 30 Dec 2010 10:38:21 +0000 (UTC)
	(envelope-from swell.k@gmail.com)
Received: from mail-qw0-f54.google.com (mail-qw0-f54.google.com [209.85.216.54])
	by mx1.freebsd.org (Postfix) with ESMTP id 6ECE28FC0A
	for <FreeBSD-gnats-submit@freebsd.org>; Thu, 30 Dec 2010 10:38:21 +0000 (UTC)
Received: by qwj9 with SMTP id 9so10565344qwj.13
        for <FreeBSD-gnats-submit@freebsd.org>; Thu, 30 Dec 2010 02:38:20 -0800 (PST)
Received: by 10.229.212.133 with SMTP id gs5mr14144879qcb.192.1293705499913;
        Thu, 30 Dec 2010 02:38:19 -0800 (PST)
Received: from localhost (anonymizer3.torservers.net [174.36.199.201])
        by mx.google.com with ESMTPS id m14sm9130948qcu.32.2010.12.30.02.38.15
        (version=SSLv3 cipher=RC4-MD5);
        Thu, 30 Dec 2010 02:38:19 -0800 (PST)
Message-Id: <86zkrnbl6e.fsf@gmail.com>
Date: Thu, 30 Dec 2010 13:38:01 +0300
From: Anonymous <swell.k@gmail.com>
To: FreeBSD-gnats-submit@freebsd.org
Subject: [patch] devel/git: respect STRIP for stripping

>Number:         153541
>Category:       ports
>Synopsis:       [patch] devel/git: respect STRIP for stripping
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    wxs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Thu Dec 30 10:40:09 UTC 2010
>Closed-Date:    
>Last-Modified:  Sat Jan  1 16:10:11 UTC 2011
>Originator:     Anonymous
>Release:        FreeBSD 9.0-CURRENT amd64
>Organization:
>Environment:
cf. ports/150689
>Description:
Strip binaries based on STRIP value, not only when WITH_DEBUG is used.
It's as ports/146961 originally intended.

depends on STRIP re-defined in bsd.port.pre.mk as per ports/153539
>How-To-Repeat:
>Fix:
--- a.diff begins here ---
Index: devel/git/Makefile
===================================================================
RCS file: /a/.cvsup/ports/devel/git/Makefile,v
retrieving revision 1.96
diff -u -p -r1.96 Makefile
--- devel/git/Makefile	19 Dec 2010 07:48:18 -0000	1.96
+++ devel/git/Makefile	30 Dec 2010 10:28:50 -0000
@@ -195,10 +195,6 @@ OPTIONS=	GUI "Enable building of GUI too
 
 .include <bsd.port.options.mk>
 
-.ifndef (WITH_DEBUG)
-ALL_TARGET=	all strip
-.endif
-
 .ifdef (WITH_P4) || defined (WITH_CONTRIB)
 USE_PYTHON=	yes
 PLIST_SUB=	PYTHON_VER=${PYTHON_VER} PYTHON=""
@@ -314,6 +310,12 @@ PLIST_SUB+=	ETCSHELLS=""
 PLIST_SUB+=	ETCSHELLS="@comment "
 .endif
 
+.include <bsd.port.pre.mk>
+
+.if defined(STRIP) && ${STRIP} != ""
+ALL_TARGET=	all strip
+.endif
+
 .if defined(MAINTAINER_MODE)
 DISTFILES+=	${PORTNAME}-${PORTVERSION}${EXTRACT_SUFX}.sign \
 		${PORTNAME}-manpages-${PORTVERSION}${EXTRACT_SUFX}.sign
@@ -409,4 +411,4 @@ post-install:
 	@${CAT} ${PKGMESSAGE}
 .endif
 
-.include <bsd.port.mk>
+.include <bsd.port.post.mk>
--- a.diff ends here ---
>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->wxs 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Thu Dec 30 10:40:15 UTC 2010 
Responsible-Changed-Why:  
Over to maintainer (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=153541 

From: Anonymous <swell.k@gmail.com>
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/153541: [patch] devel/git: respect STRIP for stripping
Date: Sat, 01 Jan 2011 19:00:16 +0300

 the last diff from ports/153539 allows checking STRIP from bsd.port.options.mk
 
 --- a.diff begins here ---
 Index: devel/git/Makefile
 ===================================================================
 RCS file: /a/.cvsup/ports/devel/git/Makefile,v
 retrieving revision 1.96
 diff -u -p -r1.96 Makefile
 --- devel/git/Makefile	19 Dec 2010 07:48:18 -0000	1.96
 +++ devel/git/Makefile	1 Jan 2011 15:13:33 -0000
 @@ -195,7 +195,7 @@ OPTIONS=	GUI "Enable building of GUI too
  
  .include <bsd.port.options.mk>
  
 -.ifndef (WITH_DEBUG)
 +.if defined(STRIP) && ${STRIP} != ""
  ALL_TARGET=	all strip
  .endif
  
 --- a.diff ends here ---
>Unformatted:
